@yemi33/minions 0.1.1662 → 0.1.1664

package/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 0.1.1664 (2026-05-01)
+
+### Features
+- prevent duplicate PR fix dispatch (#1953)
+
 ## 0.1.1662 (2026-05-01)
 
 ### Other

package/engine/copilot-models.json

@@ -1,5 +1,5 @@
 {
   "runtime": "copilot",
   "models": null,
-  "cachedAt": "2026-05-01T15:02:53.143Z"
+  "cachedAt": "2026-05-01T19:29:49.074Z"
 }

package/engine/dispatch.js

@@ -59,16 +59,52 @@ function mutateDispatch(mutator) {
 
 // ─── Add to Dispatch ─────────────────────────────────────────────────────────
 
-function getPrDispatchDedupeKey(entry) {
-  if (!entry?.meta?.pr || !entry?.meta?.project || !entry?.type) return null;
-  const type = entry.type === WORK_TYPE.FIX ? WORK_TYPE.FIX : entry.type;
+function getDispatchProjectKey(project) {
+  if (!project) return '';
+  return project.name || (project.localPath ? path.resolve(project.localPath).toLowerCase() : '');
+}
+
+function getPrDispatchTargetKey(entry) {
+  if (!entry?.meta?.pr || !entry?.meta?.project) return null;
   const project = entry.meta.project;
-  const projectKey = project.name
-    || (project.localPath ? path.resolve(project.localPath).toLowerCase() : '');
+  const projectKey = getDispatchProjectKey(project);
   if (!projectKey) return null;
   const prKey = shared.getCanonicalPrId(project, entry.meta.pr, entry.meta.pr?.url || '');
   if (!prKey) return null;
-  return `${projectKey}:${type}:${prKey}`;
+  return `${projectKey}:${prKey}`;
+}
+
+function getPrDispatchDedupeKey(entry) {
+  if (!entry?.type) return null;
+  const targetKey = getPrDispatchTargetKey(entry);
+  if (!targetKey) return null;
+  const type = entry.type === WORK_TYPE.FIX ? WORK_TYPE.FIX : entry.type;
+  return `${targetKey}:${type}`;
+}
+
+function getBranchDispatchLockKey(entry) {
+  const branch = entry?.meta?.branch || entry?.meta?.pr?.branch || '';
+  if (!branch) return null;
+  const normalizedBranch = shared.sanitizeBranch(branch);
+  if (!normalizedBranch) return null;
+  const projectKey = getDispatchProjectKey(entry?.meta?.project) || 'default';
+  return `${projectKey}:${normalizedBranch}`;
+}
+
+function findActivePrOrBranchLock(dispatch, item) {
+  if (item?.type !== WORK_TYPE.FIX) return null;
+  const active = dispatch.active || [];
+  const prTargetKey = getPrDispatchTargetKey(item);
+  if (prTargetKey) {
+    const existing = active.find(d => getPrDispatchTargetKey(d) === prTargetKey);
+    if (existing) return { existing, reason: `active PR dispatch ${prTargetKey}` };
+  }
+
+  const branchLockKey = getBranchDispatchLockKey(item);
+  if (!branchLockKey) return null;
+  const existing = active.find(d => getBranchDispatchLockKey(d) === branchLockKey);
+  if (!existing) return null;
+  return { existing, reason: `active branch dispatch ${branchLockKey}` };
 }
 
 function addToDispatch(item) {
@@ -106,6 +142,11 @@ function addToDispatch(item) {
         return dispatch;
       }
     }
+    const activeLock = findActivePrOrBranchLock(dispatch, item);
+    if (activeLock) {
+      log('info', `Dedup: skipping ${item.id} — ${activeLock.reason} already in ${activeLock.existing.id}`);
+      return dispatch;
+    }
     dispatch.pending.push(item);
     added = true;
     return dispatch;

package/engine/shared.js

@@ -1275,9 +1275,11 @@ function projectPrPath(project) {
 
 function resolveProjectForPrPath(filePath, config = null) {
   const resolvedPath = path.resolve(filePath);
-  for (const project of getProjects(config)) {
+  const projects = getProjects(config);
+  for (const project of projects) {
     if (path.resolve(projectPrPath(project)) === resolvedPath) return project;
   }
+  if (projects.length === 1) return projects[0];
   return null;
 }
 
@@ -1673,7 +1675,9 @@ function normalizePrScopeSegment(value) {
 function parseCanonicalPrId(value) {
   const match = String(value || '').trim().match(/^(github|ado):(.+?)#(\d+)$/i);
   if (!match) return null;
-  const scope = `${match[1].toLowerCase()}:${match[2].split('/').map(normalizePrScopeSegment).join('/')}`;
+  const normalizedParts = match[2].split('/').map(normalizePrScopeSegment);
+  if (!normalizedParts.some(Boolean)) return null;
+  const scope = `${match[1].toLowerCase()}:${normalizedParts.join('/')}`;
   return { scope, prNumber: parseInt(match[3], 10) };
 }
 
@@ -2429,9 +2433,14 @@ module.exports = {
   projectStateDir,
   projectWorkItemsPath,
   projectPrPath,
+  resolveProjectForPrPath, // exported for testing
   getPrLinks,
   addPrLink,
+  normalizePrScopeSegment, // exported for testing
   parseCanonicalPrId,
+  parseGitHubPrUrl, // exported for testing
+  parseAdoPrUrl, // exported for testing
+  parsePrUrl, // exported for testing
   getProjectPrScope,
   getPrNumber,
   getPrDisplayId,
@@ -2444,6 +2453,8 @@ module.exports = {
   applyPrFieldDelta,
   normalizePrRecord,
   normalizePrRecords,
+  normalizePrLinkItems, // exported for testing
+  mergePrLinkItems, // exported for testing
   upsertPullRequestRecord,
   nextWorkItemId,
   getAdoOrgBase,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1662",
+  "version": "0.1.1664",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"