@yemi33/minions 0.1.1654 → 0.1.1656

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.1.1656 (2026-05-01)
+
+### Features
+- ADO manual PR link metadata and branch race
+- gate non-terminal task completions
+
 ## 0.1.1654 (2026-05-01)
 
 ### Fixes

package/dashboard.js

@@ -75,7 +75,42 @@ function getWorkItemIdFromPrLinkContext(context, workItemId) {
   return null;
 }
 
-function linkPullRequestForTracking({ url, title, project: projectName, autoObserve, context, workItemId }, config = CONFIG) {
+function decodeUrlSegment(segment) {
+  try { return decodeURIComponent(segment); } catch { return segment; }
+}
+
+function parseAdoPrMetadataTarget(url) {
+  const raw = String(url || '');
+  const devAzure = raw.match(/https?:\/\/dev\.azure\.com\/([^/]+)\/([^/]+)\/_git\/([^/]+)\/pullrequest\/(\d+)/i);
+  if (devAzure) {
+    return {
+      adoOrg: decodeUrlSegment(devAzure[1]),
+      adoProj: decodeUrlSegment(devAzure[2]),
+      adoRepo: decodeUrlSegment(devAzure[3]),
+      prNum: devAzure[4],
+    };
+  }
+  const visualStudio = raw.match(/https?:\/\/([^/.]+)\.visualstudio\.com\/(?:DefaultCollection\/)?([^/]+)\/_git\/([^/]+)\/pullrequest\/(\d+)/i);
+  if (!visualStudio) return null;
+  return {
+    adoOrg: `${decodeUrlSegment(visualStudio[1])}.visualstudio.com`,
+    adoProj: decodeUrlSegment(visualStudio[2]),
+    adoRepo: decodeUrlSegment(visualStudio[3]),
+    prNum: visualStudio[4],
+  };
+}
+
+function normalizePrMetadata(metadata) {
+  if (!metadata || typeof metadata !== 'object') return null;
+  return {
+    title: typeof metadata.title === 'string' ? metadata.title.trim() : '',
+    description: typeof metadata.description === 'string' ? metadata.description : '',
+    branch: typeof metadata.branch === 'string' ? metadata.branch.trim().replace(/^refs\/heads\//i, '') : '',
+    author: typeof metadata.author === 'string' ? metadata.author.trim() : '',
+  };
+}
+
+function linkPullRequestForTracking({ url, title, project: projectName, autoObserve, context, workItemId }, config = CONFIG, options = {}) {
   if (!url) {
     const err = new Error('url required');
     err.statusCode = 400;
@@ -90,13 +125,14 @@ function linkPullRequestForTracking({ url, title, project: projectName, autoObse
   const prId = shared.getCanonicalPrId(targetProject, prNum, url);
   const linkedWorkItemId = getWorkItemIdFromPrLinkContext(context, workItemId);
   const contextText = typeof context === 'string' ? context : (context == null ? '' : JSON.stringify(context));
+  const metadata = normalizePrMetadata(options.metadata);
   const result = shared.upsertPullRequestRecord(prPath, {
     id: prId,
     prNumber: parseInt(prNum, 10) || null,
-    title: (title || 'PR #' + prNum + ' (polling...)').slice(0, 120),
-    description: '',
-    agent: 'human',
-    branch: '',
+    title: (metadata?.title || title || 'PR #' + prNum + ' (polling...)').slice(0, 120),
+    description: metadata?.description ? metadata.description.slice(0, 500) : '',
+    agent: metadata?.author || 'human',
+    branch: metadata?.branch || '',
     reviewStatus: 'pending',
     status: 'active',
     created: new Date().toISOString(),
@@ -5994,7 +6030,16 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       if (!url) return jsonReply(res, 400, { error: 'url required' });
 
       reloadConfig();
-      const { id: prId, prPath, targetProject, prNum, created, linked } = linkPullRequestForTracking(body, CONFIG);
+      const adoTarget = parseAdoPrMetadataTarget(url);
+      let initialPrData = null;
+      if (adoTarget) {
+        try {
+          initialPrData = await ado.fetchAdoPrMetadata(adoTarget.prNum, adoTarget.adoOrg, adoTarget.adoProj, adoTarget.adoRepo);
+        } catch (e) {
+          shared.log('warn', `ADO PR link metadata fetch failed for ${url}: ${e.message}`);
+        }
+      }
+      const { id: prId, prPath, prNum, created, linked } = linkPullRequestForTracking(body, CONFIG, { metadata: initialPrData });
       invalidateStatusCache();
       jsonReply(res, 200, { ok: true, id: prId, created, linked });
 
@@ -6003,16 +6048,14 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         try {
           let prData = null;
           const ghMatch = url.match(/github\.com\/([^/]+\/[^/]+)\/pull\/(\d+)/);
-          const adoMatch = url.match(/dev\.azure\.com\/([^/]+)\/([^/]+)\/_git\/([^/]+)\/pullrequest\/(\d+)/);
           if (ghMatch) {
             const slug = ghMatch[1];
             const result = await shared.execAsync(`gh api "repos/${slug}/pulls/${prNum}"`, { timeout: 15000, encoding: 'utf-8' });
             const d = JSON.parse(result);
             prData = { title: d.title, description: d.body, branch: d.head?.ref, author: d.user?.login };
-          } else if (adoMatch) {
-            const [, adoOrg, adoProj, adoRepo] = adoMatch;
+          } else if (adoTarget && !initialPrData) {
             try {
-              prData = await ado.fetchAdoPrMetadata(prNum, adoOrg, adoProj, adoRepo);
+              prData = await ado.fetchAdoPrMetadata(adoTarget.prNum, adoTarget.adoOrg, adoTarget.adoProj, adoTarget.adoRepo);
             } catch { /* ADO token may not be available */ }
           }
           if (!prData) return;

package/engine/ado.js

@@ -138,6 +138,48 @@ function clearBuildStatusStale(pr) {
   if (pr._buildStatusDetail) delete pr._buildStatusDetail;
 }
 
+function isPlaceholderPrTitle(title, prNum) {
+  const text = String(title || '').trim();
+  if (!text) return true;
+  if (/\bpolling\.\.\./i.test(text)) return true;
+  if (String(prNum || '') && (text === `PR #${prNum}` || text === `PR-${prNum}`)) return true;
+  if (/[{}"\[\]]/.test(text)) return true;
+  return /^[0-9a-f-]{8,}$/i.test(text);
+}
+
+function applyAdoPrMetadata(pr, prData, prNum) {
+  if (!pr || !prData) return false;
+  let updated = false;
+
+  const sourceBranch = stripRefsHeads(prData.sourceRefName);
+  if (sourceBranch && (pr.branch !== sourceBranch || pr._branchResolutionError || pr._pendingReason === shared.PR_PENDING_REASON.MISSING_BRANCH)) {
+    pr.branch = sourceBranch;
+    if (pr._branchResolutionError) delete pr._branchResolutionError;
+    if (pr._pendingReason === shared.PR_PENDING_REASON.MISSING_BRANCH) delete pr._pendingReason;
+    updated = true;
+  }
+
+  const title = String(prData.title || '').trim();
+  if (title && isPlaceholderPrTitle(pr.title, prNum) && pr.title !== title.slice(0, 120)) {
+    pr.title = title.slice(0, 120);
+    updated = true;
+  }
+
+  const description = typeof prData.description === 'string' ? prData.description : '';
+  if (description && (pr.description == null || pr.description === '')) {
+    pr.description = description.slice(0, 500);
+    updated = true;
+  }
+
+  const author = String(prData.createdBy?.displayName || '').trim();
+  if (author && pr.agent === 'human') {
+    pr.agent = author;
+    updated = true;
+  }
+
+  return updated;
+}
+
 // ── Build/Review Status Helpers ───────────────────────────────────────────────
 
 /** Classify an array of ADO build records into a single status string. */
@@ -454,13 +496,7 @@ async function pollPrStatus(config) {
 
     const prData = await adoFetch(`${repoBase}?api-version=7.1`, token);
 
-    const sourceBranch = stripRefsHeads(prData.sourceRefName);
-    if (sourceBranch && pr.branch !== sourceBranch) {
-      pr.branch = sourceBranch;
-      if (pr._branchResolutionError) delete pr._branchResolutionError;
-      if (pr._pendingReason === 'missing_pr_branch') delete pr._pendingReason;
-      updated = true;
-    }
+    if (applyAdoPrMetadata(pr, prData, prNum)) updated = true;
 
     let newStatus = pr.status;
     if (prData.status === 'completed') newStatus = PR_STATUS.MERGED;
@@ -1121,7 +1157,8 @@ async function checkLiveBuildAndConflict(pr, project) {
 async function fetchAdoPrMetadata(prNum, adoOrg, adoProj, adoRepo) {
   const token = await getAdoToken();
   if (!token) return null;
-  const url = `https://dev.azure.com/${adoOrg}/${adoProj}/_apis/git/repositories/${adoRepo}/pullrequests/${prNum}?api-version=7.1`;
+  const orgBase = getAdoOrgBase({ adoOrg });
+  const url = `${orgBase}/${encodeURIComponent(adoProj)}/_apis/git/repositories/${encodeURIComponent(adoRepo)}/pullrequests/${encodeURIComponent(String(prNum))}?api-version=7.1`;
   const pr = await adoFetch(url, token);
   if (!pr) return null;
   return {

package/engine/copilot-models.json

@@ -1,5 +1,5 @@
 {
   "runtime": "copilot",
   "models": null,
-  "cachedAt": "2026-05-01T04:15:15.814Z"
+  "cachedAt": "2026-05-01T04:21:06.784Z"
 }

package/engine/lifecycle.js

@@ -2260,7 +2260,7 @@ async function runPostCompletionHooks(dispatchItem, agentId, code, stdout, confi
     if (nonTerminalCompletion) {
       skipDoneStatus = true;
       const reason = deferNonTerminalCompletion(meta, nonTerminalCompletion);
-      completionContractFailure = { reason, itemId: meta.item.id, nonTerminal: true };
+      completionContractFailure = { reason, itemId: meta.item.id, nonTerminal: true, processWorkItemFailure: false };
       if (!nonCleanReportWritten) {
         writeNonCleanAgentReport(dispatchItem, agentId, 'partial', structuredCompletion, completionGateSummary, code);
       }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1654",
+  "version": "0.1.1656",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"