@yemi33/minions 0.1.162 → 0.1.164

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.1.164 (2026-04-02)
+
+### Engine
+- engine/lifecycle.js
+
+## 0.1.163 (2026-04-02)
+
+### Engine
+- engine/lifecycle.js
+
 ## 0.1.162 (2026-04-02)
 
 ### Other

package/engine/lifecycle.js

@@ -1188,6 +1188,11 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
         ? path.join(MINIONS_DIR, 'work-items.json')
         : meta.project?.name ? path.join(MINIONS_DIR, 'projects', meta.project.name, 'work-items.json') : null;
       if (wiPath) {
+        // Cost ceiling circuit breaker config — resolved outside lock for clarity
+        const engineCfg = config?.engine || {};
+        const evalMaxCost = engineCfg.evalMaxCost != null ? engineCfg.evalMaxCost : shared.ENGINE_DEFAULTS.evalMaxCost;
+
+        // Single lock: accumulate cost AND check ceiling atomically (no TOCTOU)
         mutateJsonFileLocked(wiPath, (items) => {
           if (!Array.isArray(items)) return items;
           const wi = items.find(i => i.id === meta.item.id);
@@ -1195,29 +1200,17 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
             wi._totalCostUsd = (wi._totalCostUsd || 0) + (taskUsage.costUsd || 0);
             wi._totalInputTokens = (wi._totalInputTokens || 0) + (taskUsage.inputTokens || 0);
             wi._totalOutputTokens = (wi._totalOutputTokens || 0) + (taskUsage.outputTokens || 0);
+
+            // Cost ceiling circuit breaker — treat like evalMaxIterations exceeded
+            if (evalMaxCost != null && evalMaxCost > 0 &&
+                wi._totalCostUsd > evalMaxCost && wi.status !== 'needs-human-review') {
+              wi.status = 'needs-human-review';
+              wi.failReason = `Cumulative cost $${wi._totalCostUsd.toFixed(2)} exceeds evalMaxCost ceiling $${evalMaxCost.toFixed(2)}`;
+              log('warn', `Work item ${meta.item.id} exceeded cost ceiling ($${wi._totalCostUsd.toFixed(2)} > $${evalMaxCost.toFixed(2)}) — needs-human-review`);
+            }
           }
           return items;
         }, { defaultValue: [] });
-
-        // Cost ceiling circuit breaker — treat like evalMaxIterations exceeded
-        const engineCfg = config?.engine || {};
-        const evalMaxCost = engineCfg.evalMaxCost != null ? engineCfg.evalMaxCost : shared.ENGINE_DEFAULTS.evalMaxCost;
-        if (evalMaxCost != null && evalMaxCost > 0) {
-          const freshItems = safeJson(wiPath) || [];
-          const wi = freshItems.find(i => i.id === meta.item.id);
-          if (wi && wi._totalCostUsd > evalMaxCost && wi.status !== 'needs-human-review') {
-            mutateJsonFileLocked(wiPath, (items) => {
-              if (!Array.isArray(items)) return items;
-              const target = items.find(i => i.id === meta.item.id);
-              if (target) {
-                target.status = 'needs-human-review';
-                target.failReason = `Cumulative cost $${wi._totalCostUsd.toFixed(2)} exceeds evalMaxCost ceiling $${evalMaxCost.toFixed(2)}`;
-                log('warn', `Work item ${meta.item.id} exceeded cost ceiling ($${wi._totalCostUsd.toFixed(2)} > $${evalMaxCost.toFixed(2)}) — needs-human-review`);
-              }
-              return items;
-            }, { defaultValue: [] });
-          }
-        }
       }
     } catch (err) { log('warn', `Cost accumulation: ${err.message}`); }
   }
@@ -1250,40 +1243,48 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
 
   if (isSuccess && meta?.item?.id && !skipDoneStatus) updateWorkItemStatus(meta, 'done', '');
 
-  // Auto-dispatch review work item after implement completes successfully
-  if (isSuccess && !skipDoneStatus && type === 'implement' && meta?.item?.id) {
+  // Auto-dispatch review work item after implement or fix completes successfully
+  // For 'fix' items, only trigger when they were created by the eval loop (_evalParentId set)
+  const isEvalEligible = type === 'implement' || (type === 'fix' && meta?.item?._evalParentId);
+  if (isSuccess && !skipDoneStatus && isEvalEligible && meta?.item?.id) {
     const autoReview = config.engine?.autoReview ?? shared.ENGINE_DEFAULTS.autoReview;
     if (autoReview) {
       try {
         const wiPath = resolveWiPath(meta);
         if (wiPath) {
           const items = safeJson(wiPath) || [];
+          // For fix items, the eval parent is the original implement item
+          const evalParentId = type === 'fix' ? meta.item._evalParentId : meta.item.id;
           // Dedup: skip if a review item already exists for this parent
-          const existing = items.find(i => i._evalParentId === meta.item.id && i.type === 'review');
+          const existing = items.find(i => i._evalParentId === evalParentId && i.type === 'review' && i.status !== 'done' && i.status !== 'failed');
           if (existing) {
-            log('info', `Eval loop: review item ${existing.id} already exists for ${meta.item.id}, skipping`);
+            log('info', `Eval loop: review item ${existing.id} already exists for ${evalParentId}, skipping`);
           } else {
-            const parentItem = items.find(i => i.id === meta.item.id);
-            const evalItem = {
-              id: 'W-' + shared.uid(),
-              title: `Review: ${meta.item.title || meta.item.id}`,
-              type: 'review',
-              priority: meta.item.priority || 'high',
-              status: 'pending',
-              created: ts(),
-              createdBy: 'engine:eval-loop',
-              project: meta.project?.name || meta.item.project,
-              branch_name: parentItem?.branch_name || meta.branch || null,
-              pr_url: parentItem?.pr_url || null,
-              acceptance_criteria: parentItem?.acceptance_criteria || meta.item.acceptance_criteria || null,
-              _evalParentId: meta.item.id,
-            };
-            if (parentItem?.sourcePlan) evalItem.sourcePlan = parentItem.sourcePlan;
-            // Mark parent as eval-dispatched before writing to prevent duplicates on re-run
-            if (parentItem) parentItem._evalDispatched = true;
-            items.push(evalItem);
-            shared.safeWrite(wiPath, items);
-            log('info', `Eval loop: created ${evalItem.id} for completed implement ${meta.item.id}`);
+            const parentItem = items.find(i => i.id === evalParentId);
+            if (parentItem?._evalDispatched) {
+              log('info', `Eval loop: parent ${evalParentId} already has _evalDispatched set, skipping`);
+            } else {
+              const evalItem = {
+                id: 'W-' + shared.uid(),
+                title: `Review: ${parentItem?.title || meta.item.title || evalParentId}`,
+                type: 'review',
+                priority: parentItem?.priority || meta.item.priority || 'high',
+                status: 'pending',
+                created: ts(),
+                createdBy: 'engine:eval-loop',
+                project: meta.project?.name || meta.item.project,
+                branch_name: parentItem?.branch_name || meta.branch || null,
+                pr_url: parentItem?.pr_url || null,
+                acceptance_criteria: parentItem?.acceptance_criteria || meta.item.acceptance_criteria || null,
+                _evalParentId: evalParentId,
+              };
+              if (parentItem?.sourcePlan) evalItem.sourcePlan = parentItem.sourcePlan;
+              // Mark parent as eval-dispatched before writing to prevent duplicates on re-run
+              if (parentItem) parentItem._evalDispatched = true;
+              items.push(evalItem);
+              shared.safeWrite(wiPath, items);
+              log('info', `Eval loop: created ${evalItem.id} for completed ${type} ${meta.item.id} (parent: ${evalParentId})`);
+            }
           }
         }
       } catch (err) {
@@ -1350,15 +1351,15 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
   }
 
   if (!isSuccess && meta?.item?.id) {
-    const wiPath = resolveWiPath(meta);
-    if (wiPath) {
-      let finalStatus = null;
-      try {
+    // Auto-retry with atomic read-modify-write (no TOCTOU race)
+    try {
+      const wiPath = resolveWiPath(meta);
+      if (wiPath) {
+        let retriesExhausted = false;
         mutateJsonFileLocked(wiPath, (items) => {
           if (!Array.isArray(items)) return items;
           const wi = items.find(i => i.id === meta.item.id);
           if (!wi) return items;
-
           const retries = wi._retryCount || 0;
           if (retries < 3) {
             log('info', `Agent failed for ${meta.item.id} — auto-retry ${retries + 1}/3`);
@@ -1366,22 +1367,28 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
             wi.status = 'pending';
             delete wi.dispatched_at;
             delete wi.dispatched_to;
-            finalStatus = 'pending';
+            if (type === 'decompose') delete wi._decomposing;
           } else {
-            wi.status = 'failed';
-            wi.failReason = 'Agent failed (3 retries exhausted)';
-            wi.failedAt = ts();
-            finalStatus = 'failed';
+            retriesExhausted = true;
           }
+          // Clear _decomposing flag on any decompose failure to prevent permanent stuck
           if (type === 'decompose') delete wi._decomposing;
           return items;
-        });
-      } catch (err) { log('warn', `Retry update: ${err.message}`); }
-      // Sync status to PRD outside the work-items lock
-      if (finalStatus) {
-        syncPrdItemStatus(meta.item.id, finalStatus, meta.item?.sourcePlan);
+        }, { defaultValue: [] });
+        if (retriesExhausted) {
+          updateWorkItemStatus(meta, 'failed', 'Agent failed (3 retries exhausted)');
+        }
+      } else {
+        // No wiPath — can't read retries, fall back to meta snapshot
+        const retries = meta.item._retryCount || 0;
+        if (retries < 3) {
+          log('info', `Agent failed for ${meta.item.id} — auto-retry ${retries + 1}/3`);
+          updateWorkItemStatus(meta, 'pending', '');
+        } else {
+          updateWorkItemStatus(meta, 'failed', 'Agent failed (3 retries exhausted)');
+        }
       }
-    }
+    } catch (err) { log('warn', `Retry/decompose update: ${err.message}`); }
   }
   // Meeting post-completion: collect findings/debate/conclusion
   if (type === 'meeting' && meta?.meetingId) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.162",
+  "version": "0.1.164",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"