@yemi33/minions 0.1.1612 → 0.1.1614

package/CHANGELOG.md

@@ -1,8 +1,14 @@
 # Changelog
 
-## 0.1.1612 (2026-04-28)
+## 0.1.1614 (2026-04-29)
+
+### Fixes
+- recover ===ACTIONS=== JSON from fences and trailing prose (#1834) (#1837)
+
+## 0.1.1613 (2026-04-28)
 
 ### Features
+- fix npm test failures (#1846)
 - hard-pin agent assignment when CC names a specific agent
 - auto-detect available CLI runtimes and pin engine.defaultCli
 - match runtime tags to actual logos (pixel-crab Claude, mascot Copilot)

package/dashboard/js/command-center.js

@@ -623,6 +623,11 @@ async function _ccDoSend(message, skipUserMsg, forceTabId) {
         if (evt.actions && evt.actions.length > 0) {
           _tagServerExecuted(evt.actions, evt.actionResults);
           for (var ai = 0; ai < evt.actions.length; ai++) { await ccExecuteAction(evt.actions[ai], activeTabId); }
+        } else if (evt.actionParseError) {
+          // Issue #1834: server saw ===ACTIONS=== but couldn't parse the JSON.
+          // Surface as an inline warning so the user knows actions were dropped
+          // (was previously silent — appeared as "actions failed" with no signal).
+          addMsg('system', '<div style="padding:6px 12px;font-size:11px;color:var(--red);background:var(--surface2);border-radius:6px;margin:4px 0">⚠️ Actions block emitted but JSON could not be parsed — no actions were executed. Resend or rephrase. (' + escHtml(String(evt.actionParseError).slice(0, 200)) + ')</div>', false, activeTabId);
         }
       } else if (evt.type === 'error') {
         terminalEventSeen = true;

package/dashboard/js/utils.js

@@ -183,8 +183,8 @@ function copyLlmText(btn) {
   const clone = container.cloneNode(true);
   clone.querySelectorAll('.llm-copy-btn').forEach(b => b.remove());
   navigator.clipboard.writeText(clone.textContent.trim());
-  btn.innerHTML = '✓';
-  setTimeout(() => { btn.innerHTML = '⎘'; }, 1500);
+  btn.textContent = '\u2713';
+  setTimeout(() => { btn.textContent = '\u2398'; }, 1500);
 }
 
 /**

package/dashboard.js

@@ -758,16 +758,68 @@ function findCCActionsDelimiter(text) {
   return match.index + match[0].indexOf('===ACTIONS===');
 }
 
+// Issue #1834: non-Claude runtimes (Copilot/GPT) routinely wrap the action JSON
+// in ```json fences or append trailing prose ("Let me know if that helps!").
+// JSON.parse on the raw segment fails silently → actions dropped, user sees
+// inert text. This extractor pulls out the balanced JSON value (array or
+// object) regardless of fences, leading whitespace, or trailing junk so the
+// downstream parse can succeed. Returns null if no plausible JSON value is
+// present (caller surfaces the failure via _actionParseError).
+function _extractActionsJson(segment) {
+  if (!segment) return null;
+  let body = segment.trim();
+  // Strip ```json / ``` fences (open + close). The model sometimes only emits
+  // an opening fence (truncation), so handle both halves independently.
+  body = body.replace(/^```[a-zA-Z0-9_-]*\s*\r?\n?/, '').replace(/\r?\n?```\s*$/, '').trim();
+  if (!body) return null;
+  const first = body.indexOf('[');
+  const firstObj = body.indexOf('{');
+  let start = -1;
+  let openCh = '';
+  let closeCh = '';
+  if (first >= 0 && (firstObj < 0 || first <= firstObj)) {
+    start = first; openCh = '['; closeCh = ']';
+  } else if (firstObj >= 0) {
+    start = firstObj; openCh = '{'; closeCh = '}';
+  }
+  if (start < 0) return null;
+  let depth = 0;
+  let inString = false;
+  let escape = false;
+  for (let i = start; i < body.length; i++) {
+    const ch = body[i];
+    if (escape) { escape = false; continue; }
+    if (ch === '\\') { escape = true; continue; }
+    if (ch === '"') { inString = !inString; continue; }
+    if (inString) continue;
+    if (ch === openCh) depth++;
+    else if (ch === closeCh) {
+      depth--;
+      if (depth === 0) return body.slice(start, i + 1);
+    }
+  }
+  return null;
+}
+
 function parseCCActions(text) {
   let actions = [];
   let displayText = text;
+  let parseError = null;
   const delimIdx = findCCActionsDelimiter(text);
   if (delimIdx >= 0) {
     displayText = text.slice(0, delimIdx).trim();
-    try {
-      const parsed = JSON.parse(text.slice(delimIdx + '===ACTIONS==='.length).trim());
-      actions = Array.isArray(parsed) ? parsed : [parsed];
-    } catch {}
+    const segment = text.slice(delimIdx + '===ACTIONS==='.length);
+    const jsonStr = _extractActionsJson(segment);
+    if (jsonStr) {
+      try {
+        const parsed = JSON.parse(jsonStr);
+        actions = Array.isArray(parsed) ? parsed : [parsed];
+      } catch (e) {
+        parseError = e.message || 'invalid JSON';
+      }
+    } else if (segment.trim()) {
+      parseError = 'no JSON value found after ===ACTIONS=== delimiter';
+    }
   }
   if (actions.length === 0) {
     const actionRegex = /`{3,}\s*action\s*\r?\n([\s\S]*?)`{3,}/g;
@@ -775,9 +827,24 @@ function parseCCActions(text) {
     while ((match = actionRegex.exec(displayText)) !== null) {
       try { actions.push(JSON.parse(match[1].trim())); } catch {}
     }
-    if (actions.length > 0) displayText = displayText.replace(/`{3,}\s*action\s*\r?\n[\s\S]*?`{3,}\n?/g, '').trim();
+    if (actions.length > 0) {
+      displayText = displayText.replace(/`{3,}\s*action\s*\r?\n[\s\S]*?`{3,}\n?/g, '').trim();
+      parseError = null; // legacy fallback recovered actions
+    }
   }
-  return { text: displayText, actions };
+  const result = { text: displayText, actions };
+  if (parseError && actions.length === 0) {
+    result._actionParseError = parseError;
+    // Visibility for the engine log — silent failure here previously masked issue #1834.
+    try {
+      const snippet = (text.slice(delimIdx + '===ACTIONS==='.length).trim() || '').slice(0, 200);
+      console.warn(`[CC] action JSON parse failed (${parseError}); raw segment: ${snippet}`);
+      if (typeof shared !== 'undefined' && shared && typeof shared.log === 'function') {
+        shared.log('warn', `CC action JSON parse failed: ${parseError} — segment: ${snippet}`);
+      }
+    } catch { /* logging is best-effort */ }
+  }
+  return result;
 }
 
 // ── /loop → create-watch safety net ──────────────────────────────────────────
@@ -4382,7 +4449,12 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         if (parsed.actions.length > 0) {
           parsed.actionResults = await executeCCActions(parsed.actions);
         }
-        const reply = { ...parsed, sessionId: ccSession.sessionId, newSession: !wasResume };
+        // Issue #1834: rename _actionParseError → actionParseError (public field)
+        // so the client can surface a warning when the model emitted ===ACTIONS===
+        // but the JSON couldn't be recovered.
+        const { _actionParseError, ...parsedReply } = parsed;
+        const reply = { ...parsedReply, sessionId: ccSession.sessionId, newSession: !wasResume };
+        if (_actionParseError) reply.actionParseError = _actionParseError;
         if (sessionReset) reply.sessionReset = true;
         return jsonReply(res, 200, reply);
       } finally {
@@ -4639,7 +4711,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
         }
 
         // Send final result with actions — execute server-side first
-        const { text: displayText, actions } = parseCCActions(result.text);
+        const { text: displayText, actions, _actionParseError } = parseCCActions(result.text);
         // Safety net: detect /loop invocation and convert to create-watch
         const _loopWatch = _detectLoopInvocation(displayText, actions, toolUses);
         if (_loopWatch) {
@@ -4652,6 +4724,9 @@ What would you like to discuss or change? When you're happy, say "approve" and I
           actionResults = await executeCCActions(actions);
         }
         const donePayload = { type: 'done', text: displayText, actions, actionResults, sessionId: responseSessionId, newSession: !wasResume };
+        // Issue #1834: surface action JSON parse failures so the UI can warn
+        // instead of silently dropping. Client renders this as a small notice.
+        if (_actionParseError) donePayload.actionParseError = _actionParseError;
         if (sessionReset) donePayload.sessionReset = true;
         liveState.donePayload = donePayload;
         if (liveState.writer) liveState.writer(donePayload);

package/engine/queries.js

@@ -11,7 +11,7 @@ const shared = require('./shared');
 
 const { safeRead, safeReadDir, safeJson, safeWrite, getProjects, mutateJsonFileLocked,
   projectWorkItemsPath, projectPrPath, parseSkillFrontmatter, KB_CATEGORIES,
-  WI_STATUS, DONE_STATUSES, PRD_ITEM_STATUS, PR_STATUS, ENGINE_DEFAULTS } = shared;
+  WI_STATUS, DONE_STATUSES, PRD_ITEM_STATUS, PR_STATUS, ENGINE_DEFAULTS, DEFAULT_AGENT_METRICS } = shared;
 
 /**
  * Read the first `bytes` and last `bytes` of a file efficiently using byte offsets.
@@ -196,6 +196,14 @@ function getEngineLog() {
 function getMetrics() {
   const metrics = safeJson(path.join(ENGINE_DIR, 'metrics.json')) || {};
 
+  for (const [agentId, m] of Object.entries(metrics)) {
+    if (agentId.startsWith('_')) continue;
+    metrics[agentId] = {
+      ...DEFAULT_AGENT_METRICS,
+      ...(m && typeof m === 'object' && !Array.isArray(m) ? m : {}),
+    };
+  }
+
   // Enrich agent PR counts from pull-requests.json (source of truth)
   const allPrs = getPullRequests();
   const prCountByAgent = {};

package/engine/routing.js

@@ -116,7 +116,15 @@ function setTempBudget(n) {
 }
 function getTempBudget() { return _tempBudget; }
 
-function resolveAgent(workType, config, authorAgent = null) {
+function normalizeAgentHints(agentHints, authorAgent = null) {
+  const raw = Array.isArray(agentHints) ? agentHints : (agentHints ? [agentHints] : []);
+  return raw
+    .map(id => id === '_author_' ? authorAgent : id)
+    .map(id => typeof id === 'string' ? id.trim().toLowerCase() : '')
+    .filter(Boolean);
+}
+
+function resolveAgent(workType, config, authorAgent = null, agentHints = null) {
   const routes = getRoutingTableCached();
   const route = routes[workType] || routes['implement'];
   const agents = config.agents || {};
@@ -145,6 +153,14 @@ function resolveAgent(workType, config, authorAgent = null) {
     return null;
   };
 
+  const hintedAgents = normalizeAgentHints(agentHints, authorAgent);
+  if (hintedAgents.length > 0) {
+    for (const id of hintedAgents) {
+      if (isAvailable(id)) { _claimedAgents.add(id); return id; }
+    }
+    return null;
+  }
+
   // Resolve _any_ token — pick any available agent (#480)
   if (preferred === '_any_') { const pick = pickAnyIdle(); if (pick) return pick; }
   else if (preferred && isAvailable(preferred)) { _claimedAgents.add(preferred); return preferred; }
@@ -192,4 +208,5 @@ module.exports = {
   resolveAgent,
   setTempBudget,
   getTempBudget,
+  normalizeAgentHints,
 };

package/engine.js

@@ -2441,7 +2441,8 @@ function discoverFromWorkItems(config, project) {
       item._decomposing = true;
       needsWrite = true;
     }
-    const agentId = item.agent || resolveAgent(workType, config);
+    const agentHints = item.preferred_agent || item.agents || null;
+    const agentId = item.agent || resolveAgent(workType, config, null, agentHints);
     if (!agentId) {
       // Check if reason is budget
       const cfgAgents = config.agents || {};
@@ -2960,7 +2961,8 @@ function discoverCentralWorkItems(config) {
 
     } else {
       // ─── Normal: single agent dispatch ──────────────────────────────
-      const agentId = item.agent || resolveAgent(workType, config);
+      const agentHints = item.preferred_agent || item.agents || null;
+      const agentId = item.agent || resolveAgent(workType, config, null, agentHints);
       if (!agentId) continue;
 
       const agentName = config.agents[agentId]?.name || agentId;
@@ -3602,7 +3604,8 @@ async function tickInner() {
     // be of type string. Received undefined` and re-queues — every tick. Try to
     // resolve a fallback via routing; if none is available, skip this tick.
     if (!item.agent || typeof item.agent !== 'string') {
-      const fallback = resolveAgent(item.type || WORK_TYPE.FIX, config);
+      const agentHints = item.meta?.item?.preferred_agent || item.meta?.item?.agents || null;
+      const fallback = resolveAgent(item.type || WORK_TYPE.FIX, config, null, agentHints);
       if (!fallback) {
         log('warn', `Pending dispatch ${item.id} has no agent and routing returned no fallback — skipping`);
         continue;
@@ -3660,7 +3663,7 @@ async function tickInner() {
       // Agent busy reassignment: if item has been waiting on a busy agent past the threshold,
       // try to find an alternative agent via routing. Skip explicitly assigned items.
       const reassignMs = config.engine?.agentBusyReassignMs ?? ENGINE_DEFAULTS.agentBusyReassignMs;
-      const isExplicitReassign = !!item.meta?.item?.agent;
+      const isExplicitReassign = !!(item.meta?.item?.agent || item.meta?.item?.preferred_agent || item.meta?.item?.agents?.length);
       if (!isExplicitReassign && reassignMs > 0 && item._agentBusySince) {
         const busySinceMs = new Date(item._agentBusySince).getTime();
         if (Date.now() - busySinceMs > reassignMs) {

package/minions.js

@@ -465,6 +465,7 @@ async function initMinions({ skipScan = false, scanRoot, scanDepth } = {}) {
   // Merge defaults — fills in new fields from upgrades while preserving user customizations
   if (!config.engine) config.engine = {};
   for (const [k, v] of Object.entries(ENGINE_DEFAULTS)) {
+    if (k === 'defaultCli') continue;
     if (config.engine[k] === undefined) config.engine[k] = v;
   }
   if (!config.claude) config.claude = {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1612",
+  "version": "0.1.1614",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"

package/prompts/cc-system.md

@@ -52,6 +52,8 @@ When in doubt, delegate. You are the dispatcher, not the worker. Agents have iso
 ## Actions
 Append actions at the END of your response. Write your response first, then `===ACTIONS===` on its own line, then a JSON array. No text after the JSON. Omit entirely if no actions needed.
 
+**CRITICAL — emit RAW JSON only.** Do NOT wrap the JSON array in ```json fences, ``` fences, or any other markdown. Do NOT add commentary or "Let me know if that helps" lines after the JSON. The JSON array must start with `[` on the line immediately after `===ACTIONS===` and end with `]` as the very last character of the response. Anything else (fences, prose, trailing commas) breaks server-side action parsing and your actions will be silently dropped.
+
 Example:
 I'll dispatch dallas to fix that bug.