@yemi33/minions 0.1.1607 → 0.1.1608

package/CHANGELOG.md

@@ -1,12 +1,13 @@
 # Changelog
 
-## 0.1.1607 (2026-04-28)
+## 0.1.1608 (2026-04-28)
 
 ### Features
 - match runtime tags to actual logos (pixel-crab Claude, mascot Copilot)
 - replace runtime text tag with inline SVG logos
 
 ### Fixes
+-  kill agents from engine tmp pid files
 -  gate live completion banner on final process exit
 - wrap CC Model input so its label/hint survive runtime hydration
 - preserve reconnect stream state

package/engine/cli.js

@@ -1142,12 +1142,27 @@ const commands = {
     const config = getConfig();
     const shared = require('./shared');
 
-    // Kill processes via PID files (expensive — outside dispatch lock)
-    const pidFiles = fs.readdirSync(ENGINE_DIR).filter(f => f.startsWith('pid-'));
+    // Kill processes via PID files (expensive — outside dispatch lock).
+    // PID files live in engine/tmp/ (see engine/spawn-agent.js:220 — derived from
+    // the prompt-<id>.md sidecar path that engine.js builds in engine/tmp/).
+    // Reading from ENGINE_DIR directly is a no-op: spawn-agent never writes there.
+    const pidDir = path.join(ENGINE_DIR, 'tmp');
+    const pidFiles = shared.safeReadDir(pidDir).filter(f => f.startsWith('pid-') && f.endsWith('.pid'));
     for (const f of pidFiles) {
-      const pid = safeRead(path.join(ENGINE_DIR, f)).trim();
-      try { process.kill(Number(pid)); console.log(`Killed process ${pid} (${f})`); } catch { console.log(`Process ${pid} already dead`); }
-      fs.unlinkSync(path.join(ENGINE_DIR, f));
+      const pidPath = path.join(pidDir, f);
+      const raw = safeRead(pidPath).trim();
+      // Guard against falsy/zero/NaN PIDs. Empty pid files would resolve to
+      // Number('') === 0, and process.kill(0) on POSIX targets the entire
+      // calling process group — which would kill the engine itself.
+      let pidNum = NaN;
+      try { pidNum = shared.validatePid(raw); } catch { /* invalid — skip */ }
+      if (pidNum > 0) {
+        try { process.kill(pidNum); console.log(`Killed process ${pidNum} (${f})`); }
+        catch { console.log(`Process ${pidNum} already dead`); }
+      } else {
+        console.log(`Skipping ${f}: invalid or empty PID`);
+      }
+      try { fs.unlinkSync(pidPath); } catch { /* may not exist */ }
     }
 
     // Atomically read and clear dispatch.active (locked read-modify-write)

package/engine/dispatch.js

@@ -341,7 +341,7 @@ function cancelPendingDispatchesForPr(prId) {
  */
 function cleanDispatchEntries(matchFn) {
   const dispatchPath = path.join(MINIONS_DIR, 'engine', 'dispatch.json');
-  const engineDir = path.join(MINIONS_DIR, 'engine');
+  const tmpDir = path.join(MINIONS_DIR, 'engine', 'tmp');
   let removed = 0;
   const pidsToKill = [];
   const filesToDelete = [];
@@ -353,15 +353,17 @@ function cleanDispatchEntries(matchFn) {
         if (queue === 'active') {
           for (const d of dispatch[queue]) {
             if (!matchFn(d)) continue;
-            const pidFile = path.join(engineDir, `pid-${d.id}.pid`);
+            // PID files live in engine/tmp/ (see engine/spawn-agent.js:220 — derived
+            // from the prompt-<id>.md path that engine.js builds in engine/tmp/).
+            const pidFile = path.join(tmpDir, `pid-${d.id}.pid`);
             try {
               const pid = parseInt(fs.readFileSync(pidFile, 'utf8').trim());
               if (pid) pidsToKill.push(pid);
             } catch { /* PID file may not exist */ }
             filesToDelete.push(pidFile);
-            filesToDelete.push(path.join(engineDir, 'tmp', `prompt-${d.id}.md`));
-            filesToDelete.push(path.join(engineDir, 'tmp', `sysprompt-${d.id}.md`));
-            filesToDelete.push(path.join(engineDir, 'tmp', `sysprompt-${d.id}.md.tmp`));
+            filesToDelete.push(path.join(tmpDir, `prompt-${d.id}.md`));
+            filesToDelete.push(path.join(tmpDir, `sysprompt-${d.id}.md`));
+            filesToDelete.push(path.join(tmpDir, `sysprompt-${d.id}.md.tmp`));
           }
         }
         dispatch[queue] = dispatch[queue].filter(d => !matchFn(d));

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1607",
+  "version": "0.1.1608",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"