@yemi33/minions 0.1.1600 → 0.1.1602

package/CHANGELOG.md

@@ -1,12 +1,14 @@
 # Changelog
 
-## 0.1.1600 (2026-04-28)
+## 0.1.1602 (2026-04-28)
 
 ### Features
 - match runtime tags to actual logos (pixel-crab Claude, mascot Copilot)
 - replace runtime text tag with inline SVG logos
 
 ### Fixes
+- guard runtime model races
+- runtime-aware model picker + cross-runtime validation
 -  keep cc stream final text complete
 - switch Copilot icon to outline style for cleaner inline read
 - un-invert Copilot — purple silhouette + white cutouts

package/dashboard/js/settings.js

@@ -1,6 +1,25 @@
 // settings.js — Settings panel functions extracted from dashboard.html
 
 let _settingsData = null;
+// Async runtime/model discovery can resolve out of order when the operator
+// flips between runtimes quickly. Without a per-target token, a slower Copilot
+// response can repaint the Claude model field after the runtime already
+// changed, which then leaks a stale cross-runtime model into saveSettings().
+const _modelLoadEpochs = {
+  runtime: Object.create(null),
+  agent: Object.create(null),
+};
+
+function _nextModelLoadToken(scope, key) {
+  const bucket = _modelLoadEpochs[scope];
+  const next = (bucket[key] || 0) + 1;
+  bucket[key] = next;
+  return next;
+}
+
+function _isCurrentModelLoad(scope, key, token) {
+  return _modelLoadEpochs[scope][key] === token;
+}
 
 async function openSettings() {
   document.getElementById('modal-title').textContent = 'Settings';
@@ -35,7 +54,11 @@ async function openSettings() {
         // <select> populated from /api/runtimes once the registry resolves.
         '<input value="' + escHtml(a.cli || '') + '" placeholder="' + escHtml(fleetCliLabel) + ' (fleet)" disabled style="width:100%;padding:4px 6px;background:var(--surface);border:1px solid var(--border);border-radius:4px;color:var(--muted);font-size:11px">' +
       '</td>' +
-      '<td><input data-agent="' + escHtml(id) + '" data-field="model" value="' + escHtml(a.model || '') + '" placeholder="' + escHtml(fleetModelLabel) + ' (fleet)" style="width:120px;padding:4px 6px;background:var(--surface);border:1px solid var(--border);border-radius:4px;color:var(--text);font-size:11px"></td>' +
+      '<td data-runtime-model="' + escHtml(id) + '" style="min-width:140px">' +
+        // Loading placeholder — initRuntimeFleetUI() replaces this with a
+        // <select> populated from /api/runtimes/<resolved-cli>/models.
+        '<input value="' + escHtml(a.model || '') + '" placeholder="' + escHtml(fleetModelLabel) + ' (fleet)" disabled style="width:120px;padding:4px 6px;background:var(--surface);border:1px solid var(--border);border-radius:4px;color:var(--muted);font-size:11px">' +
+      '</td>' +
       '<td><input data-agent="' + escHtml(id) + '" data-field="monthlyBudgetUsd" value="' + escHtml(a.monthlyBudgetUsd != null ? String(a.monthlyBudgetUsd) : '') + '" placeholder="unlimited" style="width:70px;padding:4px 6px;background:var(--surface);border:1px solid var(--border);border-radius:4px;color:var(--text);font-size:11px;text-align:right"></td>' +
     '</tr>';
   }).join('');
@@ -347,6 +370,26 @@ async function initRuntimeFleetUI(engineCfg, agentsCfg) {
         ).join('') +
       '</select>';
   }
+  // Hydrate per-agent model dropdowns. The model list is keyed off the
+  // agent's RESOLVED runtime: per-agent override → fleet default. Without
+  // this the input was free-text and a user could (and did) save an agent
+  // with cli=claude + model=<some gpt> — invalid combination that crashed
+  // dispatch. Refreshing on CLI change clears stale model values.
+  const fleetDefaultCli = engineCfg.defaultCli || 'claude';
+  for (const cell of cliCells) {
+    const agentId = cell.getAttribute('data-runtime-cli');
+    const agent = (agentsCfg || {})[agentId] || {};
+    const resolvedCli = agent.cli || fleetDefaultCli;
+    loadModelsForAgent(agentId, resolvedCli, agent.model || '');
+    // CLI dropdown change → refresh that agent's model dropdown to match.
+    const sel = cell.querySelector('select[data-field="cli"]');
+    if (sel) {
+      sel.addEventListener('change', () => {
+        const newCli = sel.value || fleetDefaultCli;
+        loadModelsForAgent(agentId, newCli, ''); // clear value: previous model may not exist for the new runtime
+      });
+    }
+  }
 
   // Models load for the resolved default + CC CLIs. ccCli falls back to
   // defaultCli when unset — same rule as resolveCcCli().
@@ -376,6 +419,7 @@ async function initRuntimeFleetUI(engineCfg, agentsCfg) {
 async function loadModelsForRuntime(runtimeName, inputId, currentValue) {
   const wrap = document.getElementById(inputId)?.parentElement;
   if (!wrap) return;
+  const token = _nextModelLoadToken('runtime', inputId);
   if (!runtimeName) {
     wrap.innerHTML = '<input id="' + inputId + '" value="' + escHtml(currentValue || '') + '" placeholder="(no runtime selected)" disabled style="width:100%;padding:4px 6px;background:var(--surface);border:1px solid var(--border);border-radius:4px;color:var(--muted);font-size:12px">';
     return;
@@ -386,6 +430,7 @@ async function loadModelsForRuntime(runtimeName, inputId, currentValue) {
     if (res.ok) payload = await res.json();
   } catch { /* fall through to free-text */ }
 
+  if (!_isCurrentModelLoad('runtime', inputId, token)) return;
   const models = Array.isArray(payload.models) ? payload.models : null;
   if (!models || models.length === 0) {
     // Free-text fallback — let the user type anything (custom Anthropic /
@@ -409,6 +454,49 @@ async function loadModelsForRuntime(runtimeName, inputId, currentValue) {
   wrap.innerHTML = '<select id="' + inputId + '" style="width:100%;padding:4px 6px;background:var(--surface);border:1px solid var(--border);border-radius:4px;color:var(--text);font-size:12px">' + opts + '</select>';
 }
 
+/**
+ * Per-agent model hydrator. Replaces the placeholder input in the cell
+ * `[data-runtime-model="<agentId>"]` with a <select> of valid models for the
+ * given runtime. Output element keeps `data-agent` + `data-field="model"` so
+ * the existing save flow picks it up unchanged. Free-text input fallback
+ * when the runtime returns no model list (Claude / discovery disabled).
+ */
+async function loadModelsForAgent(agentId, runtimeName, currentValue) {
+  const cell = document.querySelector('[data-runtime-model="' + agentId + '"]');
+  if (!cell) return;
+  const baseAttrs = 'data-agent="' + escHtml(agentId) + '" data-field="model"';
+  const baseStyle = 'width:120px;padding:4px 6px;background:var(--surface);border:1px solid var(--border);border-radius:4px;color:var(--text);font-size:11px';
+  const token = _nextModelLoadToken('agent', agentId);
+  if (!runtimeName) {
+    cell.innerHTML = '<input ' + baseAttrs + ' value="' + escHtml(currentValue || '') + '" placeholder="(no runtime)" disabled style="' + baseStyle + ';color:var(--muted)">';
+    return;
+  }
+  let payload = { models: null };
+  try {
+    const res = await fetch('/api/runtimes/' + encodeURIComponent(runtimeName) + '/models');
+    if (res.ok) payload = await res.json();
+  } catch { /* fall through to free-text */ }
+
+  if (!_isCurrentModelLoad('agent', agentId, token)) return;
+  const models = Array.isArray(payload.models) ? payload.models : null;
+  if (!models || models.length === 0) {
+    cell.innerHTML = '<input ' + baseAttrs + ' value="' + escHtml(currentValue || '') + '" placeholder="' + escHtml(runtimeName) + ' default" style="' + baseStyle + '">';
+    return;
+  }
+  let opts = '<option value=""' + (!currentValue ? ' selected' : '') + '>(fleet/default)</option>';
+  for (const m of models) {
+    const id = m.id || m.name || '';
+    if (!id) continue;
+    const label = m.name && m.name !== id ? (id + ' — ' + m.name) : id;
+    opts += '<option value="' + escHtml(id) + '"' + (id === currentValue ? ' selected' : '') + '>' + escHtml(label) + '</option>';
+  }
+  // Preserve unknown saved values so a user-set custom ID survives the next save.
+  if (currentValue && !models.some(m => (m.id || m.name) === currentValue)) {
+    opts += '<option value="' + escHtml(currentValue) + '" selected>' + escHtml(currentValue) + ' (custom — invalid for ' + escHtml(runtimeName) + '?)</option>';
+  }
+  cell.innerHTML = '<select ' + baseAttrs + ' style="' + baseStyle + '">' + opts + '</select>';
+}
+
 function settingsToggle(label, id, checked, hint) {
   return '<div style="display:flex;align-items:center;gap:8px;padding:4px 0">' +
     '<input type="checkbox" id="' + id + '"' + (checked ? ' checked' : '') + ' style="accent-color:var(--blue);width:16px;height:16px;cursor:pointer">' +

package/dashboard.js

@@ -4918,13 +4918,58 @@ What would you like to discuss or change? When you're happy, say "approve" and I
           else if (_validCli(e.ccCli)) config.engine.ccCli = String(e.ccCli);
           else _clamped.push(`ccCli: "${e.ccCli}" not registered (kept previous value)`);
         }
+        // Validate fleet-level model assignments against the resolved runtime.
+        // This is where the bug bit: defaultCli=copilot + defaultModel=gpt-5.5
+        // (where gpt-5.5 doesn't actually exist) cascaded into every agent
+        // that didn't pin its own model. Reject when the model is known to
+        // belong to a different runtime than the one it'll spawn against.
+        const _engineModelDiscovery = require('./engine/model-discovery');
+        const _engineRuntimes = require('./engine/runtimes');
+        async function _validateFleetModel(modelStr, resolvedRuntime) {
+          if (!modelStr) return null;
+          let knownForResolved = null;
+          try {
+            const list = await _engineModelDiscovery.getRuntimeModels(resolvedRuntime, { config });
+            if (Array.isArray(list?.models) && list.models.length > 0) {
+              knownForResolved = new Set(list.models.map(m => m.id || m.name).filter(Boolean));
+            }
+          } catch { /* unknown runtime */ }
+          if (knownForResolved && !knownForResolved.has(modelStr)) {
+            return `not a valid model for runtime "${resolvedRuntime}" (known: ${[...knownForResolved].slice(0, 4).join(', ')}${knownForResolved.size > 4 ? '…' : ''})`;
+          }
+          if (!knownForResolved) {
+            // Free-text runtime (Claude). Reject only if model belongs to a different runtime's published list.
+            for (const rt of _engineRuntimes.listRuntimes()) {
+              if (rt === resolvedRuntime) continue;
+              try {
+                const otherList = await _engineModelDiscovery.getRuntimeModels(rt, { config });
+                if (Array.isArray(otherList?.models) && otherList.models.some(m => (m.id || m.name) === modelStr)) {
+                  return `belongs to runtime "${rt}" but resolved runtime is "${resolvedRuntime}" — incompatible combination`;
+                }
+              } catch { /* skip */ }
+            }
+          }
+          return null;
+        }
         if (e.defaultModel !== undefined) {
           if (_isClear(e.defaultModel)) delete config.engine.defaultModel;
-          else config.engine.defaultModel = String(e.defaultModel);
+          else {
+            const candidate = String(e.defaultModel);
+            const resolvedCli = config.engine.defaultCli || 'claude';
+            const rejection = await _validateFleetModel(candidate, resolvedCli);
+            if (rejection) _clamped.push(`engine.defaultModel: "${candidate}" ${rejection} — kept previous value`);
+            else config.engine.defaultModel = candidate;
+          }
         }
         if (e.ccModel !== undefined) {
           if (_isClear(e.ccModel)) delete config.engine.ccModel;
-          else config.engine.ccModel = String(e.ccModel);
+          else {
+            const candidate = String(e.ccModel);
+            const resolvedCli = config.engine.ccCli || config.engine.defaultCli || 'claude';
+            const rejection = await _validateFleetModel(candidate, resolvedCli);
+            if (rejection) _clamped.push(`engine.ccModel: "${candidate}" ${rejection} — kept previous value`);
+            else config.engine.ccModel = candidate;
+          }
         }
         if (e.claudeFallbackModel !== undefined) {
           if (_isClear(e.claudeFallbackModel)) delete config.engine.claudeFallbackModel;
@@ -4982,6 +5027,34 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       }
 
       if (body.agents) {
+        // Cache cross-runtime model lists once per request so we can reject
+        // claude+gpt-* / copilot+claude-* combinations before they crash a
+        // dispatch (see #model-validation: a stray engine.defaultModel='gpt-5.5'
+        // pinned every Claude agent into a 404 spawn loop).
+        const _modelDiscovery = require('./engine/model-discovery');
+        const _runtimeModelsCache = new Map(); // runtimeName → Set<modelId> (or null when unknown / Claude)
+        async function _modelsFor(runtimeName) {
+          if (_runtimeModelsCache.has(runtimeName)) return _runtimeModelsCache.get(runtimeName);
+          let set = null;
+          try {
+            const list = await _modelDiscovery.getRuntimeModels(runtimeName, { config });
+            if (Array.isArray(list?.models) && list.models.length > 0) {
+              set = new Set(list.models.map(m => m.id || m.name).filter(Boolean));
+            }
+          } catch { /* unknown runtime → free-text */ }
+          _runtimeModelsCache.set(runtimeName, set);
+          return set;
+        }
+        // Returns the runtime that "owns" this model, or null if no other
+        // runtime claims it. Catches "claude + gpt-5.5" by spotting that
+        // gpt-5.5 belongs to copilot's list.
+        async function _ownerOfModel(modelId) {
+          for (const rt of require('./engine/runtimes').listRuntimes()) {
+            const set = await _modelsFor(rt);
+            if (set && set.has(modelId)) return rt;
+          }
+          return null;
+        }
         for (const [id, updates] of Object.entries(body.agents)) {
           if (!config.agents[id]) continue;
           if (updates.role !== undefined) config.agents[id].role = String(updates.role);
@@ -5001,7 +5074,30 @@ What would you like to discuss or change? When you're happy, say "approve" and I
           }
           if (updates.model !== undefined) {
             if (updates.model === '' || updates.model === null) delete config.agents[id].model;
-            else config.agents[id].model = String(updates.model);
+            else {
+              const candidate = String(updates.model);
+              const resolvedCli = config.agents[id].cli || config.engine.defaultCli || 'claude';
+              const knownModels = await _modelsFor(resolvedCli);
+              // Two validation paths:
+              //   1. If the runtime publishes a model list, enforce membership.
+              //   2. If the runtime doesn't (Claude), still reject when the
+              //      model belongs to a DIFFERENT runtime's list — that's how
+              //      we catch claude+gpt-5.5 (gpt-5.5 is in Copilot's list).
+              let rejection = null;
+              if (knownModels && !knownModels.has(candidate)) {
+                rejection = `not a valid model for runtime "${resolvedCli}" (known: ${[...knownModels].slice(0, 4).join(', ')}${knownModels.size > 4 ? '…' : ''})`;
+              } else if (!knownModels) {
+                const owner = await _ownerOfModel(candidate);
+                if (owner && owner !== resolvedCli) {
+                  rejection = `belongs to runtime "${owner}" but agent uses "${resolvedCli}" — incompatible combination`;
+                }
+              }
+              if (rejection) {
+                _clamped.push(`agents.${id}.model: "${candidate}" ${rejection} — kept previous value`);
+              } else {
+                config.agents[id].model = candidate;
+              }
+            }
           }
           if (updates.maxBudgetUsd !== undefined) {
             if (updates.maxBudgetUsd === '' || updates.maxBudgetUsd === null) delete config.agents[id].maxBudgetUsd;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1600",
+  "version": "0.1.1602",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"