@yemi33/minions 0.1.1567 → 0.1.1569

package/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## 0.1.1569 (2026-04-27)
+
+### Fixes
+-  avoid duplicate review retry loops
+
+## 0.1.1568 (2026-04-27)
+
+### Fixes
+-  smooth project add and scan UX
+
 ## 0.1.1567 (2026-04-27)
 
 ### Other

package/dashboard/js/render-other.js

@@ -21,6 +21,28 @@ function renderProjects(projects) {
 
 }
 
+function _projectCachePath(project) {
+  return String((project && (project.localPath || project.path)) || '').replace(/\\/g, '/');
+}
+
+function optimisticallyAddProject(project) {
+  if (!project || !project.name) return;
+  const next = {
+    name: project.name,
+    description: project.description || '',
+    localPath: _projectCachePath(project),
+    path: _projectCachePath(project),
+  };
+  if (!window._lastStatus) window._lastStatus = {};
+  const current = Array.isArray(window._lastStatus.projects) ? window._lastStatus.projects.slice() : [];
+  const nextPath = _projectCachePath(next);
+  if (current.some(function(p) { return p.name === next.name || (nextPath && _projectCachePath(p) === nextPath); })) return;
+  current.push(next);
+  window._lastStatus.projects = current;
+  if (typeof cmdUpdateProjectList === 'function') cmdUpdateProjectList(current);
+  renderProjects(current);
+}
+
 async function projectChipRemove(name) {
   if (!confirm('Remove project "' + name + '"? Pending work cancels, active agents are killed, data dir is archived to projects/.archived/.')) return;
   showToast('cmd-toast', 'Removing project "' + name + '"...', true);
@@ -385,7 +407,18 @@ async function _addSelectedProjects() {
         method: 'POST', headers: { 'Content-Type': 'application/json' },
         body: JSON.stringify({ path: repo.path })
       });
-      if (res.ok) { added++; cb.disabled = true; cb.closest('label').style.opacity = '0.5'; }
+      var data = await res.json().catch(function() { return {}; });
+      if (res.ok) {
+        added++;
+        optimisticallyAddProject({
+          name: data.name || repo.name,
+          description: (data.detected && data.detected.description) || repo.description || '',
+          path: data.path || repo.path,
+          localPath: data.path || repo.path,
+        });
+        cb.disabled = true;
+        cb.closest('label').style.opacity = '0.5';
+      }
     } catch { /* continue with next */ }
   }
   if (added > 0) {
@@ -394,4 +427,4 @@ async function _addSelectedProjects() {
   }
 }
 
-window.MinionsOther = { renderProjects, projectChipRemove, renderMcpServers, renderMetrics, renderLlmPerf, renderTokenUsage, openScanProjectsModal };
+window.MinionsOther = { renderProjects, optimisticallyAddProject, projectChipRemove, renderMcpServers, renderMetrics, renderLlmPerf, renderTokenUsage, openScanProjectsModal };

package/dashboard/js/settings.js

@@ -384,6 +384,19 @@ async function addProject() {
     });
     const addData = await addRes.json();
     if (!addRes.ok) { alert('Failed: ' + (addData.error || 'unknown')); return; }
+    const addedProject = {
+      name: addData.name,
+      description: (addData.detected && addData.detected.description) || '',
+      path: addData.path,
+      localPath: addData.path,
+    };
+    if (_settingsData && Array.isArray(_settingsData.projects)) {
+      const exists = _settingsData.projects.some(function(p) {
+        return p.name === addedProject.name || String(p.localPath || p.path || '').replace(/\\/g, '/') === String(addedProject.localPath || '').replace(/\\/g, '/');
+      });
+      if (!exists) _settingsData.projects = _settingsData.projects.concat([addedProject]);
+    }
+    if (typeof optimisticallyAddProject === 'function') optimisticallyAddProject(addedProject);
     try { showToast('cmd-toast', 'Project "' + addData.name + '" added — restart engine to pick it up', true); } catch { /* expected */ }
     refresh();
   } catch (e) { alert('Error: ' + e.message); }

package/dashboard.js

@@ -3807,6 +3807,17 @@ What would you like to discuss or change? When you're happy, say "approve" and I
     return jsonReply(res, 200, { confirmToken: token, ttlMs: PROJECT_CONFIRM_TOKEN_TTL_MS });
   }
 
+  function _execGitInRepo(repoPath, args, timeoutMs) {
+    const { execFileSync } = require('child_process');
+    return execFileSync('git', args, {
+      cwd: repoPath,
+      encoding: 'utf8',
+      timeout: timeoutMs || 5000,
+      stdio: ['ignore', 'pipe', 'pipe'],
+      windowsHide: true,
+    }).trim();
+  }
+
   async function handleProjectsAdd(req, res) {
     try {
       const body = await readBody(req);
@@ -3840,14 +3851,16 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       }
 
       // Auto-discover from git repo
-      const { execSync: ex } = require('child_process');
       const detected = { name: path.basename(target), _found: [] };
       try {
-        const head = ex('git symbolic-ref refs/remotes/origin/HEAD 2>/dev/null || git symbolic-ref HEAD', { cwd: target, encoding: 'utf8', timeout: 5000 }).trim();
+        let head = '';
+        try { head = _execGitInRepo(target, ['symbolic-ref', 'refs/remotes/origin/HEAD'], 5000); }
+        catch { head = _execGitInRepo(target, ['symbolic-ref', 'HEAD'], 5000); }
+        if (!head) throw new Error('empty git ref');
         detected.mainBranch = head.replace('refs/remotes/origin/', '').replace('refs/heads/', '');
       } catch { detected.mainBranch = 'main'; }
       try {
-        const remoteUrl = ex('git remote get-url origin', { cwd: target, encoding: 'utf8', timeout: 5000 }).trim();
+        const remoteUrl = _execGitInRepo(target, ['remote', 'get-url', 'origin'], 5000);
         if (remoteUrl.includes('github.com')) {
           detected.repoHost = 'github';
           const m = remoteUrl.match(/github\.com[:/]([^/]+)\/([^/.]+)/);
@@ -3906,6 +3919,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       config.projects.push(project);
       safeWrite(configPath, config);
       reloadConfig(); // Update in-memory project list immediately
+      invalidateStatusCache();
 
       // Create project-local state files
       const minionsDir = path.join(target, '.minions');
@@ -3969,7 +3983,7 @@ What would you like to discuss or change? When you're happy, say "approve" and I
       const results = repos.map(repoPath => {
         const result = { path: repoPath.replace(/\\/g, '/'), name: path.basename(repoPath), host: 'git', linked: existingPaths.has(path.resolve(repoPath)) };
         try {
-          const remoteUrl = require('child_process').execSync('git remote get-url origin', { cwd: repoPath, encoding: 'utf8', timeout: 3000, stdio: ['pipe', 'pipe', 'pipe'] }).trim();
+          const remoteUrl = _execGitInRepo(repoPath, ['remote', 'get-url', 'origin'], 3000);
           const gh = remoteUrl.match(/github\.com[:/]([^/]+)\/([^/.]+)/);
           const ado = remoteUrl.match(/dev\.azure\.com\/([^/]+)\/([^/]+)\/_git\/([^/\s]+)/) || remoteUrl.match(/([^.]+)\.visualstudio\.com.*?\/([^/]+)\/_git\/([^/\s]+)/);
           if (gh) { result.host = 'GitHub'; result.org = gh[1]; result.name = gh[2]; }

package/engine/lifecycle.js

@@ -892,6 +892,23 @@ function parseReviewVerdict(text) {
   return null;
 }
 
+/**
+ * Detect "idempotent bailout" output from a review agent — the agent saw a
+ * prior review on the PR (or the same dispatchKey re-fired) and chose to bail
+ * rather than spam a duplicate comment.
+ *
+ * Such output is intentionally short and contains no VERDICT keyword. Treating
+ * it as a retryable failure burns _retryCount and eventually flips the WI to
+ * status=failed even though the original review was successfully posted (#1770).
+ *
+ * @param {string} text - Agent output / resultSummary
+ * @returns {boolean}
+ */
+function isReviewBailout(text) {
+  if (!text || typeof text !== 'string') return false;
+  return /bail(ing)?\s+out/i.test(text) || /already\s+posted/i.test(text);
+}
+
 async function updatePrAfterReview(agentId, pr, project, config, resultSummary) {
 
   if (!pr?.id) return;
@@ -1657,9 +1674,18 @@ async function runPostCompletionHooks(dispatchItem, agentId, code, stdout, confi
   // same pattern as plan-to-prd (#893): updateWorkItemStatus deletes _retryCount, so the check
   // must read/increment it before that happens. Also sets skipDoneStatus so completedAt isn't
   // written and then left dangling when status is reset to pending for retry.
+  //
+  // (#1770) Idempotent bailout: if the agent explicitly bailed because a review was
+  // already posted (e.g. the WI got re-dispatched before lifecycle marked the first
+  // run done), treat the run as success — fall through to mark DONE without retry.
+  // Without this, the second run produces no VERDICT, _retryCount increments,
+  // and after 3 such bailouts the WI flips to status=failed even though the
+  // original review was posted on the first run.
   if (effectiveSuccess && type === WORK_TYPE.REVIEW && meta?.item?.id) {
     const verdict = parseReviewVerdict(resultSummary);
-    if (!verdict) {
+    if (!verdict && isReviewBailout(resultSummary)) {
+      log('info', `Review ${meta.item.id} bailed out (review already posted) — treating as DONE without retry`);
+    } else if (!verdict) {
       skipDoneStatus = true;
       const wiPath = resolveWorkItemPath(meta);
       if (wiPath) {
@@ -1672,6 +1698,8 @@ async function runPostCompletionHooks(dispatchItem, agentId, code, stdout, confi
             if (retries < ENGINE_DEFAULTS.maxRetries) {
               w.status = WI_STATUS.PENDING;
               w._retryCount = retries + 1;
+              w._lastRetryAt = ts();
+              w._lastRetryReason = 'no review verdict';
               delete w.dispatched_at;
               delete w.completedAt;
               log('warn', `Review ${meta.item.id} completed without verdict — auto-retry ${retries + 1}/${ENGINE_DEFAULTS.maxRetries}`);
@@ -2162,6 +2190,7 @@ module.exports = {
   updateMetrics,
   parseAgentOutput,
   parseReviewVerdict,
+  isReviewBailout,
   parseStructuredCompletion,
   runPostCompletionHooks,
   syncPrdFromPrs,

package/engine/shared.js

@@ -758,6 +758,7 @@ const ENGINE_DEFAULTS = {
   evalMaxIterations: 3, // max review→fix cycles before escalating to human
   evalMaxCost: null, // USD ceiling per work item across all eval iterations; null = no limit (gather baseline data first)
   maxRetries: 3, // max dispatch retries before marking work item as failed
+  minRetryGapMs: 120000, // 2min — minimum gap between retry dispatches for the same work item; prevents tight retry loops when an idempotent agent (e.g. review bailing out on a duplicate) cannot produce the expected output (#1770)
   pipelineApiRetries: 2, // max attempts for pipeline API calls
   pipelineApiRetryDelay: 2000, // ms delay between pipeline API retries
   versionCheckInterval: 3600000, // 1 hour — how often to check npm for updates (ms)

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1567",
+  "version": "0.1.1569",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"