@yemi33/minions 0.1.1565 → 0.1.1566

package/CHANGELOG.md

@@ -1,8 +1,12 @@
 # Changelog
 
-## 0.1.1565 (2026-04-27)
+## 0.1.1566 (2026-04-27)
+
+### Features
+- hook Teams pr-approved event in poll loops (#1759)
 
 ### Other
+- test(dashboard): add unit tests for getMcpServers, _filterCcTabSessions, _getVersionCheckInterval, _parseWatchInterval, parsePinnedEntries (#1753)
 - docs(sched-weekly-docs-cleanup-1776960000531): sync stale references with current source (#1750)
 
 ## 0.1.1564 (2026-04-27)

package/dashboard.js

@@ -5521,71 +5521,86 @@ What would you like to discuss or change? When you're happy, say "approve" and I
   }
 });
 
-server.listen(PORT, '127.0.0.1', () => {
-  console.log(`\n  Minions Mission Control`);
-  console.log(`  -----------------------------------`);
-  console.log(`  http://localhost:${PORT}`);
-  console.log(`\n  Watching:`);
-  console.log(`  Minions dir:  ${MINIONS_DIR}`);
-  console.log(`  Projects:   ${PROJECTS.map(p => `${p.name} (${p.localPath})`).join(', ')}`);
-  console.log(`\n  Auto-refreshes every 4s. Ctrl+C to stop.\n`);
-
-  const { exec } = require('child_process');
-  try {
-    if (process.platform === 'win32') {
-      exec(`start "" "http://localhost:${PORT}"`);
-    } else if (process.platform === 'darwin') {
-      exec(`open http://localhost:${PORT}`);
-    } else {
-      exec(`xdg-open http://localhost:${PORT}`);
-    }
-  } catch (e) {
-    console.log(`  Could not auto-open browser: ${e.message}`);
-    console.log(`  Please open http://localhost:${PORT} manually.`);
-  }
+// Exported for testing — pure helpers with no hidden side effects.
+// Production entry points use the closures directly; tests import via require('./dashboard').
+module.exports = {
+  getMcpServers,
+  _filterCcTabSessions,
+  _getVersionCheckInterval,
+  _parseWatchInterval,
+  parsePinnedEntries,
+};
 
-  // ─── Engine Watchdog ─────────────────────────────────────────────────────
-  // Every 30s, check if engine PID is alive. If dead but control.json says
-  // running, auto-restart it. Prevents silent engine death.
-  const { execSync } = require('child_process');
-  setInterval(() => {
+// Start the HTTP server only when run directly (node dashboard.js).
+// When required as a module (e.g. by unit tests), skip the listen/watchdog/signal
+// handlers so tests can import exported helpers without binding to port 7331.
+if (require.main === module) {
+  server.listen(PORT, '127.0.0.1', () => {
+    console.log(`\n  Minions Mission Control`);
+    console.log(`  -----------------------------------`);
+    console.log(`  http://localhost:${PORT}`);
+    console.log(`\n  Watching:`);
+    console.log(`  Minions dir:  ${MINIONS_DIR}`);
+    console.log(`  Projects:   ${PROJECTS.map(p => `${p.name} (${p.localPath})`).join(', ')}`);
+    console.log(`\n  Auto-refreshes every 4s. Ctrl+C to stop.\n`);
+
+    const { exec } = require('child_process');
     try {
-      const control = getEngineState();
-      if (control.state !== 'running' || !control.pid) return;
+      if (process.platform === 'win32') {
+        exec(`start "" "http://localhost:${PORT}"`);
+      } else if (process.platform === 'darwin') {
+        exec(`open http://localhost:${PORT}`);
+      } else {
+        exec(`xdg-open http://localhost:${PORT}`);
+      }
+    } catch (e) {
+      console.log(`  Could not auto-open browser: ${e.message}`);
+      console.log(`  Please open http://localhost:${PORT} manually.`);
+    }
 
-      // Check if PID is alive
-      let alive = false;
+    // ─── Engine Watchdog ─────────────────────────────────────────────────────
+    // Every 30s, check if engine PID is alive. If dead but control.json says
+    // running, auto-restart it. Prevents silent engine death.
+    const { execSync } = require('child_process');
+    setInterval(() => {
       try {
-        if (process.platform === 'win32') {
-          const out = execSync(`tasklist /FI "PID eq ${control.pid}" /NH`, { encoding: 'utf8', timeout: 3000, windowsHide: true });
-          alive = out.includes(String(control.pid));
-        } else {
-          process.kill(control.pid, 0); // signal 0 = check existence
-          alive = true;
-        }
-      } catch { alive = false; }
+        const control = getEngineState();
+        if (control.state !== 'running' || !control.pid) return;
+
+        // Check if PID is alive
+        let alive = false;
+        try {
+          if (process.platform === 'win32') {
+            const out = execSync(`tasklist /FI "PID eq ${control.pid}" /NH`, { encoding: 'utf8', timeout: 3000, windowsHide: true });
+            alive = out.includes(String(control.pid));
+          } else {
+            process.kill(control.pid, 0); // signal 0 = check existence
+            alive = true;
+          }
+        } catch { alive = false; }
 
-      if (!alive) {
-        console.log(`[watchdog] Engine PID ${control.pid} is dead — auto-restarting...`);
-        restartEngine();
+        if (!alive) {
+          console.log(`[watchdog] Engine PID ${control.pid} is dead — auto-restarting...`);
+          restartEngine();
+        }
+      } catch (e) {
+        console.error(`[watchdog] Error: ${e.message}`);
       }
-    } catch (e) {
-      console.error(`[watchdog] Error: ${e.message}`);
-    }
-  }, 30000);
-  console.log(`  Engine watchdog: active (checks every 30s)`);
-});
+    }, 30000);
+    console.log(`  Engine watchdog: active (checks every 30s)`);
+  });
 
-server.on('error', e => {
-  if (e.code === 'EADDRINUSE') {
-    console.error(`\n  Port ${PORT} already in use. Kill the existing process or change PORT.\n`);
-  } else {
-    console.error(e);
-  }
-  process.exit(1);
-});
+  server.on('error', e => {
+    if (e.code === 'EADDRINUSE') {
+      console.error(`\n  Port ${PORT} already in use. Kill the existing process or change PORT.\n`);
+    } else {
+      console.error(e);
+    }
+    process.exit(1);
+  });
 
-// ── Graceful shutdown: flush debounced writes ──────────────────────────────
-server.on('close', () => flushPendingDocSessions());
-process.on('SIGTERM', () => { flushPendingDocSessions(); process.exit(0); });
-process.on('SIGINT', () => { flushPendingDocSessions(); process.exit(0); });
+  // ── Graceful shutdown: flush debounced writes ──────────────────────────────
+  server.on('close', () => flushPendingDocSessions());
+  process.on('SIGTERM', () => { flushPendingDocSessions(); process.exit(0); });
+  process.on('SIGINT', () => { flushPendingDocSessions(); process.exit(0); });
+}

package/engine/ado.js

@@ -430,6 +430,12 @@ async function pollPrStatus(config) {
       if (newReviewStatus === 'approved') {
         delete pr._reviewFixCycles;
         delete pr._evalEscalated;
+        // Teams notification for PR approval — non-blocking, edge-triggered (only on transition)
+        try {
+          const teams = require('./teams');
+          const prFilePath = shared.projectPrPath(project);
+          teams.teamsNotifyPrEvent(pr, 'pr-approved', project, prFilePath).catch(() => {});
+        } catch {}
       }
     }
 

package/engine/github.js

@@ -414,6 +414,12 @@ async function pollPrStatus(config) {
         if (newReviewStatus === 'approved') {
           delete pr._reviewFixCycles;
           delete pr._evalEscalated;
+          // Teams notification for PR approval — non-blocking, edge-triggered (only on transition)
+          try {
+            const teams = require('./teams');
+            const prFilePath = shared.projectPrPath(project);
+            teams.teamsNotifyPrEvent(pr, 'pr-approved', project, prFilePath).catch(() => {});
+          } catch {}
         }
       }
     }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1565",
+  "version": "0.1.1566",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"