@yemi33/minions 0.1.155 → 0.1.156

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Changelog
 
+## 0.1.156 (2026-04-02)
+
+### Engine
+- engine.js
+- engine/shared.js
+
+### Dashboard
+- dashboard/js/render-plans.js
+- dashboard/js/render-prd.js
+
+### Other
+- test/unit.test.js
+
 ## 0.1.155 (2026-04-02)
 
 ### Engine

package/dashboard/js/render-plans.js

@@ -66,9 +66,7 @@ function derivePlanStatus(prdFile, mdFile, prdJsonStatus, workItems) {
   const implementWi = wi.filter(w => w.type !== 'plan-to-prd' && w.type !== 'verify');
   const hasPendingPrd = wi.some(w => w.type === 'plan-to-prd' && (w.status === 'pending' || w.status === 'dispatched'));
   const hasActiveWork = implementWi.some(w => w.status === 'pending' || w.status === 'dispatched');
-  const allDone = implementWi.length > 0 && implementWi.every(w =>
-    w.status === 'done'
-  );
+  const allDone = implementWi.length > 0 && implementWi.every(w => w.status === 'done');
   const hasFailed = implementWi.some(w => w.status === 'failed');
 
   // User-set statuses take priority when no work has started
@@ -304,6 +302,48 @@ function openArchivedPlansModal() {
   document.getElementById('modal').classList.add('open');
 }
 
+// Disable all PRD action buttons to prevent double-clicks
+function qaDisablePrdButtons() {
+  const container = document.getElementById('qa-generate-prd-btn');
+  if (container) container.querySelectorAll('button').forEach(b => { b.disabled = true; b.style.opacity = '0.5'; });
+}
+
+// Show plan version action buttons (Run alongside / Replace / Just save)
+function showPlanVersionActions(thread, newFile, originalFile) {
+  const esc = newFile.replace(/'/g, "\\'");
+  // Look up existing PRD for the original plan's project
+  const allPlans = window._lastStatus?.plans || [];
+  const origPlan = allPlans.find(p => p.file === originalFile);
+  const project = origPlan?.project || '';
+  const existingPrd = allPlans.find(p => p.file.endsWith('.json') && p.project === project && p.status !== 'completed');
+
+  const btn = document.createElement('div');
+  btn.id = 'qa-generate-prd-btn';
+  btn.style.cssText = 'margin:8px 0;padding:8px 12px;background:rgba(63,185,80,0.1);border:1px solid rgba(63,185,80,0.3);border-radius:6px;display:flex;flex-wrap:wrap;align-items:center;gap:8px';
+
+  if (existingPrd) {
+    btn.innerHTML = '<span style="color:var(--green);font-weight:600;font-size:12px;width:100%">New plan version created — existing PRD running</span>' +
+      '<button onclick="qaNewPrd(\'' + esc + '\')" style="background:var(--green);color:#fff;border:none;border-radius:4px;padding:4px 12px;font-size:11px;font-weight:600;cursor:pointer" title="Execute this plan as a separate PRD alongside the current one">Run alongside</button>' +
+      '<button onclick="qaReplacePrd(\'' + esc + '\')" style="background:var(--orange);color:#fff;border:none;border-radius:4px;padding:4px 12px;font-size:11px;font-weight:600;cursor:pointer" title="Pause existing PRD, clean pending items, execute this plan instead">Replace old PRD</button>' +
+      '<button onclick="qaJustSave(this)" style="background:var(--surface2);color:var(--text);border:1px solid var(--border);border-radius:4px;padding:4px 12px;font-size:11px;cursor:pointer" title="Keep the new version saved without dispatching any work">Just save</button>' +
+      '<span style="color:var(--muted);font-size:10px;width:100%">Run alongside keeps current work going. Replace pauses it and starts fresh.</span>';
+  } else {
+    btn.innerHTML = '<span style="color:var(--green);font-weight:600;font-size:12px;width:100%">New plan version created</span>' +
+      '<button onclick="qaNewPrd(\'' + esc + '\')" style="background:var(--green);color:#fff;border:none;border-radius:4px;padding:4px 12px;font-size:11px;font-weight:600;cursor:pointer">Execute plan</button>' +
+      '<button onclick="qaJustSave(this)" style="background:var(--surface2);color:var(--text);border:1px solid var(--border);border-radius:4px;padding:4px 12px;font-size:11px;cursor:pointer">Just save</button>' +
+      '<span style="color:var(--muted);font-size:10px">Execute dispatches an agent to create PRD items from this plan</span>';
+  }
+  // Remove any previous action buttons
+  const old = thread.querySelector('#qa-generate-prd-btn');
+  if (old) old.remove();
+  thread.appendChild(btn);
+}
+
+function qaJustSave(el) {
+  const container = el.closest('#qa-generate-prd-btn');
+  if (container) container.innerHTML = '<span style="color:var(--muted);font-size:11px">Saved. No work dispatched.</span>';
+}
+
 async function planExecute(file, project, btn) {
   if (btn) { btn.textContent = 'Executing...'; btn.disabled = true; btn.style.color = 'var(--blue)'; }
   try {
@@ -694,4 +734,4 @@ async function planUnarchive(file, btn) {
   } catch (e) { resetBtn(); alert('Error: ' + e.message); }
 }
 
-window.MinionsPlans = { openCreatePlanModal, refreshPlans, derivePlanStatus, renderPlans, openArchivedPlansModal, planExecute, planSubmitRevise, planShowRevise, planHideRevise, planView, planApprove, planArchive, planUnarchive, planDelete, planPause, planReject, planDiscuss, planOpenInDocChat, planRegeneratePRD, openVerifyGuide, triggerVerify };
+window.MinionsPlans = { openCreatePlanModal, refreshPlans, derivePlanStatus, renderPlans, openArchivedPlansModal, qaDisablePrdButtons, showPlanVersionActions, qaJustSave, planExecute, planSubmitRevise, planShowRevise, planHideRevise, planView, planApprove, planArchive, planUnarchive, planDelete, planPause, planReject, planDiscuss, planOpenInDocChat, planRegeneratePRD, openVerifyGuide, triggerVerify };

package/dashboard/js/render-prd.js

@@ -116,7 +116,7 @@ function renderPrdProgress(prog) {
       'failed':      'background:rgba(248,81,73,0.15);color:var(--red)',
       'paused':      'background:rgba(139,148,158,0.15);color:var(--muted)',
     };
-    const labels = { 'done': 'DONE', 'in-progress': 'WIP', 'failed': 'FAIL', 'paused': 'PAUSED', 'missing': '—' };
+    const labels = { 'done': 'DONE', 'in-progress': 'WIP', 'failed': 'FAIL', 'paused': 'PAUSED', 'missing': '\u2014' };
     const style = styles[s] || 'background:var(--surface);color:var(--muted)';
     const label = labels[s] || '—';
     return '<span style="font-size:9px;font-weight:700;padding:2px 6px;border-radius:3px;letter-spacing:0.5px;white-space:nowrap;' + style + '">' + label + '</span>';

package/engine/shared.js

@@ -501,7 +501,27 @@ function parseSkillFrontmatter(content, filename) {
 // Never touched by polling loops — only written when a PR is first linked to a PRD item.
 
 function getPrLinks() {
-  try { return JSON.parse(require('fs').readFileSync(PR_LINKS_PATH, 'utf8')); } catch { return {}; }
+  // Derive from PR.prdItems (single source of truth) + legacy pr-links.json as fallback
+  const links = {};
+  try {
+    const projects = getProjects();
+    for (const project of projects) {
+      const prs = safeJson(projectPrPath(project)) || [];
+      for (const pr of prs) {
+        for (const itemId of (pr.prdItems || [])) {
+          if (!links[pr.id]) links[pr.id] = itemId;
+        }
+      }
+    }
+  } catch { /* optional */ }
+  // Merge legacy pr-links.json for items not yet in PR.prdItems
+  try {
+    const legacy = JSON.parse(require('fs').readFileSync(PR_LINKS_PATH, 'utf8'));
+    for (const [prId, itemId] of Object.entries(legacy)) {
+      if (!links[prId]) links[prId] = itemId;
+    }
+  } catch { /* optional */ }
+  return links;
 }
 
 function addPrLink(prId, itemId) {
@@ -512,6 +532,33 @@ function addPrLink(prId, itemId) {
   safeWrite(PR_LINKS_PATH, links);
 }
 
+/**
+ * Locked mutation of a project's pull-requests.json.
+ * Single source of truth for PR data including prdItems links.
+ */
+function mutatePrs(project, mutateFn) {
+  const prPath = projectPrPath(project);
+  return mutateJsonFileLocked(prPath, (prs) => {
+    return mutateFn(Array.isArray(prs) ? prs : []);
+  }, { defaultValue: [] });
+}
+
+/**
+ * Link a PR to a work item via PR.prdItems (single source of truth).
+ * Uses file-locked mutation to prevent race conditions.
+ */
+function linkPrToItem(project, prId, itemId) {
+  if (!prId || !itemId) return;
+  mutatePrs(project, (prs) => {
+    const pr = prs.find(p => p.id === prId);
+    if (pr) {
+      pr.prdItems = Array.isArray(pr.prdItems) ? pr.prdItems : [];
+      if (!pr.prdItems.includes(itemId)) pr.prdItems.push(itemId);
+    }
+    return prs;
+  });
+}
+
 module.exports = {
   MINIONS_DIR,
   PR_LINKS_PATH,
@@ -549,6 +596,8 @@ module.exports = {
   projectPrPath,
   getPrLinks,
   addPrLink,
+  mutatePrs,
+  linkPrToItem,
   nextWorkItemId,
   getAdoOrgBase,
   sanitizePath,

package/engine.js

@@ -307,7 +307,7 @@ function spawnAgent(dispatchItem, config) {
 
           if (isSharedBranch) {
             log('info', `Creating worktree for shared branch: ${worktreePath} on ${branchName}`);
-            try { exec(`git fetch origin "${branchName}"`, { ..._gitOpts, cwd: rootDir }); } catch (e) { log('warn', 'git: ' + e.message); }
+            try { exec(`git fetch origin "${branchName}"`, { ..._gitOpts, cwd: rootDir }); } catch (e) { log('warn', 'git fetch: ' + e.message); }
             try {
               runWorktreeAdd(rootDir, worktreePath, `"${branchName}"`, _worktreeGitOpts, worktreeCreateRetries);
             } catch (eShared) {
@@ -317,6 +317,11 @@ function spawnAgent(dispatchItem, config) {
                   log('info', `Shared branch ${branchName} already checked out at ${existingWtPath} — reusing`);
                   worktreePath = existingWtPath;
                 } else { throw eShared; }
+              } else if (eShared.message?.includes('invalid reference') || eShared.message?.includes('not a valid branch')) {
+                // Branch doesn't exist yet — create it from main
+                log('info', `Shared branch ${branchName} not found — creating from ${project.mainBranch || 'main'}`);
+                const mainRef = sanitizeBranch(project.mainBranch || 'main');
+                runWorktreeAdd(rootDir, worktreePath, `-b "${branchName}" ${mainRef}`, _worktreeGitOpts, worktreeCreateRetries);
               } else { throw eShared; }
             }
           } else {
@@ -1190,9 +1195,17 @@ function materializePlansAsWorkItems(config) {
           const root = path.resolve(firstProject.localPath);
           const mainBranch = firstProject.mainBranch || 'main';
           const branch = sanitizeBranch(plan.feature_branch);
-          // Create branch from main (idempotent — ignores if exists)
-          exec(`git branch "${branch}" "${mainBranch}" 2>/dev/null || true`, { cwd: root, stdio: 'pipe' });
-          exec(`git push -u origin "${branch}" 2>/dev/null || true`, { cwd: root, stdio: 'pipe' });
+          // Create branch from main — verify it actually succeeded
+          try {
+            exec(`git branch "${branch}" "${mainBranch}"`, { cwd: root, stdio: 'pipe', windowsHide: true });
+          } catch (e) {
+            // Branch may already exist — that's fine
+            if (!e.message?.includes('already exists')) throw e;
+          }
+          // Push to remote (best-effort — may not have a remote)
+          try {
+            exec(`git push -u origin "${branch}"`, { cwd: root, stdio: 'pipe', windowsHide: true, timeout: 15000 });
+          } catch { /* no remote or push failed — branch still exists locally */ }
           log('info', `Shared branch pre-created: ${branch} for plan ${file}`);
         } catch (err) {
           log('warn', `Failed to pre-create shared branch for ${file}: ${err.message}`);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.155",
+  "version": "0.1.156",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"