@yemi33/minions 0.1.153 → 0.1.154

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.153 (2026-04-02)
+## 0.1.154 (2026-04-02)
 
 ### Engine
 - engine.js
@@ -11,12 +11,15 @@
 ### Dashboard
 - dashboard.html
 - dashboard.js
+- dashboard/js/command-center.js
 - dashboard/js/modal-qa.js
 - dashboard/js/modal.js
+- dashboard/js/refresh.js
 - dashboard/js/render-inbox.js
 - dashboard/js/render-kb.js
 - dashboard/js/render-plans.js
 - dashboard/js/render-prd.js
+- dashboard/js/render-work-items.js
 - dashboard/styles.css
 
 ### Documentation

package/dashboard/js/command-center.js

@@ -88,7 +88,7 @@ function ccAddMessage(role, html, skipSave) {
   const isUser = role === 'user';
   const div = document.createElement('div');
   const isAssistant = !isUser;
-  div.className = isAssistant ? 'cc-msg-assistant' : '';
+  div.className = isAssistant ? 'cc-msg-assistant md-content' : '';
   div.style.cssText = 'padding:8px 12px;border-radius:8px;font-size:12px;line-height:1.6;max-width:95%;' +
     (isUser ? 'background:var(--blue);color:#fff;align-self:flex-end' : 'background:var(--surface2);color:var(--text);align-self:flex-start;border:1px solid var(--border);position:relative');
   div.innerHTML = (isAssistant && !html.includes('color:var(--red)') && !html.includes('cc-queued-pill') ? llmCopyBtn() : '') + html;
@@ -205,11 +205,9 @@ async function _ccDoSend(message, skipUserMsg) {
       ccUpdateSessionIndicator();
     }
 
-    // Render markdown-ish response
+    // Render markdown response
     const ccElapsed = Math.round((Date.now() - ccStartTime) / 1000);
-    const rendered = (data.text || '').replace(/\*\*(.+?)\*\*/g, '<strong>$1</strong>')
-      .replace(/`([^`]+)`/g, '<code style="background:var(--surface);padding:1px 4px;border-radius:3px;font-size:11px">$1</code>')
-      .replace(/\n/g, '<br>');
+    const rendered = renderMd(data.text || '');
     ccAddMessage('assistant', rendered + '<div style="font-size:9px;color:var(--muted);margin-top:6px;display:flex;justify-content:flex-end;padding-right:30px">' + ccElapsed + 's</div>');
 
     // Execute actions

package/dashboard/js/refresh.js

@@ -2,6 +2,7 @@
 
 // Sidebar activity indicators — detect changes between refreshes
 let _prevCounts = {};
+let _prevEngineAlert = false;
 function _detectPageChanges(data) {
   const counts = {
     completions: (data.dispatch?.completed || []).length,
@@ -22,9 +23,52 @@ function _detectPageChanges(data) {
     if (counts.meetingRounds > _prevCounts.meetingRounds) changes.meetings = true;
   }
   _prevCounts = counts;
+
+  // Engine page — only badge for genuine problems, not routine activity
+  const engineAlert = _isEngineAlertWorthy(data);
+  if (engineAlert && !_prevEngineAlert) changes.engine = true;
+  // Clear the engine badge when alert condition resolves
+  if (!engineAlert && _prevEngineAlert) {
+    const engineLink = document.querySelector('.sidebar-link[data-page="engine"]');
+    if (engineLink) clearNotifBadge(engineLink);
+  }
+  _prevEngineAlert = engineAlert;
+
   return changes;
 }
 
+/**
+ * Determine if the engine state warrants a notification dot.
+ * Returns true only for genuine problems:
+ * - Engine stopped, stale, or in error state
+ * - 3+ failed work items in the last hour
+ * - Agent timeout/crash detected (error results in recent completions)
+ */
+function _isEngineAlertWorthy(data) {
+  // 1. Engine not running (stopped, stale, or error)
+  const engineState = data.engine?.state || 'stopped';
+  if (engineState === 'stopped' || engineState === 'error') return true;
+  // Stale heartbeat (>2 min old while claiming running)
+  if (engineState === 'running' && data.engine?.heartbeat) {
+    if (Date.now() - data.engine.heartbeat > 120000) return true;
+  }
+
+  // 2. 3+ failed work items in the last hour
+  const oneHourAgo = Date.now() - 3600000;
+  const recentFailures = (data.workItems || []).filter(w =>
+    w.status === 'failed' && w.updated_at && new Date(w.updated_at).getTime() > oneHourAgo
+  );
+  if (recentFailures.length >= 3) return true;
+
+  // 3. Agent timeout/crash — 3+ error results in recent completed dispatches
+  const recentErrors = (data.dispatch?.completed || []).filter(d =>
+    d.result === 'error' && d.completed_at && new Date(d.completed_at).getTime() > oneHourAgo
+  );
+  if (recentErrors.length >= 3) return true;
+
+  return false;
+}
+
 function _processStatusUpdate(data) {
   // Detect fresh install — clear stale browser state if install ID changed
   if (data.installId) {

package/dashboard/js/render-work-items.js

@@ -4,6 +4,30 @@ let allWorkItems = [];
 let wiPage = 0;
 const WI_PER_PAGE = 20;
 
+// Track retry state per work item so loading/success/error survives re-renders
+const _wiRetryState = {}; // { [id]: { status: 'pending'|'done'|'error', message?, until? } }
+function setWiRetryState(id, state) { _wiRetryState[id] = state; }
+function getWiRetryState(id) {
+  const s = _wiRetryState[id];
+  if (!s) return null;
+  if (s.until && Date.now() > s.until) { delete _wiRetryState[id]; return null; }
+  return s;
+}
+
+function wiRetryBtn(item) {
+  const rs = getWiRetryState(item.id);
+  if (rs && rs.status === 'pending') {
+    return '<span style="font-size:9px;padding:1px 6px;color:var(--yellow);border:1px solid rgba(210,153,34,0.35);background:rgba(210,153,34,0.1);border-radius:3px;cursor:wait;margin-left:4px">Retrying\u2026</span>';
+  }
+  if (rs && rs.status === 'done') {
+    return '<span style="font-size:9px;padding:1px 6px;color:var(--green);border:1px solid rgba(63,185,80,0.35);background:rgba(63,185,80,0.1);border-radius:3px;margin-left:4px">Requeued</span>';
+  }
+  if (rs && rs.status === 'error') {
+    return '<span style="font-size:9px;padding:1px 6px;color:var(--red);border:1px solid rgba(248,81,73,0.35);background:rgba(248,81,73,0.1);border-radius:3px;margin-left:4px;cursor:pointer" title="' + escHtml(rs.message || 'Retry failed') + ' — click to try again" onclick="event.stopPropagation();retryWorkItem(\'' + escHtml(item.id) + '\',\'' + escHtml(item._source || '') + '\')">Retry failed</span>';
+  }
+  return '<button class="pr-pager-btn" style="font-size:9px;padding:1px 6px;color:var(--yellow);border-color:var(--yellow);margin-left:4px" onclick="event.stopPropagation();retryWorkItem(\'' + escHtml(item.id) + '\',\'' + escHtml(item._source || '') + '\')">Retry</button>';
+}
+
 function wiRow(item) {
   const statusBadge = (s) => {
     const cls = s === 'failed' ? 'rejected' : s === 'needs-human-review' ? 'needs-review' : s === 'dispatched' ? 'building' : s === 'pending' || s === 'queued' ? 'active' : s === 'done' ? 'approved' : 'draft';
@@ -23,7 +47,7 @@ function wiRow(item) {
     '<td>' + priBadge(item.priority) + '</td>' +
     '<td>' + statusBadge(item.status || 'pending') +
       (item._pendingReason ? ' <span style="font-size:9px;color:var(--muted);margin-left:4px" title="Pending reason: ' + escHtml(item._pendingReason) + '">' + escHtml(item._pendingReason.replace(/_/g, ' ')) + '</span>' : '') +
-      (item.status === 'failed' ? ' <button class="pr-pager-btn" style="font-size:9px;padding:1px 6px;color:var(--yellow);border-color:var(--yellow);margin-left:4px" onclick="event.stopPropagation();retryWorkItem(\'' + escHtml(item.id) + '\',\'' + escHtml(item._source || '') + '\',this)">Retry</button>' : '') +
+      (item.status === 'failed' ? ' ' + wiRetryBtn(item) : '') +
     '</td>' +
     '<td>' +
       (item.completedAgents && item.completedAgents.length > 0
@@ -92,7 +116,7 @@ function renderWorkItems(items) {
 function editWorkItem(id, source) {
   const item = allWorkItems.find(i => i.id === id);
   if (!item) return;
-  const types = ['implement', 'fix', 'review', 'plan', 'verify', 'investigate', 'refactor', 'test', 'docs'];
+  const types = ['implement', 'fix', 'review', 'plan', 'verify', 'evaluate', 'decompose', 'meeting', 'investigate', 'refactor', 'test', 'explore', 'ask', 'docs'];
   const priorities = ['critical', 'high', 'medium', 'low'];
   const agentOpts = (cmdAgents || []).map(a => '<option value="' + escHtml(a.id) + '"' + (item.agent === a.id ? ' selected' : '') + '>' + escHtml(a.name) + '</option>').join('');
   const typeOpts = types.map(t => '<option value="' + t + '"' + ((item.type || 'implement') === t ? ' selected' : '') + '>' + t + '</option>').join('');
@@ -211,23 +235,33 @@ async function toggleWorkItemArchive() {
   } catch (e) { el.innerHTML = '<p class="empty">Failed to load archive.</p>'; }
 }
 
-async function retryWorkItem(id, source, btn) {
-  if (btn) { btn.dataset.origText = btn.textContent; btn.textContent = 'Retrying...'; btn.style.pointerEvents = 'none'; btn.style.opacity = '0.6'; }
+async function retryWorkItem(id, source) {
+  // Prevent double-click: if already retrying, ignore
+  const existing = getWiRetryState(id);
+  if (existing && existing.status === 'pending') return;
+
+  setWiRetryState(id, { status: 'pending' });
+  renderWorkItems(allWorkItems);
   try {
     const res = await fetch('/api/work-items/retry', {
       method: 'POST', headers: { 'Content-Type': 'application/json' },
       body: JSON.stringify({ id, source: source || undefined })
     });
     if (res.ok) {
+      setWiRetryState(id, { status: 'done', until: Date.now() + 8000 });
       showToast('cmd-toast', 'Work item ' + id + ' reset to pending', true);
       wakeEngine();
       refresh();
     } else {
-      if (btn) { btn.textContent = btn.dataset.origText || 'Retry'; btn.style.pointerEvents = ''; btn.style.opacity = ''; }
       const d = await res.json().catch(() => ({}));
-      alert('Retry failed: ' + (d.error || 'unknown'));
+      const msg = d.error || 'unknown';
+      setWiRetryState(id, { status: 'error', message: msg, until: Date.now() + 10000 });
+      renderWorkItems(allWorkItems);
     }
-  } catch (e) { if (btn) { btn.textContent = btn.dataset.origText || 'Retry'; btn.style.pointerEvents = ''; btn.style.opacity = ''; } alert('Retry error: ' + e.message); }
+  } catch (e) {
+    setWiRetryState(id, { status: 'error', message: e.message, until: Date.now() + 10000 });
+    renderWorkItems(allWorkItems);
+  }
 }
 
 function wiPrev() { if (wiPage > 0) { wiPage--; renderWorkItems(allWorkItems); } }
@@ -282,7 +316,7 @@ async function submitFeedback(id, source) {
 }
 
 function openCreateWorkItemModal() {
-  const typeOpts = ['implement', 'fix', 'explore', 'test', 'review', 'ask', 'plan'].map(t =>
+  const typeOpts = ['implement', 'fix', 'explore', 'test', 'review', 'ask', 'plan', 'verify', 'evaluate', 'decompose', 'meeting'].map(t =>
     '<option value="' + t + '"' + (t === 'implement' ? ' selected' : '') + '>' + t + '</option>'
   ).join('');
   const priOpts = ['high', 'medium', 'low'].map(p =>

package/dashboard/styles.css

@@ -505,6 +505,10 @@
   .dispatch-type.plan { background: rgba(168,85,247,0.15); color: #a855f7; }
   .dispatch-type.plan-to-prd { background: rgba(168,85,247,0.1); color: #a855f7; }
   .dispatch-type.ask { background: rgba(63,185,80,0.15); color: var(--green); }
+  .dispatch-type.evaluate { background: rgba(248,81,73,0.15); color: var(--red); }
+  .dispatch-type.verify { background: rgba(63,185,80,0.2); color: var(--green); }
+  .dispatch-type.meeting { background: rgba(88,166,255,0.2); color: var(--blue); }
+  .dispatch-type.decompose { background: rgba(188,140,255,0.2); color: var(--purple); }
   .dispatch-type.manual { background: rgba(139,148,158,0.15); color: var(--muted); }
   .dispatch-agent { font-weight: 600; color: var(--text); }
   .dispatch-task { flex: 1; color: var(--muted); white-space: nowrap; overflow: hidden; text-overflow: ellipsis; }

package/engine/lifecycle.js

@@ -603,7 +603,14 @@ function syncPrsFromOutput(output, agentId, meta, config) {
       dirtyTargets.set(targetName, { prs: safeJson(prPath) || [], prPath });
     }
     const entry = dirtyTargets.get(targetName);
-    if (entry.prs.some(p => p.id === fullId || String(p.id) === String(prId))) continue;
+    const existing = entry.prs.find(p => p.id === fullId || String(p.id) === String(prId));
+    if (existing) {
+      // Backfill prdItems if the entry was added by the poller before syncPrsFromOutput ran
+      if (meta?.item?.id && !existing.prdItems?.includes(meta.item.id)) {
+        existing.prdItems = [...(existing.prdItems || []), meta.item.id];
+      }
+      continue;
+    }
 
     let title = meta?.item?.title || '';
     const titleMatch = output.match(new RegExp(`${prId}[^\\n]*?[—–-]\\s*([^\\n]+)`, 'i'));
@@ -637,10 +644,26 @@ function syncPrsFromOutput(output, agentId, meta, config) {
 
 // ─── Post-Completion Hooks ──────────────────────────────────────────────────
 
+/**
+ * Resolve which project's pull-requests.json contains a given PR ID.
+ * Returns the project object, or null if not found in any project file.
+ */
+function resolveProjectForPr(prId) {
+  const config = getConfig();
+  for (const p of shared.getProjects(config)) {
+    const prs = safeJson(projectPrPath(p)) || [];
+    if (prs.some(pr => pr.id === prId)) return p;
+  }
+  return null;
+}
+
 function updatePrAfterReview(agentId, pr, project) {
 
   if (!pr?.id) return;
-  const prs = getPrs(project);
+  // Resolve actual project if not provided — avoids writing merged array to wrong path
+  const resolvedProject = project || resolveProjectForPr(pr.id);
+  if (!resolvedProject) { log('warn', `updatePrAfterReview: cannot resolve project for ${pr.id}`); return; }
+  const prs = getPrs(resolvedProject);
   const target = prs.find(p => p.id === pr.id);
   if (!target) return;
 
@@ -674,7 +697,7 @@ function updatePrAfterReview(agentId, pr, project) {
     shared.safeWrite(metricsPath, metrics);
   }
 
-  shared.safeWrite(project ? shared.projectPrPath(project) : path.join(path.resolve(MINIONS_DIR, '..'), '.minions', 'pull-requests.json'), prs);
+  shared.safeWrite(shared.projectPrPath(resolvedProject), prs);
   log('info', `Updated ${pr.id} → minions review: ${target.reviewStatus} by ${reviewerName}`);
   createReviewFeedbackForAuthor(agentId, { ...pr, ...target }, config);
 }
@@ -682,7 +705,10 @@ function updatePrAfterReview(agentId, pr, project) {
 function updatePrAfterFix(pr, project, source) {
 
   if (!pr?.id) return;
-  const prs = getPrs(project);
+  // Resolve actual project if not provided — avoids writing merged array to wrong path
+  const resolvedProject = project || resolveProjectForPr(pr.id);
+  if (!resolvedProject) { log('warn', `updatePrAfterFix: cannot resolve project for ${pr.id}`); return; }
+  const prs = getPrs(resolvedProject);
   const target = prs.find(p => p.id === pr.id);
   if (!target) return;
 
@@ -697,7 +723,7 @@ function updatePrAfterFix(pr, project, source) {
     log('info', `Updated ${pr.id} → reviewStatus: waiting (fix pushed)`);
   }
 
-  shared.safeWrite(project ? shared.projectPrPath(project) : path.join(path.resolve(MINIONS_DIR, '..'), '.minions', 'pull-requests.json'), prs);
+  shared.safeWrite(shared.projectPrPath(resolvedProject), prs);
 }
 
 // ─── Post-Merge / Post-Close Hooks ───────────────────────────────────────────
@@ -1323,51 +1349,37 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
   }
 
   if (!isSuccess && meta?.item?.id) {
-    // Auto-retry: read fresh _retryCount from file (not stale dispatch-time snapshot)
-    let retries = (meta.item._retryCount || 0);
-    try {
-      const wiPath = meta.source === 'central-work-item' || meta.source === 'central-work-item-fanout'
-        ? path.join(MINIONS_DIR, 'work-items.json')
-        : meta.project?.name ? path.join(MINIONS_DIR, 'projects', meta.project.name, 'work-items.json') : null;
-      if (wiPath) {
-        const items = safeJson(wiPath) || [];
-        const wi = items.find(i => i.id === meta.item.id);
-        if (wi) retries = (wi._retryCount || 0); // Use fresh value from file
-      }
-    } catch { /* optional */ }
-
-    if (retries < 3) {
-      log('info', `Agent failed for ${meta.item.id} — auto-retry ${retries + 1}/3`);
-      updateWorkItemStatus(meta, 'pending', '');
+    const wiPath = resolveWiPath(meta);
+    if (wiPath) {
+      let finalStatus = null;
       try {
-        const wiPath = meta.source === 'central-work-item' || meta.source === 'central-work-item-fanout'
-          ? path.join(MINIONS_DIR, 'work-items.json')
-          : meta.project?.name ? path.join(MINIONS_DIR, 'projects', meta.project.name, 'work-items.json') : null;
-        if (wiPath) {
-          const items = safeJson(wiPath) || [];
+        mutateJsonFileLocked(wiPath, (items) => {
+          if (!Array.isArray(items)) return items;
           const wi = items.find(i => i.id === meta.item.id);
-          if (wi) {
-            wi._retryCount = retries + 1; wi.status = 'pending'; delete wi.dispatched_at; delete wi.dispatched_to;
-            if (type === 'decompose') delete wi._decomposing; // clear so item can retry decomposition
-            shared.safeWrite(wiPath, items);
+          if (!wi) return items;
+
+          const retries = wi._retryCount || 0;
+          if (retries < 3) {
+            log('info', `Agent failed for ${meta.item.id} — auto-retry ${retries + 1}/3`);
+            wi._retryCount = retries + 1;
+            wi.status = 'pending';
+            delete wi.dispatched_at;
+            delete wi.dispatched_to;
+            finalStatus = 'pending';
+          } else {
+            wi.status = 'failed';
+            wi.failReason = 'Agent failed (3 retries exhausted)';
+            wi.failedAt = ts();
+            finalStatus = 'failed';
           }
-        }
+          if (type === 'decompose') delete wi._decomposing;
+          return items;
+        });
       } catch (err) { log('warn', `Retry update: ${err.message}`); }
-    } else {
-      updateWorkItemStatus(meta, 'failed', 'Agent failed (3 retries exhausted)');
-    }
-    // Clear _decomposing flag on failure so item doesn't get permanently stuck
-    if (type === 'decompose') {
-      try {
-        const wiPath = meta.source === 'central-work-item' || meta.source === 'central-work-item-fanout'
-          ? path.join(MINIONS_DIR, 'work-items.json')
-          : meta.project?.name ? path.join(MINIONS_DIR, 'projects', meta.project.name, 'work-items.json') : null;
-        if (wiPath) {
-          const items = safeJson(wiPath) || [];
-          const wi = items.find(i => i.id === meta.item.id);
-          if (wi) { delete wi._decomposing; shared.safeWrite(wiPath, items); }
-        }
-      } catch (err) { log('warn', `Decompose cleanup: ${err.message}`); }
+      // Sync status to PRD outside the work-items lock
+      if (finalStatus) {
+        syncPrdItemStatus(meta.item.id, finalStatus, meta.item?.sourcePlan);
+      }
     }
   }
   // Meeting post-completion: collect findings/debate/conclusion
@@ -1420,7 +1432,7 @@ function runPostCompletionHooks(dispatchItem, agentId, code, stdout, config) {
   }
 
   // Detect implement tasks that completed without creating a PR
-  if (isSuccess && (type === 'implement' || type === 'implement:large' || type === 'fix') && prsCreatedCount === 0 && meta?.item?.id) {
+  if (isSuccess && (type === 'implement' || type === 'implement:large' || type === 'fix') && prsCreatedCount === 0 && meta?.item?.id && !meta?.item?.skipPr) {
     // Check if a PR already exists linked to this work item (from a previous attempt)
     const projects = shared.getProjects(config);
     const existingPrFound = Object.values(getPrLinks()).includes(meta.item.id);
@@ -1513,6 +1525,7 @@ module.exports = {
   updateWorkItemStatus,
   syncPrdItemStatus,
   syncPrsFromOutput,
+  resolveProjectForPr,
   updatePrAfterReview,
   updatePrAfterFix,
   handlePostMerge,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.153",
+  "version": "0.1.154",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"