@yemi33/minions 0.1.1105 → 0.1.1107

package/CHANGELOG.md

@@ -1,11 +1,12 @@
 # Changelog
 
-## 0.1.1105 (2026-04-18)
+## 0.1.1107 (2026-04-18)
 
 ### Features
 - seed realActivityMap at spawn time, stamp pid in live-output (#1200)
 
 ### Fixes
+- preserve buildErrorLog through transient build states (#1232) (#1274)
 - annotate fast-exit empty-output failures with diagnostic hint (#1276)
 - invalidate PRD cache on pr-links.json change + guard aggregate PRs (#1220) (#1272)
 - pass --add-dir for minions + ~/.claude to agents (#1271)
@@ -23,6 +24,8 @@
 -  harden settings save and migrate pr poll config
 
 ### Other
+- Clarify PR poll labels
+- Prevent modal opens on text selection
 - refactor: clarify settings page section structure and PR polling dependencies
 - refactor: extract _probeClaudePackage helper, use shared.log for spawn errors
 - Make work item descriptions scrollable

package/dashboard/js/render-agents.js

@@ -4,7 +4,7 @@ function renderAgents(agents) {
   agentData = agents;
   const grid = document.getElementById('agents-grid');
   grid.innerHTML = agents.map(a => `
-    <div class="agent-card ${statusColor(a.status)}" onclick="openAgentDetail('${escHtml(a.id)}')">
+    <div class="agent-card ${statusColor(a.status)}" onclick="if(shouldIgnoreSelectionClick(event))return;openAgentDetail('${escHtml(a.id)}')">
       <div class="agent-card-header">
         <span class="agent-name"><span class="agent-emoji">${escHtml(a.emoji)}</span>${escHtml(a.name)}</span>
         <span class="status-badge ${escHtml(a.status)}">${escHtml(a.status)}</span>

package/dashboard/js/render-meetings.js

@@ -48,7 +48,7 @@ function renderMeetings(meetings) {
     const dt = m.completedAt || m.createdAt;
     const timeStr = dt ? new Date(dt).toLocaleString(undefined, { month: 'short', day: 'numeric', hour: 'numeric', minute: '2-digit' }) : '';
 
-    return '<div data-file="meetings/' + escHtml(m.id) + '.json" style="background:var(--surface);border:1px solid var(--border);border-radius:8px;padding:12px 16px;margin-bottom:8px;cursor:pointer;position:relative" onclick="openMeetingDetail(\'' + escHtml(m.id) + '\')">' +
+    return '<div data-file="meetings/' + escHtml(m.id) + '.json" style="background:var(--surface);border:1px solid var(--border);border-radius:8px;padding:12px 16px;margin-bottom:8px;cursor:pointer;position:relative" onclick="if(shouldIgnoreSelectionClick(event))return;openMeetingDetail(\'' + escHtml(m.id) + '\')">' +
       '<div style="display:flex;justify-content:space-between;align-items:center">' +
         '<strong style="font-size:13px">' + escHtml(m.title) + '</strong>' +
         '<div style="display:flex;align-items:center;gap:8px">' +

package/dashboard/js/render-pinned.js

@@ -13,7 +13,7 @@ function renderPinned(entries) {
   el.innerHTML = entries.map((e, i) =>
     '<div class="pinned-card" data-file="pinned:' + escHtml(e.title) + '" style="padding:8px 12px;margin-bottom:6px;background:var(--surface2);border-left:3px solid ' +
       (e.level === 'critical' ? 'var(--red)' : e.level === 'warning' ? 'var(--yellow)' : 'var(--blue)') +
-      ';border-radius:4px;cursor:pointer" onclick="openPinnedView(' + i + ')">' +
+      ';border-radius:4px;cursor:pointer" onclick="if(shouldIgnoreSelectionClick(event))return;openPinnedView(' + i + ')">' +
       '<div style="display:flex;justify-content:space-between;align-items:center">' +
         '<strong style="font-size:var(--text-md)">' + escHtml(e.title) + '</strong>' +
         '<button class="pr-pager-btn" style="font-size:9px;padding:1px 6px;color:var(--red);border-color:var(--red)" data-pin-title="' + escHtml(e.title) + '" onclick="event.stopPropagation();removePinnedNote(this.dataset.pinTitle)">Unpin</button>' +

package/dashboard/js/render-pipelines.js

@@ -277,7 +277,7 @@ function renderPipelines(pipelines) {
     var allResources = _collectMonitoredResources(p);
     var resourcesHtml = _renderMonitoredResources(allResources, { compact: true });
 
-    return '<div style="background:var(--surface);border:1px solid var(--border);border-radius:8px;padding:12px 16px;margin-bottom:8px;cursor:pointer" onclick="openPipelineDetail(\'' + escHtml(p.id) + '\')">' +
+    return '<div style="background:var(--surface);border:1px solid var(--border);border-radius:8px;padding:12px 16px;margin-bottom:8px;cursor:pointer" onclick="if(shouldIgnoreSelectionClick(event))return;openPipelineDetail(\'' + escHtml(p.id) + '\')">' +
       '<div style="display:flex;justify-content:space-between;align-items:center">' +
         '<strong style="font-size:13px">' + escHtml(p.title) + '</strong>' +
         '<div style="display:flex;align-items:center;gap:8px">' +

package/dashboard/js/render-plans.js

@@ -263,7 +263,7 @@ function renderPlans(plans) {
     const versionBadge = p.version ? ' <span style="font-size:9px;font-weight:700;padding:1px 5px;border-radius:3px;background:rgba(56,139,253,0.15);color:var(--blue);vertical-align:middle">v' + p.version + '</span>' : '';
     const statusColors = { 'completed': 'var(--green)', 'dispatched': 'var(--blue)', 'converting': 'var(--yellow)', 'paused': 'var(--muted)', 'awaiting-approval': 'var(--yellow)', 'approved': 'var(--green)', 'rejected': 'var(--red)', 'has-failures': 'var(--red)', 'revision-requested': 'var(--purple,#a855f7)', 'active': 'var(--muted)' };
     const cardClass = effectiveStatus === 'dispatched' || effectiveStatus === 'converting' ? 'working' : effectiveStatus === 'awaiting-approval' || effectiveStatus === 'paused' ? 'awaiting' : effectiveStatus;
-    return '<div class="plan-card ' + cardClass + '" data-file="plans/' + escHtml(p.file) + '" style="cursor:pointer' + (isArchived ? ';opacity:0.7' : '') + '" onclick="planView(\'' + escHtml(p.file) + '\')">' +
+    return '<div class="plan-card ' + cardClass + '" data-file="plans/' + escHtml(p.file) + '" style="cursor:pointer' + (isArchived ? ';opacity:0.7' : '') + '" onclick="if(shouldIgnoreSelectionClick(event))return;planView(\'' + escHtml(p.file) + '\')">' +
       '<div class="plan-card-header">' +
         '<div><div class="plan-card-title">' + escHtml(p.summary || p.file) + versionBadge + '</div>' +
           '<div class="plan-card-meta">' +
@@ -323,7 +323,7 @@ function openArchivedPlansModal() {
   const html = plans.map(p => {
     const itemCount = p.itemCount || 0;
     const completed = p.completedAt ? p.completedAt.slice(0, 10) : '';
-    return '<div class="plan-card" data-file="plans/' + escHtml(p.file) + '" style="cursor:pointer;opacity:0.8" onclick="planView(\'' + escHtml(p.file) + '\')">' +
+    return '<div class="plan-card" data-file="plans/' + escHtml(p.file) + '" style="cursor:pointer;opacity:0.8" onclick="if(shouldIgnoreSelectionClick(event))return;planView(\'' + escHtml(p.file) + '\')">' +
       '<div class="plan-card-header">' +
         '<div><div class="plan-card-title" style="font-size:13px">' + escHtml(p.summary || p.file) + '</div>' +
           '<div class="plan-card-meta">' +

package/dashboard/js/render-prd.js

@@ -203,7 +203,7 @@ function renderPrdProgress(prog) {
       ? '<span onclick="event.stopPropagation();prdItemReopen(\'' + escHtml(i.source || '') + '\',\'' + escHtml(i.id) + '\')" style="color:var(--blue);cursor:pointer;font-size:9px;padding:1px 5px;background:rgba(56,139,253,0.1);border:1px solid rgba(56,139,253,0.3);border-radius:3px" title="Re-open: set to updated so engine re-dispatches on existing branch">re-open</span>'
       : '';
 
-    return '<div class="prd-item-row st-' + (i.status || 'missing') + '" style="flex-wrap:wrap;cursor:pointer" onclick="prdItemEdit(\'' + src + '\',\'' + iid + '\')">' +
+    return '<div class="prd-item-row st-' + (i.status || 'missing') + '" style="flex-wrap:wrap;cursor:pointer" onclick="if(shouldIgnoreSelectionClick(event))return;prdItemEdit(\'' + src + '\',\'' + iid + '\')">' +
       statusBadge(i.status, i.id) +
       '<span class="prd-item-id">' + escHtml(i.id) + '</span>' +
       '<span class="prd-item-name" title="' + escHtml(i.name) + '">' + escHtml(i.name) + '</span>' +
@@ -579,7 +579,7 @@ function openArchivedPrdModal() {
       const done = g.items.filter(it => it.status === 'done').length;
       const failed = g.items.filter(it => it.status === 'failed').length;
       const completed = g.completedAt ? new Date(g.completedAt).toLocaleDateString() : '';
-      return '<div class="plan-card" style="cursor:pointer;margin-bottom:8px" onclick="showArchivedPrdDetail(\'' + escHtml(g.file) + '\')">' +
+      return '<div class="plan-card" style="cursor:pointer;margin-bottom:8px" onclick="if(shouldIgnoreSelectionClick(event))return;showArchivedPrdDetail(\'' + escHtml(g.file) + '\')">' +
         '<div class="plan-card-title" style="font-size:13px">' + escHtml(g.summary || g.file) + '</div>' +
         '<div class="plan-card-meta">' +
           (g._projects.length > 0 ? g._projects.map(function(p) { return '<span>' + escHtml(p) + '</span>'; }).join(' ') : '') +

package/dashboard/js/render-schedules.js

@@ -250,7 +250,7 @@ function _renderScheduleCalendar(schedules) {
         var strikeStyle = s.enabled === false ? 'text-decoration:line-through;' : '';
         var timeLabel = String(sl.hour).padStart(2, '0') + ':' + String(sl.minute).padStart(2, '0');
         html += '<div class="sched-cal-slot" style="background:' + colors.bg + ';border-left-color:' + colors.border + ';color:' + colors.text + ';opacity:' + opacity + '" ' +
-          'onclick="openScheduleDetail(\'' + escHtml(s.id) + '\')" title="' + escHtml(s.title + ' — ' + timeLabel + ' — ' + (s.type || 'implement')) + '">' +
+          'onclick="if(shouldIgnoreSelectionClick(event))return;openScheduleDetail(\'' + escHtml(s.id) + '\')" title="' + escHtml(s.title + ' — ' + timeLabel + ' — ' + (s.type || 'implement')) + '">' +
           '<span style="font-weight:600;' + strikeStyle + '">' + escHtml((s.title || s.id).slice(0, 25)) + '</span>' +
           '<span style="font-size:9px;opacity:0.7"> ' + timeLabel + '</span>' +
         '</div>';
@@ -292,7 +292,7 @@ function renderSchedules(schedules) {
       const lastRun = s._lastRun ? timeAgo(s._lastRun) : 'never';
       const typeBadge = '<span class="dispatch-type ' + escHtml(s.type || 'implement') + '">' + escHtml(s.type || 'implement') + '</span>';
       const humanCron = _cronToHuman(s.cron || '');
-      html += '<tr style="cursor:pointer" onclick="openScheduleDetail(\'' + escHtml(s.id) + '\')">' +
+      html += '<tr style="cursor:pointer" onclick="if(shouldIgnoreSelectionClick(event))return;openScheduleDetail(\'' + escHtml(s.id) + '\')">' +
         '<td><span class="pr-id">' + escHtml(s.id || '') + '</span></td>' +
         '<td style="max-width:200px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap" title="' + escHtml(s.title || '') + '">' + escHtml(s.title || '') + '</td>' +
         '<td><span title="' + escHtml(s.cron || '') + '" style="font-size:11px;color:var(--blue)">' + escHtml(humanCron) + '</span></td>' +

package/dashboard/js/render-watches.js

@@ -89,7 +89,7 @@ function renderWatches(watchesData) {
     var lastTriggered = w.last_triggered ? timeAgo(w.last_triggered) : 'never';
     var triggerInfo = (w.triggerCount || 0) + (w.stopAfter > 0 ? '/' + w.stopAfter : '');
 
-    html += '<tr style="cursor:pointer" onclick="openWatchDetail(\'' + escHtml(w.id) + '\')">' +
+    html += '<tr style="cursor:pointer" onclick="if(shouldIgnoreSelectionClick(event))return;openWatchDetail(\'' + escHtml(w.id) + '\')">' +
       '<td><span class="pr-id">' + escHtml(w.id) + '</span></td>' +
       '<td style="max-width:180px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap" title="' + escHtml(w.description || w.target) + '">' + escHtml(w.target) + '</td>' +
       '<td><span class="dispatch-type explore">' + escHtml(targetLabel) + '</span></td>' +

package/dashboard/js/render-work-items.js

@@ -40,7 +40,7 @@ function wiRow(item) {
     : (item.branchStrategy === 'shared-branch' && item.status === 'done')
       ? '<span style="font-size:9px;color:var(--muted)" title="Part of shared branch — aggregate PR created at verify stage">shared branch</span>'
       : '<span style="color:var(--muted)">—</span>';
-  return '<tr style="cursor:pointer" onclick="if(window.getSelection().toString().length>0)return;openWorkItemDetail(\'' + escHtml(item.id) + '\')">' +
+  return '<tr style="cursor:pointer" onclick="if(shouldIgnoreSelectionClick(event))return;openWorkItemDetail(\'' + escHtml(item.id) + '\')">' +
     '<td><span class="pr-id">' + escHtml(item.id || '') + '</span></td>' +
     '<td style="max-width:220px;overflow:hidden;text-overflow:ellipsis;white-space:nowrap" title="' + escHtml((item.title || '').slice(0, 200)) + '">' + escHtml(item.title || '') + '</td>' +
     '<td><span style="font-size:10px;color:var(--muted)">' + escHtml(item._source || '') + '</span>' +

package/dashboard/js/settings.js

@@ -68,8 +68,8 @@ async function openSettings() {
       '</div>' +
       settingsToggle('GitHub Polling', 'set-ghPollEnabled', e.ghPollEnabled !== false, 'Keeps GitHub PR build results, votes, and comments fresh each tick (reconciliation always runs regardless)') +
       '<div style="display:grid;grid-template-columns:1fr 1fr;gap:8px;margin-top:10px">' +
-        settingsField('Status Poll Frequency', 'set-prPollStatusEvery', e.prPollStatusEvery ?? e.adoPollStatusEvery ?? 12, 'ticks', 'Poll PR build/review/merge status every N ticks for both ADO and GitHub (~12 min at default tick rate)') +
-        settingsField('Comments Poll Frequency', 'set-prPollCommentsEvery', e.prPollCommentsEvery ?? e.adoPollCommentsEvery ?? 12, 'ticks', 'Poll PR human comments every N ticks for both ADO and GitHub (~12 min at default tick rate)') +
+        settingsField('PR Status Poll Frequency', 'set-prPollStatusEvery', e.prPollStatusEvery ?? e.adoPollStatusEvery ?? 12, 'ticks', 'Poll PR build/review/merge status every N ticks for both ADO and GitHub (~12 min at default tick rate)') +
+        settingsField('PR Comments Poll Frequency', 'set-prPollCommentsEvery', e.prPollCommentsEvery ?? e.adoPollCommentsEvery ?? 12, 'ticks', 'Poll PR human comments every N ticks for both ADO and GitHub (~12 min at default tick rate)') +
       '</div>' +
     '</div>' +
 

package/dashboard/js/utils.js

@@ -129,6 +129,26 @@ function statusColor(s) {
   return s === 'working' ? 'working' : s === 'done' ? 'done' : s === 'error' ? 'error' : '';
 }
 
+var SELECTION_CLICK_GUARD_MS = 300;
+var _lastTextSelectionAt = 0;
+
+function _selectionHasText() {
+  var sel = window.getSelection ? window.getSelection() : null;
+  return !!(sel && !sel.isCollapsed && sel.toString().trim());
+}
+
+function _markRecentTextSelection() {
+  if (_selectionHasText()) _lastTextSelectionAt = Date.now();
+}
+
+document.addEventListener('selectionchange', _markRecentTextSelection);
+document.addEventListener('mouseup', _markRecentTextSelection);
+
+function shouldIgnoreSelectionClick() {
+  if (_selectionHasText()) return true;
+  return (Date.now() - _lastTextSelectionAt) < SELECTION_CLICK_GUARD_MS;
+}
+
 function llmCopyBtn() {
   return '<button class="llm-copy-btn" onclick="event.stopPropagation();copyLlmText(this)" title="Copy">&#x2398;</button>';
 }
@@ -462,4 +482,4 @@ async function submitBugReport() {
   }
 }
 
-window.MinionsUtils = { wakeEngine, escHtml, renderMd, normalizePlanFile, timeAgo, statusColor, llmCopyBtn, copyLlmText, openBugReport, submitBugReport };
+window.MinionsUtils = { wakeEngine, escHtml, renderMd, normalizePlanFile, timeAgo, statusColor, shouldIgnoreSelectionClick, llmCopyBtn, copyLlmText, openBugReport, submitBugReport };

package/engine/ado.js

@@ -465,6 +465,11 @@ async function pollPrStatus(config) {
       } catch (e) { log('warn', `ADO build query for ${pr.id}: ${e.message}`); }
     }
 
+    // Record actual poll time — makes lastBuildCheck reflect when the engine last
+    // talked to ADO, not when the agent was dispatched. Issue #1233.
+    pr.lastBuildCheck = ts();
+    updated = true;
+
     if (pr.buildStatus !== buildStatus) {
       log('info', `PR ${pr.id} build: ${pr.buildStatus || 'none'} → ${buildStatus}${buildFailReason ? ' (' + buildFailReason + ')' : ''}`);
       pr.buildStatus = buildStatus;
@@ -475,9 +480,17 @@ async function pollPrStatus(config) {
       if (buildStatus === 'failing') delete pr._autoCompleted;
       if (buildStatus !== 'failing') {
         delete pr._buildFailNotified;
-        delete pr.buildErrorLog;
-        // Reset build fix retry counter on recovery — allows fresh auto-fix cycles if build breaks again
-        if (pr.buildFixAttempts) { delete pr.buildFixAttempts; delete pr.buildFixEscalated; }
+        // Preserve buildErrorLog + buildFixAttempts through transient 'none'/'running'
+        // transitions — only clear on confirmed 'passing' recovery. Issue #1232: 'none'
+        // can also occur when ADO recomputes the merge commit after a target-branch
+        // update but no new builds have been triggered yet (filter by sourceVersion
+        // returns []), which previously wiped the last known error log and caused
+        // fix agents to be dispatched blind.
+        if (buildStatus === 'passing') {
+          delete pr.buildErrorLog;
+          // Reset build fix retry counter on recovery — allows fresh auto-fix cycles if build breaks again
+          if (pr.buildFixAttempts) { delete pr.buildFixAttempts; delete pr.buildFixEscalated; }
+        }
       }
       updated = true;
 

package/engine/github.js

@@ -422,6 +422,10 @@ async function pollPrStatus(config) {
     if (prData.state === 'open' && prData.head?.sha) {
       const checksData = await ghApi(`/commits/${prData.head.sha}/check-runs`, slug);
       if (checksData && checksData.check_runs) {
+        // Record actual poll time — makes lastBuildCheck reflect when the engine last
+        // talked to GitHub, not when the agent was dispatched. Issue #1233.
+        pr.lastBuildCheck = ts();
+        updated = true;
         const runs = checksData.check_runs;
         let buildStatus = 'none';
         let buildFailReason = '';
@@ -452,9 +456,15 @@ async function pollPrStatus(config) {
           if (buildStatus === 'failing') delete pr._autoCompleted; // allow re-merge after fix
           if (buildStatus !== 'failing') {
             delete pr._buildFailNotified;
-            delete pr.buildErrorLog;
-            // Reset build fix retry counter on recovery — allows fresh auto-fix cycles if build breaks again
-            if (pr.buildFixAttempts) { delete pr.buildFixAttempts; delete pr.buildFixEscalated; }
+            // Preserve buildErrorLog + buildFixAttempts through transient 'none'/'running'
+            // transitions — only clear on confirmed 'passing' recovery. Issue #1232:
+            // clearing on every non-failing transition blinded the next fix agent
+            // while a queued build was still running.
+            if (buildStatus === 'passing') {
+              delete pr.buildErrorLog;
+              // Reset build fix retry counter on recovery — allows fresh auto-fix cycles if build breaks again
+              if (pr.buildFixAttempts) { delete pr.buildFixAttempts; delete pr.buildFixEscalated; }
+            }
           }
           updated = true;
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1105",
+  "version": "0.1.1107",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"