@yemi33/minions 0.1.1080 → 0.1.1082

package/CHANGELOG.md

@@ -1,11 +1,12 @@
 # Changelog
 
-## 0.1.1080 (2026-04-18)
+## 0.1.1082 (2026-04-18)
 
 ### Features
 - seed realActivityMap at spawn time, stamp pid in live-output (#1200)
 
 ### Fixes
+-  avoid no-op work item writes
 -  resilient claude binary resolution + surface spawn errors
 -  resolve native claude.exe from npm wrapper on Windows
 - cap temp-agent creation at maxConcurrent per tick (#1219)
@@ -16,6 +17,37 @@
 - stamp live-output.log stub before spawn (#1198)
 -  harden settings save and migrate pr poll config
 
+### Other
+- refactor: extract _probeClaudePackage helper, use shared.log for spawn errors
+- Make work item descriptions scrollable
+- Use PAT for publish merges
+- test(queries): add unit tests for invalidateDispatchCache/getInbox/getAgentCharter (#1214)
+- test(shared): add unit tests for truncateTextBytes/tailTextBytes/execSilent/trackReviewMetric/parseCanonicalPrId (#1215)
+- Fix publish workflow merge
+- chore: raise default meeting round timeout
+- Harden prompt context handling
+- Harden loop watch conversion
+- Add watches sidebar activity badge
+- test(cli): add unit tests for handleCommand, start, stop, kill, spawn (#1191)
+- chore: untrack pipeline files — local config only
+- restore: recover daily-arch-improvement and weekly-dead-code-cleanup pipelines
+- Harden CC stream resilience
+
+## 0.1.1079 (2026-04-18)
+
+### Features
+- seed realActivityMap at spawn time, stamp pid in live-output (#1200)
+
+### Fixes
+-  resolve native claude.exe from npm wrapper on Windows
+- cap temp-agent creation at maxConcurrent per tick (#1219)
+-  reassign pending items from unspawned temp agents to idle named agents (#1204) (#1212)
+- guard undefined agent in pending dispatch loop (closes #1206) (#1210)
+-  improve fallback meeting conclusion
+-  remove command center chevron
+- stamp live-output.log stub before spawn (#1198)
+-  harden settings save and migrate pr poll config
+
 ### Other
 - Use PAT for publish merges
 - test(queries): add unit tests for invalidateDispatchCache/getInbox/getAgentCharter (#1214)

package/dashboard/js/render-work-items.js

@@ -453,7 +453,7 @@ function openWorkItemDetail(id) {
     '<span class="dispatch-type ' + (item.type || 'implement') + '">' + escHtml(item.type || 'implement') + '</span>' +
     '<span class="prd-item-priority ' + (item.priority || '') + '">' + escHtml(item.priority || 'medium') + '</span>' +
     '</div>';
-  html += field('Description', '<div style="font-size:12px">' + renderMd((item.description || item.title || '—').slice(0, 1000)) + '</div>');
+  html += field('Description', '<div style="font-size:12px;max-height:320px;overflow-y:auto;padding:8px 10px;background:var(--surface2);border:1px solid var(--border);border-radius:var(--radius-sm)">' + renderMd(item.description || item.title || '—') + '</div>');
   html += field('Agent', escHtml(item.dispatched_to || item.agent || 'Auto'));
   html += field('Source', escHtml(item._source || 'central'));
   if (item.created) html += field('Created', escHtml(new Date(item.created).toLocaleString()));

package/engine/llm.js

@@ -246,7 +246,7 @@ function callLLM(promptText, sysPromptText, { timeout = 120000, label = 'llm', m
     proc.on('error', (err) => {
       clearTimeout(timer);
       for (const f of cleanupFiles) safeUnlink(f);
-      console.error(`[LLM] spawn error (${label}): ${err.message}`);
+      shared.log('error', `LLM spawn error (${label}): ${err.message}`);
       resolve({ text: '', usage: null, sessionId: null, code: 1, stderr: err.message, raw: '', toolUses: [] });
     });
   });
@@ -308,7 +308,7 @@ function callLLMStreaming(promptText, sysPromptText, { timeout = 120000, label =
     proc.on('error', (err) => {
       clearTimeout(timer);
       for (const f of cleanupFiles) safeUnlink(f);
-      console.error(`[LLM-stream] spawn error (${label}): ${err.message}`);
+      shared.log('error', `LLM-stream spawn error (${label}): ${err.message}`);
       resolve({ text: '', usage: null, sessionId: null, code: 1, stderr: err.message, raw: '', toolUses: [] });
     });
   });

package/engine/shared.js

@@ -347,23 +347,30 @@ function withFileLock(lockPath, fn, {
 function mutateJsonFileLocked(filePath, mutateFn, {
   defaultValue = {},
   lockRetries,
-  lockRetryBackoffMs
+  lockRetryBackoffMs,
+  skipWriteIfUnchanged = false
 } = {}) {
   const lockPath = `${filePath}.lock`;
   const retries = lockRetries ?? ENGINE_DEFAULTS.lockRetries;
   const retryBackoffMs = lockRetryBackoffMs ?? ENGINE_DEFAULTS.lockRetryBackoffMs;
   return withFileLock(lockPath, () => {
+    const fileExists = fs.existsSync(filePath);
     let data = safeJson(filePath);
+    const parsedInvalid = fileExists && data === null;
     if (data === null || typeof data !== 'object') data = Array.isArray(defaultValue) ? [...defaultValue] : { ...defaultValue };
-    // Back up last-known-good state before mutation (best-effort)
-    const backupPath = filePath + '.backup';
-    try { if (fs.existsSync(filePath)) fs.copyFileSync(filePath, backupPath); } catch { /* backup is best-effort */ }
+    const beforeSerialized = skipWriteIfUnchanged ? JSON.stringify(data) : null;
     if (path.basename(filePath) === 'pull-requests.json' && Array.isArray(data)) {
       normalizePrRecords(data, resolveProjectForPrPath(filePath));
     }
     const next = mutateFn(data);
     const finalData = next === undefined ? data : next;
-    safeWrite(filePath, finalData);
+    const shouldWrite = !skipWriteIfUnchanged || parsedInvalid || JSON.stringify(finalData) !== beforeSerialized;
+    if (shouldWrite) {
+      // Back up last-known-good state before mutation (best-effort)
+      const backupPath = filePath + '.backup';
+      try { if (fileExists) fs.copyFileSync(filePath, backupPath); } catch { /* backup is best-effort */ }
+      safeWrite(filePath, finalData);
+    }
     return finalData;
   }, { retries, retryBackoffMs });
 }
@@ -1351,7 +1358,7 @@ function mutateWorkItems(filePath, mutator) {
   return mutateJsonFileLocked(filePath, (data) => {
     if (!Array.isArray(data)) data = [];
     return mutator(data) || data;
-  }, { defaultValue: [] });
+  }, { defaultValue: [], skipWriteIfUnchanged: true });
 }
 
 /**

package/engine/spawn-agent.js

@@ -27,6 +27,16 @@ let claudeBin;
 let claudeIsNative = false; // true = native binary, false = node cli.js
 const capsCachePath = path.join(__dirname, 'claude-caps.json');
 let _cacheHit = false;
+const isWin = process.platform === 'win32';
+
+// Probe a @anthropic-ai/claude-code package dir for the best binary: native exe > cli.js
+function _probeClaudePackage(pkgDir) {
+  const nativeBin = path.join(pkgDir, 'bin', isWin ? 'claude.exe' : 'claude');
+  if (fs.existsSync(nativeBin)) return { bin: nativeBin, native: true };
+  const cliJs = path.join(pkgDir, 'cli.js');
+  if (fs.existsSync(cliJs)) return { bin: cliJs, native: false };
+  return null;
+}
 
 // Fast path: use cached binary path if it still exists on disk
 const caps = safeJson(capsCachePath);
@@ -36,31 +46,21 @@ if (caps?.claudeBin && fs.existsSync(caps.claudeBin)) {
   _cacheHit = true;
 }
 
-// Strategy 1: Find `claude` on PATH, then resolve to the actual binary
-// Don't parse wrapper scripts — probe known binary locations relative to the wrapper's directory.
+// Strategy 1: Find `claude` on PATH, then probe known binary locations relative to the wrapper's directory
 if (!claudeBin) try {
-  const isWin = process.platform === 'win32';
   const cmd = isWin ? 'where claude 2>NUL' : 'which claude 2>/dev/null';
   const which = exec(cmd, { encoding: 'utf8', env, timeout: 10000 }).trim().split('\n')[0].trim();
   if (which) {
+    // On non-Windows under Git Bash/MSYS, `which` returns POSIX paths (/c/Users/...) — normalize
     const whichNative = isWin ? which : which.replace(/^\/([a-zA-Z])\//, (_, d) => d.toUpperCase() + ':/').replace(/\//g, path.sep);
-    const baseDir = path.dirname(whichNative);
-    const ccPkg = path.join(baseDir, 'node_modules', '@anthropic-ai', 'claude-code');
-
-    // Probe in priority order: native binary > cli.js > wrapper itself
-    const nativeBin = path.join(ccPkg, 'bin', isWin ? 'claude.exe' : 'claude');
-    const cliJs = path.join(ccPkg, 'cli.js');
-
-    if (fs.existsSync(nativeBin)) {
-      claudeBin = nativeBin;
-      claudeIsNative = true;
-    } else if (fs.existsSync(cliJs)) {
-      claudeBin = cliJs;
+    const ccPkg = path.join(path.dirname(whichNative), 'node_modules', '@anthropic-ai', 'claude-code');
+    const found = _probeClaudePackage(ccPkg);
+    if (found) {
+      claudeBin = found.bin;
+      claudeIsNative = found.native;
     } else {
-      // Not an npm wrapper — check if the path itself is a native binary
-      // On Windows, only trust .exe files; shell scripts can't be spawned directly
-      const ext = path.extname(whichNative).toLowerCase();
-      if (!isWin || ext === '.exe') {
+      // Not an npm wrapper — on Windows, only trust .exe files (shell scripts can't be spawned directly)
+      if (!isWin || path.extname(whichNative).toLowerCase() === '.exe') {
         claudeBin = whichNative;
         claudeIsNative = true;
       }
@@ -69,9 +69,7 @@ if (!claudeBin) try {
 } catch { /* optional */ }
 
 // Strategy 2: Known node_modules locations (npm global installs)
-// Check for native binary first, then cli.js
 if (!claudeBin) {
-  const isWin = process.platform === 'win32';
   const prefixes = [
     process.env.npm_config_prefix ? path.join(process.env.npm_config_prefix, 'node_modules', '@anthropic-ai', 'claude-code') : '',
     process.env.APPDATA ? path.join(process.env.APPDATA, 'npm', 'node_modules', '@anthropic-ai', 'claude-code') : '',
@@ -84,10 +82,8 @@ if (!claudeBin) {
   ].filter(Boolean);
   for (const pkg of prefixes) {
     try {
-      const nativeBin = path.join(pkg, 'bin', isWin ? 'claude.exe' : 'claude');
-      if (fs.existsSync(nativeBin)) { claudeBin = nativeBin; claudeIsNative = true; break; }
-      const cliJs = path.join(pkg, 'cli.js');
-      if (fs.existsSync(cliJs)) { claudeBin = cliJs; break; }
+      const found = _probeClaudePackage(pkg);
+      if (found) { claudeBin = found.bin; claudeIsNative = found.native; break; }
     } catch {}
   }
 }
@@ -96,8 +92,8 @@ if (!claudeBin) {
 if (!claudeBin) {
   try {
     const globalRoot = exec('npm root -g', { encoding: 'utf8', env, timeout: 10000 }).trim();
-    const candidate = path.join(globalRoot, '@anthropic-ai', 'claude-code', 'cli.js');
-    if (fs.existsSync(candidate)) claudeBin = candidate;
+    const found = _probeClaudePackage(path.join(globalRoot, '@anthropic-ai', 'claude-code'));
+    if (found) { claudeBin = found.bin; claudeIsNative = found.native; }
   } catch { /* optional */ }
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1080",
+  "version": "0.1.1082",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"