@yemi33/minions 0.1.1079 → 0.1.1081

package/CHANGELOG.md

@@ -1,5 +1,36 @@
 # Changelog
 
+## 0.1.1081 (2026-04-18)
+
+### Features
+- seed realActivityMap at spawn time, stamp pid in live-output (#1200)
+
+### Fixes
+-  avoid no-op work item writes
+-  resilient claude binary resolution + surface spawn errors
+-  resolve native claude.exe from npm wrapper on Windows
+- cap temp-agent creation at maxConcurrent per tick (#1219)
+-  reassign pending items from unspawned temp agents to idle named agents (#1204) (#1212)
+- guard undefined agent in pending dispatch loop (closes #1206) (#1210)
+-  improve fallback meeting conclusion
+-  remove command center chevron
+- stamp live-output.log stub before spawn (#1198)
+-  harden settings save and migrate pr poll config
+
+### Other
+- Use PAT for publish merges
+- test(queries): add unit tests for invalidateDispatchCache/getInbox/getAgentCharter (#1214)
+- test(shared): add unit tests for truncateTextBytes/tailTextBytes/execSilent/trackReviewMetric/parseCanonicalPrId (#1215)
+- Fix publish workflow merge
+- chore: raise default meeting round timeout
+- Harden prompt context handling
+- Harden loop watch conversion
+- Add watches sidebar activity badge
+- test(cli): add unit tests for handleCommand, start, stop, kill, spawn (#1191)
+- chore: untrack pipeline files — local config only
+- restore: recover daily-arch-improvement and weekly-dead-code-cleanup pipelines
+- Harden CC stream resilience
+
 ## 0.1.1079 (2026-04-18)
 
 ### Features

package/engine/llm.js

@@ -246,6 +246,7 @@ function callLLM(promptText, sysPromptText, { timeout = 120000, label = 'llm', m
     proc.on('error', (err) => {
       clearTimeout(timer);
       for (const f of cleanupFiles) safeUnlink(f);
+      console.error(`[LLM] spawn error (${label}): ${err.message}`);
       resolve({ text: '', usage: null, sessionId: null, code: 1, stderr: err.message, raw: '', toolUses: [] });
     });
   });
@@ -307,6 +308,7 @@ function callLLMStreaming(promptText, sysPromptText, { timeout = 120000, label =
     proc.on('error', (err) => {
       clearTimeout(timer);
       for (const f of cleanupFiles) safeUnlink(f);
+      console.error(`[LLM-stream] spawn error (${label}): ${err.message}`);
       resolve({ text: '', usage: null, sessionId: null, code: 1, stderr: err.message, raw: '', toolUses: [] });
     });
   });

package/engine/shared.js

@@ -347,23 +347,30 @@ function withFileLock(lockPath, fn, {
 function mutateJsonFileLocked(filePath, mutateFn, {
   defaultValue = {},
   lockRetries,
-  lockRetryBackoffMs
+  lockRetryBackoffMs,
+  skipWriteIfUnchanged = false
 } = {}) {
   const lockPath = `${filePath}.lock`;
   const retries = lockRetries ?? ENGINE_DEFAULTS.lockRetries;
   const retryBackoffMs = lockRetryBackoffMs ?? ENGINE_DEFAULTS.lockRetryBackoffMs;
   return withFileLock(lockPath, () => {
+    const fileExists = fs.existsSync(filePath);
     let data = safeJson(filePath);
+    const parsedInvalid = fileExists && data === null;
     if (data === null || typeof data !== 'object') data = Array.isArray(defaultValue) ? [...defaultValue] : { ...defaultValue };
-    // Back up last-known-good state before mutation (best-effort)
-    const backupPath = filePath + '.backup';
-    try { if (fs.existsSync(filePath)) fs.copyFileSync(filePath, backupPath); } catch { /* backup is best-effort */ }
+    const beforeSerialized = skipWriteIfUnchanged ? JSON.stringify(data) : null;
     if (path.basename(filePath) === 'pull-requests.json' && Array.isArray(data)) {
       normalizePrRecords(data, resolveProjectForPrPath(filePath));
     }
     const next = mutateFn(data);
     const finalData = next === undefined ? data : next;
-    safeWrite(filePath, finalData);
+    const shouldWrite = !skipWriteIfUnchanged || parsedInvalid || JSON.stringify(finalData) !== beforeSerialized;
+    if (shouldWrite) {
+      // Back up last-known-good state before mutation (best-effort)
+      const backupPath = filePath + '.backup';
+      try { if (fileExists) fs.copyFileSync(filePath, backupPath); } catch { /* backup is best-effort */ }
+      safeWrite(filePath, finalData);
+    }
     return finalData;
   }, { retries, retryBackoffMs });
 }
@@ -1351,7 +1358,7 @@ function mutateWorkItems(filePath, mutator) {
   return mutateJsonFileLocked(filePath, (data) => {
     if (!Array.isArray(data)) data = [];
     return mutator(data) || data;
-  }, { defaultValue: [] });
+  }, { defaultValue: [], skipWriteIfUnchanged: true });
 }
 
 /**

package/engine/spawn-agent.js

@@ -36,55 +36,59 @@ if (caps?.claudeBin && fs.existsSync(caps.claudeBin)) {
   _cacheHit = true;
 }
 
-// Strategy 1: Check if `claude` is on PATH (native installer or npm global bin)
+// Strategy 1: Find `claude` on PATH, then resolve to the actual binary
+// Don't parse wrapper scripts — probe known binary locations relative to the wrapper's directory.
 if (!claudeBin) try {
   const isWin = process.platform === 'win32';
   const cmd = isWin ? 'where claude 2>NUL' : 'which claude 2>/dev/null';
   const which = exec(cmd, { encoding: 'utf8', env, timeout: 10000 }).trim().split('\n')[0].trim();
   if (which) {
     const whichNative = isWin ? which : which.replace(/^\/([a-zA-Z])\//, (_, d) => d.toUpperCase() + ':/').replace(/\//g, path.sep);
-    // Check if it's a node wrapper (npm install) or native binary
-    try {
-      const content = fs.readFileSync(whichNative, 'utf8');
-      // npm wrapper scripts reference cli.js — extract the path
-      const m = content.match(/node_modules[\\/]@anthropic-ai[\\/]claude-code[\\/]cli\.js/);
-      if (m) {
-        const candidate = path.join(path.dirname(whichNative), 'node_modules', '@anthropic-ai', 'claude-code', 'cli.js');
-        if (fs.existsSync(candidate)) { claudeBin = candidate; }
-      }
-      // npm wrapper may reference native binary (claude.exe) instead of cli.js
-      if (!claudeBin) {
-        const exeMatch = content.match(/node_modules[\\/]@anthropic-ai[\\/]claude-code[\\/]bin[\\/]claude(?:\.exe)?/);
-        if (exeMatch) {
-          const candidate = path.join(path.dirname(whichNative), 'node_modules', '@anthropic-ai', 'claude-code', 'bin', isWin ? 'claude.exe' : 'claude');
-          if (fs.existsSync(candidate)) { claudeBin = candidate; claudeIsNative = true; }
-        }
-      }
-    } catch {
-      // Can't read as text — it's a compiled binary
-    }
-    if (!claudeBin) {
-      // Native binary or wrapper without cli.js reference — use directly
-      claudeBin = whichNative;
+    const baseDir = path.dirname(whichNative);
+    const ccPkg = path.join(baseDir, 'node_modules', '@anthropic-ai', 'claude-code');
+
+    // Probe in priority order: native binary > cli.js > wrapper itself
+    const nativeBin = path.join(ccPkg, 'bin', isWin ? 'claude.exe' : 'claude');
+    const cliJs = path.join(ccPkg, 'cli.js');
+
+    if (fs.existsSync(nativeBin)) {
+      claudeBin = nativeBin;
       claudeIsNative = true;
+    } else if (fs.existsSync(cliJs)) {
+      claudeBin = cliJs;
+    } else {
+      // Not an npm wrapper — check if the path itself is a native binary
+      // On Windows, only trust .exe files; shell scripts can't be spawned directly
+      const ext = path.extname(whichNative).toLowerCase();
+      if (!isWin || ext === '.exe') {
+        claudeBin = whichNative;
+        claudeIsNative = true;
+      }
     }
   }
 } catch { /* optional */ }
 
 // Strategy 2: Known node_modules locations (npm global installs)
+// Check for native binary first, then cli.js
 if (!claudeBin) {
-  const searchPaths = [
-    process.env.npm_config_prefix ? path.join(process.env.npm_config_prefix, 'node_modules', '@anthropic-ai', 'claude-code', 'cli.js') : '',
-    process.env.APPDATA ? path.join(process.env.APPDATA, 'npm', 'node_modules', '@anthropic-ai', 'claude-code', 'cli.js') : '',
-    '/usr/local/lib/node_modules/@anthropic-ai/claude-code/cli.js',
-    '/usr/lib/node_modules/@anthropic-ai/claude-code/cli.js',
-    '/opt/homebrew/lib/node_modules/@anthropic-ai/claude-code/cli.js',
-    path.join(path.dirname(process.execPath), '..', 'lib', 'node_modules', '@anthropic-ai', 'claude-code', 'cli.js'),
-    path.join(path.dirname(process.execPath), 'node_modules', '@anthropic-ai', 'claude-code', 'cli.js'),
-    path.join(__dirname, '..', 'node_modules', '@anthropic-ai', 'claude-code', 'cli.js'),
+  const isWin = process.platform === 'win32';
+  const prefixes = [
+    process.env.npm_config_prefix ? path.join(process.env.npm_config_prefix, 'node_modules', '@anthropic-ai', 'claude-code') : '',
+    process.env.APPDATA ? path.join(process.env.APPDATA, 'npm', 'node_modules', '@anthropic-ai', 'claude-code') : '',
+    '/usr/local/lib/node_modules/@anthropic-ai/claude-code',
+    '/usr/lib/node_modules/@anthropic-ai/claude-code',
+    '/opt/homebrew/lib/node_modules/@anthropic-ai/claude-code',
+    path.join(path.dirname(process.execPath), '..', 'lib', 'node_modules', '@anthropic-ai', 'claude-code'),
+    path.join(path.dirname(process.execPath), 'node_modules', '@anthropic-ai', 'claude-code'),
+    path.join(__dirname, '..', 'node_modules', '@anthropic-ai', 'claude-code'),
   ].filter(Boolean);
-  for (const p of searchPaths) {
-    try { if (fs.existsSync(p)) { claudeBin = p; break; } } catch {}
+  for (const pkg of prefixes) {
+    try {
+      const nativeBin = path.join(pkg, 'bin', isWin ? 'claude.exe' : 'claude');
+      if (fs.existsSync(nativeBin)) { claudeBin = nativeBin; claudeIsNative = true; break; }
+      const cliJs = path.join(pkg, 'cli.js');
+      if (fs.existsSync(cliJs)) { claudeBin = cliJs; break; }
+    } catch {}
   }
 }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1079",
+  "version": "0.1.1081",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"