@yemi33/minions 0.1.1045 → 0.1.1047

package/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Changelog
 
-## 0.1.1045 (2026-04-16)
+## 0.1.1047 (2026-04-16)
+
+### Fixes
+- stamp live-output.log stub before spawn (#1198)
+-  harden settings save and migrate pr poll config
 
 ### Other
 - Harden loop watch conversion

package/dashboard/js/settings.js

@@ -1,14 +1,18 @@
 // settings.js — Settings panel functions extracted from dashboard.html
 
+let _settingsData = null;
+
 async function openSettings() {
   document.getElementById('modal-title').textContent = 'Settings';
   document.getElementById('modal-body').innerHTML = '<p style="color:var(--muted)">Loading...</p>';
   document.getElementById('modal').classList.add('open');
 
+  _settingsData = null;
   let data;
   try {
     const res = await fetch('/api/settings');
     data = await res.json();
+    _settingsData = data;
   } catch (e) { showToast('cmd-toast', 'Failed to load settings: ' + e.message, false); return; }
 
   const e = data.engine || {};
@@ -56,8 +60,8 @@ async function openSettings() {
       settingsToggle('GitHub Polling', 'set-ghPollEnabled', e.ghPollEnabled !== false, 'Poll GitHub PR status and comments each tick (reconciliation always runs)') +
     '</div>' +
     '<div style="display:grid;grid-template-columns:1fr 1fr;gap:8px;margin-bottom:16px">' +
-      settingsField('PR Status Poll Frequency', 'set-adoPollStatusEvery', e.adoPollStatusEvery || 6, 'ticks', 'Poll PR build/review/merge status every N ticks for both ADO and GitHub (~6 min at default tick rate)') +
-      settingsField('PR Comments Poll Frequency', 'set-adoPollCommentsEvery', e.adoPollCommentsEvery || 12, 'ticks', 'Poll PR human comments every N ticks for both ADO and GitHub (~12 min at default tick rate)') +
+      settingsField('PR Status Poll Frequency', 'set-prPollStatusEvery', e.prPollStatusEvery ?? e.adoPollStatusEvery ?? 12, 'ticks', 'Poll PR build/review/merge status every N ticks for both ADO and GitHub (~12 min at default tick rate)') +
+      settingsField('PR Comments Poll Frequency', 'set-prPollCommentsEvery', e.prPollCommentsEvery ?? e.adoPollCommentsEvery ?? 12, 'ticks', 'Poll PR human comments every N ticks for both ADO and GitHub (~12 min at default tick rate)') +
     '</div>' +
     '<div style="display:grid;grid-template-columns:1fr 1fr;gap:8px;margin-bottom:16px">' +
       settingsField('Eval Max Iterations', 'set-evalMaxIterations', e.evalMaxIterations || 3, '', 'Max review→fix cycles before escalating (1-10)') +
@@ -258,8 +262,8 @@ async function saveSettings() {
       autoCompletePrs: document.getElementById('set-autoCompletePrs').checked,
       adoPollEnabled: document.getElementById('set-adoPollEnabled').checked,
       ghPollEnabled: document.getElementById('set-ghPollEnabled').checked,
-      adoPollStatusEvery: document.getElementById('set-adoPollStatusEvery').value,
-      adoPollCommentsEvery: document.getElementById('set-adoPollCommentsEvery').value,
+      prPollStatusEvery: document.getElementById('set-prPollStatusEvery').value,
+      prPollCommentsEvery: document.getElementById('set-prPollCommentsEvery').value,
       evalMaxIterations: document.getElementById('set-evalMaxIterations').value,
       evalMaxCost: document.getElementById('set-evalMaxCost').value || null,
       maxBuildFixAttempts: document.getElementById('set-maxBuildFixAttempts').value,
@@ -305,7 +309,8 @@ async function saveSettings() {
       agentsPayload[id][field] = el.value;
     });
 
-    const projectsPayload = (data.projects || []).map(function(p) {
+    const currentProjects = (_settingsData && Array.isArray(_settingsData.projects)) ? _settingsData.projects : [];
+    const projectsPayload = currentProjects.map(function(p) {
       return {
         name: p.name,
         workSources: {

package/docs/deprecated.json

@@ -14,5 +14,13 @@
     "reason": "Redundant with evalLoop; evalLoop is the single gate for the review+fix cycle",
     "locations": ["engine/shared.js ENGINE_DEFAULTS.autoReview", "engine.js discoverFromPrs autoReview variable"],
     "cleanup": "Removed from ENGINE_DEFAULTS, removed autoReview variable from engine.js, replaced with reviewEnabled = evalLoopEnabled && pollEnabled"
+  },
+  {
+    "id": "ado-poll-frequency-keys",
+    "summary": "adoPollStatusEvery and adoPollCommentsEvery renamed to prPollStatusEvery and prPollCommentsEvery",
+    "deprecated": "2026-04-16",
+    "reason": "These cadence settings gate both ADO and GitHub PR polling, so the ADO-prefixed names are misleading.",
+    "locations": ["engine.js read-side fallback from config.engine.adoPollStatusEvery/adoPollCommentsEvery", "dashboard.js handleSettingsRead/handleSettingsUpdate alias fallback for old keys"],
+    "cleanup": "Remove the adoPoll* alias fallback reads after existing configs have been migrated to prPollStatusEvery/prPollCommentsEvery."
   }
 ]

package/engine/queries.js

@@ -9,7 +9,7 @@ const path = require('path');
 const os = require('os');
 const shared = require('./shared');
 
-const { safeRead, safeReadDir, safeJson, safeWrite, getProjects,
+const { safeRead, safeReadDir, safeJson, safeWrite, getProjects, mutateJsonFileLocked,
   projectWorkItemsPath, projectPrPath, parseSkillFrontmatter, KB_CATEGORIES,
   WI_STATUS, DONE_STATUSES, PRD_ITEM_STATUS, ENGINE_DEFAULTS } = shared;
 
@@ -99,7 +99,49 @@ function timeSince(ms) {
 
 // ── Core State Readers ──────────────────────────────────────────────────────
 
+let _configPollKeyMigrationChecked = false;
+
+function migrateDeprecatedConfigPollKeysOnce() {
+  if (_configPollKeyMigrationChecked) return;
+  const initial = safeJson(CONFIG_PATH);
+  if (!initial || typeof initial !== 'object' || Array.isArray(initial)) {
+    _configPollKeyMigrationChecked = true;
+    return;
+  }
+  const engine = initial.engine;
+  if (!engine || typeof engine !== 'object' || Array.isArray(engine)) {
+    _configPollKeyMigrationChecked = true;
+    return;
+  }
+  const hasOldStatus = engine.adoPollStatusEvery !== undefined;
+  const hasOldComments = engine.adoPollCommentsEvery !== undefined;
+  if (!hasOldStatus && !hasOldComments) {
+    _configPollKeyMigrationChecked = true;
+    return;
+  }
+  try {
+    mutateJsonFileLocked(CONFIG_PATH, (config) => {
+      if (!config || typeof config !== 'object' || Array.isArray(config)) return config;
+      const nextEngine = config.engine;
+      if (!nextEngine || typeof nextEngine !== 'object' || Array.isArray(nextEngine)) return config;
+      if (nextEngine.prPollStatusEvery === undefined && nextEngine.adoPollStatusEvery !== undefined) {
+        nextEngine.prPollStatusEvery = nextEngine.adoPollStatusEvery;
+      }
+      if (nextEngine.prPollCommentsEvery === undefined && nextEngine.adoPollCommentsEvery !== undefined) {
+        nextEngine.prPollCommentsEvery = nextEngine.adoPollCommentsEvery;
+      }
+      delete nextEngine.adoPollStatusEvery;
+      delete nextEngine.adoPollCommentsEvery;
+      return config;
+    });
+    _configPollKeyMigrationChecked = true;
+  } catch (e) {
+    console.warn('[config] one-time prPoll migration failed:', e.message);
+  }
+}
+
 function getConfig() {
+  migrateDeprecatedConfigPollKeysOnce();
   return safeJson(CONFIG_PATH) || {};
 }
 

package/engine/shared.js

@@ -673,8 +673,8 @@ const ENGINE_DEFAULTS = {
   buildFixGracePeriod: 600000, // 10min — wait for CI to run after build fix before re-dispatching
   adoPollEnabled: true, // poll ADO PR status, comments, and reconciliation on each tick cycle
   ghPollEnabled: true, // poll GitHub PR status, comments, and reconciliation on each tick cycle
-  adoPollStatusEvery: 6,   // poll ADO PR build/review/merge status every N ticks (~6 min at default interval)
-  adoPollCommentsEvery: 12, // poll ADO PR human comments every N ticks (~12 min at default interval)
+  prPollStatusEvery: 12,   // poll PR build/review/merge status every N ticks for both ADO and GitHub (~12 min at default interval)
+  prPollCommentsEvery: 12, // poll PR human comments every N ticks for both ADO and GitHub (~12 min at default interval)
   autoCompletePrs: false, // auto-merge PRs when builds green + review approved (opt-in)
   prMergeMethod: 'squash', // merge method: squash, merge, rebase
   ignoredCommentAuthors: [], // comments from these authors are auto-closed and never trigger fixes

package/engine/timeout.js

@@ -308,16 +308,27 @@ function checkTimeouts(config) {
     const procInfo = activeProcesses.get(item.id);
     if (procInfo?._steeringAt && Date.now() - procInfo._steeringAt < 60000) continue;
 
+    // Capture live-output.log file state for orphan/hung diagnostics (#W-mo248lkjwgsu).
+    // Three distinguishable failure modes:
+    //   logExists=false           → spawn call itself threw, no log ever written
+    //   logExists=true, size~stub → process died at startup (stub-only content)
+    //   logExists=true, size>stub → genuine hang (process alive, wrote output, then stopped)
+    let _logState = 'logExists=false logSize=0';
+    try {
+      const lst = fs.statSync(liveLogPath);
+      _logState = `logExists=true logSize=${lst.size}`;
+    } catch { /* ENOENT — keep default */ }
+
     if (!hasProcess && silentMs > effectiveTimeout && (Date.now() > engineRestartGraceUntil || engineRestartGraceExempt?.has(item.id))) {
       // No tracked process AND no recent output past effective timeout AND (grace period expired OR confirmed-dead at restart) → orphaned
-      log('warn', `Orphan detected: ${item.agent} (${item.id}) — no process tracked, silent for ${silentSec}s${isBlocking ? ' (blocking timeout exceeded)' : ''}`);
+      log('warn', `Orphan detected: ${item.agent} (${item.id}) — no process tracked, silent for ${silentSec}s${isBlocking ? ' (blocking timeout exceeded)' : ''} [${_logState}]`);
       dispatch().updateAgentStatus(item.id, AGENT_STATUS.TIMED_OUT, `Orphaned — no process, silent for ${silentSec}s`);
       // Clear session so retry starts fresh
       try { shared.safeUnlink(path.join(AGENTS_DIR, item.agent, 'session.json')); } catch {}
       deadItems.push({ item, reason: `Orphaned — no process, silent for ${silentSec}s` });
     } else if (hasProcess && silentMs > effectiveTimeout) {
       // Has process but no output past effective timeout → hung
-      log('warn', `Hung agent: ${item.agent} (${item.id}) — process exists but no output for ${silentSec}s${isBlocking ? ' (blocking timeout exceeded)' : ''}`);
+      log('warn', `Hung agent: ${item.agent} (${item.id}) — process exists but no output for ${silentSec}s${isBlocking ? ' (blocking timeout exceeded)' : ''} [${_logState}]`);
       dispatch().updateAgentStatus(item.id, AGENT_STATUS.TIMED_OUT, `Hung — no output for ${silentSec}s`);
       const procInfo = activeProcesses.get(item.id);
       if (procInfo) {

package/engine.js

@@ -871,25 +871,16 @@ async function spawnAgent(dispatchItem, config) {
   const spawnScript = path.join(ENGINE_DIR, 'spawn-agent.js');
   const spawnArgs = [spawnScript, promptPath, sysPromptPath, ...args];
 
-  const proc = runFile(process.execPath, spawnArgs, {
-    cwd,
-    stdio: ['pipe', 'pipe', 'pipe'],
-    env: childEnv,
-  });
-
-  const MAX_OUTPUT = 1024 * 1024; // 1MB
-  let stdout = '';
-  let stderr = '';
-  let lastOutputAt = Date.now();
-  let heartbeatTimer = null;
-  let _trustCheckDone = false;
-  const _spawnTime = Date.now();
-
-  // Live output file — written as data arrives so dashboard can tail it
+  // Live output file — stamped BEFORE child process is spawned (#W-mo248lkjwgsu).
+  // Writing the stub pre-spawn lets the orphan detector distinguish three failure modes
+  // that otherwise look identical:
+  //   1. No log file          → spawn call itself threw before reaching this line
+  //   2. Log has stub only    → process started but died before its first write
+  //   3. Log has stub + ...   → process alive but hung (the only case that warrants orphan kill+retry)
   const liveOutputPath = path.join(AGENTS_DIR, agentId, 'live-output.log');
 
   // Rotate previous live output to preserve session history (fixes #543: orphan recovery overwrites)
-  // Only rotate if the existing file has meaningful content (beyond just the header)
+  // Only rotate if the existing file has meaningful content (beyond just the header stub)
   const LIVE_OUTPUT_SPARSE_THRESHOLD = 500; // bytes — header + init JSON is typically < 500
   try {
     if (fs.existsSync(liveOutputPath)) {
@@ -901,7 +892,37 @@ async function spawnAgent(dispatchItem, config) {
     }
   } catch { /* rotation is best-effort — overwrite still happens below */ }
 
-  safeWrite(liveOutputPath, `# Live output for ${agentId} — ${id}\n# Started: ${startedAt}\n# Task: ${dispatchItem.task}\n\n`);
+  // Stamp the log synchronously before spawn. If the synchronous write throws,
+  // we still attempt to spawn (log-file stamp failure must not block the agent),
+  // but we note it so the diagnostic trail isn't silent either.
+  try {
+    safeWrite(liveOutputPath, `# Live output for ${agentId} — ${id}\n# Started: ${startedAt}\n# Task: ${dispatchItem.task}\n[${new Date().toISOString()}] spawn: agent=${agentId} item=${id}\n\n`);
+  } catch (stubErr) {
+    log('warn', `Failed to stamp live-output stub for ${agentId} (${id}): ${stubErr.message}`);
+  }
+
+  let proc;
+  try {
+    proc = runFile(process.execPath, spawnArgs, {
+      cwd,
+      stdio: ['pipe', 'pipe', 'pipe'],
+      env: childEnv,
+    });
+  } catch (spawnErr) {
+    // Synchronous spawn failure — record it to the (already-stamped) log so the
+    // orphan detector's "logSize > stub-only" check can tell this apart from a
+    // hung process. Then rethrow so the dispatch loop handles it normally.
+    try { fs.appendFileSync(liveOutputPath, `[${new Date().toISOString()}] spawn-failed: ${spawnErr.message}\n[process-exit] spawn-failed\n`); } catch { /* cleanup-only best effort */ }
+    throw spawnErr;
+  }
+
+  const MAX_OUTPUT = 1024 * 1024; // 1MB
+  let stdout = '';
+  let stderr = '';
+  let lastOutputAt = Date.now();
+  let heartbeatTimer = null;
+  let _trustCheckDone = false;
+  const _spawnTime = Date.now();
 
   // Keep live log active even when the agent produces no stdout/stderr for long stretches.
   // This makes "silent but running" states visible in the dashboard tail view.
@@ -3226,13 +3247,19 @@ async function tickInner() {
 
   const adoPollEnabled = config.engine?.adoPollEnabled ?? ENGINE_DEFAULTS.adoPollEnabled;
   const ghPollEnabled = config.engine?.ghPollEnabled ?? ENGINE_DEFAULTS.ghPollEnabled;
-  const adoPollStatusEvery = Math.max(1, Number(config.engine?.adoPollStatusEvery) || ENGINE_DEFAULTS.adoPollStatusEvery);
-  const adoPollCommentsEvery = Math.max(1, Number(config.engine?.adoPollCommentsEvery) || ENGINE_DEFAULTS.adoPollCommentsEvery);
+  const prPollStatusEvery = Math.max(
+    1,
+    Number(config.engine?.prPollStatusEvery ?? config.engine?.adoPollStatusEvery) || ENGINE_DEFAULTS.prPollStatusEvery
+  );
+  const prPollCommentsEvery = Math.max(
+    1,
+    Number(config.engine?.prPollCommentsEvery ?? config.engine?.adoPollCommentsEvery) || ENGINE_DEFAULTS.prPollCommentsEvery
+  );
 
-  // 2.6. Poll PR status: build, review, merge (every adoPollStatusEvery ticks, default ~6 minutes)
+  // 2.6. Poll PR status: build, review, merge (every prPollStatusEvery ticks, default ~12 minutes)
   // Awaited so PR state is consistent before discoverWork reads it
   // Also re-polls early if previous tick had ADO auth failures (stale build status recovery)
-  if (tickCount % adoPollStatusEvery === 0 || needsAdoPollRetry()) {
+  if (tickCount % prPollStatusEvery === 0 || needsAdoPollRetry()) {
     // Build promise array — enabled+unthrottled polls run concurrently via Promise.allSettled
     const statusPolls = [];
     if (adoPollEnabled && !isAdoThrottled()) {
@@ -3265,8 +3292,8 @@ async function tickInner() {
     } catch (err) { log('warn', `Plan completion check error: ${err?.message || err}`); }
   }
 
-  // 2.7. Poll PR threads for human comments (every adoPollCommentsEvery ticks, default ~12 minutes)
-  if (tickCount % adoPollCommentsEvery === 0) {
+  // 2.7. Poll PR threads for human comments (every prPollCommentsEvery ticks, default ~12 minutes)
+  if (tickCount % prPollCommentsEvery === 0) {
     // Build promise array — enabled+unthrottled comment polls run concurrently via Promise.allSettled
     const commentPolls = [];
     if (adoPollEnabled && !isAdoThrottled()) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1045",
+  "version": "0.1.1047",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"