@yemi33/minions 0.1.1019 → 0.1.1021

package/CHANGELOG.md

@@ -1,5 +1,42 @@
 # Changelog
 
+## 0.1.1021 (2026-04-16)
+
+### Features
+- route implement items to dedicated implement playbook (#1115)
+
+### Fixes
+-  mark PR abandoned on 404 instead of silently retrying each tick
+- replace undefined PROJECTS with config.projects in checkWatches (#1108)
+- write permission for publish workflow
+-  run tests inline and post check runs for publish PRs
+- add maxBuffer to all GitHub CLI spawns + paginate PR list (#1130)
+-  add required CI checks for PRs + update publish for auto-merge
+-  revert to PR merge now that stale status check is removed
+- guard live review check against undefined vote/state values (#1132)
+-  push version bump directly to master instead of via PR
+-  add push-triggered CI for chore/publish branches
+-  publish workflow chore PRs failing to merge
+-  harden KB ordering
+-  harden audited state transitions
+
+### Other
+- chore: test publish after removing stale status check
+- chore: trigger publish test
+- chore: test publish workflow fix
+- chore: trigger publish workflow test
+
+## 0.1.1020 (2026-04-16)
+
+### Features
+- route implement items to dedicated implement playbook (#1115)
+
+### Fixes
+- add maxBuffer to all GitHub CLI spawns + paginate PR list (#1130)
+- replace undefined PROJECTS with config.projects in checkWatches (#1108)
+- write permission for publish workflow
+-  run tests inline and post check runs for publish PRs
+
 ## 0.1.1019 (2026-04-16)
 
 ### Features

package/engine/github.js

@@ -20,6 +20,11 @@ function engine() {
 let _dispatch = null;
 function dispatchModule() { if (!_dispatch) _dispatch = require('./dispatch'); return _dispatch; }
 
+// ─── Constants ──────────────────────────────────────────────────────────────
+
+// 10 MB — prevents maxBuffer exceeded errors on repos with many open PRs.
+// Node.js default is 1 MB which overflows when GitHub API returns 100+ PR objects.
+const GH_MAX_BUFFER = 10 * 1024 * 1024;
 // ─── Helpers ────────────────────────────────────────────────────────────────
 
 function isGitHub(project) {
@@ -83,11 +88,19 @@ const isGhThrottled = () => _ghThrottle.isThrottled();
 /** Returns a snapshot of the current GitHub throttle state. */
 const getGhThrottleState = () => _ghThrottle.getState();
 
-/** Run a `gh api` call and parse JSON result. Returns null on failure. */
-async function ghApi(endpoint, slug) {
+/** Sentinel returned by ghApi when the resource does not exist (HTTP 404). */
+const GH_NOT_FOUND = Object.freeze({ _notFound: true });
+
+/** Run a `gh api` call and parse JSON result. Returns null on failure, GH_NOT_FOUND on 404.
+ * @param {string} endpoint - API endpoint (e.g. '/pulls?state=open')
+ * @param {string} slug - owner/repo slug
+ * @param {object} [opts] - Options: { paginate: boolean, timeout: number }
+ */
+async function ghApi(endpoint, slug, opts = {}) {
   try {
-    const cmd = `gh api "repos/${slug}${endpoint}"`;
-    const result = await execAsync(cmd, { timeout: 30000, encoding: 'utf-8' });
+    const paginateFlag = opts.paginate ? ' --paginate' : '';
+    const cmd = `gh api${paginateFlag} "repos/${slug}${endpoint}"`;
+    const result = await execAsync(cmd, { timeout: opts.timeout || 30000, encoding: 'utf-8', maxBuffer: GH_MAX_BUFFER });
     const parsed = JSON.parse(result);
     _ghThrottle.recordSuccess();
     return parsed;
@@ -100,6 +113,10 @@ async function ghApi(endpoint, slug) {
       const retryAfterMs = secMatch ? parseInt(secMatch[1], 10) * 1000 : 0;
       _ghThrottle.recordThrottle(retryAfterMs);
     }
+    if (/HTTP 404|Not Found/i.test(msg)) {
+      log('warn', `GitHub API error (${endpoint}): ${e.message}`);
+      return GH_NOT_FOUND;
+    }
     log('warn', `GitHub API error (${endpoint}): ${e.message}`);
     return null;
   }
@@ -152,7 +169,7 @@ async function fetchGhBuildErrorLog(slug, failedRuns) {
       // Always fetch job log — annotations alone often lack test failure details
       try {
         const cmd = `gh api "repos/${slug}/actions/jobs/${run.id}/logs" 2>&1`;
-        const result = await execAsync(cmd, { timeout: 15000, encoding: 'utf-8' });
+        const result = await execAsync(cmd, { timeout: 15000, encoding: 'utf-8', maxBuffer: GH_MAX_BUFFER });
         if (result && !result.includes('Not Found')) {
           logParts.push(`--- ${run.name || 'Check'} (log) ---\n${result}`);
         }
@@ -295,6 +312,15 @@ async function pollPrStatus(config) {
   const totalUpdated = await forEachActiveGhPr(config, async (project, pr, prNum, slug) => {
     const prData = await ghApi(`/pulls/${prNum}`, slug);
     if (!prData) return false;
+    if (prData === GH_NOT_FOUND) {
+      // PR no longer exists — mark abandoned so it stops being polled
+      if (pr.status !== PR_STATUS.ABANDONED) {
+        pr.status = PR_STATUS.ABANDONED;
+        log('info', `PR ${pr.id} returned 404 — marking abandoned`);
+        return true;
+      }
+      return false;
+    }
 
     let updated = false;
 
@@ -471,7 +497,7 @@ async function pollPrStatus(config) {
       if (autoComplete) {
         try {
           const mergeMethod = ['squash', 'merge', 'rebase'].includes(config.engine?.prMergeMethod) ? config.engine.prMergeMethod : 'squash';
-          await execAsync(`gh pr merge ${prNum} --${mergeMethod} --repo ${slug} --delete-branch`, { timeout: 30000, encoding: 'utf-8' });
+          await execAsync(`gh pr merge ${prNum} --${mergeMethod} --repo ${slug} --delete-branch`, { timeout: 30000, encoding: 'utf-8', maxBuffer: GH_MAX_BUFFER });
           pr._autoCompleted = true;
           log('info', `Auto-completed PR ${pr.id}: builds green + review approved → merged (${mergeMethod})`);
           updated = true;
@@ -612,8 +638,8 @@ async function reconcilePrs(config) {
       } catch { continue; }
     }
 
-    // Fetch open PRs
-    const prsData = await ghApi('/pulls?state=open&per_page=100', slug);
+    // Fetch open PRs — paginate to handle repos with >100 open PRs
+    const prsData = await ghApi('/pulls?state=open&per_page=100', slug, { paginate: true, timeout: 60000 });
     if (!prsData || !Array.isArray(prsData)) {
       recordSlugFailure(slug);
       continue;
@@ -760,4 +786,5 @@ module.exports = {
   resetSlugBackoff,
   _ghPollBackoff,
   _ghThrottle, // exported for testing
+  GH_MAX_BUFFER, // exported for testing
 };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1019",
+  "version": "0.1.1021",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"