@yemi33/minions 0.1.101 → 0.1.103

package/CHANGELOG.md

@@ -1,5 +1,23 @@
 # Changelog
 
+## 0.1.103 (2026-04-01)
+
+### Engine
+- engine/lifecycle.js
+- engine/meeting.js
+- engine/shared.js
+
+### Other
+- test/unit.test.js
+
+## 0.1.102 (2026-04-01)
+
+### Engine
+- engine/scheduler.js
+
+### Other
+- test/unit.test.js
+
 ## 0.1.101 (2026-04-01)
 
 ### Engine

package/engine/lifecycle.js

@@ -137,17 +137,10 @@ function checkPlanCompletion(meta, config) {
     ...uniquePrs.map(pr => `- ${pr.id}: ${pr.title || ''} ${pr.url || ''}`),
   ].filter(Boolean).join('\n');
 
-  // Write summary to notes/inbox (slug+date dedup — same pattern as writeInboxAlert in dispatch.js)
-  const summarySlug = `prd-completion-${planFile.replace('.json', '')}`;
-  const summaryFile = `${summarySlug}-${dateStamp()}.md`;
-  const inboxDir = path.join(MINIONS_DIR, 'notes', 'inbox');
-  const existing = safeReadDir(inboxDir).find(f => f.startsWith(`${summarySlug}-${dateStamp()}`));
-  if (!existing) {
-    shared.safeWrite(path.join(inboxDir, summaryFile), summary);
-    log('info', `PRD completion summary written to notes/inbox/${summaryFile}`);
-  } else {
-    log('info', `PRD completion summary already exists for today: ${existing}, skipping inbox write`);
-  }
+  // Write summary to notes/inbox (slug-based dedup prevents duplicates on same day)
+  const slug = `prd-completion-${planFile.replace('.json', '')}`;
+  const wrote = shared.writeToInbox('engine', slug, summary);
+  if (wrote) log('info', `PRD completion summary written to notes/inbox/`);
 
   // Persist _completionNotified flag atomically BEFORE creating work items.
   // This prevents duplicate inbox notes on re-entry. Work item creation below has its own
@@ -892,8 +885,7 @@ function createReviewFeedbackForAuthor(reviewerAgentId, pr, config) {
   const reviewFiles = inboxFiles.filter(f => f.includes(reviewerAgentId) && f.includes(today));
   if (reviewFiles.length === 0) return;
   const reviewContent = reviewFiles.map(f => safeRead(path.join(INBOX_DIR, f))).join('\n\n');
-  const feedbackFile = `feedback-${authorAgentId}-from-${reviewerAgentId}-${pr.id}-${today}.md`;
-  const feedbackPath = shared.uniquePath(path.join(INBOX_DIR, feedbackFile));
+  const slug = `feedback-from-${reviewerAgentId}-${pr.id}`;
   const content = `# Review Feedback for ${config.agents[authorAgentId]?.name || authorAgentId}\n\n` +
     `**PR:** ${pr.id} — ${pr.title || ''}\n` +
     `**Reviewer:** ${config.agents[reviewerAgentId]?.name || reviewerAgentId}\n` +
@@ -902,8 +894,8 @@ function createReviewFeedbackForAuthor(reviewerAgentId, pr, config) {
     `## Action Required\n\nRead this feedback carefully. When you work on similar tasks in the future, ` +
     `avoid the patterns flagged here. If you are assigned to fix this PR, ` +
     `address every point raised above.\n`;
-  shared.safeWrite(feedbackPath, content);
-  log('info', `Created review feedback for ${authorAgentId} from ${reviewerAgentId} on ${pr.id}`);
+  const wrote = shared.writeToInbox(authorAgentId, slug, content);
+  if (wrote) log('info', `Created review feedback for ${authorAgentId} from ${reviewerAgentId} on ${pr.id}`);
 }
 
 function updateMetrics(agentId, dispatchItem, result, taskUsage, prsCreatedCount, model) {

package/engine/meeting.js

@@ -206,15 +206,13 @@ function collectMeetingFindings(meetingId, agentId, roundName, output) {
     meeting.status = 'completed';
     meeting.completedAt = new Date().toISOString();
 
-    // Write transcript to inbox so agents learn from it
+    // Write transcript to inbox so agents learn from it (slug-based dedup)
     const config = queries.getConfig();
     const agents = config.agents || {};
     const transcript = meeting.transcript.map(t =>
       `### ${agents[t.agent]?.name || t.agent} (${t.type}, Round ${t.round})\n\n${t.content}`
     ).join('\n\n---\n\n');
-    const inboxPath = path.join(__dirname, '..', 'notes', 'inbox',
-      `meeting-${meetingId}-${new Date().toISOString().slice(0, 10)}.md`);
-    safeWrite(inboxPath, `# Meeting Transcript: ${meeting.title}\n\n${transcript}`);
+    shared.writeToInbox('meeting', meetingId, `# Meeting Transcript: ${meeting.title}\n\n${transcript}`);
 
     log('info', `Meeting ${meetingId} completed — transcript written to inbox`);
     saveMeeting(meeting);

package/engine/scheduler.js

@@ -61,11 +61,11 @@ function parseCronField(field, min, max) {
 function parseCronExpr(expr) {
   if (!expr || typeof expr !== 'string') return null;
   const parts = expr.trim().split(/\s+/);
-  if (parts.length < 2 || parts.length > 3) return null;
+  if (parts.length !== 3) return null;
 
   const minuteMatcher = parseCronField(parts[0], 0, 59);
   const hourMatcher = parseCronField(parts[1], 0, 23);
-  const dowMatcher = parts[2] ? parseCronField(parts[2], 0, 6) : () => true;
+  const dowMatcher = parseCronField(parts[2], 0, 6);
 
   return {
     matches(date) {

package/engine/shared.js

@@ -169,6 +169,33 @@ function uniquePath(filePath) {
   return `${base}-${Date.now()}${ext}`;
 }
 
+// ── Inbox Helpers ───────────────────────────────────────────────────────────
+
+/**
+ * Write a file to notes/inbox/ with slug+date-based dedup.
+ * Filename: `{agentId}-{slug}-{YYYY-MM-DD}.md`
+ * If a file with the same prefix already exists for today, skip the write.
+ * Pattern matches writeInboxAlert() in dispatch.js.
+ * @param {string} agentId - Agent or source identifier (e.g. 'engine', 'ralph')
+ * @param {string} slug - Short descriptive slug (e.g. 'prd-completion-plan1')
+ * @param {string} content - Markdown content to write
+ * @returns {boolean} true if a write occurred, false if deduped/skipped
+ */
+function writeToInbox(agentId, slug, content, _inboxDir) {
+  try {
+    const inboxDir = _inboxDir || path.join(MINIONS_DIR, 'notes', 'inbox');
+    const prefix = `${agentId}-${slug}-${dateStamp()}`;
+    const existing = safeReadDir(inboxDir).find(f => f.startsWith(prefix));
+    if (existing) return false;
+    const filePath = path.join(inboxDir, `${prefix}.md`);
+    safeWrite(filePath, content);
+    return true;
+  } catch (e) {
+    log('warn', `writeToInbox failed: ${e.message}`);
+    return false;
+  }
+}
+
 // ── Process Spawning ────────────────────────────────────────────────────────
 // All child process calls go through these to ensure windowsHide: true
 
@@ -479,6 +506,7 @@ module.exports = {
   mutateJsonFileLocked,
   uid,
   uniquePath,
+  writeToInbox,
   exec,
   execSilent,
   run,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.101",
+  "version": "0.1.103",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"