@yemi33/minions 0.1.1001 → 0.1.1003

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Changelog
 
-## 0.1.1001 (2026-04-15)
+## 0.1.1003 (2026-04-15)
 
 ### Features
 - fix stopAfter=0 watch expiry — run forever for all conditions (#1117)
@@ -25,6 +25,8 @@
 - gate auto-fix conflict dispatch behind autoFixConflicts flag
 
 ### Fixes
+-  only gate reviews/fixes when no free agent slots remain
+-  extend auto-link fallback to ADO projects
 -  auto-link existing GitHub PR when agent completes without creating one
 -  preserve ordered lists across blank lines in markdown renderer
 -  restore CC rendering and tab bar
@@ -43,8 +45,6 @@
 -  move review verdict check before updateWorkItemStatus(DONE)
 -  address review feedback — move writeToInbox outside lock, add absolute condition auto-expire
 - fix watches feature gaps — human notifications, branch stub, status-change init, unique keys
--  skip isAlreadyDispatched in needsReReview to allow re-review within 1hr
-- skip SessionStart hook settings test on CI
 
 ### Other
 - docs: update CLAUDE.md with recent Minions architecture changes

package/engine/ado.js

@@ -890,6 +890,29 @@ const isAdoThrottled = () => _adoThrottle.isThrottled();
 /** Returns a snapshot of the current throttle state. Calls isAdoThrottled() for a fresh value. */
 const getAdoThrottleState = () => _adoThrottle.getState();
 
+/**
+ * Query ADO for an open PR on a specific branch.
+ * Used as a last-resort fallback when an agent completes without logging a PR URL
+ * but a PR may already exist from a prior orphaned dispatch.
+ * @param {object} project — project config with adoOrg, adoProject, repositoryId, prUrlBase
+ * @param {string} branch — source branch name (without refs/heads/ prefix)
+ * @returns {{ prNumber: number, url: string }|null}
+ */
+async function findOpenPrOnBranch(project, branch) {
+  if (!project.adoOrg || !project.adoProject || !project.repositoryId || !branch) return null;
+  const token = await getAdoToken();
+  if (!token) return null;
+  const orgBase = shared.getAdoOrgBase(project);
+  const sourceRef = encodeURIComponent(`refs/heads/${branch}`);
+  const url = `${orgBase}/${project.adoProject}/_apis/git/repositories/${project.repositoryId}/pullrequests?searchCriteria.status=active&searchCriteria.sourceRefName=${sourceRef}&api-version=7.1`;
+  const data = await adoFetch(url, token);
+  const pr = (data.value || [])[0];
+  if (!pr) return null;
+  const prNumber = pr.pullRequestId;
+  const prUrl = project.prUrlBase ? `${project.prUrlBase}${prNumber}` : `https://dev.azure.com/${project.adoOrg}/${project.adoProject}/_git/${project.repositoryId}/pullrequest/${prNumber}`;
+  return { prNumber, url: prUrl };
+}
+
 /** Reset throttle state — exported for testing only. */
 function _resetAdoThrottle() {
   _adoThrottle._reset();
@@ -913,6 +936,7 @@ module.exports = {
   getAdoThrottleState,
   fetchAdoPrMetadata,
   fetchSinglePrBuildStatus,
+  findOpenPrOnBranch,
   _resetAdoThrottle, // exported for testing
   _setAdoThrottleForTest, // exported for testing
 };

package/engine/lifecycle.js

@@ -1792,37 +1792,44 @@ async function runPostCompletionHooks(dispatchItem, agentId, code, stdout, confi
         }
       }
     }
-    // Last resort: query GitHub directly for an open PR on this branch.
+    // Last resort: query the platform directly for an open PR on this branch.
     // Handles the case where a prior orphaned dispatch created a PR but the engine
-    // never processed its output — so the PR exists on GitHub but not in pull-requests.json.
+    // never processed its output — so the PR exists on the platform but not in pull-requests.json.
     if (!existingPrFound && meta?.branch) {
       const projectObj = shared.getProjects(config).find(p => p.name === meta?.project?.name);
-      const ghSlug = projectObj?.prUrlBase?.match(/github\.com\/([^/]+\/[^/]+)\/pull/)?.[1];
-      if (projectObj?.repoHost === 'github' && ghSlug) {
+      if (projectObj) {
         try {
-          const raw = await execAsync(`gh pr list --head "${meta.branch}" --repo ${ghSlug} --json number,url,state --limit 1`, { timeout: 15000, windowsHide: true });
-          const found = JSON.parse(raw || '[]');
-          if (found.length > 0 && found[0].state === 'OPEN') {
-            const prNum = found[0].number;
-            const fullId = `PR-${prNum}`;
+          let found = null;
+          if (projectObj.repoHost === 'github') {
+            const ghSlug = projectObj.prUrlBase?.match(/github\.com\/([^/]+\/[^/]+)\/pull/)?.[1];
+            if (ghSlug) {
+              const raw = await execAsync(`gh pr list --head "${meta.branch}" --repo ${ghSlug} --json number,url,state --limit 1`, { timeout: 15000, windowsHide: true });
+              const hits = JSON.parse(raw || '[]');
+              if (hits.length > 0 && hits[0].state === 'OPEN') found = { prNumber: hits[0].number, url: hits[0].url };
+            }
+          } else {
+            found = await require('./ado').findOpenPrOnBranch(projectObj, meta.branch);
+          }
+          if (found) {
+            const fullId = `PR-${found.prNumber}`;
             const prPath = shared.projectPrPath(projectObj);
             mutateJsonFileLocked(prPath, prs => {
               if (!Array.isArray(prs)) prs = [];
               if (prs.some(p => p.id === fullId)) return prs;
               prs.push({
-                id: fullId, prNumber: prNum, title: meta.item?.title || '',
+                id: fullId, prNumber: found.prNumber, title: meta.item?.title || '',
                 agent: agentId, branch: meta.branch, reviewStatus: 'pending',
-                status: PR_STATUS.ACTIVE, created: ts(), url: found[0].url,
+                status: PR_STATUS.ACTIVE, created: ts(), url: found.url,
                 prdItems: meta.item?.id ? [meta.item.id] : [],
                 sourcePlan: meta.item?.sourcePlan || '', itemType: meta.item?.itemType || '',
               });
               return prs;
             });
             if (meta.item?.id) addPrLink(fullId, meta.item.id);
-            log('info', `Auto-linked existing GH PR ${fullId} on branch ${meta.branch} for ${meta.item?.id}`);
+            log('info', `Auto-linked existing PR ${fullId} on branch ${meta.branch} for ${meta.item?.id}`);
             existingPrFound = true;
           }
-        } catch (e) { log('warn', `GH PR lookup for branch ${meta.branch}: ${e.message}`); }
+        } catch (e) { log('warn', `PR lookup for branch ${meta.branch}: ${e.message}`); }
       }
     }
     if (!existingPrFound) {

package/engine.js

@@ -3081,18 +3081,24 @@ async function discoverWork(config) {
     } catch (e) { log('warn', 'plan completion sweep: ' + e.message); }
   }
 
-  // Gate reviews and fixes: do not dispatch until all implement items are complete
+  // Gate reviews and fixes: only when at max concurrency — idle agents should pick up reviews
+  // even if implement items are in progress (implements get priority via sort order, not by blocking)
   const hasIncompleteImplements = queries.getWorkItems(config).some(i =>
     ['queued', 'pending', 'dispatched'].includes(i.status) && (i.type || '').startsWith('implement')
   );
   if (hasIncompleteImplements) {
-    if (allReviews.length > 0) {
-      log('info', `Gating ${allReviews.length} reviews — implement items still in progress`);
-      allReviews = [];
-    }
-    if (allFixes.length > 0) {
-      log('info', `Gating ${allFixes.length} fixes — implement items still in progress`);
-      allFixes = [];
+    const activeCount = (getDispatch().active || []).length;
+    const maxConcurrent = config.engine?.maxConcurrent ?? DEFAULTS.maxConcurrent;
+    const freeSlots = Math.max(0, maxConcurrent - activeCount);
+    if (freeSlots === 0) {
+      if (allReviews.length > 0) {
+        log('info', `Gating ${allReviews.length} reviews — implement items in progress and no free slots`);
+        allReviews = [];
+      }
+      if (allFixes.length > 0) {
+        log('info', `Gating ${allFixes.length} fixes — implement items in progress and no free slots`);
+        allFixes = [];
+      }
     }
   }
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yemi33/minions",
-  "version": "0.1.1001",
+  "version": "0.1.1003",
   "description": "Multi-agent AI dev team that runs from ~/.minions/ — five autonomous agents share a single engine, dashboard, and knowledge base",
   "bin": {
     "minions": "bin/minions.js"