@yeaft/webchat-agent 1.0.79 → 1.0.81

package/crew/role-query.js

@@ -1,406 +0,0 @@
-/**
- * Crew — 角色 Query 管理
- * createRoleQuery, buildRoleSystemPrompt, sessionId 持久化, 错误分类
- */
-import { query, Stream } from '../sdk/index.js';
-import { promises as fs, mkdirSync } from 'fs';
-import { join } from 'path';
-import { getMessages } from '../crew-i18n.js';
-import { handleAskUserQuestion } from '../conversation.js';
-import ctx from '../context.js';
-
-/** Format role label */
-function roleLabel(r) {
-  return r.icon ? `${r.icon} ${r.displayName}` : r.displayName;
-}
-
-// =====================================================================
-// Session Persistence (role sessionId)
-// =====================================================================
-
-/**
- * 保存角色的 claudeSessionId 到文件
- */
-export async function saveRoleSessionId(sharedDir, roleName, claudeSessionId) {
-  const sessionsDir = join(sharedDir, 'sessions');
-  await fs.mkdir(sessionsDir, { recursive: true });
-  const filePath = join(sessionsDir, `${roleName}.json`);
-  await fs.writeFile(filePath, JSON.stringify({
-    claudeSessionId,
-    savedAt: Date.now()
-  }));
-  console.log(`[Crew] Saved sessionId for ${roleName}: ${claudeSessionId}`);
-}
-
-/**
- * 从文件加载角色的 claudeSessionId
- */
-export async function loadRoleSessionId(sharedDir, roleName) {
-  const filePath = join(sharedDir, 'sessions', `${roleName}.json`);
-  try {
-    const data = JSON.parse(await fs.readFile(filePath, 'utf-8'));
-    return data.claudeSessionId || null;
-  } catch {
-    return null;
-  }
-}
-
-/**
- * 清除角色的 savedSessionId（用于强制新建 conversation）
- */
-export async function clearRoleSessionId(sharedDir, roleName) {
-  const filePath = join(sharedDir, 'sessions', `${roleName}.json`);
-  try {
-    await fs.unlink(filePath);
-    console.log(`[Crew] Cleared sessionId for ${roleName} (force new conversation)`);
-  } catch {
-    // 文件不存在也正常
-  }
-}
-
-/**
- * 判断角色错误是否可恢复
- */
-export function classifyRoleError(error) {
-  const msg = error.message || '';
-  if (/context.*(window|limit|exceeded)|token.*limit|too.*(long|large)|max.*token/i.test(msg)) {
-    return { recoverable: true, reason: 'context_exceeded' };
-  }
-  if (/compact|compress|context.*reduc/i.test(msg)) {
-    return { recoverable: true, reason: 'compact_failed' };
-  }
-  if (/rate.?limit|429|overloaded|503|502|timeout|ECONNRESET|ETIMEDOUT/i.test(msg)) {
-    return { recoverable: true, reason: 'transient_api_error' };
-  }
-  if (/exited with code [1-9]/i.test(msg) && msg.length < 100) {
-    return { recoverable: true, reason: 'process_crashed' };
-  }
-  if (/spawn|ENOENT|not found/i.test(msg)) {
-    return { recoverable: false, reason: 'spawn_failed' };
-  }
-  return { recoverable: true, reason: 'unknown' };
-}
-
-// =====================================================================
-// Role Query Management
-// =====================================================================
-
-// P1-6: Per-role mutex to prevent concurrent createRoleQuery calls creating orphan processes
-const _roleQueryLocks = new Map();
-
-/**
- * 为角色创建持久 query 实例
- */
-export async function createRoleQuery(session, roleName) {
-  const lockKey = `${session.id}:${roleName}`;
-
-  // P1-6: 如果该角色已有 pending 的 createRoleQuery，等待它完成
-  if (_roleQueryLocks.has(lockKey)) {
-    console.log(`[Crew] Waiting for existing createRoleQuery lock on ${roleName}`);
-    try {
-      await _roleQueryLocks.get(lockKey);
-    } catch {
-      // Previous attempt failed, proceed with new creation
-    }
-    // 锁释放后，检查是否已经有可用的 query
-    const existing = session.roleStates.get(roleName);
-    if (existing?.query && existing?.inputStream && !existing.inputStream.isDone) {
-      console.log(`[Crew] Reusing existing query for ${roleName} after lock release`);
-      return existing;
-    }
-  }
-
-  const promise = _createRoleQueryInner(session, roleName);
-  _roleQueryLocks.set(lockKey, promise);
-  try {
-    const result = await promise;
-    return result;
-  } finally {
-    // 只删除自己的 lock（如果后续调用覆盖了，不误删）
-    if (_roleQueryLocks.get(lockKey) === promise) {
-      _roleQueryLocks.delete(lockKey);
-    }
-  }
-}
-
-/**
- * createRoleQuery 内部实现
- */
-async function _createRoleQueryInner(session, roleName) {
-  const role = session.roles.get(roleName);
-  if (!role) throw new Error(`Role not found: ${roleName}`);
-
-  // Lazy import to avoid circular dependency
-  const { processRoleOutput } = await import('./role-output.js');
-
-  const inputStream = new Stream();
-  const abortController = new AbortController();
-
-  const systemPrompt = buildRoleSystemPrompt(role, session);
-
-  // 尝试加载之前保存的 sessionId
-  const savedSessionId = await loadRoleSessionId(session.sharedDir, roleName);
-
-  // cwd 设为项目目录（确保 Claude CLI 能匹配项目级 MCP 配置）
-  // 角色的 CLAUDE.md 和工作路径已通过 appendSystemPrompt 注入
-  const roleCwd = session.projectDir || join(session.sharedDir, 'roles', roleName);
-  const roleDir = join(session.sharedDir, 'roles', roleName);
-  mkdirSync(roleDir, { recursive: true });
-
-  // 继承全局 MCP disallowedTools，避免不必要的 tool schema token 消耗
-  const globalDisallowed = ctx.CONFIG?.disallowedTools || [];
-  // Developer 角色保留 skills（tdd、commit 等对开发有帮助），
-  // 其他角色（pm、reviewer、product-reviewer）禁用 skills 以避免和 ROUTE 冲突
-  const isDeveloper = role.roleType === 'developer';
-  // Crew 角色禁用 Agent 工具：角色间协作必须通过 ROUTE 块，不能自行启动 sub-agent
-  // 非 developer 角色额外禁用 Skill 工具：skills 的 trigger 词会和角色职能冲突
-  //   （如 review-code、commit），导致 Claude 调用 Skill 而不是输出 ROUTE 块
-  const crewDisallowed = isDeveloper ? ['Agent'] : ['Agent', 'Skill'];
-  const effectiveDisallowed = [...globalDisallowed, ...crewDisallowed];
-
-  const queryOptions = {
-    cwd: roleCwd,
-    // 不设 permissionMode（走 SDK 默认 'default'）。bypassPermissions +
-    // canCallTool 在新版 Claude CLI 会卡死 init 握手 / message_start。
-    // canCallTool 在 default 模式下能正常工作，并对非 AskUserQuestion
-    // 工具返回 { behavior:'allow', updatedInput } 等同放行。
-    abort: abortController.signal,
-    model: role.model || undefined,
-    appendSystemPrompt: systemPrompt,
-    // 非 developer 角色禁用 skills（--disable-slash-commands），
-    // 从 CLI 层面阻止 skills 系统 prompt 注入，避免和 ROUTE 冲突
-    ...(!isDeveloper && { disableSlashCommands: true }),
-    ...(effectiveDisallowed.length > 0 && { disallowedTools: effectiveDisallowed })
-  };
-
-  // Intercept AskUserQuestion for all roles — forward to Web UI for interactive answering.
-  // Without this, non-DM roles' AskCard buttons stay disabled (no askRequestId).
-  // Note: Skill tool is fully disallowed via disallowedTools above, so no canCallTool guard needed.
-  queryOptions.canCallTool = async (toolName, input, toolCtx) => {
-    if (toolName === 'AskUserQuestion') {
-      return await handleAskUserQuestion(session.id, input, toolCtx);
-    }
-    return { behavior: 'allow', updatedInput: input };
-  };
-
-  if (savedSessionId) {
-    queryOptions.resume = savedSessionId;
-    console.log(`[Crew] Resuming ${roleName} with sessionId: ${savedSessionId}`);
-  }
-
-  const roleQuery = query({
-    prompt: inputStream,
-    options: queryOptions
-  });
-
-  // resume 场景：保留已有 roleState 的 baseline，避免双重计算
-  // 只有 fresh query（无 savedSessionId）才用 0 初始化
-  const existingState = session.roleStates.get(roleName);
-  const isResume = !!savedSessionId;
-
-  const roleState = {
-    query: roleQuery,
-    inputStream,
-    abortController,
-    accumulatedText: '',
-    turnActive: false,
-    claudeSessionId: savedSessionId,
-    lastCostUsd: (isResume && existingState?.lastCostUsd) || 0,
-    lastInputTokens: (isResume && existingState?.lastInputTokens) || 0,
-    lastOutputTokens: (isResume && existingState?.lastOutputTokens) || 0,
-    lastSeenUsage: null,
-    consecutiveErrors: 0,
-    lastDispatchContent: null,
-    lastDispatchFrom: null,
-    lastDispatchTaskId: null,
-    lastDispatchTaskTitle: null
-  };
-
-  session.roleStates.set(roleName, roleState);
-
-  // 异步处理角色输出
-  processRoleOutput(session, roleName, roleQuery, roleState);
-
-  return roleState;
-}
-
-/**
- * 构建角色的 system prompt
- */
-export function buildRoleSystemPrompt(role, session) {
-  const allRoles = Array.from(session.roles.values());
-
-  let routeTargets;
-  if (role.groupIndex > 0) {
-    routeTargets = allRoles.filter(r =>
-      r.name !== role.name && (r.groupIndex === role.groupIndex || r.groupIndex === 0)
-    );
-  } else {
-    routeTargets = allRoles.filter(r => r.name !== role.name);
-  }
-
-  const m = getMessages(session.language || 'zh-CN');
-
-  let prompt = `${m.teamCollab}
-${m.teamCollabIntro()}
-
-${m.teamMembers}
-${allRoles.map(r => `- ${roleLabel(r)}: ${r.description}${r.isDecisionMaker ? ` (${m.decisionMakerTag})` : ''}`).join('\n')}`;
-
-  const hasMultiInstance = allRoles.some(r => r.groupIndex > 0);
-
-  if (routeTargets.length > 0) {
-    prompt += `\n\n${m.routingRules}
-${m.routingIntro}
-
-\`\`\`
----ROUTE---
-to: <roleName>
-summary: <必须填写具体内容：你完成了什么、需要对方做什么。禁止留空！>
----END_ROUTE---
-\`\`\`
-
-${m.routeTargets}
-${routeTargets.map(r => `- ${r.name}: ${roleLabel(r)} — ${r.description}`).join('\n')}
-- human: ${m.humanTarget}
-
-${m.routeNotes(session.decisionMaker)}`;
-  }
-
-  // 决策者额外 prompt
-  if (role.isDecisionMaker) {
-    const isDevTeam = session.teamType === 'dev';
-
-    prompt += `\n\n${m.toolUsage}
-${m.toolUsageContent(isDevTeam)}`;
-
-    prompt += `\n\n${m.dmRole}
-${m.dmRoleContent}`;
-
-    if (isDevTeam) {
-      prompt += m.dmDevExtra;
-    }
-
-    if (!isDevTeam) {
-      prompt += `\n\n${m.collabMode}
-${m.collabModeContent}`;
-    }
-
-    if (isDevTeam && hasMultiInstance) {
-      const maxGroup = Math.max(...allRoles.map(r => r.groupIndex));
-      const groupLines = [];
-      for (let g = 1; g <= maxGroup; g++) {
-        const members = allRoles.filter(r => r.groupIndex === g);
-        const memberStrs = members.map(r => {
-          const state = session.roleStates.get(r.name);
-          const busy = state?.turnActive;
-          const task = state?.currentTask;
-          if (busy && task) return `${r.name}(${m.groupBusy(task.taskId + ' ' + task.taskTitle)})`;
-          if (busy) return `${r.name}(${m.groupBusyShort})`;
-          return `${r.name}(${m.groupIdle})`;
-        });
-        groupLines.push(`${m.groupLabel(g)}: ${memberStrs.join(' ')}`);
-      }
-
-      prompt += `\n\n${m.execGroupStatus}
-${groupLines.join(' / ')}
-
-${m.parallelRules}
-${m.parallelRulesContent(maxGroup)}
-
-\`\`\`
----ROUTE---
-to: dev-1
-task: task-1
-taskTitle: ${m.implLoginPage}
-summary: ${m.implLoginSummary}
----END_ROUTE---
-
----ROUTE---
-to: dev-2
-task: task-2
-taskTitle: ${m.implRegisterPage}
-summary: ${m.implRegisterSummary}
----END_ROUTE---
-\`\`\`
-
-${m.parallelExample}`;
-    }
-
-    prompt += `\n
-${m.workflowEnd}
-${m.workflowEndContent(isDevTeam)}
-
-${m.taskList}
-${m.taskListContent}
-
-\`\`\`
-${m.taskExample}
-\`\`\`
-
-${m.taskListNotes}`;
-  }
-
-  // 非 dev 团队的非决策者也需要知道协作模式
-  if (!role.isDecisionMaker && session.teamType !== 'dev') {
-    prompt += `\n\n${m.collabMode}
-${m.collabModeContent}`;
-  }
-
-  // 非 DM 角色的团队特定协作建议
-  if (!role.isDecisionMaker && m.teamCollabFlow) {
-    // roleType 在多个团队中出现时用 roleType_teamType 消歧
-    const flowFn = m.teamCollabFlow[role.roleType + '_' + session.teamType]
-      || m.teamCollabFlow[role.roleType];
-    if (flowFn) {
-      const flowText = flowFn(session.decisionMaker);
-      if (flowText) {
-        prompt += `\n\n${m.teamCollabFlowTitle}
-${flowText}`;
-      }
-    }
-  }
-
-  // Feature 进度文件说明
-  prompt += `\n\n${m.featureRecordTitle}
-${m.featureRecordContent}
-
-${m.contextRestartTitle}
-${m.contextRestartContent}`;
-
-  // 执行者角色的组绑定 prompt
-  if (role.groupIndex > 0 && role.roleType === 'developer') {
-    const gi = role.groupIndex;
-    const rev = allRoles.find(r => r.roleType === 'reviewer' && r.groupIndex === gi);
-    const prev = allRoles.find(r => r.roleType === 'product-reviewer' && r.groupIndex === gi);
-    if (rev && prev) {
-      prompt += `\n\n${m.devGroupBinding}
-${m.devGroupBindingContent(gi, roleLabel(rev), rev.name, roleLabel(prev), prev.name)}
-
-\`\`\`
----ROUTE---
-to: ${rev.name}
-summary: ${m.reviewCode}
----END_ROUTE---
-
----ROUTE---
-to: ${prev.name}
-summary: ${m.productReviewFeature}
----END_ROUTE---
-\`\`\`
-
-${m.devGroupBindingNote}`;
-    }
-  }
-
-  // Language instruction
-  if (session.language === 'en') {
-    prompt += `\n\n# Language
-Always respond in English. Use English for all explanations, comments, and communications with the user. Technical terms and code identifiers should remain in their original form.`;
-  } else {
-    prompt += `\n\n# Language
-Always respond in 中文. Use 中文 for all explanations, comments, and communications with the user. Technical terms and code identifiers should remain in their original form.`;
-  }
-
-  return prompt;
-}

package/crew/role-states.js

@@ -1,180 +0,0 @@
-/**
- * Crew — Role State Store (task-330d, Fowler Final Spec §D)
- *
- * Replaces the legacy "standby task" pattern (where PM idle was modelled
- * as a synthetic task in `.crew/context/features/standby.md`). Role idle/
- * busy/pending state is now first-class and persisted to a single file:
- *
- *     <sharedDir>/context/role-states.json
- *
- * File shape:
- *   {
- *     "version": 1,
- *     "states": {
- *       "<roleName>": { role, status, since, reason }
- *     }
- *   }
- *
- * Status values:
- *   - 'standby' : role has no active task and is waiting for routing
- *   - 'busy'    : role is currently executing a turn
- *   - 'pending' : role finished a turn but did not emit a ROUTE
- *
- * Public API (consumed by the `role_standby` tool added in task-330a):
- *   - getRoleState(sharedDir, role)        → state | null
- *   - setRoleState(sharedDir, role, patch) → state
- *   - listRoleStates(sharedDir)            → Record<role, state>
- *
- * Atomicity: writes go to `role-states.json.tmp` then rename, matching the
- * convention in persistence.js. A per-process write lock (Promise chain)
- * serialises concurrent setRoleState calls so the file never tears.
- *
- * Backward compatibility: a session that was created before role-states.json
- * existed simply has no file; getRoleState returns null and setRoleState
- * creates the file lazily. No migration step is required.
- */
-
-import { promises as fs } from 'fs';
-import { join } from 'path';
-
-const FILE_NAME = 'role-states.json';
-const VERSION = 1;
-const VALID_STATUSES = new Set(['standby', 'busy', 'pending']);
-
-// Per-sharedDir write lock. Keyed by absolute path so multiple sessions in
-// one process don't serialise against each other.
-const _writeLocks = new Map();
-
-function _lockKey(sharedDir) {
-  return sharedDir;
-}
-
-function _filePath(sharedDir) {
-  return join(sharedDir, 'context', FILE_NAME);
-}
-
-async function _readAll(sharedDir) {
-  try {
-    const raw = await fs.readFile(_filePath(sharedDir), 'utf-8');
-    const parsed = JSON.parse(raw);
-    if (!parsed || typeof parsed !== 'object' || !parsed.states || typeof parsed.states !== 'object') {
-      return { version: VERSION, states: {} };
-    }
-    return { version: parsed.version || VERSION, states: parsed.states };
-  } catch (err) {
-    if (err && err.code === 'ENOENT') return { version: VERSION, states: {} };
-    // Corrupt JSON → start fresh rather than crash. This matches the
-    // "legacy session replay compatibility" red line: a broken file must
-    // not block resume.
-    return { version: VERSION, states: {} };
-  }
-}
-
-async function _writeAtomic(sharedDir, payload) {
-  const dir = join(sharedDir, 'context');
-  await fs.mkdir(dir, { recursive: true });
-  const target = _filePath(sharedDir);
-  const tmp = target + '.tmp';
-  await fs.writeFile(tmp, JSON.stringify(payload, null, 2));
-  await fs.rename(tmp, target);
-}
-
-/**
- * Read the current state for a single role.
- * @param {string} sharedDir — session shared directory (`.crew` root)
- * @param {string} role — role name
- * @returns {Promise<null | {role:string, status:string, since:number, reason?:string}>}
- */
-export async function getRoleState(sharedDir, role) {
-  if (!sharedDir || !role) return null;
-  const all = await _readAll(sharedDir);
-  return all.states[role] || null;
-}
-
-/**
- * Read every role's state at once. Returns a plain object keyed by role
- * name (empty when the file is missing).
- */
-export async function listRoleStates(sharedDir) {
-  if (!sharedDir) return {};
-  const all = await _readAll(sharedDir);
-  return { ...all.states };
-}
-
-/**
- * Patch a single role's state. Unspecified fields are preserved from the
- * existing record. `since` defaults to Date.now() when status changes (or
- * when no prior record exists). Throws on invalid status — callers are
- * expected to pass one of standby|busy|pending.
- *
- * @param {string} sharedDir
- * @param {string} role
- * @param {Partial<{status:string, reason:string, since:number}>} patch
- * @returns {Promise<{role:string, status:string, since:number, reason?:string}>}
- */
-export async function setRoleState(sharedDir, role, patch = {}) {
-  if (!sharedDir) throw new Error('setRoleState: sharedDir required');
-  if (!role) throw new Error('setRoleState: role required');
-  if (patch.status !== undefined && !VALID_STATUSES.has(patch.status)) {
-    throw new Error(`setRoleState: invalid status '${patch.status}'`);
-  }
-
-  const key = _lockKey(sharedDir);
-  const prev = _writeLocks.get(key) || Promise.resolve();
-
-  const next = prev.then(async () => {
-    const all = await _readAll(sharedDir);
-    const existing = all.states[role] || null;
-    const statusChanged = patch.status !== undefined && (!existing || existing.status !== patch.status);
-    const merged = {
-      role,
-      status: patch.status !== undefined ? patch.status : (existing ? existing.status : 'standby'),
-      since: patch.since !== undefined
-        ? patch.since
-        : (statusChanged || !existing ? Date.now() : existing.since),
-    };
-    if (patch.reason !== undefined) {
-      merged.reason = patch.reason;
-    } else if (existing && existing.reason !== undefined && !statusChanged) {
-      merged.reason = existing.reason;
-    }
-    all.states[role] = merged;
-    all.version = VERSION;
-    await _writeAtomic(sharedDir, all);
-    return merged;
-  }, async () => {
-    // If a prior write rejected we still want to attempt this one rather
-    // than poisoning the chain forever.
-    const all = await _readAll(sharedDir);
-    const merged = {
-      role,
-      status: patch.status || 'standby',
-      since: patch.since !== undefined ? patch.since : Date.now(),
-      ...(patch.reason !== undefined ? { reason: patch.reason } : {}),
-    };
-    all.states[role] = merged;
-    await _writeAtomic(sharedDir, all);
-    return merged;
-  });
-
-  // Hold onto the chain so the next caller waits on this write.
-  _writeLocks.set(key, next.catch(() => {}));
-  return next;
-}
-
-/**
- * Test/diagnostic helper — clear in-process write lock for a sharedDir.
- * Production callers should never need this; tests use it between runs to
- * avoid bleeding lock state across describe blocks.
- */
-export function __resetWriteLockForTests(sharedDir) {
-  if (sharedDir) _writeLocks.delete(sharedDir);
-  else _writeLocks.clear();
-}
-
-/**
- * Constants exported for tests + downstream consumers (the `role_standby`
- * tool in task-330a).
- */
-export const ROLE_STATE_FILE_NAME = FILE_NAME;
-export const ROLE_STATE_STATUSES = ['standby', 'busy', 'pending'];

package/crew/routing-fallback.js

@@ -1,64 +0,0 @@
-/**
- * task-330b — Single fallback-target resolver (Final Spec §B item 3).
- *
- * Replaces ad-hoc `session.decisionMaker` lookups scattered across
- * routing.js / role-output.js / human-interaction.js when a message has
- * nowhere obvious to go. Centralising this in ONE function lets us:
- *
- *   - test the fallback policy in isolation
- *   - add per-reason policy without touching every call site
- *   - keep the §B `recordRoutingEvent` calls right next to the decision
- *
- * Policy (mirrors what the codebase already does — this is a refactor,
- * not a behaviour change for the existing 4 reasons):
- *
- *   missing-route     → PM (decisionMaker) IF caller is non-PM AND has
- *                       active task or routing intent. Else: pending (null).
- *                       PM-no-auto-forward rule (§B item 2): if caller IS
- *                       PM → ALWAYS pending (null), even with active task.
- *   parse-fail        → PM (decisionMaker)
- *   self-route        → null (rejected; §A handles, §B only logs)
- *   state-stopped     → null (let session.status block the dispatch)
- *   fallback-forward  → PM (decisionMaker) — explicit auto-forward path
- *
- * Returns the target role NAME, or null when "do nothing / pending".
- *
- * @param {object} session — crew session (.decisionMaker, .roles)
- * @param {string} fromRole
- * @param {string} reason — one of ROUTING_REASONS
- * @param {object} [opts]
- * @param {boolean} [opts.hasActiveTask]
- * @param {boolean} [opts.hasRouteIntent]
- * @returns {string|null}
- */
-export function resolveFallbackTarget(session, fromRole, reason, opts = {}) {
-  if (!session) return null;
-  const dm = session.decisionMaker || null;
-
-  switch (reason) {
-    case 'missing-route': {
-      // PM-no-auto-forward rule (§B item 2): PM never auto-forwards to
-      // itself. Returning null signals "park as pending, wait for human".
-      if (fromRole === dm) return null;
-      // Non-PM: only auto-forward when there is something to forward
-      // (active task OR detected routing intent in the prose).
-      if (opts.hasActiveTask || opts.hasRouteIntent) return dm;
-      return null;
-    }
-    case 'parse-fail':
-      // Parser found a ROUTE block but couldn't read it — PM should see
-      // the malformed output to decide next step.
-      return dm;
-    case 'self-route':
-      // §A rejects self-routing; §B records, no fallback dispatch.
-      return null;
-    case 'state-stopped':
-      // Session is stopped/paused; routing must not auto-resume here.
-      return null;
-    case 'fallback-forward':
-      // Explicit safety net (the rename of the existing auto-forward).
-      return dm;
-    default:
-      return null;
-  }
-}