@yeaft/webchat-agent 1.0.413 → 1.0.415

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yeaft/webchat-agent",
-  "version": "1.0.413",
+  "version": "1.0.415",
   "description": "Remote worker agent for Yeaft Web Code Agent — connects the native Yeaft engine, CLI providers, and workbench tools",
   "main": "index.js",
   "type": "module",
@@ -41,6 +41,8 @@
     "docker-entrypoint.sh",
     "yeaft/templates/**/*.md",
     "yeaft/dream/prompts/**/*.md",
+    "browser-runtime/extension/**/*",
+    "browser-runtime/*.ps1",
     "local-runtime/**/*"
   ],
   "license": "MIT",
@@ -62,6 +64,7 @@
   },
   "dependencies": {
     "@homebridge/node-pty-prebuilt-multiarch": "^0.13.1",
+    "@puppeteer/browsers": "2.13.0",
     "bcrypt": "^6.0.0",
     "compression": "^1.8.1",
     "dotenv": "^16.3.1",
@@ -69,6 +72,7 @@
     "jsonwebtoken": "^9.0.2",
     "multer": "^2.2.0",
     "nodemailer": "^9.0.3",
+    "puppeteer-core": "24.41.0",
     "qrcode": "^1.5.4",
     "speakeasy": "^2.0.0",
     "tweetnacl": "^1.0.3",

package/service/config.js

@@ -113,7 +113,7 @@ export function resolveServiceInstanceId(args = [], env = process.env, options =
 }
 
 /** Resolve the CLI/env/default Yeaft data root for one Agent instance. */
-export function resolveYeaftDir(args = [], env = process.env, instanceId = DEFAULT_INSTANCE_ID) {
+function explicitYeaftDirFromArgs(args = []) {
   let explicitYeaftDir = null;
   for (let index = 0; index < args.length; index += 1) {
     if (args[index] !== '--yeaft-dir') continue;
@@ -122,7 +122,28 @@ export function resolveYeaftDir(args = [], env = process.env, instanceId = DEFAU
     explicitYeaftDir = value;
     index += 1;
   }
-  return explicitYeaftDir || env.YEAFT_DIR || getDefaultYeaftDir(instanceId);
+  return explicitYeaftDir;
+}
+
+export function resolveYeaftDir(args = [], env = process.env, instanceId = DEFAULT_INSTANCE_ID) {
+  return explicitYeaftDirFromArgs(args) || env.YEAFT_DIR || getDefaultYeaftDir(instanceId);
+}
+
+/** Resolve the persisted data root for an explicitly selected management target. */
+export function resolveManagedYeaftDir(
+  args = [],
+  env = process.env,
+  instanceId = DEFAULT_INSTANCE_ID,
+  dependencies = {},
+) {
+  const explicitYeaftDir = explicitYeaftDirFromArgs(args);
+  if (explicitYeaftDir) return explicitYeaftDir;
+  const hasExplicitIdentity = args.includes('--name') || args.includes('--instance');
+  if (!hasExplicitIdentity && env.YEAFT_DIR) return env.YEAFT_DIR;
+  const readServiceConfig = dependencies.loadServiceConfig || loadServiceConfig;
+  const defaultYeaftDir = dependencies.getDefaultYeaftDir || getDefaultYeaftDir;
+  const persisted = readServiceConfig(instanceId)?.yeaftDir;
+  return persisted || defaultYeaftDir(instanceId);
 }
 
 /** Legacy alias for resolveServiceInstanceId(). */

package/service/index.js

@@ -29,6 +29,7 @@ export {
   resolveDisplayName,
   resolveRuntimeIdentity,
   resolveServiceInstanceId,
+  resolveManagedYeaftDir,
   shouldLoadLegacyLocalConfig,
   normalizeInstanceId,
   isDefaultInstance,

package/service/linux.js

@@ -12,7 +12,7 @@ export function getSystemdServicePath(instanceId = DEFAULT_INSTANCE_ID) {
   return join(homedir(), '.config', 'systemd', 'user', `${getServiceName(instanceId)}.service`);
 }
 
-function generateSystemdUnit(config) {
+export function generateSystemdUnit(config) {
   const nodePath = getNodePath();
   const cliPath = getCliPath();
   const logDir = getLogDir(config.instanceId);
@@ -38,7 +38,8 @@ ExecStart=${nodePath} ${cliPath}
 WorkingDirectory=${config.workDir || homedir()}
 Restart=on-failure
 RestartSec=10
-KillMode=process
+KillMode=mixed
+TimeoutStopSec=15
 ${envLines.join('\n')}
 Environment=PATH=${nodeBinDir}:${homedir()}/.local/bin:${homedir()}/.npm-global/bin:/usr/local/bin:/usr/bin:/bin
 

package/terminal.js

@@ -62,28 +62,122 @@ function terminalRoutingFields(source) {
   return {
     ...(source?._requestUserId ? { _requestUserId: source._requestUserId } : {}),
     ...(source?._requestClientId ? { _requestClientId: source._requestClientId } : {}),
+    ...(source?._workbenchRequestId ? { _workbenchRequestId: source._workbenchRequestId } : {}),
+    ...(source?.workbenchRouteKey ? { workbenchRouteKey: source.workbenchRouteKey } : {}),
+    ...(source?.workbenchWorkspaceGeneration
+      ? { workbenchWorkspaceGeneration: source.workbenchWorkspaceGeneration }
+      : {}),
   };
 }
 
+function terminalOwner(source) {
+  return {
+    conversationId: source?.conversationId || '',
+    workbenchRouteKey: source?.workbenchRouteKey || '',
+    workbenchWorkspaceGeneration: source?.workbenchWorkspaceGeneration || '',
+  };
+}
+
+function terminalOwnerMatches(term, msg) {
+  if (!term || !msg) return false;
+  const owner = terminalOwner(term);
+  const request = terminalOwner(msg);
+  if (owner.workbenchRouteKey) {
+    return request.workbenchRouteKey === owner.workbenchRouteKey
+      && request.workbenchWorkspaceGeneration === owner.workbenchWorkspaceGeneration
+      && request.conversationId === owner.conversationId;
+  }
+  return !request.workbenchRouteKey
+    && !request.workbenchWorkspaceGeneration
+    && request.conversationId === owner.conversationId;
+}
+
+function rejectTerminalOwnerMismatch(msg, terminalId) {
+  ctx.sendToServer({
+    type: 'terminal_error',
+    conversationId: msg?.conversationId,
+    terminalId,
+    message: 'Terminal owner mismatch',
+    ...terminalRoutingFields(msg),
+  });
+}
+
+/**
+ * Fail closed when the Agent transport loses its Server-side owner state.
+ * Pending creates are cancelled before their backend resolves; established
+ * PTYs are removed from the owner map before kill so synchronous or delayed
+ * exit callbacks cannot affect a replacement terminal with the same id.
+ * No wire event is emitted because the transport is unavailable.
+ */
+export function cleanupTerminalsForDisconnect() {
+  const terminals = [...ctx.terminals.entries()];
+  if (terminals.length === 0) return 0;
+
+  for (const [, term] of terminals) {
+    term.cancelled = true;
+    if (term.timer) {
+      clearTimeout(term.timer);
+      term.timer = null;
+    }
+  }
+  ctx.terminals.clear();
+
+  for (const [, term] of terminals) {
+    if (!term.pty) continue;
+    try { term.pty.kill(); } catch {}
+  }
+  return terminals.length;
+}
+
 export async function handleTerminalCreate(msg) {
   const { conversationId, cols, rows } = msg;
   const terminalId = msg.terminalId || conversationId;
   const conv = ctx.conversations.get(conversationId);
-  const workDir = conv?.workDir || ctx.CONFIG.workDir;
+  const routeScoped = !!msg.workbenchRouteKey;
+  if (routeScoped && !msg.workbenchWorkspaceGeneration) {
+    rejectTerminalOwnerMismatch(msg, terminalId);
+    return;
+  }
+  const workDir = routeScoped
+    ? (msg.workDir || ctx.CONFIG.workDir)
+    : (conv?.workDir || ctx.CONFIG.workDir);
   const routingFields = terminalRoutingFields(msg);
 
-  // 如果已存在终端，先关闭
+  // A terminal id is an object capability. It may only be replaced by its
+  // immutable owner, never by another Session that guessed the id.
   if (ctx.terminals.has(terminalId)) {
     const existing = ctx.terminals.get(terminalId);
+    if (!terminalOwnerMatches(existing, msg)) {
+      rejectTerminalOwnerMismatch(msg, terminalId);
+      return;
+    }
+    existing.cancelled = true;
+    if (existing.timer) {
+      clearTimeout(existing.timer);
+      existing.timer = null;
+    }
+    ctx.terminals.delete(terminalId);
     if (existing.pty) {
       try { existing.pty.kill(); } catch {}
     }
-    if (existing.timer) clearTimeout(existing.timer);
-    ctx.terminals.delete(terminalId);
   }
 
+  const pendingCreation = {
+    pty: null,
+    pending: true,
+    cancelled: false,
+    conversationId,
+    cols: cols || 80,
+    rows: rows || 24,
+    ...terminalOwner(msg),
+    ...routingFields,
+  };
+  ctx.terminals.set(terminalId, pendingCreation);
+
   const pty = await loadNodePty();
+  if (ctx.terminals.get(terminalId) !== pendingCreation || pendingCreation.cancelled) return;
   if (!pty) {
+    ctx.terminals.delete(terminalId);
     ctx.sendToServer({
       type: 'terminal_error',
       conversationId,
@@ -120,40 +214,65 @@ export async function handleTerminalCreate(msg) {
       env: terminalEnv
     });
 
-    // 输出缓冲 - 每 16ms 批量发送
-    let buffer = '';
-    let timer = null;
+    if (ctx.terminals.get(terminalId) !== pendingCreation || pendingCreation.cancelled) {
+      try { ptyProcess.kill(); } catch {}
+      return;
+    }
+
+    const terminalRecord = {
+      pty: ptyProcess,
+      cancelled: false,
+      conversationId,
+      cols: cols || 80,
+      rows: rows || 24,
+      buffer: '',
+      timer: null,
+      ...terminalOwner(msg),
+      ...routingFields,
+    };
+    ctx.terminals.set(terminalId, terminalRecord);
 
+    // Output callbacks are fenced to this exact record. A disconnect or
+    // same-id replacement removes it before kill, so stale data/exit events
+    // cannot leak or delete the replacement.
     ptyProcess.onData(data => {
-      buffer += data;
-      if (!timer) {
-        timer = setTimeout(() => {
+      if (ctx.terminals.get(terminalId) !== terminalRecord || terminalRecord.cancelled) return;
+      terminalRecord.buffer += data;
+      if (!terminalRecord.timer) {
+        terminalRecord.timer = setTimeout(() => {
+          terminalRecord.timer = null;
+          if (ctx.terminals.get(terminalId) !== terminalRecord || terminalRecord.cancelled) {
+            terminalRecord.buffer = '';
+            return;
+          }
           ctx.sendToServer({
             type: 'terminal_output',
             conversationId,
             terminalId,
-            data: buffer,
+            data: terminalRecord.buffer,
             ...routingFields,
           });
-          buffer = '';
-          timer = null;
+          terminalRecord.buffer = '';
         }, 16);
       }
     });
 
     ptyProcess.onExit(({ exitCode }) => {
-      // 发送剩余缓冲
-      if (buffer) {
+      if (ctx.terminals.get(terminalId) !== terminalRecord || terminalRecord.cancelled) return;
+      if (terminalRecord.buffer) {
         ctx.sendToServer({
           type: 'terminal_output',
           conversationId,
           terminalId,
-          data: buffer,
+          data: terminalRecord.buffer,
           ...routingFields,
         });
-        buffer = '';
+        terminalRecord.buffer = '';
+      }
+      if (terminalRecord.timer) {
+        clearTimeout(terminalRecord.timer);
+        terminalRecord.timer = null;
       }
-      if (timer) clearTimeout(timer);
 
       console.log(`[PTY] Process exited for ${terminalId}, code: ${exitCode}`);
       ctx.terminals.delete(terminalId);
@@ -165,16 +284,6 @@ export async function handleTerminalCreate(msg) {
       });
     });
 
-    ctx.terminals.set(terminalId, {
-      pty: ptyProcess,
-      conversationId,
-      cols: cols || 80,
-      rows: rows || 24,
-      buffer: '',
-      timer: null,
-      ...routingFields,
-    });
-
     console.log(`[PTY] Created terminal ${terminalId} for ${conversationId} in ${workDir}`);
     ctx.sendToServer({
       type: 'terminal_created',
@@ -184,6 +293,7 @@ export async function handleTerminalCreate(msg) {
       ...routingFields,
     });
   } catch (e) {
+    if (ctx.terminals.get(terminalId) === pendingCreation) ctx.terminals.delete(terminalId);
     console.error(`[PTY] Failed to create terminal:`, e.message);
     ctx.sendToServer({
       type: 'terminal_error',
@@ -199,6 +309,10 @@ export function handleTerminalInput(msg) {
   const terminalId = msg.terminalId || msg.conversationId;
   const term = ctx.terminals.get(terminalId);
   if (term?.pty) {
+    if (!terminalOwnerMatches(term, msg)) {
+      rejectTerminalOwnerMismatch(msg, terminalId);
+      return;
+    }
     try {
       term.pty.write(msg.data);
     } catch (e) {
@@ -212,6 +326,10 @@ export function handleTerminalResize(msg) {
   const { cols, rows } = msg;
   const term = ctx.terminals.get(terminalId);
   if (term?.pty && cols > 0 && rows > 0) {
+    if (!terminalOwnerMatches(term, msg)) {
+      rejectTerminalOwnerMismatch(msg, terminalId);
+      return;
+    }
     try {
       term.pty.resize(cols, rows);
       term.cols = cols;
@@ -226,11 +344,30 @@ export function handleTerminalClose(msg) {
   const terminalId = msg.terminalId || msg.conversationId;
   const term = ctx.terminals.get(terminalId);
   if (term) {
+    if (!terminalOwnerMatches(term, msg)) {
+      rejectTerminalOwnerMismatch(msg, terminalId);
+      return;
+    }
+    if (term.pending && !term.pty) {
+      term.cancelled = true;
+      ctx.terminals.delete(terminalId);
+      ctx.sendToServer({
+        type: 'terminal_closed',
+        conversationId: term.conversationId || msg.conversationId,
+        terminalId,
+        ...terminalRoutingFields(term),
+      });
+      return;
+    }
+    term.cancelled = true;
+    if (term.timer) {
+      clearTimeout(term.timer);
+      term.timer = null;
+    }
+    ctx.terminals.delete(terminalId);
     if (term.pty) {
       try { term.pty.kill(); } catch {}
     }
-    if (term.timer) clearTimeout(term.timer);
-    ctx.terminals.delete(terminalId);
     console.log(`[PTY] Closed terminal ${terminalId}`);
     ctx.sendToServer({
       type: 'terminal_closed',

package/workbench/file-ops.js

@@ -4,6 +4,7 @@ import { join, basename, dirname, extname } from 'path';
 import { platform } from 'os';
 import ctx from '../context.js';
 import { resolveAndValidatePath, BINARY_EXTENSIONS } from './utils.js';
+import { sendWorkbenchResult } from './request-routing.js';
 
 export async function handleReadFile(msg) {
   const { conversationId, filePath, requestId, _requestUserId, _requestClientId } = msg;
@@ -20,7 +21,7 @@ export async function handleReadFile(msg) {
       // Binary file: read as Buffer, send base64
       const buffer = await readFile(resolved);
       console.log('[Agent] Sending binary file_content:', { filePath: resolved, size: buffer.length, mimeType, conversationId });
-      ctx.sendToServer({
+      sendWorkbenchResult(ctx, msg, {
         type: 'file_content',
         conversationId,
         requestId,
@@ -56,7 +57,7 @@ export async function handleReadFile(msg) {
       };
 
       console.log('[Agent] Sending file_content:', { filePath: resolved, contentLen: content.length, conversationId });
-      ctx.sendToServer({
+      sendWorkbenchResult(ctx, msg, {
         type: 'file_content',
         conversationId,
         requestId,
@@ -69,7 +70,7 @@ export async function handleReadFile(msg) {
       });
     }
   } catch (e) {
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_content',
       conversationId,
       requestId,
@@ -92,7 +93,7 @@ export async function handleWriteFile(msg) {
     const resolved = resolveAndValidatePath(filePath, workDir);
     await writeFile(resolved, content, 'utf-8');
 
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_saved',
       conversationId,
       requestId,
@@ -103,7 +104,7 @@ export async function handleWriteFile(msg) {
       success: true
     });
   } catch (e) {
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_saved',
       conversationId,
       requestId,
@@ -133,7 +134,7 @@ export async function handleListDirectory(msg) {
             drives.push({ name: letter + ':', type: 'directory', size: 0 });
           }
         }
-        ctx.sendToServer({
+        sendWorkbenchResult(ctx, msg, {
           type: 'directory_listing',
           conversationId,
           requestId,
@@ -150,7 +151,7 @@ export async function handleListDirectory(msg) {
           .filter(e => !(e.isDirectory() && SKIP_DIRS.has(e.name)))
           .map(e => ({ name: e.name, type: e.isDirectory() ? 'directory' : 'file', size: 0 }))
           .sort((a, b) => a.name.localeCompare(b.name));
-        ctx.sendToServer({
+        sendWorkbenchResult(ctx, msg, {
           type: 'directory_listing',
           conversationId,
           requestId,
@@ -161,7 +162,7 @@ export async function handleListDirectory(msg) {
         });
       }
     } catch (e) {
-      ctx.sendToServer({
+      sendWorkbenchResult(ctx, msg, {
         type: 'directory_listing',
         conversationId,
         requestId,
@@ -209,7 +210,7 @@ export async function handleListDirectory(msg) {
       return a.name.localeCompare(b.name);
     });
 
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'directory_listing',
       conversationId,
       requestId,
@@ -219,7 +220,7 @@ export async function handleListDirectory(msg) {
       entries: result
     });
   } catch (e) {
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'directory_listing',
       conversationId,
       requestId,
@@ -251,13 +252,13 @@ export async function handleCreateFile(msg) {
       }
       await writeFile(resolved, '', 'utf-8');
     }
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_op_result', conversationId, _requestUserId,
       operation: 'create', success: true,
       message: (isDirectory ? 'Directory' : 'File') + ' created: ' + basename(resolved)
     });
   } catch (e) {
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_op_result', conversationId, _requestUserId,
       operation: 'create', success: false, error: e.message
     });
@@ -293,13 +294,13 @@ export async function handleDeleteFiles(msg) {
       ? 'Deleted: ' + deleted.join(', ') + (errors.length > 0 ? '; Errors: ' + errors.join(', ') : '')
       : 'Failed: ' + errors.join(', ');
 
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_op_result', conversationId, _requestUserId,
       operation: 'delete', success: deleted.length > 0,
       message, deletedCount: deleted.length, errorCount: errors.length
     });
   } catch (e) {
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_op_result', conversationId, _requestUserId,
       operation: 'delete', success: false, error: e.message
     });
@@ -341,13 +342,13 @@ export async function handleMoveFiles(msg) {
       ? 'Moved: ' + moved.join(', ') + ' → ' + basename(destResolved) + (errors.length > 0 ? '; Errors: ' + errors.join(', ') : '')
       : 'Failed: ' + errors.join(', ');
 
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_op_result', conversationId, _requestUserId,
       operation: 'move', success: moved.length > 0,
       message, movedCount: moved.length, errorCount: errors.length
     });
   } catch (e) {
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_op_result', conversationId, _requestUserId,
       operation: 'move', success: false, error: e.message
     });
@@ -402,13 +403,13 @@ export async function handleCopyFiles(msg) {
       ? 'Copied: ' + copied.join(', ') + (errors.length > 0 ? '; Errors: ' + errors.join(', ') : '')
       : 'Failed: ' + errors.join(', ');
 
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_op_result', conversationId, _requestUserId,
       operation: 'copy', success: copied.length > 0,
       message, copiedCount: copied.length, errorCount: errors.length
     });
   } catch (e) {
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_op_result', conversationId, _requestUserId,
       operation: 'copy', success: false, error: e.message
     });
@@ -444,13 +445,13 @@ export async function handleUploadToDir(msg) {
       ? 'Uploaded: ' + saved.join(', ') + (errors.length > 0 ? '; Errors: ' + errors.join(', ') : '')
       : 'Failed: ' + errors.join(', ');
 
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_op_result', conversationId, _requestUserId,
       operation: 'upload', success: saved.length > 0,
       message, uploadedCount: saved.length, errorCount: errors.length
     });
   } catch (e) {
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_op_result', conversationId, _requestUserId,
       operation: 'upload', success: false, error: e.message
     });

package/workbench/file-search.js

@@ -1,6 +1,7 @@
 import { readdir, stat } from 'fs/promises';
 import { join, relative, resolve } from 'path';
 import ctx from '../context.js';
+import { sendWorkbenchResult } from './request-routing.js';
 
 export async function handleFileSearch(msg) {
   const { conversationId, query, _requestUserId } = msg;
@@ -10,7 +11,7 @@ export async function handleFileSearch(msg) {
 
   try {
     if (!query || query.trim().length === 0) {
-      ctx.sendToServer({ type: 'file_search_result', conversationId, _requestUserId, query, results: [] });
+      sendWorkbenchResult(ctx, msg, { type: 'file_search_result', conversationId, _requestUserId, query, results: [] });
       return;
     }
 
@@ -51,7 +52,7 @@ export async function handleFileSearch(msg) {
 
     await walk(resolved, 0);
 
-    ctx.sendToServer({
+    sendWorkbenchResult(ctx, msg, {
       type: 'file_search_result',
       conversationId,
       _requestUserId,
@@ -60,6 +61,6 @@ export async function handleFileSearch(msg) {
       truncated: results.length >= MAX_RESULTS
     });
   } catch (e) {
-    ctx.sendToServer({ type: 'file_search_result', conversationId, _requestUserId, query, results: [], error: e.message });
+    sendWorkbenchResult(ctx, msg, { type: 'file_search_result', conversationId, _requestUserId, query, results: [], error: e.message });
   }
 }