@yeaft/webchat-agent 0.1.792 → 0.1.794

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yeaft/webchat-agent",
-  "version": "0.1.792",
+  "version": "0.1.794",
   "description": "Remote agent for Yeaft WebChat — connects worker machines to the central server",
   "main": "index.js",
   "type": "module",

package/unify/vp/seed-defaults.js

@@ -31,6 +31,7 @@ import { existsSync, mkdirSync, readdirSync, statSync } from 'fs';
 import { join } from 'path';
 import { createVp, VpCrudError } from './vp-crud.js';
 import { DEFAULT_VP_LIB_DIR } from './vp-store.js';
+import { STOCK_VP_IDS } from './stock-ids.js';
 
 /**
  * The 33 default VPs. Each entry is a valid `createVp` payload.
@@ -855,6 +856,33 @@ Bad for: requests that require pretending to be a licensed professional, bypassi
   },
 ]);
 
+/**
+ * Self-check: every seed persona's vpId must appear in STOCK_VP_IDS, and
+ * vice versa. The two lists live in separate modules to break a circular
+ * import (see stock-ids.js header), so the only thing keeping them in
+ * sync is this load-time assertion. If you add a new seed VP and forget
+ * to add its id to stock-ids.js#STOCK_VP_ID_LIST (or vice versa), the
+ * agent will refuse to start with a clear error.
+ */
+const _seedIds = new Set(DEFAULT_VPS.map(v => v.vpId));
+{
+  const missingInStockIds = [];
+  for (const id of _seedIds) {
+    if (!STOCK_VP_IDS.has(id)) missingInStockIds.push(id);
+  }
+  const missingInSeeds = [];
+  for (const id of STOCK_VP_IDS) {
+    if (!_seedIds.has(id)) missingInSeeds.push(id);
+  }
+  if (missingInStockIds.length || missingInSeeds.length) {
+    throw new Error(
+      '[seed-defaults] DEFAULT_VPS / STOCK_VP_IDS mismatch — '
+      + `add to stock-ids.js: [${missingInStockIds.join(', ')}]; `
+      + `add to DEFAULT_VPS: [${missingInSeeds.join(', ')}]`,
+    );
+  }
+}
+
 /**
  * True iff `libDir` exists and contains at least one subdirectory that
  * looks like a VP entry (has a `role.md` file). A stray empty directory

package/unify/vp/stock-ids.js

@@ -0,0 +1,53 @@
+/**
+ * stock-ids.js — single source of truth for "is this vpId a stock seed VP?".
+ *
+ * Owns the canonical list of seed vpIds and exposes `STOCK_VP_IDS` (a Set
+ * for O(1) lookup) plus `isStockVpId(vpId)`.
+ *
+ * Why this lives in its own tiny module instead of in seed-defaults.js:
+ *   `seed-defaults.js` imports `createVp / VpCrudError` from `vp-crud.js`,
+ *   so if `vp-crud.js` were to import `STOCK_VP_IDS` from `seed-defaults`
+ *   directly, the module graph would be circular (vp-crud → seed-defaults
+ *   → vp-crud). The cycle "works" today only because every consumer reads
+ *   STOCK_VP_IDS inside a function body (live binding), but a future
+ *   refactor that moves the check to module top level — say, to validate
+ *   input on import — would crash with `STOCK_VP_IDS is undefined`. Moving
+ *   the Set into a leaf module with zero inbound deps from elsewhere in
+ *   the package breaks the cycle for good.
+ *
+ * Authoritative-vs-derived: this file is the SOURCE OF TRUTH for stock
+ * ids. seed-defaults.js asserts at module load that every entry in
+ * DEFAULT_VPS appears here, and vice versa — see the self-check at the
+ * bottom of seed-defaults.js. So adding a new seed VP only requires
+ * adding both the persona object *and* its id here (two-file change,
+ * caught by the assertion if you forget either).
+ */
+
+const STOCK_VP_ID_LIST = Object.freeze([
+  // engineering
+  'steve', 'linus', 'martin', 'dieter', 'ada', 'grace', 'alice', 'ken',
+  'margaret', 'shannon', 'alan', 'norman',
+  // philosophy / psychology
+  'kongzi', 'socrates', 'nietzsche', 'kahneman', 'jung',
+  // strategy / business
+  'sunzi', 'clausewitz', 'simaqian', 'harari',
+  'buffett', 'munger', 'dalio', 'bezos', 'drucker',
+  // arts / culture
+  'luxun', 'sudongpo', 'borges', 'einstein', 'kubrick', 'miyazaki',
+  // assistant
+  'omni',
+]);
+
+/** @type {ReadonlySet<string>} */
+export const STOCK_VP_IDS = new Set(STOCK_VP_ID_LIST);
+
+/**
+ * True iff `vpId` is a stock seed VP that ships with the agent.
+ * Pure function of the string — undefined / non-string input returns false.
+ *
+ * @param {unknown} vpId
+ * @returns {boolean}
+ */
+export function isStockVpId(vpId) {
+  return typeof vpId === 'string' && STOCK_VP_IDS.has(vpId);
+}

package/unify/vp/vp-bridge.js

@@ -23,6 +23,7 @@
 
 import { defaultRegistry } from './registry.js';
 import { VpLoader } from './vp-loader.js';
+import { STOCK_VP_IDS } from './stock-ids.js';
 
 /** Process-singleton VpLoader; lazily started on first subscribe. */
 let _loaderStarted = false;
@@ -175,8 +176,8 @@ function ensureLoader(registry = defaultRegistry) {
  * Serialise a VP (entity layer shape) to the wire-format the web layer
  * expects (spec §2.1). Pure; no IO.
  *
- * @param {{id:string,name:string,role:string,traits?:string[],modelHint?:string,personaHash?:string}} vp
- * @returns {{vpId:string,displayName:string,subtitle:string,role:string,traits:string[],modelHint:?string,personaHash:?string}}
+ * @param {{id:string,name:string,role:string,nameZh?:string,aliases?:string[],traits?:string[],modelHint?:string,personaHash?:string}} vp
+ * @returns {{vpId:string,displayName:string,displayNameZh:string,aliases:string[],subtitle:string,role:string,traits:string[],modelHint:?string,personaHash:?string,isStock:boolean}}
  */
 export function serializeVpForWire(vp) {
   return {
@@ -191,6 +192,13 @@ export function serializeVpForWire(vp) {
     traits: Array.isArray(vp.traits) ? vp.traits.slice() : [],
     modelHint: vp.modelHint ?? null,
     personaHash: vp.personaHash ?? null,
+    // task-vp-customize: mark seed VPs so the frontend can disable
+    // Edit/Delete and surface a "Stock" badge. Pure id check — see
+    // stock-ids.js#STOCK_VP_IDS for the contract. `Set.has(undefined)`
+    // is fine, but we still coerce to plain boolean so the wire field
+    // is strictly `true | false` (never `undefined`) and downstream
+    // `!!` reads can collapse cleanly.
+    isStock: STOCK_VP_IDS.has(vp.id) === true,
   };
 }
 

package/unify/vp/vp-crud.js

@@ -14,6 +14,7 @@
  * Error codes returned to the caller (wire-visible):
  *   'duplicate'      — vpId already exists (on create)
  *   'not_found'      — vpId does not exist on disk (on update/delete)
+ *   'stock_readonly' — vpId is one of the seed/stock VPs (mutation refused)
  *   <reason from validateVpId> — invalid shape
  */
 
@@ -24,6 +25,7 @@ import { validateVpId } from '../groups/ids.js';
 import { DEFAULT_VP_LIB_DIR, parseRoleMd } from './vp-store.js';
 import { seedSummaryIfMissingSync, removeScopeDirSync } from '../memory/store-v2.js';
 import { VP_STUB_MARKER } from '../memory/seed-backfill.js';
+import { STOCK_VP_IDS } from './stock-ids.js';
 
 /**
  * Default memory root used when callers don't pass `options.memoryRoot`.
@@ -34,13 +36,6 @@ import { VP_STUB_MARKER } from '../memory/seed-backfill.js';
  */
 const DEFAULT_MEMORY_ROOT = join(homedir(), '.yeaft', 'memory');
 
-/**
- * Build the seed summary body for a freshly-created VP. Pulled into a
- * helper so tests can pin the exact format.
- *
- * @param {object} payload  same shape as createVp
- * @returns {string}
- */
 /**
  * Build the seed body for a freshly-created VP's `<root>/vp/<id>/summary.md`.
  *
@@ -218,6 +213,11 @@ export function updateVp(payload, options = {}) {
   const v = validateVpId(vpId);
   if (!v.ok) throw new VpCrudError(v.reason, vpId);
 
+  // Stock VPs ship with the agent and are immutable from the CRUD path.
+  // The UI also disables Edit/Delete on these, but a misbehaving WS client
+  // could bypass the UI — refuse here so the file on disk stays canonical.
+  if (STOCK_VP_IDS.has(vpId)) throw new VpCrudError('stock_readonly', vpId);
+
   const dir = vpDirFor(libDir, vpId);
   if (!existsSync(dir) || !existsSync(vpRolePathFor(libDir, vpId))) {
     throw new VpCrudError('not_found', vpId);
@@ -249,6 +249,10 @@ export function deleteVp(vpId, options = {}) {
   if (!vpId || typeof vpId !== 'string' || vpId.includes('/') || vpId.includes('\\') || vpId === '..' || vpId === '.') {
     throw new VpCrudError('illegal_character', vpId);
   }
+  // Stock VPs ship with the agent. Refuse the delete server-side so a
+  // misbehaving WS client cannot wipe `~/.yeaft/virtual-persons/steve/`
+  // even if the UI's delete button is missing or disabled.
+  if (STOCK_VP_IDS.has(vpId)) throw new VpCrudError('stock_readonly', vpId);
   const dir = vpDirFor(libDir, vpId);
   if (!existsSync(dir)) {
     throw new VpCrudError('not_found', vpId);
@@ -298,5 +302,11 @@ export function readVp(vpId, options = {}) {
     modelHint,
     persona: body,
     planInstruction: typeof meta.planInstruction === 'string' ? String(meta.planInstruction) : '',
+    // Echo the authoritative stock flag on the read response so the UI's
+    // detail view doesn't have to trust the (potentially stale) list
+    // snapshot it was launched from. Defence-in-depth: same Set, two
+    // call sites; if either disagrees, the agent guard in updateVp /
+    // deleteVp is still the final word.
+    isStock: STOCK_VP_IDS.has(id) === true,
   };
 }