@ycodium-ai/plugin-team 0.2.3395 → 0.2.3405

package/dist/index.js

@@ -7472,7 +7472,7 @@ var PERSON_MESSAGE_RULE = "Send a message to the person only for a product decis
 var MEMBER_CHECKS_RULE = "Before you mark an item done, run the checks that this project's rules name for the code you changed, and fix every failure. Do not mark an item done while a check still fails; say in a work item comment what still fails instead.";
 var NO_STASH = "Do not use git stash: all worktrees of this repository share one stash stack.";
 var MEMBER_NO_STASH_RULE = `${NO_STASH} To try something you can undo, commit to a temporary branch or copy files into an ignored folder inside your own worktree, and delete it before you mark the item done.`;
-var MEMBER_ASK_BEFORE_OUTSIDE_RULE = "Before you change dependencies or patches, write outside the project root, or fetch code from the network (git clone, downloads), mention your lead in a work item comment and wait for an answer.";
+var MEMBER_ASK_BEFORE_OUTSIDE_RULE = "Before you change dependencies or patches, write outside the project root, or fetch code from the network (git clone, downloads), mention your lead in a work item comment (put them in the mentions parameter of the comment) and wait for an answer.";
 var MEMBER_READ_RANGES_RULE = "Read files in ranges: find the place with Grep first, then read only the lines you need; read only the relevant section of a skill file.";
 var LEAD_ACCEPT_RULE = `When you check a finished item, run the checks that this project's rules name yourself. Send the item back if its changes touch patches/ or a lockfile, unless the item has a comment from you approving that change. ${NO_STASH} To compare against the base, run the same check in your own working directory on the base branch and compare the error counts; do not stash in the member's worktree.`;
 var PROGRESS_CHECKIN_MINUTES = 20;
@@ -7490,8 +7490,8 @@ var LEAD_SCHEDULE_CHECKIN_RULE = "Before you end a turn while any item of this g
 var LEAD_SPLIT_RULE = "Use work_create_item to split the goal into a few work items: one item per task, with a clear action in the title. Members do not see this conversation or your goal, so put everything a member needs into the description: the deliverable, the constraints, and how to hand the work in. Create them without assignees.";
 var LEAD_OWN_ITEM_RULE = "If a work item for this goal is assigned to you, also record it as blocked by every item you create. Each time a member marks an item done you will be told, so check it then; when they are all done, mark that item done with work_update_item.";
 var LEAD_REBALANCE_RULE = "When a member has nothing in progress while another member has an item waiting in line that is not blocked, move one waiting item to the idle member with work_update_item.";
-var LEAD_CHECKPOINT_RULE = `Members commit and post a one-line progress comment each time they reach a step (a group of tests turns green, a file passes its typecheck, before they change approach, before they stop to wait for someone), and the team plugin mentions a member on an item in progress after ${PROGRESS_CHECKIN_MINUTES} minutes with no progress from them, up to ${PROGRESS_CHECKIN_LIMIT} times in a row. Each time you look in on members, check each item in progress: if the plugin has asked the member and there has been no answer for ${PROGRESS_CHECKIN_LIMIT * PROGRESS_CHECKIN_MINUTES} minutes since its first ask (a member on another machine that has gone offline is asked only once), or the member keeps posting progress but their branch has had no new commit for more than 30 minutes, post a comment with work_post_comment that mentions the member and asks them to run the tests and typecheck for what they have changed so far, commit the work in progress to their branch, and post a one-line progress and blocker comment on the item. Take the times from work_history and, when you can read the member's worktree on this machine, from git log -1 --format=%cI there, and compare them with the current time; do not estimate. When you cannot read their worktree, as with a remote member, judge by work_history and comments alone; not being able to see commits does not mean there are none.`;
-var LEAD_SEND_BACK_RULE = "If a finished item is not acceptable, send it back: use work_update_item to set its state back to an open one (see work_list_states), and change its assignees too if someone else should redo it. Then say what is wrong in a comment with work_post_comment, mentioning the member.";
+var LEAD_CHECKPOINT_RULE = `Members commit and post a one-line progress comment each time they reach a step (a group of tests turns green, a file passes its typecheck, before they change approach, before they stop to wait for someone), and the team plugin mentions a member on an item in progress after ${PROGRESS_CHECKIN_MINUTES} minutes with no progress from them, up to ${PROGRESS_CHECKIN_LIMIT} times in a row. Each time you look in on members, check each item in progress: if the plugin has asked the member and there has been no answer for ${PROGRESS_CHECKIN_LIMIT * PROGRESS_CHECKIN_MINUTES} minutes since its first ask (a member on another machine that has gone offline is asked only once), or the member keeps posting progress but their branch has had no new commit for more than 30 minutes, post a comment with work_post_comment, mentioning the member in its mentions parameter, that asks them to run the tests and typecheck for what they have changed so far, commit the work in progress to their branch, and post a one-line progress and blocker comment on the item. Take the times from work_history and, when you can read the member's worktree on this machine, from git log -1 --format=%cI there, and compare them with the current time; do not estimate. When you cannot read their worktree, as with a remote member, judge by work_history and comments alone; not being able to see commits does not mean there are none.`;
+var LEAD_SEND_BACK_RULE = 'If a finished item is not acceptable, send it back: use work_update_item to set its state back to an open one (see work_list_states), and change its assignees too if someone else should redo it. Then say what is wrong in a comment with work_post_comment, mentioning the member in its mentions parameter (for a local member: { "kind": "agent", "threadId": <their threadId> }); that is what wakes them.';
 var LEAD_NO_MEMBER_TASKS = "Do not do members' tasks yourself, and never assign an item you create to yourself: merging, pushing and integrating the work are member tasks too.";
 var tableCell = (value) => value.replace(/\|/g, "\\|").replace(/[\r\n]/g, " ");
 function leadBrief(goal, roster) {
@@ -8904,6 +8904,89 @@ ${await worktreeSetupSentence(ctx, input.projectId, branch)}`
   return true;
 }
 
+// src/runtime/commentWakes.ts
+var COMMENT_MENTIONS_FACT = "comment-mentions";
+var COMMENT_MENTIONS_EVENT = `team/${COMMENT_MENTIONS_FACT}`;
+var CommentMentionsFact = Struct({
+  version: Literal2(1),
+  projectId: String4,
+  workItemId: String4,
+  commentId: String4,
+  recipients: ArraySchema(
+    Union2([
+      Struct({ threadId: String4 }),
+      Struct({ principalId: String4 })
+    ])
+  )
+});
+var commentPeople = (comment) => [
+  ...comment.parentAuthor === void 0 ? [] : [comment.parentAuthor],
+  ...comment.mentions
+];
+var recipientsOf = (people) => {
+  const recipients = /* @__PURE__ */ new Map();
+  for (const person of people) {
+    const recipient = recipientOf(person);
+    if (recipient !== void 0) recipients.set(recipientKey(recipient), recipient);
+  }
+  return recipients;
+};
+var reachedKeys = (actor, people) => new Set(recipientsOf([actor, ...people]).keys());
+var commentRecipients = (project2, actor, people) => {
+  const author = recipientOf(actor);
+  const authorKey = author === void 0 ? void 0 : recipientKey(author);
+  return [...recipientsOf(people)].filter(([key]) => key !== authorKey).map(([, recipient]) => recipient).filter((recipient) => isMember(project2, recipient));
+};
+var commentWakeKey = (commentId, recipient) => "threadId" in recipient ? `comment:${commentId}:${recipient.threadId}` : `comment:${commentId}:principal:${recipient.principalId}`;
+var queueCommentWakes = (project2, comment, recipients) => [
+  ...project2.pendingComments,
+  ...recipients.map((recipient) => ({
+    ...recipient,
+    key: commentWakeKey(comment.commentId, recipient),
+    projectId: comment.projectId,
+    workItemId: comment.workItemId,
+    commentId: comment.commentId
+  })).filter((queued) => !project2.pendingComments.some((pending) => pending.key === queued.key))
+];
+
+// src/domain/mentionText.ts
+var isAtSign = (character) => character === "@" || character === "\uFF20";
+var MENTION_BOUNDARY = /[\s\p{Script=Han}\p{Script=Hiragana}\p{Script=Katakana}\u3000-\u303f\uff01-\uff0f\uff1a-\uff20\uff3b-\uff40\uff5b-\uff65]/u;
+var isMentionStart = (text, index) => {
+  if (!isAtSign(text[index])) return false;
+  const before = Array.from(text.slice(Math.max(0, index - 2), index)).at(-1);
+  return before === void 0 || MENTION_BOUNDARY.test(before);
+};
+
+// src/runtime/mentionedMembers.ts
+var ASCII_WORD = /[A-Za-z0-9_-]/;
+function mentionedMembers(body, members) {
+  const aliases = members.flatMap((member) => {
+    const principal = mentionPrincipal(member);
+    const recipient = principal === null ? void 0 : recipientOf(principal);
+    if (recipient === void 0) return [];
+    const id = "threadId" in recipient ? recipient.threadId : recipient.principalId;
+    return [id, member.memberId, member.name].flatMap(
+      (text) => text === void 0 || text === null || text === "" ? [] : [{ text: text.toLowerCase(), key: recipientKey(recipient), recipient }]
+    );
+  }).sort((a, b) => b.text.length - a.text.length);
+  const found = /* @__PURE__ */ new Map();
+  for (let at = 0; at < body.length; at++) {
+    if (!isMentionStart(body, at)) continue;
+    const rest = body.slice(at + 1);
+    const hits = aliases.filter((alias) => {
+      if (rest.slice(0, alias.text.length).toLowerCase() !== alias.text) return false;
+      const next = rest[alias.text.length];
+      return next === void 0 || !(ASCII_WORD.test(alias.text.slice(-1)) && ASCII_WORD.test(next));
+    });
+    const longest = hits.filter((hit) => hit.text.length === hits[0]?.text.length);
+    const keys = new Set(longest.map((hit) => hit.key));
+    const [only] = longest;
+    if (only !== void 0 && keys.size === 1) found.set(only.key, only.recipient);
+  }
+  return [...found.values()];
+}
+
 // src/runtime/recoveryState.ts
 var RecoveryPlan = Struct({
   action: Literals(["resume", "lead", "remind", "stall-lead"]),
@@ -9354,6 +9437,11 @@ var decodeEnvelope2 = decodeUnknownOption2(
       name: Literal2("team/member-woken"),
       data: MemberWokenFact
     }),
+    Struct({
+      pluginId: Literal2("team"),
+      name: Literal2(COMMENT_MENTIONS_EVENT),
+      data: CommentMentionsFact
+    }),
     Struct({
       pluginId: Literal2("team"),
       name: Literal2("team/member-worktree-failed"),
@@ -9440,18 +9528,6 @@ var decodeWorkEvent = decodeUnknownOption2(
 var agentThreads = (principals) => [
   ...new Set(principals.flatMap((p) => p.kind === "agent" ? [p.threadId] : []))
 ];
-var commentRecipients = (project2, actor, people) => {
-  const author = recipientOf(actor);
-  const recipients = /* @__PURE__ */ new Map();
-  for (const person of people) {
-    const recipient = recipientOf(person);
-    if (recipient === void 0) continue;
-    const key = recipientKey(recipient);
-    if (author === void 0 || recipientKey(author) !== key) recipients.set(key, recipient);
-  }
-  return [...recipients.values()].filter((recipient) => isMember(project2, recipient));
-};
-var commentWakeKey = (commentId, recipient) => "threadId" in recipient ? `comment:${commentId}:${recipient.threadId}` : `comment:${commentId}:principal:${recipient.principalId}`;
 function foldWorkWakes(state, event) {
   if (event.type === "plugin.event-appended") {
     const decoded2 = decodeEnvelope2(event.payload);
@@ -9488,6 +9564,21 @@ function foldWorkWakes(state, event) {
         }
       };
     }
+    if (fact.name === COMMENT_MENTIONS_EVENT) {
+      const { projectId: projectId3, workItemId: workItemId2, commentId, recipients } = fact.data;
+      const project4 = readFact(state, projectId3) ?? emptyProject();
+      return {
+        ...state,
+        [projectId3]: {
+          ...project4,
+          pendingComments: queueCommentWakes(
+            project4,
+            { projectId: projectId3, workItemId: workItemId2, commentId },
+            recipients.filter((recipient) => isMember(project4, recipient))
+          )
+        }
+      };
+    }
     if (fact.name === "team/member-worktree-failed" || fact.name === "team/member-worktree-reported") {
       const { projectId: projectId3, threadId } = fact.data;
       const project4 = readFact(state, projectId3) ?? emptyProject();
@@ -9651,21 +9742,18 @@ function foldWorkWakes(state, event) {
     }
     case "work.comment-posted": {
       const { actor, parentAuthor, mentions, commentId } = work.payload;
-      const comments = commentRecipients(project2, actor, [
-        ...parentAuthor === void 0 ? [] : [parentAuthor],
-        ...mentions
-      ]).map((recipient) => ({
-        ...recipient,
-        key: commentWakeKey(commentId, recipient),
-        projectId,
-        workItemId,
-        commentId
-      })).filter(
-        (comment) => !project2.pendingComments.some((pending) => pending.key === comment.key)
+      const recipients = commentRecipients(
+        project2,
+        actor,
+        commentPeople({ parentAuthor, mentions })
       );
       next = {
         ...project2,
-        pendingComments: [...project2.pendingComments, ...comments],
+        pendingComments: queueCommentWakes(
+          project2,
+          { projectId, workItemId, commentId },
+          recipients
+        ),
         items: currentItem === null ? project2.items : {
           ...project2.items,
           [workItemId]: {
@@ -9789,6 +9877,52 @@ function dueWakes(state) {
   return due.sort((a, b) => compare2(a.projectId, b.projectId) || compare2(a.key, b.key));
 }
 
+// src/runtime/commentMentions.ts
+var COMMENT_MENTION_RETRIES = 2;
+function startCommentMentionRuntime(ctx, goals) {
+  const handle = async (event) => {
+    const decoded = decodeWorkEvent(event);
+    if (isNone2(decoded) || decoded.value.type !== "work.comment-posted") return;
+    const comment = decoded.value.payload;
+    const { projectId, workItemId, commentId } = comment;
+    const resolve2 = async () => {
+      const goal = await goals.read(projectId);
+      if (goal === null) return;
+      const { comment: posted } = await ctx.work.comments.get({ projectId, commentId });
+      if (posted.body === null) return;
+      const reached = reachedKeys(comment.actor, commentPeople(comment));
+      const recipients = mentionedMembers(posted.body, goal.members).filter(
+        (recipient) => !reached.has(recipientKey(recipient))
+      );
+      if (recipients.length === 0) return;
+      await ctx.events.append({
+        commandId: `team-comment-mentions:${commentId}`,
+        name: COMMENT_MENTIONS_FACT,
+        aggregate: { kind: "project", id: projectId },
+        data: { version: 1, projectId, workItemId, commentId, recipients }
+      });
+    };
+    for (let attempt = 1; ; attempt++) {
+      try {
+        return await resolve2();
+      } catch (error) {
+        if (attempt > COMMENT_MENTION_RETRIES) {
+          ctx.log.warn("team comment mentions failed", {
+            projectId,
+            workItemId,
+            commentId,
+            eventId: event.eventId,
+            attempts: attempt,
+            error
+          });
+          return;
+        }
+      }
+    }
+  };
+  ctx.reactor({ name: "team-comment-mentions", events: ["work.comment-posted"], handle });
+}
+
 // src/runtime/wake.ts
 var workLabel = (workItemId, sequenceId) => sequenceId === void 0 ? `the work item with workItemId ${workItemId}` : `work item W${sequenceId} (workItemId ${workItemId})`;
 var titled = (workItemId, sequenceId, title) => `${workLabel(workItemId, sequenceId)}${title ? `: ${title}` : ""}`;
@@ -9936,7 +10070,7 @@ var leadText = (recovery, name, paused) => `Member ${name} (threadId ${recovery.
 var commentInstructions = (recovery) => recovery.items.map(
   (item) => item.lastCommentId === void 0 ? `${itemLabel(item)} has no comments yet. Continue from your existing workspace changes and turn history.` : `For ${itemLabel(item)}, the latest comment is commentId ${item.lastCommentId}. Read work_list_comments with workItemId: "${item.workItemId}" and continue from that comment and your existing workspace changes; do not start over.`
 ).join("\n");
-var leadInstructions = (paused = false) => `${paused ? "Their sending is paused; a person needs to click Resume sending. " : ""}You can post a comment mentioning the member with work_post_comment to ask them to continue (the comment wakes them), reassign the work with work_update_item, or report the problem to the person.${paused ? " A comment will wait until the person resumes sending." : ""}`;
+var leadInstructions = (paused = false) => `${paused ? "Their sending is paused; a person needs to click Resume sending. " : ""}You can post a comment with work_post_comment, with the member in its mentions parameter, to ask them to continue (the mention wakes them), reassign the work with work_update_item, or report the problem to the person.${paused ? " A comment will wait until the person resumes sending." : ""}`;
 var resumeText = (recovery) => `Your previous turn was interrupted by an upstream error (${recovery.category}). Continue ${recovery.items.map(itemLabel).join(", ")} from where you stopped.
 ${commentInstructions(recovery)}`;
 var remindText = (recovery) => `Your turn ended normally, but ${recovery.items.map(itemLabel).join(", ")} ${recovery.items.length === 1 ? "is" : "are"} still in progress. If finished, mark the work done with work_update_item. If blocked, explain where you are stuck on the item with work_post_comment. Otherwise continue from where you stopped; do not start over.
@@ -11100,6 +11234,7 @@ var index_default = definePlugin({
     const goals = createGoalService(ctx, rosters);
     registerGoalCommands(ctx, goals);
     const wakes = startWakeRuntime(ctx, goals);
+    startCommentMentionRuntime(ctx, goals);
     registerBoardCommands(ctx, goals, rosters, wakes.state);
     registerDetailCommands(ctx, goals);
     startRecoveryRuntime(ctx, goals, wakes.state, wakes.worktrees);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@ycodium-ai/plugin-team",
-  "version": "0.2.3395",
+  "version": "0.2.3405",
   "description": "A project team roster with members, a lead, and goals.",
   "keywords": [
     "teams",
@@ -34,7 +34,7 @@
     "tailwindcss": "^4.0.0",
     "typescript": "~6.0.3",
     "vite-plus": "0.2.2",
-    "@ycodium-ai/plugin-api": "0.2.3395"
+    "@ycodium-ai/plugin-api": "0.2.3405"
   },
   "ycodium": {
     "plugin": "./dist/index.js",