@yasainet/eslint 0.0.15 → 0.0.17

package/README.md

@@ -100,22 +100,22 @@ export default [...eslintConfig];
 
 ## Release
 
-1. Update `version` in `package.json`
-2. Commit and push to `main`
-3. Create and push a tag:
+Version is derived from the Git tag. CI automatically sets `package.json` version before publishing.
+
+1. Commit and push to `main`
+2. Create and push a tag:
 
 ```sh
 git tag v1.0.0
 git push --tags
 ```
 
-4. GitHub Actions will automatically publish to npm
+3. GitHub Actions will automatically publish to npm
 
 ### With lazygit
 
-1. Update `version` in `package.json`
-2. Stage and commit in lazygit
-3. Select the commit, press `T` to create a tag (e.g. `v1.0.0`)
-4. Press `P` to push the commit
-5. Switch to the Tags panel (`]`), select the tag, and press `P` to push it
-6. GitHub Actions will automatically publish to npm
+1. Stage and commit in lazygit
+2. Select the commit, press `T` to create a tag (e.g. `v1.0.0`)
+3. Press `P` to push the commit
+4. Switch to the Tags panel (`]`), select the tag, and press `P` to push it
+5. GitHub Actions will automatically publish to npm

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yasainet/eslint",
-  "version": "0.0.15",
+  "version": "0.0.17",
   "description": "ESLint",
   "type": "module",
   "exports": {

package/src/common/imports.mjs

@@ -129,9 +129,34 @@ export const libBoundaryConfigs = [
 ];
 
 /** @description Scope import restriction rules to the given feature root */
-export function createImportsConfigs(featureRoot, prefixLibMapping) {
+export function createImportsConfigs(
+  featureRoot,
+  prefixLibMapping,
+  { banAliasImports = false } = {},
+) {
   const configs = [];
 
+  if (banAliasImports) {
+    configs.push({
+      name: "imports/ban-alias",
+      files: [`${featureRoot}/**/*.ts`],
+      rules: {
+        "no-restricted-imports": [
+          "error",
+          {
+            patterns: [
+              {
+                group: ["@/*", "@/**"],
+                message:
+                  "Alias imports (@/) are not available in this environment. Use relative paths.",
+              },
+            ],
+          },
+        ],
+      },
+    });
+  }
+
   configs.push(
     makeConfig(
       "repositories",

package/src/common/index.mjs

@@ -6,13 +6,16 @@ import { createNamingConfigs } from "./naming.mjs";
 import { rulesConfigs } from "./rules.mjs";
 
 /** @description Build common configs scoped to the given feature root */
-export function createCommonConfigs(featureRoot) {
+export function createCommonConfigs(
+  featureRoot,
+  { banAliasImports = false } = {},
+) {
   const prefixLibMapping = generatePrefixLibMapping(featureRoot);
   return [
     ...rulesConfigs,
     ...createNamingConfigs(featureRoot, prefixLibMapping),
     ...createLayersConfigs(featureRoot),
-    ...createImportsConfigs(featureRoot, prefixLibMapping),
+    ...createImportsConfigs(featureRoot, prefixLibMapping, { banAliasImports }),
     ...createJsdocConfigs(featureRoot),
   ];
 }

package/src/common/layers.mjs

@@ -1,6 +1,24 @@
 /** @description Scope layer rules to the given feature root */
 export function createLayersConfigs(featureRoot) {
+  const loggerSelector = "CallExpression[callee.object.name='logger']";
+  const loggerMessage =
+    "logger is not allowed outside actions. Logging belongs in actions.";
+
   return [
+    // Logger/console: all features except actions
+    {
+      name: "layers/logger",
+      files: [`${featureRoot}/**/*.ts`],
+      ignores: [`${featureRoot}/**/actions/*.ts`],
+      rules: {
+        "no-console": "error",
+        "no-restricted-syntax": [
+          "error",
+          { selector: loggerSelector, message: loggerMessage },
+        ],
+      },
+    },
+    // Repositories: try-catch + if + logger
     {
       name: "layers/repositories",
       files: [`${featureRoot}/**/repositories/*.ts`],
@@ -17,9 +35,11 @@ export function createLayersConfigs(featureRoot) {
             message:
               "if statements are not allowed in repositories. Conditional logic belongs in services.",
           },
+          { selector: loggerSelector, message: loggerMessage },
         ],
       },
     },
+    // Services: try-catch + logger
     {
       name: "layers/services",
       files: [`${featureRoot}/**/services/*.ts`],
@@ -31,6 +51,7 @@ export function createLayersConfigs(featureRoot) {
             message:
               "try-catch is not allowed in services. Error handling belongs in actions.",
           },
+          { selector: loggerSelector, message: loggerMessage },
         ],
       },
     },

package/src/common/local-plugins/import-path-style.mjs

@@ -0,0 +1,99 @@
+import path from "path";
+
+/**
+ * @description Enforce import path style within features:
+ * - Same-feature imports must use relative paths
+ * - Cross-feature imports must use @/ alias
+ */
+export const importPathStyleRule = {
+  meta: {
+    type: "problem",
+    messages: {
+      useRelative:
+        "Same-feature import must use a relative path instead of '{{ importPath }}'.",
+      useAlias:
+        "Cross-feature import must use '@/' instead of relative path '{{ importPath }}'.",
+    },
+    schema: [
+      {
+        type: "object",
+        properties: {
+          featureRoot: { type: "string" },
+        },
+        required: ["featureRoot"],
+        additionalProperties: false,
+      },
+    ],
+  },
+  create(context) {
+    const { featureRoot } = context.options[0];
+    const filename = context.filename;
+
+    const rootSep = featureRoot + "/";
+    const rootIdx = filename.indexOf(rootSep);
+    if (rootIdx === -1) return {};
+
+    const afterRoot = filename.slice(rootIdx + rootSep.length);
+    const featureName = afterRoot.split("/")[0];
+    if (!featureName) return {};
+
+    // Absolute path of the current feature directory
+    const featureDir =
+      filename.slice(0, rootIdx + rootSep.length) + featureName;
+
+    // Alias prefix for same-feature: @/features/{featureName}
+    const aliasBase = featureRoot.replace(/^src\//, "");
+    const sameFeaturePrefix = `@/${aliasBase}/${featureName}/`;
+    const sameFeatureExact = `@/${aliasBase}/${featureName}`;
+
+    function check(source) {
+      if (!source || typeof source.value !== "string") return;
+      const importPath = source.value;
+
+      // Case 1: @/features/{same-feature}/... → use relative path
+      if (
+        importPath.startsWith(sameFeaturePrefix) ||
+        importPath === sameFeatureExact
+      ) {
+        context.report({
+          node: source,
+          messageId: "useRelative",
+          data: { importPath },
+        });
+        return;
+      }
+
+      // Case 2: relative path that exits current feature → use @/
+      if (importPath.startsWith(".")) {
+        const resolved = path.resolve(path.dirname(filename), importPath);
+        if (
+          !resolved.startsWith(featureDir + "/") &&
+          resolved !== featureDir
+        ) {
+          context.report({
+            node: source,
+            messageId: "useAlias",
+            data: { importPath },
+          });
+        }
+      }
+    }
+
+    return {
+      ImportDeclaration(node) {
+        check(node.source);
+      },
+      ExportNamedDeclaration(node) {
+        if (node.source) check(node.source);
+      },
+      ExportAllDeclaration(node) {
+        check(node.source);
+      },
+      ImportExpression(node) {
+        if (node.source && node.source.type === "Literal") {
+          check(node.source);
+        }
+      },
+    };
+  },
+};

package/src/common/local-plugins/index.mjs

@@ -0,0 +1,10 @@
+import { actionHandleServiceRule } from "./action-handle-service.mjs";
+import { importPathStyleRule } from "./import-path-style.mjs";
+
+/** @description Shared local plugin object to avoid ESLint "Cannot redefine plugin" errors */
+export const localPlugin = {
+  rules: {
+    "action-handle-service": actionHandleServiceRule,
+    "import-path-style": importPathStyleRule,
+  },
+};

package/src/common/naming.mjs

@@ -1,6 +1,6 @@
 import { featuresGlob } from "./constants.mjs";
+import { localPlugin } from "./local-plugins/index.mjs";
 import { checkFile } from "./plugins.mjs";
-import { actionHandleServiceRule } from "./local-plugins/action-handle-service.mjs";
 
 /** @description Scope naming rules to the given feature root */
 export function createNamingConfigs(featureRoot, prefixLibMapping) {
@@ -181,11 +181,7 @@ export function createNamingConfigs(featureRoot, prefixLibMapping) {
     {
       name: "naming/actions-handle-service",
       files: featuresGlob(featureRoot, "**/actions/*.ts"),
-      plugins: {
-        local: {
-          rules: { "action-handle-service": actionHandleServiceRule },
-        },
-      },
+      plugins: { local: localPlugin },
       rules: {
         "local/action-handle-service": "error",
       },

package/src/deno/index.mjs

@@ -1,5 +1,7 @@
 import { createCommonConfigs } from "../common/index.mjs";
 
 export const eslintConfig = [
-  ...createCommonConfigs("supabase/functions/features"),
+  ...createCommonConfigs("supabase/functions/features", {
+    banAliasImports: true,
+  }),
 ];

package/src/next/imports.mjs

@@ -0,0 +1,16 @@
+import { localPlugin } from "../common/local-plugins/index.mjs";
+
+/** @description Next.js: enforce relative paths within same feature, @/ for cross-feature */
+export const importPathStyleConfigs = [
+  {
+    name: "imports/path-style",
+    files: ["src/features/**/*.ts"],
+    plugins: { local: localPlugin },
+    rules: {
+      "local/import-path-style": [
+        "error",
+        { featureRoot: "src/features" },
+      ],
+    },
+  },
+];

package/src/next/index.mjs

@@ -2,6 +2,7 @@ import { createCommonConfigs } from "../common/index.mjs";
 import { libBoundaryConfigs } from "../common/imports.mjs";
 
 import { directivesConfigs } from "./directives.mjs";
+import { importPathStyleConfigs } from "./imports.mjs";
 import { namingConfigs } from "./naming.mjs";
 
 export const eslintConfig = [
@@ -9,4 +10,5 @@ export const eslintConfig = [
   ...libBoundaryConfigs,
   ...namingConfigs,
   ...directivesConfigs,
+  ...importPathStyleConfigs,
 ];

package/src/node/index.mjs

@@ -1,3 +1,5 @@
 import { createCommonConfigs } from "../common/index.mjs";
 
-export const eslintConfig = [...createCommonConfigs("scripts/features")];
+export const eslintConfig = [
+  ...createCommonConfigs("scripts/features", { banAliasImports: true }),
+];