@yarkivaev/source-to-sink 1.3.9 → 1.3.10

package/README.md

@@ -47,3 +47,5 @@ integer to tune throughput. A zero (unlimited) window is rejected because a
 backlog can otherwise exhaust the consumer's heap. With `manualAck: true`, the
 collector remains responsible for settling frames. If it flushes only by count,
 its batch must not exceed the prefetch window; a timed flush also avoids stalls.
+
+Manual collectors may call `settle.nack(false)` to dead-letter invalid messages. Configure a durable dead-letter queue and broker policy before enabling this; without a route RabbitMQ discards rejected messages. `settle.nack()` retains retry behaviour.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yarkivaev/source-to-sink",
-  "version": "1.3.9",
+  "version": "1.3.10",
   "description": "Generic library for building data streaming pipelines",
   "repository": {
     "type": "git",

package/src/stompSource.js

@@ -62,8 +62,8 @@ function settleOf(channel, message) {
     ack() {
       channel.ack(message);
     },
-    nack() {
-      channel.nack(message);
+    nack(requeue = true) {
+      channel.nack(message, { requeue: String(requeue) });
     }
   };
 }

package/test/test_stompSource.js

@@ -114,3 +114,33 @@ describe('STOMP delivery window', function() {
     });
   }
 });
+
+
+describe('STOMP dead lettering', function() {
+  it('sends requeue=false for a rejected poison message', async function() {
+    const original = stompit.Channel;
+    let receive;
+    let headers;
+    stompit.Channel = function Channel() {
+      return {
+        subscribe(value, callback) { receive = callback; },
+        nack(message, value) { headers = value; },
+        close() {}
+      };
+    };
+    try {
+      const source = stompSource('stomp://localhost:61613', '/queue/test', {
+        accept({ settle }) { settle.nack(false); }
+      }, { manualAck: true });
+      source.start();
+      receive(null, { readString(encoding, callback) { callback(null, '{}'); } });
+      await new Promise((resolve) => { setImmediate(resolve); });
+      source.stop();
+      assert.deepStrictEqual(headers, { requeue: 'false' });
+    } finally {
+      // Test restores its synchronous module stub after delivery completes.
+      // eslint-disable-next-line require-atomic-updates
+      stompit.Channel = original;
+    }
+  });
+});