@yaoyuanchao/dingtalk 1.7.3 → 1.7.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yaoyuanchao/dingtalk",
-  "version": "1.7.3",
+  "version": "1.7.5",
   "type": "module",
   "description": "DingTalk channel plugin for ClawdBot/OpenClaw with Stream Mode support",
   "license": "MIT",

package/src/monitor.ts

@@ -308,8 +308,11 @@ export async function startDingTalkMonitor(ctx: DingTalkMonitorContext): Promise
     touchActivity(); // Track message activity for heartbeat
 
     // Deduplication: skip messages already processed (e.g. re-delivered after reconnect)
+    // Check both protocol-level messageId AND business-level msgId, because
+    // DingTalk re-delivers with a NEW protocol messageId after reconnect but
+    // the same business msgId.
     if (isDuplicateMessage(protocolMsgId)) {
-      log?.info?.("[dingtalk] Duplicate message skipped: " + protocolMsgId);
+      log?.info?.("[dingtalk] Duplicate message skipped (protocol): " + protocolMsgId);
       return { status: "SUCCESS", message: "OK" };
     }
     markMessageProcessed(protocolMsgId);
@@ -317,6 +320,15 @@ export async function startDingTalkMonitor(ctx: DingTalkMonitorContext): Promise
     try {
       const data: DingTalkRobotMessage = typeof downstream.data === "string"
         ? JSON.parse(downstream.data) : downstream.data;
+
+      // Business-level dedup: same msgId re-delivered with different protocol ID
+      const bizMsgId = data.msgId;
+      if (bizMsgId && isDuplicateMessage('biz:' + bizMsgId)) {
+        log?.info?.("[dingtalk] Duplicate message skipped (bizMsgId): " + bizMsgId);
+        return { status: "SUCCESS", message: "OK" };
+      }
+      if (bizMsgId) markMessageProcessed('biz:' + bizMsgId);
+
       setStatus?.({ lastInboundAt: Date.now() });
       await processInboundMessage(data, ctx);
     } catch (err) {
@@ -1656,7 +1668,6 @@ async function dispatchWithFullPipeline(params: {
           log, setStatus, onFirstReply } = params;
   
   let firstReplyFired = false;
-  let typingSafetyTimeout: ReturnType<typeof setTimeout> | null = null;
 
   // 1. Resolve agent route via own bindings matching (like official plugin).
   // OpenClaw's resolveAgentRoute doesn't handle accountId correctly for multi-account.
@@ -1752,7 +1763,6 @@ async function dispatchWithFullPipeline(params: {
       // Recall typing indicator on first delivery
       if (!firstReplyFired && onFirstReply) {
         firstReplyFired = true;
-        if (typingSafetyTimeout) { clearTimeout(typingSafetyTimeout); typingSafetyTimeout = null; }
         await onFirstReply().catch((err) => {
           log?.info?.("[dingtalk] onFirstReply error: " + err);
         });
@@ -1780,21 +1790,11 @@ async function dispatchWithFullPipeline(params: {
     await rt.channel.reply.dispatchReplyFromConfig({ ctx, cfg, dispatcher, replyOptions });
   } finally {
     markDispatchIdle();
-    // Don't recall typing immediately — dispatchReplyFromConfig resolves when
-    // dispatch is *initiated*, not when the agent finishes. The agent may still
-    // be doing tool calls for minutes before producing the first text reply.
-    // The deliver callback above handles the normal recall on first delivery.
-    // Set a safety timeout to recall if no delivery ever arrives (edge case).
-    if (!firstReplyFired && onFirstReply) {
-      const TYPING_SAFETY_TIMEOUT_MS = 3 * 60 * 1000; // 3 minutes
-      typingSafetyTimeout = setTimeout(async () => {
-        if (!firstReplyFired && onFirstReply) {
-          firstReplyFired = true;
-          log?.info?.('[dingtalk] Typing safety timeout — recalling after no delivery');
-          await onFirstReply().catch(() => {});
-        }
-      }, TYPING_SAFETY_TIMEOUT_MS);
-    }
+    // Don't recall typing here — dispatchReplyFromConfig resolves when dispatch
+    // is *initiated*, not when the agent finishes. The agent may still be doing
+    // tool calls for many minutes before producing text. The deliver callback
+    // above handles recall on first delivery. If the agent crashes without
+    // replying, the emoji reaction simply stays — acceptable tradeoff.
   }
 
   // 10. Record activity