@yannelli/paseo-linear-plugin 0.4.0 → 1.0.1

package/README.md

@@ -31,9 +31,11 @@ The images are illustrations with sample data. They come from `docs/graphics`; s
 
 ```sh
 paseo plugin add npm:@yannelli/paseo-linear-plugin
-paseo plugin ls linear
+paseo plugin ls paseo-linear-plugin
 ```
 
+Version 0.4.0 and earlier used the id `linear`. To upgrade from those versions, run `paseo plugin remove linear` first, then add the plugin again. Your saved keys stay in place.
+
 To pin a version, add it to the source, for example `npm:@yannelli/paseo-linear-plugin@0.1.0`. To install a Git tag instead, run `paseo plugin add github:yannelli/paseo-linear-plugin --ref v0.1.0`. Plugins run trusted code with the daemon user's access.
 
 ## Connect Linear
@@ -101,16 +103,17 @@ Select **Start agent** or **Start review** in the issue view. The agent setup pa
 1. Edit the prompt in the prompt box if you want. The prompt follows the template and options until you edit it. Select **Reset prompt** to go back to the template.
 2. Use the controls under the prompt box, as in the Paseo composer. They set the prompt template (Implement or Review), the model, the thinking level, and the mode. The thinking level shows when the model has levels, and the mode shows when the agent has modes.
    - The model picker lists the providers first. Select a provider to see its models, or search to find models from all providers.
-   - Choosing a model from another provider also changes the agent, and resets the thinking level and mode to that agent's defaults.
+   - Choosing a model from another provider also changes the agent. The thinking level and mode change to the choices you last used with that agent, or to its defaults.
+   - The controls start from your last choices: the model, thinking level, and mode of your last launch from the plugin, then the choices Paseo remembers for new agents. A default model in the settings takes priority for the model. On the mobile app, the plugin cannot read Paseo's choices, so it remembers only launches from the current session.
 3. Choose the **Project**. The default is the project of the current workspace. Without a workspace, it is the last project you used for the team, then a project mapped to the team.
 4. Choose where the agent runs in **Run in**:
    - **New worktree** on the issue branch.
    - **Check out PR #N** for a review, when the issue links a GitHub pull request.
-   - **Check out issue branch** for a review.
+   - **Check out issue branch** for a review. If nobody pushed the branch yet, the plugin starts a new worktree on it.
    - **Existing agent workspace** or **Implementation workspace**, when an agent already works on the issue.
    - **This workspace**, or **Project folder** when you are not in a workspace of that project.
 
-   The worktree and checkout options show only for a Git project.
+   The worktree and checkout options show only for a Git project. When agents run in worktrees (the default), a review uses the pull request, then the implementation workspace, then the issue branch.
 5. Set the options: **Include comments in the prompt**, **Move the issue to In Progress**, and **Assign the issue to me**. The last two show only for Implement, and only when they would change the issue.
 6. Select **Start agent** or **Start review**.
 
@@ -174,7 +177,7 @@ npm run check
 paseo plugin add "$PWD"
 ```
 
-After you edit the source, run `paseo plugin reload linear`. `npm run check` runs the typecheck and the tests. The tests cover the Linear client, the key file, the cache, the handlers, sub-issue nesting, the Markdown parser and task list toggle, the description autosave, the agent options, and the release scripts. They use a local GraphQL server and do not call Linear.
+After you edit the source, run `paseo plugin reload paseo-linear-plugin`. `npm run check` runs the typecheck and the tests. The tests cover the Linear client, the key file, the cache, the handlers, sub-issue nesting, the Markdown parser and task list toggle, the description autosave, the agent options, and the release scripts. They use a local GraphQL server and do not call Linear.
 
 ## Graphics
 

package/client/agent-options.ts

@@ -1,5 +1,7 @@
 // Turns the daemon's provider snapshot into Agent, Model, Effort, and Mode choices.
 
+import type { AgentPreferences } from "./agent-preferences";
+
 export interface Choice {
   id: string;
   label: string;
@@ -112,20 +114,26 @@ export interface AgentPicks {
   mode: string | null;
 }
 
-/** `configured` is the settings default in `provider/model` form. Empty uses the first agent. */
+/**
+ * `configured` is the settings default in `provider/model` form. Empty falls back to the
+ * remembered agent, then the first agent. Effort and mode come from `remembered` when unpicked.
+ */
 export function resolveAgent(
   agents: readonly AgentChoice[],
   picks: AgentPicks,
   configured: string,
+  remembered: AgentPreferences = {},
 ): AgentSelection | null {
   const [configuredAgent, ...rest] = configured.split("/");
   const configuredModel = rest.join("/");
   const agent =
     agents.find((entry) => entry.id === picks.agent) ??
     agents.find((entry) => entry.id === configuredAgent) ??
+    agents.find((entry) => entry.id === remembered.provider) ??
     agents[0];
   if (!agent) return null;
-  const preferredModel = agent.id === configuredAgent ? configuredModel : null;
+  const preference = remembered.providerPreferences?.[agent.id];
+  const preferredModel = agent.id === configuredAgent ? configuredModel : preference?.model;
   const model =
     agent.models.find((entry) => entry.id === picks.model) ??
     agent.models.find((entry) => entry.id === preferredModel) ??
@@ -134,10 +142,12 @@ export function resolveAgent(
   if (!model) return null;
   const effort =
     model.efforts.find((entry) => entry.id === picks.effort) ??
+    model.efforts.find((entry) => entry.id === preference?.thinkingByModel?.[model.id]) ??
     model.efforts.find((entry) => entry.id === model.defaultEffortId) ??
     null;
   const mode =
     agent.modes.find((entry) => entry.id === picks.mode) ??
+    agent.modes.find((entry) => entry.id === preference?.mode) ??
     agent.modes.find((entry) => entry.id === agent.defaultModeId) ??
     null;
   return { agent, model, effort, mode };

package/client/agent-preferences.ts

@@ -0,0 +1,112 @@
+import { z } from "zod";
+
+// Agent choices remembered between launches, in the shape Paseo's new-agent form stores them.
+
+const ProviderPreferenceSchema = z.object({
+  model: z.string().optional(),
+  mode: z.string().optional(),
+  thinkingByModel: z.record(z.string(), z.string()).optional(),
+});
+
+const AgentPreferencesSchema = z.object({
+  provider: z.string().optional(),
+  providerPreferences: z.record(z.string(), ProviderPreferenceSchema).optional(),
+});
+
+export type ProviderPreference = z.infer<typeof ProviderPreferenceSchema>;
+export type AgentPreferences = z.infer<typeof AgentPreferencesSchema>;
+
+/** What the user last picked for one launch. */
+export interface RememberedLaunch {
+  agent: string;
+  model: string;
+  effort: string | null;
+  mode: string | null;
+}
+
+interface KeyValueStorage {
+  getItem(key: string): string | null;
+  setItem(key: string, value: string): void;
+}
+
+/** Paseo's own new-agent preferences. Read only: the app owns this key. */
+export const PASEO_PREFERENCES_KEY = "@paseo:create-agent-preferences";
+export const PLUGIN_PREFERENCES_KEY = "@yannelli/paseo-linear-plugin:agent-preferences";
+
+let sessionPreferences: AgentPreferences = {};
+
+// Paseo keeps preferences in AsyncStorage, which is localStorage on web and desktop.
+// Native apps have no localStorage, so only this session's launches are remembered there.
+function storage(): KeyValueStorage | null {
+  try {
+    const candidate = (globalThis as { localStorage?: KeyValueStorage }).localStorage;
+    return candidate && typeof candidate.getItem === "function" ? candidate : null;
+  } catch {
+    return null;
+  }
+}
+
+export function parsePreferences(raw: string | null): AgentPreferences {
+  if (!raw) return {};
+  try {
+    const parsed = AgentPreferencesSchema.safeParse(JSON.parse(raw));
+    return parsed.success ? parsed.data : {};
+  } catch {
+    return {};
+  }
+}
+
+function readStored(key: string): AgentPreferences {
+  try {
+    return parsePreferences(storage()?.getItem(key) ?? null);
+  } catch {
+    return {};
+  }
+}
+
+/** Layers `top` over `base`, per provider and per model. */
+export function mergePreferences(base: AgentPreferences, top: AgentPreferences): AgentPreferences {
+  const providers: Record<string, ProviderPreference> = { ...base.providerPreferences };
+  for (const [id, preference] of Object.entries(top.providerPreferences ?? {})) {
+    const below = providers[id] ?? {};
+    providers[id] = {
+      ...below,
+      ...preference,
+      thinkingByModel: { ...below.thinkingByModel, ...preference.thinkingByModel },
+    };
+  }
+  return { provider: top.provider ?? base.provider, providerPreferences: providers };
+}
+
+export function withLaunch(
+  preferences: AgentPreferences,
+  launch: RememberedLaunch,
+): AgentPreferences {
+  return mergePreferences(preferences, {
+    provider: launch.agent,
+    providerPreferences: {
+      [launch.agent]: {
+        model: launch.model,
+        ...(launch.mode ? { mode: launch.mode } : {}),
+        ...(launch.effort ? { thinkingByModel: { [launch.model]: launch.effort } } : {}),
+      },
+    },
+  });
+}
+
+/** Paseo's remembered choices, overridden by launches made from this plugin. */
+export function loadAgentPreferences(): AgentPreferences {
+  const paseo = readStored(PASEO_PREFERENCES_KEY);
+  const plugin = mergePreferences(readStored(PLUGIN_PREFERENCES_KEY), sessionPreferences);
+  return mergePreferences(paseo, plugin);
+}
+
+export function rememberLaunch(launch: RememberedLaunch): void {
+  sessionPreferences = withLaunch(sessionPreferences, launch);
+  try {
+    const stored = withLaunch(readStored(PLUGIN_PREFERENCES_KEY), launch);
+    storage()?.setItem(PLUGIN_PREFERENCES_KEY, JSON.stringify(stored));
+  } catch {
+    // Storage full or blocked: this session still remembers the launch.
+  }
+}

package/client/launch-choices.ts

@@ -4,6 +4,7 @@ import { useCallback, useMemo, useState } from "react";
 import type { IssueDetail } from "../shared/linear";
 import type { AgentAction, LinearSettings } from "../shared/settings";
 import { type AgentPicks, resolveAgent } from "./agent-options";
+import { loadAgentPreferences } from "./agent-preferences";
 import {
   defaultProjectId,
   type Placement,
@@ -52,6 +53,7 @@ export function useLaunchChoices(input: {
   const [projectChoice, setProjectChoice] = useState<string | null>(null);
   const [placementChoice, setPlacementChoice] = useState<Placement | null>(null);
   const [picks, setPicks] = useState<AgentPicks>(NO_PICKS);
+  const [remembered] = useState(loadAgentPreferences);
   const projectId =
     projectChoice ??
     defaultProjectId({ target, teamId: issue.team.id, settings, projects: projects.data });
@@ -75,7 +77,7 @@ export function useLaunchChoices(input: {
     settings.launch.isolation,
   );
   const agents = providers.data ?? [];
-  const agent = resolveAgent(agents, picks, settings.launch.provider);
+  const agent = resolveAgent(agents, picks, settings.launch.provider, remembered);
   const chooseProject = useCallback((value: string) => {
     setProjectChoice(value);
     setPlacementChoice(null);

package/client/launch-plan.ts

@@ -10,6 +10,7 @@ import {
 import { AGENT_LABELS, agentTitle } from "../shared/prompts";
 import type { AgentAction, Isolation, LinearSettings } from "../shared/settings";
 import { type AgentSelection, agentConfig } from "./agent-options";
+import { rememberLaunch } from "./agent-preferences";
 import type { PaseoProjectOption } from "./queries";
 import { errorMessage } from "./ui";
 
@@ -91,10 +92,13 @@ export function placementOptions(input: {
   return options;
 }
 
-// Reviews look at existing work: the pull request, then the implementing agent's workspace.
+// Reviews look at existing work: the pull request, the implementing agent's workspace, then
+// the issue branch. Checking out a branch nobody pushed yet starts a new worktree instead.
 function preferredPlacement(action: AgentAction, isolation: Isolation): Placement[] {
-  if (action === "review") return ["pull-request", "agent-workspace", "workspace"];
-  return isolation === "worktree" ? ["worktree", "workspace"] : ["workspace"];
+  const review = action === "review";
+  const existing: Placement[] = review ? ["pull-request", "agent-workspace"] : [];
+  const fresh: Placement[] = isolation === "worktree" ? [review ? "branch" : "worktree"] : [];
+  return [...existing, ...fresh, "workspace"];
 }
 
 export function resolvePlacement(
@@ -139,21 +143,32 @@ export interface LaunchRequest {
   keyScope: string | null;
 }
 
-type Paseo = ReturnType<typeof usePaseo>;
+export type Paseo = ReturnType<typeof usePaseo>;
 
-async function openWorkspace(paseo: Paseo, request: LaunchRequest) {
+// Linear suggests a branch name for every issue, even when nobody has pushed that branch.
+// The plugin API passes only the daemon's message, so match its "Unknown branch" text.
+function isUnknownBranch(error: unknown): boolean {
+  return errorMessage(error).includes("Unknown branch");
+}
+
+function createIssueWorktree(paseo: Paseo, request: LaunchRequest, title: string) {
+  const { issue, project } = request;
+  return paseo.workspaces.create({
+    title,
+    source: {
+      kind: "worktree",
+      cwd: project.rootPath,
+      projectId: project.projectId,
+      action: "branch-off",
+      branchName: issue.branchName,
+    },
+  });
+}
+
+export async function openWorkspace(paseo: Paseo, request: LaunchRequest) {
   const { issue, project } = request;
   if (request.placement === "worktree") {
-    return paseo.workspaces.create({
-      title: `${issue.identifier} ${issue.title}`,
-      source: {
-        kind: "worktree",
-        cwd: project.rootPath,
-        projectId: project.projectId,
-        action: "branch-off",
-        branchName: issue.branchName,
-      },
-    });
+    return createIssueWorktree(paseo, request, `${issue.identifier} ${issue.title}`);
   }
   if (request.placement === "pull-request" && request.prNumber !== null) {
     return paseo.workspaces.create({
@@ -168,16 +183,22 @@ async function openWorkspace(paseo: Paseo, request: LaunchRequest) {
     });
   }
   if (request.placement === "branch") {
-    return paseo.workspaces.create({
-      title: `Review ${issue.identifier}`,
-      source: {
-        kind: "worktree",
-        cwd: project.rootPath,
-        projectId: project.projectId,
-        action: "checkout",
-        refName: issue.branchName,
-      },
-    });
+    const title = `Review ${issue.identifier}`;
+    try {
+      return await paseo.workspaces.create({
+        title,
+        source: {
+          kind: "worktree",
+          cwd: project.rootPath,
+          projectId: project.projectId,
+          action: "checkout",
+          refName: issue.branchName,
+        },
+      });
+    } catch (error) {
+      if (!isUnknownBranch(error)) throw error;
+      return createIssueWorktree(paseo, request, title);
+    }
   }
   if (request.placement === "agent-workspace" && request.agentWorkspace) {
     return paseo.workspaces.ref(request.agentWorkspace.id);
@@ -203,6 +224,12 @@ export function useLaunchAgent() {
         labels: { [AGENT_LABELS.issue]: issue.identifier, [AGENT_LABELS.action]: action },
       });
       lastProjectByTeam.set(issue.team.id, request.project.projectId);
+      rememberLaunch({
+        agent: request.agent.agent.id,
+        model: request.agent.model.id,
+        effort: request.agent.effort?.id ?? null,
+        mode: request.agent.mode?.id ?? null,
+      });
       let warning: string | null = null;
       if (Object.keys(request.patch).length > 0) {
         try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yannelli/paseo-linear-plugin",
-  "version": "0.4.0",
+  "version": "1.0.1",
   "description": "Browse and triage Linear issues in Paseo and start agents from them",
   "license": "Apache-2.0",
   "type": "module",

package/paseo-plugin.json

@@ -1,5 +1,5 @@
 {
-  "id": "linear",
+  "id": "paseo-linear-plugin",
   "description": "Browse, triage, and create Linear issues, and start agents that implement or review them",
   "requirements": {
     "paseo": ">=0.10.0"