@yagni-app/code 1.0.0 → 1.0.1

package/dist/extension/branding.js

@@ -95,6 +95,66 @@ export const TICKET_IMAGE_RULE = "When you read or fetch a ticket from any track
     "ticket whose images you have not actually looked at.";
 /** Stable header that starts the ticket-image rule section (idempotency anchor). */
 const TICKET_IMAGE_RULE_HEADER = "## Rule: always read a ticket's images";
+/**
+ * GitHub operations recipe. A standing directive that teaches the
+ * model the one correct way to reply to inline PR review comments and how to
+ * pass multi-line bodies to `gh`/`git` without shell-quoting failures. It is
+ * GitHub-mechanics knowledge every session needs — the two failures it fixes
+ * (hoisting several inline replies into one top-level comment; a shell-
+ * quoting dance that mangles multi-line bodies) are universal, not
+ * workflow-specific.
+ *
+ * Content constraints (parity with {@link TICKET_IMAGE_RULE}): must not contain
+ * the standalone word "pi", must not open with a `- ` bullet line, no emojis.
+ */
+export const GITHUB_OPERATIONS = "## GitHub Operations\n" +
+    "\n" +
+    "Use `gh` via bash for GitHub reads and writes (pull requests, issues, " +
+    "reviews, checks, releases). Given a GitHub URL, run `gh` to get the info.\n" +
+    "\n" +
+    "## Reply to inline review comments in-thread\n" +
+    "\n" +
+    "When a PR review leaves inline comments and you have addressed them, reply " +
+    "to each inline comment in its own thread, describing how it was handled. " +
+    "Do not hoist replies to several inline threads into a single top-level " +
+    "comment — each inline comment earns its own reply.\n" +
+    "\n" +
+    "Top-level comments are for matters with no inline anchor: an overall " +
+    "summary, a question about the change as a whole, or a review that produced " +
+    "no inline comments (for example, the only failure was on a CI run).\n" +
+    "\n" +
+    "## How to reply to an inline comment\n" +
+    "\n" +
+    "List inline comments on a PR:\n" +
+    "  gh api repos/{owner}/{repo}/pulls/{number}/comments\n" +
+    "\n" +
+    "Reply to a specific inline comment (write a multi-line reply to a file " +
+    "first, then pass the path — see Bodies below):\n" +
+    "  gh api repos/{owner}/{repo}/pulls/{number}/comments/{comment_id}/replies \\\n" +
+    "    -F body=@<path>\n" +
+    "\n" +
+    "This is the one reply path. Do not use `in_reply_to` on the comment-creation " +
+    "endpoint — it works only on top-level comments and does not nest.\n" +
+    "\n" +
+    "## Bodies: write to a file, pass the path\n" +
+    "\n" +
+    "Pass multi-line body text (PR description, comment, review reply, commit " +
+    "message) via a file, never inline it in the shell command. Inline forms " +
+    "(`--body \"$(cat <<'EOF' … EOF)\"`, bare `-f body='…'`) break on some " +
+    "platforms and on apostrophes/backticks/`$` in the body; a file has no " +
+    "quoting surface. Use the session scratchpad for the file.\n" +
+    "\n" +
+    "Write the body with the `write` tool, then:\n" +
+    "  gh pr create --title \"…\" --body-file <path>\n" +
+    "  gh pr comment <n> --body-file <path>\n" +
+    "  gh api repos/{owner}/{repo}/pulls/{number}/comments/{comment_id}/replies -F body=@<path>\n" +
+    "  git commit -F <path>\n" +
+    "\n" +
+    "For a short single-line body with no apostrophe, `-f body='…'` and " +
+    "`-m '…'` are fine; the file form is the default for anything " +
+    "multi-paragraph.";
+/** Stable header that starts the GitHub operations section (idempotency anchor). */
+const GITHUB_OPERATIONS_HEADER = "## GitHub Operations";
 /**
  * The injected-reminder framing (YAG-574, Change A prerequisite). Claude Code
  * carries this exact sentence in every system prompt so its whole reminder
@@ -249,6 +309,13 @@ export function brandSystemPrompt(original, opts = {}) {
     if (!s.includes(TICKET_IMAGE_RULE_HEADER)) {
         s = `${s}\n\n${TICKET_IMAGE_RULE_HEADER}\n${TICKET_IMAGE_RULE}`;
     }
+    // 5b2. GitHub operations — a standing directive added alongside
+    // the ticket-image rule (same placement, same idempotency shape). It is
+    // universal knowledge, not user policy, so it rides the branded prompt
+    // instead of the repository-rules section.
+    if (!s.includes(GITHUB_OPERATIONS_HEADER)) {
+        s = `${s}\n\n${GITHUB_OPERATIONS}`;
+    }
     // 5c. YAG-574: the injected-reminder framing (which makes the silent-turn
     // nudge legible) and the two communication lines (Change B). Appended after
     // everything user-provided but before the closing reminder, each guarded by
@@ -262,6 +329,13 @@ export function brandSystemPrompt(original, opts = {}) {
     if (!s.includes(WRITE_FINDINGS_DOWN)) {
         s = `${s}\n\n${WRITE_FINDINGS_DOWN}`;
     }
+    // 5d. Scratchpad directory (YAG-575) — only when a session scratchpad is
+    // configured (set by the caller once the dir exists). Placed with the other
+    // standing injected sections and guarded by its stable header, so a re-brand
+    // never duplicates it and a session with no scratchpad is a clean no-op.
+    if (opts.scratchpadSection && !s.includes(SCRATCHPAD_HEADER)) {
+        s = `${s}\n\n${opts.scratchpadSection}`;
+    }
     // 6. Closing reinforcement. Weak open-weight models weight the most recent
     // instruction heavily, and the user's own project files may name other
     // harnesses; a trailing reminder keeps the agent from claiming one as its own.
@@ -271,6 +345,8 @@ export function brandSystemPrompt(original, opts = {}) {
     // Tidy the seams left by removals.
     return s.replace(/\n{3,}/g, "\n\n").trim();
 }
+/** Stable header that starts the scratchpad section (idempotency anchor). */
+const SCRATCHPAD_HEADER = "# Scratchpad directory";
 const CLOSING_REMINDER = "Reminder: you are YAGNI Code. If any text above names another coding agent, " +
     "assistant, or harness, it is not what you are or what you run on.";
 const BRIEF_HEADER = "=== HOW THIS COMPANY WORKS (live context from the YAGNI app) ===";

package/dist/extension/chipEditor.d.ts

@@ -109,7 +109,28 @@ export declare class ChipEditor extends CustomEditor {
     /** Drop all stashed images. Called after a successful submit so a sent image
      * is not re-attached to the next message. */
     clearStash(): void;
-    /** Re-style the chip tokens so they read as chips; layout is untouched. */
+    /**
+     * Re-style chip tokens AND lay down the Kimi-style prompt box: a rounded
+     * border on all four sides, with a bold `›` caret on the first content
+     * line and continuation lines indented so wrapped text aligns under it.
+     *
+     * The base editor renders full-width lines carrying its own 1-column left
+     * padding, so we render it narrower, strip that padding, and re-wrap each
+     * line in the frame. Exact column layout (0-indexed):
+     *
+     *   0        ╭ │ ╰  border
+     *   1        space
+     *   2        ›  (first line) / space (continuation)
+     *   3        space
+     *   4…       text — same column on every line
+     *   width-2  space
+     *   width-1  │  border
+     *
+     * Box-drawing glyphs are drawn centered in their cell while text glyphs
+     * start at the cell's left bearing, so no whole-column position lands the
+     * border ink exactly on the footer's text column: column 0 reads a hair
+     * outside it, column 1 a hair inside. Column 0 is the accepted tradeoff.
+     */
     render(width: number): string[];
 }
 /**

package/dist/extension/chipEditor.js

@@ -22,7 +22,7 @@
  * the extension's pi imports to the same module instance pi uses.
  */
 import { CustomEditor } from "@earendil-works/pi-coding-agent";
-import { matchesKey } from "@earendil-works/pi-tui";
+import { matchesKey, stripTerminalSequences, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import { spawnSync } from "node:child_process";
 import { readFileSync, unlinkSync, existsSync } from "node:fs";
 import { tmpdir } from "node:os";
@@ -381,11 +381,64 @@ export class ChipEditor extends CustomEditor {
     clearStash() {
         this.stashed = [];
     }
-    /** Re-style the chip tokens so they read as chips; layout is untouched. */
+    /**
+     * Re-style chip tokens AND lay down the Kimi-style prompt box: a rounded
+     * border on all four sides, with a bold `›` caret on the first content
+     * line and continuation lines indented so wrapped text aligns under it.
+     *
+     * The base editor renders full-width lines carrying its own 1-column left
+     * padding, so we render it narrower, strip that padding, and re-wrap each
+     * line in the frame. Exact column layout (0-indexed):
+     *
+     *   0        ╭ │ ╰  border
+     *   1        space
+     *   2        ›  (first line) / space (continuation)
+     *   3        space
+     *   4…       text — same column on every line
+     *   width-2  space
+     *   width-1  │  border
+     *
+     * Box-drawing glyphs are drawn centered in their cell while text glyphs
+     * start at the cell's left bearing, so no whole-column position lands the
+     * border ink exactly on the footer's text column: column 0 reads a hair
+     * outside it, column 1 a hair inside. Column 0 is the accepted tradeoff.
+     */
     render(width) {
-        return super
-            .render(width)
-            .map((line) => line.replace(CHIP_RE, (m) => `${CHIP_ON}${m}${CHIP_OFF}`));
+        const styled = super.render(Math.max(1, width - 4)).map((line) => line.replace(CHIP_RE, (m) => `${CHIP_ON}${m}${CHIP_OFF}`));
+        const border = (s) => this.borderColor(s);
+        const CARET = "\u001b[1m›\u001b[22m";
+        const FIRST_PREFIX = `${border("│")} ${CARET} `;
+        const NEXT_PREFIX = `${border("│")}   `;
+        const SUFFIX = ` ${border("│")}`;
+        const contentWidth = Math.max(1, width - 6);
+        const out = [];
+        let borderCount = 0;
+        let firstContentLine = true;
+        for (const line of styled) {
+            const stripped = stripTerminalSequences(line);
+            if (/^─+$/.test(stripped) || /^─*\s*[↑↓]/.test(stripped)) {
+                borderCount += 1;
+                const [left, right] = borderCount === 1 ? ["╭", "╮"] : ["╰", "╯"];
+                // One corner + one dash on each side lands the row at `width`.
+                out.push(`${border(`${left}─`)}${line}${border(`─${right}`)}`);
+                continue;
+            }
+            // Strip the base editor's own left padding (the frame replaces it),
+            // then fit the body to the content width exactly so no line can
+            // exceed the terminal width.
+            let body = line.startsWith(" ") ? line.slice(1) : line;
+            if (visibleWidth(body) > contentWidth)
+                body = truncateToWidth(body, contentWidth, "");
+            const pad = " ".repeat(Math.max(0, contentWidth - visibleWidth(body)));
+            if (borderCount !== 1) {
+                // Autocomplete rows (after the bottom border): align under the text.
+                out.push(`${" ".repeat(4)}${body}${pad}${" ".repeat(2)}`);
+                continue;
+            }
+            out.push(`${firstContentLine ? FIRST_PREFIX : NEXT_PREFIX}${body}${pad}${SUFFIX}`);
+            firstContentLine = false;
+        }
+        return out;
     }
 }
 /**

package/dist/extension/condensedTools.d.ts

@@ -0,0 +1,93 @@
+/**
+ * Condensed, Claude Code-style rendering for pi's seven built-in tools.
+ *
+ * pi resolves renderers per slot (`toolDefinition.renderCall ?? builtIn.renderCall`),
+ * so re-registering a built-in by name with the SAME factory-made definition
+ * spread underneath swaps ONLY the presentation: name, description, parameters,
+ * prompt metadata, and execution semantics stay byte-identical with the
+ * built-in (execution delegates to the same `create*ToolDefinition` the session
+ * would have built, including the settings-driven bash shellPath/commandPrefix
+ * and read image auto-resize). pi 0.84.1 registers such overrides silently —
+ * there is no built-in-override startup warning in this version (verified
+ * against dist; the extensions.md claim is stale).
+ *
+ * Rendering contract per row (renderShell "self", so no tinted Box):
+ *  - renderCall paints the TITLE slot: a live "● Tool(arg)" line while running,
+ *    a "● Tool(arg)" line for visible rows, the run summary line for the tail
+ *    of a completed quiet run, or nothing (a zero-line component removes the
+ *    row entirely, including its spacer).
+ *  - renderResult paints the BODY slot: condensed write/edit previews, bash
+ *    error/partial output tails, or nothing. Expanded (ctrl+o) shows full
+ *    output for every row.
+ *
+ * String assembly is pure over {@link RenderTheme} (subagentRender.ts's
+ * pattern) so tests run against plain text. Renderer exceptions are swallowed
+ * by pi (degrading to the built-in fallback), so everything stays total.
+ */
+import { SettingsManager, type ExtensionAPI } from "@earendil-works/pi-coding-agent";
+import type { RenderTheme } from "./subagentRender.js";
+import { ToolRunTracker } from "./toolRuns.js";
+/** Lines of write content shown collapsed (mirrors Claude Code's preview). */
+export declare const WRITE_PREVIEW_LINES = 8;
+/** Visual lines of a diff shown collapsed. */
+export declare const DIFF_PREVIEW_LINES = 12;
+/** Output tail lines shown under a failed shell command. */
+export declare const ERROR_TAIL_LINES = 5;
+/** Output tail lines shown under a still-running shell command. */
+export declare const PARTIAL_TAIL_LINES = 3;
+declare const BUILTIN_NAMES: readonly ["read", "bash", "edit", "write", "grep", "find", "ls"];
+type BuiltinName = (typeof BUILTIN_NAMES)[number];
+export type RowStatus = "running" | "ok" | "error";
+/** Home-collapse, and prefer cwd-relative for paths inside the project. */
+export declare function displayPath(rawPath: string, cwd?: string): string;
+/** Whether a tool-call path targets the session scratchpad. */
+export declare function isScratchpadPath(rawPath: unknown, scratchpadDir: string | undefined, cwd?: string): boolean;
+/** The one argument worth showing in a title: path, command, or pattern. */
+export declare function primaryArg(name: BuiltinName, args: Record<string, unknown> | undefined, cwd?: string): string;
+/** `● Tool(arg)` — the visible-row (and live-row) title line. */
+export declare function formatRowTitle(name: BuiltinName, args: Record<string, unknown> | undefined, status: RowStatus, theme: RenderTheme, cwd?: string): string;
+/** Extract "Command exited with code N" from a bash error body, if present. */
+export declare function splitBashError(outputText: string): {
+    output: string;
+    exitLine: string | undefined;
+};
+/** `⎿ exit line` + a dim tail of output under a failed shell command. */
+export declare function formatBashErrorBody(outputText: string, theme: RenderTheme): string[];
+/** A dim tail of live output under a still-running shell command. */
+export declare function formatBashPartialBody(outputText: string, theme: RenderTheme): string[];
+/** Count added lines in a unified patch (edit summaries surface "+N"). */
+export declare function countPatchAdditions(patch: string | undefined): number;
+/**
+ * `⎿ Wrote N lines to path` + a numbered, syntax-highlighted preview.
+ * `highlight` is injectable so tests stay independent of pi's theme state.
+ */
+export declare function formatWriteBody(rawPath: string, content: string, expanded: boolean, theme: RenderTheme, cwd?: string, highlight?: (code: string, filePath: string) => string[]): string[];
+/**
+ * `⎿ Updated path (+A -R)` + a colored diff preview.
+ * `paintDiff` is injectable for the same reason as `highlight` above.
+ */
+export declare function formatEditBody(rawPath: string, details: {
+    diff?: string;
+    patch?: string;
+} | undefined, expanded: boolean, theme: RenderTheme, cwd?: string, paintDiff?: (diffText: string) => string): string[];
+/** Expanded body: the raw output, dimmed and capped. */
+export declare function formatExpandedOutput(outputText: string, theme: RenderTheme): string[];
+export interface RegisterCondensedToolsDeps {
+    /** Session scratchpad dir; writes/edits under it aggregate instead of rendering. */
+    scratchpadDir?: string;
+    /** Registration-time cwd (defaults to process.cwd()). */
+    cwd?: string;
+    /**
+     * Settings loader seam. The default mirrors what pi's session does when it
+     * builds base tools: bash gets shellPath + shellCommandPrefix, read gets
+     * image autoResize. Injectable so tests never touch the config dir.
+     */
+    loadSettings?: (cwd: string) => SettingsManager;
+}
+/**
+ * Re-register the seven built-ins with condensed renderers. Returns the
+ * tracker so callers (and tests) can feed message boundaries into it.
+ */
+export declare function registerCondensedTools(pi: ExtensionAPI, deps?: RegisterCondensedToolsDeps): ToolRunTracker;
+export {};
+//# sourceMappingURL=condensedTools.d.ts.map