@yagni-app/code-staging 1.2.13-staging.2176.1 → 1.2.13-staging.2190.1

package/dist/extension/pipeline/orchestrator.js

@@ -979,7 +979,11 @@ export async function runPipeline(ticket, deps) {
             reviewInput: written.finalOutput,
             usage: currentUsage(),
         }));
-        return done(open.length > 0 ? "round_cap" : "clean", open);
+        // The review loop's own rule (`shouldStop`): a cap is spent only on a
+        // finding that blocks. Advisory findings left when the fix turns ran out
+        // travel with the result for the pull request to name, never a stop
+        // (ENG-3028, YAG-1073).
+        return done(open.some(isBlockingFinding) ? "round_cap" : "clean", open);
     };
     const fixRound = !resume && deps.fixRound && !deps.fixRound.replan ? deps.fixRound : undefined;
     if (deps.fixRound?.replan)

package/dist/extension/pipeline/stages.d.ts

@@ -50,8 +50,14 @@ export declare function reviewStage(): PipelineStage;
 export declare function selectStages(_lane?: "full"): PipelineStage[];
 /** Interactive /go and mission builds: the diamond, three lenses, two rounds. */
 export declare const FULL_LANE: PipelineLane;
-/** The cloud lane's cap: one reviewer per round, so more rounds than the full lane. */
-export declare const CLOUD_MAX_REVIEW_ROUNDS = 4;
+/**
+ * The cloud lane's cap: one reviewer per round, so more rounds than the full
+ * lane. Five since YAG-1106 (promised to GPX on 2026-10-30): a cap never
+ * ends a build without its pull request, so the rounds past the fourth buy
+ * one more fix at a blocking finding before the pull request names what is
+ * still open. Never uncapped: each round is peak-tier output tokens.
+ */
+export declare const CLOUD_MAX_REVIEW_ROUNDS = 5;
 /** The tool every cloud plan stage calls for the decisions a person already made on this repository. */
 export declare const DECISIONS_READ_TOOL = "yagni_decisions_read_for_repository";
 /**

package/dist/extension/pipeline/stages.js

@@ -134,8 +134,14 @@ export const FULL_LANE = {
     stopAfterPlan: false,
     skillsEveryStage: false,
 };
-/** The cloud lane's cap: one reviewer per round, so more rounds than the full lane. */
-export const CLOUD_MAX_REVIEW_ROUNDS = 4;
+/**
+ * The cloud lane's cap: one reviewer per round, so more rounds than the full
+ * lane. Five since YAG-1106 (promised to GPX on 2026-10-30): a cap never
+ * ends a build without its pull request, so the rounds past the fourth buy
+ * one more fix at a blocking finding before the pull request names what is
+ * still open. Never uncapped: each round is peak-tier output tokens.
+ */
+export const CLOUD_MAX_REVIEW_ROUNDS = 5;
 /** The tool every cloud plan stage calls for the decisions a person already made on this repository. */
 export const DECISIONS_READ_TOOL = "yagni_decisions_read_for_repository";
 /**

package/dist/extension/pipeline/types.d.ts

@@ -551,13 +551,17 @@ export type PipelineProgress = {
  *  - Review rounds are peak-tier output tokens, the most expensive tokens a
  *    build buys, and the in-sandbox review is not the last reviewer: Proctor
  *    reviews the pull request and its fix rounds act on what it finds.
- *  - A third round never helped: every build that reached it ended with as many
- *    findings or more, and hit the cap anyway.
- *  - Round two runs only when round one found a blocker (`shouldStop`); what is
- *    still open after the cap is written into the pull request body under
- *    "Left for review" for Proctor, never a third round.
- * This is the `full` lane's cap. The cloud lane carries its own
- * (`PipelineLane.maxReviewRounds`): one reviewer per round, so four rounds.
+ *  - The cap is a bound on spend, never a verdict: a build that hits it still
+ *    opens its pull request, with what its own review left open named under
+ *    "Left for review" for Proctor and the person reviewing (YAG-1106). A cap
+ *    that ended a build with no pull request was the worst outcome a ticket
+ *    could have (ENG-3028).
+ *  - A round past the first runs only while a blocking finding is open
+ *    (`shouldStop`, and the fix-mode path alike); nits, needs-person and
+ *    advisory findings never spend a round and never stop a build.
+ * This is the `full` lane's cap, two rounds. The cloud lane carries its own
+ * (`PipelineLane.maxReviewRounds`): one reviewer per round, so five rounds
+ * (`CLOUD_MAX_REVIEW_ROUNDS`), never uncapped.
  */
 export declare const MAX_REVIEW_ROUNDS = 2;
 /**

package/dist/extension/pipeline/types.js

@@ -12,13 +12,17 @@
  *  - Review rounds are peak-tier output tokens, the most expensive tokens a
  *    build buys, and the in-sandbox review is not the last reviewer: Proctor
  *    reviews the pull request and its fix rounds act on what it finds.
- *  - A third round never helped: every build that reached it ended with as many
- *    findings or more, and hit the cap anyway.
- *  - Round two runs only when round one found a blocker (`shouldStop`); what is
- *    still open after the cap is written into the pull request body under
- *    "Left for review" for Proctor, never a third round.
- * This is the `full` lane's cap. The cloud lane carries its own
- * (`PipelineLane.maxReviewRounds`): one reviewer per round, so four rounds.
+ *  - The cap is a bound on spend, never a verdict: a build that hits it still
+ *    opens its pull request, with what its own review left open named under
+ *    "Left for review" for Proctor and the person reviewing (YAG-1106). A cap
+ *    that ended a build with no pull request was the worst outcome a ticket
+ *    could have (ENG-3028).
+ *  - A round past the first runs only while a blocking finding is open
+ *    (`shouldStop`, and the fix-mode path alike); nits, needs-person and
+ *    advisory findings never spend a round and never stop a build.
+ * This is the `full` lane's cap, two rounds. The cloud lane carries its own
+ * (`PipelineLane.maxReviewRounds`): one reviewer per round, so five rounds
+ * (`CLOUD_MAX_REVIEW_ROUNDS`), never uncapped.
  */
 export const MAX_REVIEW_ROUNDS = 2;
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yagni-app/code-staging",
-  "version": "1.2.13-staging.2176.1",
+  "version": "1.2.13-staging.2190.1",
   "description": "YAGNI Code: a terminal coding agent that already knows your company. One YAGNI login routes the model and grounds the agent in your team's context.",
   "license": "SEE LICENSE IN LICENSE.md",
   "author": "YAGNI, Inc. <jack@yagni.app> (https://yagni.app)",
@@ -58,5 +58,5 @@
     "turndown": "^7.2.4",
     "typebox": "^1.3.15"
   },
-  "yagniSourceSha": "aae5dcff2b6e88c794f1213893df2c24ec7be19e"
+  "yagniSourceSha": "515314459213f3e3acff697e5807da8ae3c5ce4a"
 }