@yagni-app/code-staging 1.2.13-staging.2173.1 → 1.2.13-staging.2190.1

package/dist/extension/pipeline/orchestrator.js

@@ -979,7 +979,11 @@ export async function runPipeline(ticket, deps) {
             reviewInput: written.finalOutput,
             usage: currentUsage(),
         }));
-        return done(open.length > 0 ? "round_cap" : "clean", open);
+        // The review loop's own rule (`shouldStop`): a cap is spent only on a
+        // finding that blocks. Advisory findings left when the fix turns ran out
+        // travel with the result for the pull request to name, never a stop
+        // (ENG-3028, YAG-1073).
+        return done(open.some(isBlockingFinding) ? "round_cap" : "clean", open);
     };
     const fixRound = !resume && deps.fixRound && !deps.fixRound.replan ? deps.fixRound : undefined;
     if (deps.fixRound?.replan)

package/dist/extension/pipeline/planOutput.d.ts

@@ -9,6 +9,15 @@
  * functions it runs on its own plan (`groundSessionPlan` in the backend's
  * builder/planQuestions.ts), so there is one normalizer, on the host.
  */
+/**
+ * A plan's size (YAG-1083's first half, shadow mode): the plan turn's own
+ * judgment of how big the build will be. The vocabulary is local because this
+ * package cannot depend on `@yagni/shared`; the runtime copy the host reads
+ * and stores lives in `packages/backend/src/observability/planSize.ts`. A size
+ * outside this set is dropped, never the plan.
+ */
+declare const PLAN_SIZES: readonly ["small", "standard", "complex"];
+type PlanSize = (typeof PLAN_SIZES)[number];
 /** `plan.json`, version 1, as the host reads it. */
 export interface PlanFile {
     version: 1;
@@ -55,6 +64,15 @@ export interface PlanFile {
         why: string;
         repository?: string;
     }>;
+    /**
+     * The plan turn's own judgment of how big the build will be
+     * (`small | standard | complex`), absent when the plan wrote none or one
+     * outside the vocabulary. Recorded only (YAG-1083's first half): nothing
+     * reads it back yet.
+     */
+    size?: PlanSize;
+    /** One line on why the size, clipped; absent when the plan wrote none. */
+    sizeReason?: string;
 }
 /** The plan's `wrongRepository`, or null when it names no `owner/name`. Confidence is high only when said. */
 export declare function readWrongRepository(value: unknown): PlanFile["wrongRepository"] | null;
@@ -87,4 +105,5 @@ export declare function buildPlanFile(planText: string, fallbackPaths: () => str
     file: PlanFile;
     found: boolean;
 };
+export {};
 //# sourceMappingURL=planOutput.d.ts.map

package/dist/extension/pipeline/planOutput.js

@@ -19,6 +19,14 @@ const MAX_TEXT = 500;
  *  same number as `MAX_SPLIT_CHILDREN` in @yagni/shared, kept here because this package
  *  does not depend on it. */
 const MAX_REPOSITORIES_NEEDED = 12;
+/**
+ * A plan's size (YAG-1083's first half, shadow mode): the plan turn's own
+ * judgment of how big the build will be. The vocabulary is local because this
+ * package cannot depend on `@yagni/shared`; the runtime copy the host reads
+ * and stores lives in `packages/backend/src/observability/planSize.ts`. A size
+ * outside this set is dropped, never the plan.
+ */
+const PLAN_SIZES = ["small", "standard", "complex"];
 /** The plan's `wrongRepository`, or null when it names no `owner/name`. Confidence is high only when said. */
 export function readWrongRepository(value) {
     if (!isRecord(value))
@@ -176,6 +184,8 @@ export function buildPlanFile(planText, fallbackPaths) {
     const paths = [...new Set(named.length > 0 ? named : fallbackPaths())].slice(0, MAX_LIST);
     const repositoriesNeeded = readRepositoriesNeeded(block?.repositoriesNeeded);
     const wrongRepository = readWrongRepository(block?.wrongRepository);
+    const size = PLAN_SIZES.find((known) => known === block?.size);
+    const sizeReason = size && typeof block?.sizeReason === "string" ? text(block.sizeReason, 200) : null;
     return {
         file: {
             version: 1,
@@ -187,6 +197,8 @@ export function buildPlanFile(planText, fallbackPaths) {
             ...(wrongRepository ? { wrongRepository } : {}),
             dependsOn: readDependsOn(block?.dependsOn),
             followUps: readFollowUps(block?.followUps),
+            ...(size ? { size } : {}),
+            ...(size && sizeReason ? { sizeReason } : {}),
         },
         found: block !== null,
     };

package/dist/extension/pipeline/stages.d.ts

@@ -50,8 +50,14 @@ export declare function reviewStage(): PipelineStage;
 export declare function selectStages(_lane?: "full"): PipelineStage[];
 /** Interactive /go and mission builds: the diamond, three lenses, two rounds. */
 export declare const FULL_LANE: PipelineLane;
-/** The cloud lane's cap: one reviewer per round, so more rounds than the full lane. */
-export declare const CLOUD_MAX_REVIEW_ROUNDS = 4;
+/**
+ * The cloud lane's cap: one reviewer per round, so more rounds than the full
+ * lane. Five since YAG-1106 (promised to GPX on 2026-10-30): a cap never
+ * ends a build without its pull request, so the rounds past the fourth buy
+ * one more fix at a blocking finding before the pull request names what is
+ * still open. Never uncapped: each round is peak-tier output tokens.
+ */
+export declare const CLOUD_MAX_REVIEW_ROUNDS = 5;
 /** The tool every cloud plan stage calls for the decisions a person already made on this repository. */
 export declare const DECISIONS_READ_TOOL = "yagni_decisions_read_for_repository";
 /**

package/dist/extension/pipeline/stages.js

@@ -134,8 +134,14 @@ export const FULL_LANE = {
     stopAfterPlan: false,
     skillsEveryStage: false,
 };
-/** The cloud lane's cap: one reviewer per round, so more rounds than the full lane. */
-export const CLOUD_MAX_REVIEW_ROUNDS = 4;
+/**
+ * The cloud lane's cap: one reviewer per round, so more rounds than the full
+ * lane. Five since YAG-1106 (promised to GPX on 2026-10-30): a cap never
+ * ends a build without its pull request, so the rounds past the fourth buy
+ * one more fix at a blocking finding before the pull request names what is
+ * still open. Never uncapped: each round is peak-tier output tokens.
+ */
+export const CLOUD_MAX_REVIEW_ROUNDS = 5;
 /** The tool every cloud plan stage calls for the decisions a person already made on this repository. */
 export const DECISIONS_READ_TOOL = "yagni_decisions_read_for_repository";
 /**
@@ -196,6 +202,8 @@ export const PLAN_JSON_CONTRACT = "End your answer with a fenced ```plan-json bl
     '  "repositoriesNeeded": [{"repository": "owner/name", "summary": "one line on what changes there"}],\n' +
     '  "wrongRepository": {"repository": "owner/name", "why": "one line", "confidence": "high|low"},\n' +
     '  "dependsOn": [{"repository": "owner/name", "what": "one line on what it needs there"}],\n' +
+    '  "size": "small|standard|complex",\n' +
+    '  "sizeReason": "one line on why the size",\n' +
     '  "followUps": [{"title": "...", "why": "one line", "repository": "owner/name"}]\n' +
     "}\n" +
     "```\n" +
@@ -208,6 +216,7 @@ export const PLAN_JSON_CONTRACT = "End your answer with a fenced ```plan-json bl
     "- At most two alternatives per question. A planChange only adds or rewords; it never removes.\n" +
     '- "checks" are the commands that prove the change, each run from "cwd" (repo-relative, "." for the root). ' +
     '"paths" are the package folders the plan touches.\n' +
+    '- "size" is your own judgment of how big the build will be (small: a one-file or config fix; standard: a change across one or two packages; complex: a cross-package or schema/contract change), with one line as "sizeReason". A plan that omits them, or writes a size outside the vocabulary, still produces a plan: the value is dropped, never the plan.\n' +
     '- "decisionsCited" lists only decisions the read returned that the plan relies on. Omit what you do not use.\n' +
     '- "repositoriesNeeded" is for a change that needs writes in more than one repository: list every ' +
     "repository the change writes to, in the order they must be built and merged, this one included, each " +

package/dist/extension/pipeline/types.d.ts

@@ -551,13 +551,17 @@ export type PipelineProgress = {
  *  - Review rounds are peak-tier output tokens, the most expensive tokens a
  *    build buys, and the in-sandbox review is not the last reviewer: Proctor
  *    reviews the pull request and its fix rounds act on what it finds.
- *  - A third round never helped: every build that reached it ended with as many
- *    findings or more, and hit the cap anyway.
- *  - Round two runs only when round one found a blocker (`shouldStop`); what is
- *    still open after the cap is written into the pull request body under
- *    "Left for review" for Proctor, never a third round.
- * This is the `full` lane's cap. The cloud lane carries its own
- * (`PipelineLane.maxReviewRounds`): one reviewer per round, so four rounds.
+ *  - The cap is a bound on spend, never a verdict: a build that hits it still
+ *    opens its pull request, with what its own review left open named under
+ *    "Left for review" for Proctor and the person reviewing (YAG-1106). A cap
+ *    that ended a build with no pull request was the worst outcome a ticket
+ *    could have (ENG-3028).
+ *  - A round past the first runs only while a blocking finding is open
+ *    (`shouldStop`, and the fix-mode path alike); nits, needs-person and
+ *    advisory findings never spend a round and never stop a build.
+ * This is the `full` lane's cap, two rounds. The cloud lane carries its own
+ * (`PipelineLane.maxReviewRounds`): one reviewer per round, so five rounds
+ * (`CLOUD_MAX_REVIEW_ROUNDS`), never uncapped.
  */
 export declare const MAX_REVIEW_ROUNDS = 2;
 /**

package/dist/extension/pipeline/types.js

@@ -12,13 +12,17 @@
  *  - Review rounds are peak-tier output tokens, the most expensive tokens a
  *    build buys, and the in-sandbox review is not the last reviewer: Proctor
  *    reviews the pull request and its fix rounds act on what it finds.
- *  - A third round never helped: every build that reached it ended with as many
- *    findings or more, and hit the cap anyway.
- *  - Round two runs only when round one found a blocker (`shouldStop`); what is
- *    still open after the cap is written into the pull request body under
- *    "Left for review" for Proctor, never a third round.
- * This is the `full` lane's cap. The cloud lane carries its own
- * (`PipelineLane.maxReviewRounds`): one reviewer per round, so four rounds.
+ *  - The cap is a bound on spend, never a verdict: a build that hits it still
+ *    opens its pull request, with what its own review left open named under
+ *    "Left for review" for Proctor and the person reviewing (YAG-1106). A cap
+ *    that ended a build with no pull request was the worst outcome a ticket
+ *    could have (ENG-3028).
+ *  - A round past the first runs only while a blocking finding is open
+ *    (`shouldStop`, and the fix-mode path alike); nits, needs-person and
+ *    advisory findings never spend a round and never stop a build.
+ * This is the `full` lane's cap, two rounds. The cloud lane carries its own
+ * (`PipelineLane.maxReviewRounds`): one reviewer per round, so five rounds
+ * (`CLOUD_MAX_REVIEW_ROUNDS`), never uncapped.
  */
 export const MAX_REVIEW_ROUNDS = 2;
 /**

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yagni-app/code-staging",
-  "version": "1.2.13-staging.2173.1",
+  "version": "1.2.13-staging.2190.1",
   "description": "YAGNI Code: a terminal coding agent that already knows your company. One YAGNI login routes the model and grounds the agent in your team's context.",
   "license": "SEE LICENSE IN LICENSE.md",
   "author": "YAGNI, Inc. <jack@yagni.app> (https://yagni.app)",
@@ -58,5 +58,5 @@
     "turndown": "^7.2.4",
     "typebox": "^1.3.15"
   },
-  "yagniSourceSha": "d6206a240e12cff30f8e2e5e8975adfe67e52e83"
+  "yagniSourceSha": "515314459213f3e3acff697e5807da8ae3c5ce4a"
 }