@yagni-app/code-staging 1.1.3-staging.1378.1 → 1.1.3-staging.1382.1

package/dist/extension/crashReport.d.ts

@@ -24,6 +24,7 @@
  * `backend/src/yagniCode/crashReports.ts`. Spec:
  * docs/superpowers/specs/2026-08-08-crash-reporting-design.md
  */
+import { type SinkEvent } from "./errorSink.js";
 export declare const CRASH_REPORT_DISABLE_ENV = "YAGNI_DISABLE_CRASH_REPORTS";
 export declare const CRASH_REPORT_TIMEOUT_MS = 1500;
 export declare const MAX_CRASH_MESSAGE = 512;
@@ -97,13 +98,30 @@ export type SpawnLike = (command: string, args: string[], options: {
 export interface FatalCrashOpts extends CrashReporterOpts {
     /** Spawn seam for tests (defaults to node:child_process spawn). */
     spawnImpl?: SpawnLike;
+    /** Local error-trail seam for tests (defaults to errorSink's logEvent). */
+    trail?: (event: SinkEvent) => void;
 }
+/** Test seam: forget that a fatal report went out, and that a reporter is installed. */
+export declare function resetFatalReportedForTests(): void;
 /**
  * Deliver a crash report from a process that is about to die: build the
  * sanitized payload in-process (cheap, synchronous), then spawn a detached
  * one-shot sender that outlives the crash. Never throws.
  */
 export declare function reportFatalCrash(error: unknown, opts: FatalCrashOpts, context?: string): void;
+/**
+ * Report a pi process that ends with a non-zero code WITHOUT an uncaught
+ * exception. pi's own fatal paths print to stderr and `process.exit(1)`, which
+ * the exception monitor never sees, so until now those deaths were invisible
+ * unless the user pasted their terminal. An `exit` listener observes only: it
+ * cannot keep the process alive or change the code, and the detached sender
+ * is spawned synchronously, which is all an `exit` handler is allowed to do.
+ *
+ * Skipped on the desktop surface, where the shell files a richer report built
+ * from the driver's stderr tail (one incident, one report), and for the two
+ * "stopped on purpose" codes.
+ */
+export declare function installNonZeroExitReporter(opts: FatalCrashOpts, proc?: Pick<NodeJS.Process, "on">): void;
 /**
  * Observe (never alter) a fatal crash in pi's process. Uses
  * `uncaughtExceptionMonitor`, which fires before the process dies without

package/dist/extension/crashReport.js

@@ -170,7 +170,7 @@ export function makeCrashReporter(opts) {
             const token = opts.getToken();
             const sanitized = sanitizeCrashError(error, { env, repoRoot });
             const payload = {
-                client: isDesktopSurface() ? "desktop" : "cli",
+                client: isDesktopSurface(env) ? "desktop" : "cli",
                 clientVersion: env.YAGNI_CODE_VERSION?.trim() || "unknown",
                 platform: platformLabel(),
                 ...sanitized,
@@ -226,6 +226,19 @@ const DETACHED_SENDER_SRC = [
     "  signal: AbortSignal.timeout(4000),",
     "}).catch(() => {}).finally(done);",
 ].join("\n");
+/**
+ * Set once a fatal report has been handed to a sender, so the exit reporter
+ * never files a second report for the same death (an uncaught exception is
+ * followed by an exit-1, and both hooks would otherwise fire).
+ */
+let fatalReported = false;
+/** The exit reporter is per process, not per extension load (a reload re-runs the factory). */
+let exitReporterInstalled = false;
+/** Test seam: forget that a fatal report went out, and that a reporter is installed. */
+export function resetFatalReportedForTests() {
+    fatalReported = false;
+    exitReporterInstalled = false;
+}
 /**
  * Deliver a crash report from a process that is about to die: build the
  * sanitized payload in-process (cheap, synchronous), then spawn a detached
@@ -241,7 +254,7 @@ export function reportFatalCrash(error, opts, context) {
             return;
         const sanitized = sanitizeCrashError(error, { env });
         const payload = {
-            client: isDesktopSurface() ? "desktop" : "cli",
+            client: isDesktopSurface(env) ? "desktop" : "cli",
             clientVersion: env.YAGNI_CODE_VERSION?.trim() || "unknown",
             platform: platformLabel(),
             ...sanitized,
@@ -263,11 +276,62 @@ export function reportFatalCrash(error, opts, context) {
             },
         });
         child.unref();
+        fatalReported = true;
     }
     catch {
         // a crash reporter must never add its own crash
     }
 }
+/** Exit codes that mean "someone stopped it" (Ctrl+C, SIGTERM), not "it broke". */
+const STOPPED_EXIT_CODES = new Set([130, 143]);
+/**
+ * Report a pi process that ends with a non-zero code WITHOUT an uncaught
+ * exception. pi's own fatal paths print to stderr and `process.exit(1)`, which
+ * the exception monitor never sees, so until now those deaths were invisible
+ * unless the user pasted their terminal. An `exit` listener observes only: it
+ * cannot keep the process alive or change the code, and the detached sender
+ * is spawned synchronously, which is all an `exit` handler is allowed to do.
+ *
+ * Skipped on the desktop surface, where the shell files a richer report built
+ * from the driver's stderr tail (one incident, one report), and for the two
+ * "stopped on purpose" codes.
+ */
+export function installNonZeroExitReporter(opts, proc = process) {
+    // Once per process: pi re-runs the extension factory on every reload, and
+    // a listener per reload would both pile up and race each other on exit.
+    if (exitReporterInstalled)
+        return;
+    exitReporterInstalled = true;
+    proc.on("exit", (code) => {
+        try {
+            if (code === 0 || STOPPED_EXIT_CODES.has(code) || fatalReported)
+                return;
+            const env = opts.env ?? process.env;
+            // The same source the payload's client label reads, so the skip and the
+            // label can never disagree about which surface this is.
+            if (isDesktopSurface(env))
+                return;
+            const error = new Error(`pi exited with code ${code}`);
+            error.name = "ProcessExit";
+            // The listener's own frames say nothing about why pi exited.
+            error.stack = undefined;
+            reportFatalCrash(error, opts, `process-exit:${code}`);
+            // The local trail too, so a logged-out user (no token, nothing sent)
+            // still has a record /feedback can bind next session.
+            (opts.trail ?? logEvent)({
+                source: "tool",
+                level: "error",
+                event: "process_exit",
+                sessionId: env.YAGNI_SESSION_ID ?? undefined,
+                flush: "sync",
+                fields: { code },
+            });
+        }
+        catch {
+            // an exit hook must never throw
+        }
+    });
+}
 /**
  * Observe (never alter) a fatal crash in pi's process. Uses
  * `uncaughtExceptionMonitor`, which fires before the process dies without

package/dist/extension/index.d.ts

@@ -225,6 +225,6 @@ export { ToolRunTracker, summarizeRun, isQuiet, kindForTool } from "./toolRuns.j
 export type { RowKind, ToolRow, ToolRowPatch } from "./toolRuns.js";
 export { registerWorkingLine, composeWorkingMessage, NULL_WORKING_LINE, WORKING_INDICATOR_FRAMES, WORKING_VERBS, } from "./workingLine.js";
 export type { WorkingLineHandle, RegisterWorkingLineDeps } from "./workingLine.js";
-export { crashReportsDisabled, installUncaughtExceptionMonitor, makeCrashReporter, reportFatalCrash, sanitizeCrashError, sanitizeCrashText, } from "./crashReport.js";
+export { crashReportsDisabled, installNonZeroExitReporter, installUncaughtExceptionMonitor, makeCrashReporter, reportFatalCrash, sanitizeCrashError, sanitizeCrashText, } from "./crashReport.js";
 export type { CrashReporter, CrashReporterOpts, FatalCrashOpts, SanitizedCrash } from "./crashReport.js";
 //# sourceMappingURL=index.d.ts.map

package/dist/extension/index.js

@@ -53,7 +53,7 @@ import { loadGroundingEnabled } from "./grounding.js";
 import { attributionPromptSection, loadAttributionSettings, } from "./attribution.js";
 import { registerAmbientRecall } from "./recall.js";
 import { resilientFetch } from "./resilientFetch.js";
-import { installUncaughtExceptionMonitor, makeCrashReporter, runningUnderTest } from "./crashReport.js";
+import { installNonZeroExitReporter, installUncaughtExceptionMonitor, makeCrashReporter, runningUnderTest, } from "./crashReport.js";
 import { createToolOutcomeBatcher } from "./toolOutcomes.js";
 import { flushSpool as defaultFlushSpool } from "./spool.js";
 import { makeAuthedFetch, makeTokenProvider } from "./tokenProvider.js";
@@ -252,7 +252,12 @@ export async function registerYagni(pi, deps = {}) {
     // soft, opt-out via YAGNI_DISABLE_CRASH_REPORTS=1; off in eval mode like
     // every other external side effect.
     if (!evalMode) {
-        installUncaughtExceptionMonitor({ baseUrl, getToken: getTokenFn, env: deps.env });
+        const fatalOpts = { baseUrl, getToken: getTokenFn, env: deps.env };
+        installUncaughtExceptionMonitor(fatalOpts);
+        // A pi that exits non-zero without throwing (its own fatal paths) is a
+        // death the monitor never sees; report it too, so a terminal user's
+        // "it just quit" reaches Sentry without a pasted transcript.
+        installNonZeroExitReporter(fatalOpts);
     }
     // YAG-500 Fix E: non-fatal auth-event reporter for 401s on the model path.
     // Reuses the crash endpoint (/api/yagni-code/crash) with a distinct context
@@ -1870,5 +1875,5 @@ export { appendToSpool, loadSpool, flushSpool, sendOrSpool, spoolFile, MAX_SPOOL
 export { registerCondensedTools, displayPath, isScratchpadPath, primaryArg, formatRowTitle, formatWriteBody, formatEditBody, formatBashErrorBody, formatBashPartialBody, formatExpandedOutput, splitBashError, countPatchAdditions, WRITE_PREVIEW_LINES, DIFF_PREVIEW_LINES, } from "./condensedTools.js";
 export { ToolRunTracker, summarizeRun, isQuiet, kindForTool } from "./toolRuns.js";
 export { registerWorkingLine, composeWorkingMessage, NULL_WORKING_LINE, WORKING_INDICATOR_FRAMES, WORKING_VERBS, } from "./workingLine.js";
-export { crashReportsDisabled, installUncaughtExceptionMonitor, makeCrashReporter, reportFatalCrash, sanitizeCrashError, sanitizeCrashText, } from "./crashReport.js";
+export { crashReportsDisabled, installNonZeroExitReporter, installUncaughtExceptionMonitor, makeCrashReporter, reportFatalCrash, sanitizeCrashError, sanitizeCrashText, } from "./crashReport.js";
 //# sourceMappingURL=index.js.map

package/dist/extension/surface.d.ts

@@ -6,5 +6,5 @@
  * Desktop-facing widgets are structured single-line JSON records the app
  * parses, not themed terminal lines.
  */
-export declare function isDesktopSurface(): boolean;
+export declare function isDesktopSurface(env?: NodeJS.ProcessEnv): boolean;
 //# sourceMappingURL=surface.d.ts.map

package/dist/extension/surface.js

@@ -6,7 +6,7 @@
  * Desktop-facing widgets are structured single-line JSON records the app
  * parses, not themed terminal lines.
  */
-export function isDesktopSurface() {
-    return process.env.YAGNI_SURFACE === "desktop";
+export function isDesktopSurface(env = process.env) {
+    return env.YAGNI_SURFACE === "desktop";
 }
 //# sourceMappingURL=surface.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yagni-app/code-staging",
-  "version": "1.1.3-staging.1378.1",
+  "version": "1.1.3-staging.1382.1",
   "description": "YAGNI Code: a terminal coding agent that already knows your company. One YAGNI login routes the model and grounds the agent in your team's context.",
   "license": "SEE LICENSE IN LICENSE.md",
   "author": "YAGNI, Inc. <jack@yagni.app> (https://yagni.app)",
@@ -58,5 +58,5 @@
     "turndown": "^7.2.4",
     "typebox": "^1.3.15"
   },
-  "yagniSourceSha": "cc4bcf38093fc70fc51ed4b712777566307a1e72"
+  "yagniSourceSha": "d05478fe95b7c47498cd44b4cd37c20b711724b7"
 }