@yagni-app/code-staging 0.2.1-staging.1047.1 → 0.2.1-staging.1055.1

package/dist/extension/branding.d.ts

@@ -53,6 +53,15 @@ export interface BrandSystemPromptOptions {
     identity?: string;
     /** Live company brief to inject so the agent boots grounded (Phase C). */
     contextBrief?: string;
+    /**
+     * Repository rules section (`.claude/rules`, built by claudeRules.ts).
+     * Placed after the brief and BEFORE the closing reminder: rules are user
+     * content that may legitimately name other coding agents — exactly the text
+     * the reminder inoculates against — so the reminder must stay the most
+     * recent instruction. Appended after the scrub step, so rules content is
+     * never brand-rewritten (same exemption as <project_context>).
+     */
+    rulesSection?: string | null;
 }
 /**
  * Rebrand pi's assembled system prompt as YAGNI Code's, and optionally inject a
@@ -61,7 +70,9 @@ export interface BrandSystemPromptOptions {
  * Steps: (1) drop pi's self-referential documentation block, (2) replace the
  * identity sentence (with a loose fallback, else prepend), (3) scrub residual
  * brand tokens outside user content, (4) append the company brief + a proactive
- * ask_yagni directive. Idempotent: re-branding keeps a single identity.
+ * ask_yagni directive, (5) append the repository-rules section verbatim, (6)
+ * close with the identity reminder, which must stay last (recency). Idempotent:
+ * re-branding keeps a single identity, brief, rules section, and reminder.
  */
 export declare function brandSystemPrompt(original: string, opts?: BrandSystemPromptOptions): string;
 /** The minimal theme surface the masthead needs (a subset of pi's Theme). */

package/dist/extension/branding.js

@@ -103,7 +103,9 @@ export function brandingDisabled(env) {
  * Steps: (1) drop pi's self-referential documentation block, (2) replace the
  * identity sentence (with a loose fallback, else prepend), (3) scrub residual
  * brand tokens outside user content, (4) append the company brief + a proactive
- * ask_yagni directive. Idempotent: re-branding keeps a single identity.
+ * ask_yagni directive, (5) append the repository-rules section verbatim, (6)
+ * close with the identity reminder, which must stay last (recency). Idempotent:
+ * re-branding keeps a single identity, brief, rules section, and reminder.
  */
 export function brandSystemPrompt(original, opts = {}) {
     const identity = opts.identity ?? YAGNI_IDENTITY;
@@ -133,7 +135,18 @@ export function brandSystemPrompt(original, opts = {}) {
                 "your priors. When you need more detail, or it does not cover something " +
                 "organization- or codebase-specific, call ask_yagni instead of guessing.";
     }
-    // 5. Closing reinforcement. Weak open-weight models weight the most recent
+    // 5. Repository rules — after the scrub (user content stays verbatim), before
+    // the closing reminder (which must remain last; see rulesSection's doc).
+    // The idempotency guard keys on the section's first line (its stable header,
+    // "## Repository rules (.claude/rules)") rather than the full content, so a
+    // re-brand stays single-section even if the rules BODY differs between
+    // passes — same shape as the BRIEF_HEADER guard above.
+    const rules = opts.rulesSection ?? undefined;
+    const rulesHeader = rules?.split("\n", 1)[0];
+    if (rules && rulesHeader && !s.includes(rulesHeader)) {
+        s = `${s}\n\n${rules}`;
+    }
+    // 6. Closing reinforcement. Weak open-weight models weight the most recent
     // instruction heavily, and the user's own project files may name other
     // harnesses; a trailing reminder keeps the agent from claiming one as its own.
     if (!s.includes(CLOSING_REMINDER)) {

package/dist/extension/claudeRules.d.ts

@@ -49,6 +49,4 @@ export interface BuildSectionOptions {
 export declare function buildClaudeRulesSection(rules: ClaudeRule[], opts?: BuildSectionOptions): string | null;
 /** Env-driven entry: dirs from YAGNI_CLAUDE_RULES_DIRS, null when off/empty. */
 export declare function claudeRulesSection(env: NodeJS.ProcessEnv, opts?: CollectRulesOptions & BuildSectionOptions): string | null;
-/** Append `section` to a system prompt exactly once; no-op without a section. */
-export declare function appendClaudeRules(systemPrompt: string, section: string | null): string;
 //# sourceMappingURL=claudeRules.d.ts.map

package/dist/extension/claudeRules.js

@@ -169,12 +169,4 @@ export function claudeRulesSection(env, opts = {}) {
         return null;
     }
 }
-/** Append `section` to a system prompt exactly once; no-op without a section. */
-export function appendClaudeRules(systemPrompt, section) {
-    if (!section)
-        return systemPrompt;
-    if (systemPrompt.includes(CLAUDE_RULES_HEADER))
-        return systemPrompt;
-    return `${systemPrompt}\n\n${section}`;
-}
 //# sourceMappingURL=claudeRules.js.map

package/dist/extension/index.js

@@ -11,7 +11,7 @@ import { makeRecordEngineeringContextTool } from "./recordContextTool.js";
 import { makeRecordDecisionTool } from "./recordDecisionTool.js";
 import { makeSuggestNextWorkTool } from "./nextWorkTool.js";
 import { BRAND_NAME, brandSystemPrompt, brandingDisabled, buildMastheadString, YAGNI_IDENTITY_DRIVER } from "./branding.js";
-import { appendClaudeRules, claudeRulesSection } from "./claudeRules.js";
+import { claudeRulesSection } from "./claudeRules.js";
 import { registerCostCommand } from "./costHud.js";
 import { isDebug } from "./diagnostics.js";
 import { droppedSessionRuns, sessionRunIds } from "./sessionRuns.js";
@@ -409,7 +409,11 @@ export async function registerYagni(pi, deps = {}) {
     pi.on("before_agent_start", (event) => noBranding
         ? undefined
         : {
-            systemPrompt: appendClaudeRules(brandSystemPrompt(event.systemPrompt, { contextBrief, identity }), rulesSection),
+            systemPrompt: brandSystemPrompt(event.systemPrompt, {
+                contextBrief,
+                identity,
+                rulesSection,
+            }),
         });
     // Two finalized-message guards share this handler (their conditions are
     // mutually exclusive: YAG-460 takes error-stopped messages, YAG-466 takes

package/dist/launch.js

@@ -8,6 +8,7 @@
 import { randomUUID } from "node:crypto";
 import { agentDirEnvVar } from "./branding.js";
 import { PAD_X_ENV, resolvePadX } from "./padding.js";
+import { ENGINEERING_PRACTICE_SECTION, promptEnrichmentDisabled } from "./promptEnrichment.js";
 /**
  * How close to expiry the token can be before launch warns. A coding session
  * easily outlives a token, so warn early enough that re-logging in before a long
@@ -109,11 +110,20 @@ export function buildLaunch(creds, passthroughArgs, opts) {
     // cannot switch to a different tier via /model or Ctrl+P. The proxy still
     // resolves the tier to the concrete backing model.
     const userChoseModel = passthroughArgs.some(arg => arg === "--model" || arg.startsWith("--model="));
+    // Engineering-practice enrichment (YAG-496): appended to the DRIVER's system
+    // prompt only — /go stage children and subagents build their own pi argv, so
+    // this flag never reaches them. pi treats the value as literal text (it is
+    // never an existing file path) and slots it before <project_context>, so the
+    // user's repo instructions still outrank it. The flag is repeatable, so a
+    // user-passed --append-system-prompt coexists rather than conflicting; the
+    // opt-out is YAGNI_DISABLE_PROMPT_ENRICHMENT.
+    const enrichmentOff = promptEnrichmentDisabled(opts.baseEnv ?? process.env);
     const argv = [
         "-e",
         opts.extensionPath,
         ...(userChoseProvider ? [] : ["--provider", "yagni"]),
         ...(userChoseModel ? [] : ["--model", "advanced"]),
+        ...(enrichmentOff ? [] : ["--append-system-prompt", ENGINEERING_PRACTICE_SECTION]),
         ...(opts.extraAgentArgs ?? []),
         ...passthroughArgs,
     ];

package/dist/promptEnrichment.d.ts

@@ -0,0 +1,40 @@
+/**
+ * Engineering-practice prompt enrichment (YAG-496).
+ *
+ * pi's own base system prompt is deliberately thin (~15 lines: identity, tool
+ * one-liners, two generic guidelines). The extension adds identity, grounding,
+ * and product-tool guidance — but nothing about general engineering behavior:
+ * conventions, verification, commit discipline, communication style. This
+ * section carries that missing middle, curated from the prompt lineage shared
+ * by OpenCode/Claude Code/Kimi CLI and adapted to YAGNI Code's tools and
+ * autonomy posture.
+ *
+ * Delivery mechanism: pi's `--append-system-prompt <text>` flag, injected by
+ * the launcher (launch.ts). pi places appended text after its Guidelines and
+ * BEFORE the user's <project_context>, so repo instructions still outrank it.
+ * Because `/go` stage children and subagents build their own pi argv
+ * (pi-extension-yagni's pipeline/invocation.ts and pipeline/runner.ts), a
+ * launcher flag is structurally driver-only: child prompts are untouched by
+ * construction, not by an `if`. The piContract test pins both properties.
+ *
+ * Content constraints (enforced by test/promptEnrichment.test.ts):
+ * - must not contain the standalone word "pi" — the extension's brand scrub
+ *   rewrites it to "YAGNI Code" and would mangle the sentence;
+ * - must not OPEN with a "- " bullet line — pi's self-referential docs block
+ *   (which the extension strips with a regex that consumes consecutive
+ *   bullets) sits directly above this section in the assembled prompt;
+ * - no emojis (the section itself forbids them).
+ */
+/** Env switch that skips the enrichment entirely (sibling of
+ * YAGNI_DISABLE_BRANDING / YAGNI_DISABLE_CLAUDE_COMPAT, same semantics). */
+export declare const ENRICHMENT_DISABLE_ENV = "YAGNI_DISABLE_PROMPT_ENRICHMENT";
+/** `"1"`/anything truthy disables; unset, empty, and `"0"` keep it on. */
+export declare function promptEnrichmentDisabled(env: NodeJS.ProcessEnv): boolean;
+/**
+ * The section appended to the driver session's system prompt. Keep it curated,
+ * not encyclopedic: every line here spends attention budget on an open-weight
+ * model, and the load-bearing instructions (ask_yagni contract, delegation)
+ * live elsewhere in the prompt.
+ */
+export declare const ENGINEERING_PRACTICE_SECTION = "Engineering practice:\n\nBias to action: when the user asks you to implement, fix, or change something, use your tools to make the actual edits and run the actual commands \u2014 do not answer with a description of what you would do, or with code for the user to apply themselves. When the user asks HOW to approach something, answer the question first; do not jump into making changes they have not asked for.\n\nConventions:\n- Never assume a library is available, however well known. Before using one, confirm the project already depends on it (its package manifest, or imports in neighboring files).\n- When editing, read the surrounding code and its imports first; match the file's existing style, naming, and patterns rather than introducing your own.\n- When creating a new file or component, study an existing sibling first and follow its structure.\n- Never write code that logs or exposes secrets, keys, or credentials.\n\nVerification:\n- Consider what the code you are changing is supposed to do (from its name, location, and callers) before you change it.\n- Verify changes with the project's own tests when possible. Never assume a test framework or command \u2014 check the README, package scripts, or neighboring tests for the real one.\n- After completing a task, run the project's lint and typecheck commands if you know them; if you cannot find them, ask the user and suggest recording them in AGENTS.md for next time.\n\nVersion control:\n- No unsolicited commits: commit only when the user asked for one or the task at hand clearly calls for it.\n\nCommunication:\n- Answer directly, without preamble or postamble (\"Here is what I will do next...\", \"Based on the information provided...\"). Match the length of your answer to the question.\n- After making edits, report the outcome briefly; do not restate the diff or explain the code you just wrote unless asked.\n- Do not add code comments that narrate what you changed or why the change is correct; comments are for future readers of the code.\n- Reference code as file_path:line_number so the user can jump to it.\n- Before running a non-trivial command that changes state, say in one line what it does and why.\n- Never guess or fabricate URLs. Only use URLs the user provided or that appear in local files.\n- No emojis unless the user asks for them.";
+//# sourceMappingURL=promptEnrichment.d.ts.map

package/dist/promptEnrichment.js

@@ -0,0 +1,68 @@
+/**
+ * Engineering-practice prompt enrichment (YAG-496).
+ *
+ * pi's own base system prompt is deliberately thin (~15 lines: identity, tool
+ * one-liners, two generic guidelines). The extension adds identity, grounding,
+ * and product-tool guidance — but nothing about general engineering behavior:
+ * conventions, verification, commit discipline, communication style. This
+ * section carries that missing middle, curated from the prompt lineage shared
+ * by OpenCode/Claude Code/Kimi CLI and adapted to YAGNI Code's tools and
+ * autonomy posture.
+ *
+ * Delivery mechanism: pi's `--append-system-prompt <text>` flag, injected by
+ * the launcher (launch.ts). pi places appended text after its Guidelines and
+ * BEFORE the user's <project_context>, so repo instructions still outrank it.
+ * Because `/go` stage children and subagents build their own pi argv
+ * (pi-extension-yagni's pipeline/invocation.ts and pipeline/runner.ts), a
+ * launcher flag is structurally driver-only: child prompts are untouched by
+ * construction, not by an `if`. The piContract test pins both properties.
+ *
+ * Content constraints (enforced by test/promptEnrichment.test.ts):
+ * - must not contain the standalone word "pi" — the extension's brand scrub
+ *   rewrites it to "YAGNI Code" and would mangle the sentence;
+ * - must not OPEN with a "- " bullet line — pi's self-referential docs block
+ *   (which the extension strips with a regex that consumes consecutive
+ *   bullets) sits directly above this section in the assembled prompt;
+ * - no emojis (the section itself forbids them).
+ */
+/** Env switch that skips the enrichment entirely (sibling of
+ * YAGNI_DISABLE_BRANDING / YAGNI_DISABLE_CLAUDE_COMPAT, same semantics). */
+export const ENRICHMENT_DISABLE_ENV = "YAGNI_DISABLE_PROMPT_ENRICHMENT";
+/** `"1"`/anything truthy disables; unset, empty, and `"0"` keep it on. */
+export function promptEnrichmentDisabled(env) {
+    const value = env[ENRICHMENT_DISABLE_ENV];
+    return value !== undefined && value !== "" && value !== "0";
+}
+/**
+ * The section appended to the driver session's system prompt. Keep it curated,
+ * not encyclopedic: every line here spends attention budget on an open-weight
+ * model, and the load-bearing instructions (ask_yagni contract, delegation)
+ * live elsewhere in the prompt.
+ */
+export const ENGINEERING_PRACTICE_SECTION = `Engineering practice:
+
+Bias to action: when the user asks you to implement, fix, or change something, use your tools to make the actual edits and run the actual commands — do not answer with a description of what you would do, or with code for the user to apply themselves. When the user asks HOW to approach something, answer the question first; do not jump into making changes they have not asked for.
+
+Conventions:
+- Never assume a library is available, however well known. Before using one, confirm the project already depends on it (its package manifest, or imports in neighboring files).
+- When editing, read the surrounding code and its imports first; match the file's existing style, naming, and patterns rather than introducing your own.
+- When creating a new file or component, study an existing sibling first and follow its structure.
+- Never write code that logs or exposes secrets, keys, or credentials.
+
+Verification:
+- Consider what the code you are changing is supposed to do (from its name, location, and callers) before you change it.
+- Verify changes with the project's own tests when possible. Never assume a test framework or command — check the README, package scripts, or neighboring tests for the real one.
+- After completing a task, run the project's lint and typecheck commands if you know them; if you cannot find them, ask the user and suggest recording them in AGENTS.md for next time.
+
+Version control:
+- No unsolicited commits: commit only when the user asked for one or the task at hand clearly calls for it.
+
+Communication:
+- Answer directly, without preamble or postamble ("Here is what I will do next...", "Based on the information provided..."). Match the length of your answer to the question.
+- After making edits, report the outcome briefly; do not restate the diff or explain the code you just wrote unless asked.
+- Do not add code comments that narrate what you changed or why the change is correct; comments are for future readers of the code.
+- Reference code as file_path:line_number so the user can jump to it.
+- Before running a non-trivial command that changes state, say in one line what it does and why.
+- Never guess or fabricate URLs. Only use URLs the user provided or that appear in local files.
+- No emojis unless the user asks for them.`;
+//# sourceMappingURL=promptEnrichment.js.map

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yagni-app/code-staging",
-  "version": "0.2.1-staging.1047.1",
+  "version": "0.2.1-staging.1055.1",
   "description": "YAGNI Code: a terminal coding agent that already knows your company. One YAGNI login routes the model and grounds the agent in your team's context.",
   "license": "SEE LICENSE IN LICENSE.md",
   "author": "YAGNI, Inc. <jack@yagni.app> (https://yagni.app)",
@@ -38,5 +38,5 @@
     "@earendil-works/pi-tui": "0.84.1",
     "typebox": "^1.3.11"
   },
-  "yagniSourceSha": "7468515ac44df41d14f176bb4982a348d47da532"
+  "yagniSourceSha": "154a3d40a32bd82da1a6f152100522efafabb7d1"
 }