@yadurajfleetos/cli 0.13.1 → 0.14.0

package/dist/commands/fix.js

@@ -0,0 +1,131 @@
+import { readFile, writeFile } from 'node:fs/promises';
+import { parseDocument } from 'yaml';
+import { CliError, EXIT, request, requireFleet } from '../api.js';
+import { c } from '../render.js';
+import { glyph, rule } from '../ui.js';
+import { confirm } from '../prompt.js';
+import { awaitRunning } from '../progress.js';
+/** How a manifest writes a value the model returned as a scalar. */
+function shape(field, value) {
+    // `health: /healthz` is the obvious way to say it and the manifest wants
+    // `health: { path: /healthz }`. Same normalisation the server-side review
+    // does, for the same reason: a difference in spelling should not cost a fix.
+    if (field === 'health' && typeof value === 'string')
+        return { path: value };
+    return value;
+}
+/** Whether a service is running right now, as the fleet sees it. */
+async function statusOf(fleetId, name) {
+    const { body } = await request('GET', `/fleets/${fleetId}/services`);
+    return body.services.find((s) => s.name === name)?.current?.status ?? 'not running';
+}
+export const fixCommand = {
+    async run(args, flags) {
+        const service = args[0];
+        if (!service)
+            throw new CliError('usage: fleet fix <service> [--yes]', EXIT.usage);
+        const fleetId = await requireFleet(typeof flags.fleet === 'string' ? flags.fleet : undefined);
+        console.log(`\n${rule(`fix · ${service}`)}`);
+        console.log(`${glyph.pending} looking…`);
+        const { body: found } = await request('POST', `/fleets/${fleetId}/diagnose`, {
+            body: { question: `Why is the "${service}" service not working as it should?` },
+        });
+        if (found.status !== 'ok') {
+            throw new CliError(found.status === 'disabled' ? found.reason : `inconclusive — ${found.reason}`, EXIT.failure);
+        }
+        console.log(`\n${found.summary}\n`);
+        for (const f of found.findings) {
+            console.log(`  ${c.bold(f.claim)}`);
+            console.log(`    ${c.dim(f.evidence)}`);
+        }
+        const fix = found.fix;
+        if (!fix) {
+            // Most investigations do not end in one exact manifest change, and this
+            // is not a failure. Saying what was found and stopping is the answer.
+            console.log(`\n  ${c.dim('No single manifest change would fix this. What to do:')}`);
+            for (const n of found.next)
+                console.log(`  ${c.dim('›')} ${n}`);
+            console.log();
+            return;
+        }
+        if (!fix.applicable) {
+            // Reported in words, never performed. A person clicking through a prompt
+            // is not a guardrail; not offering the button is.
+            console.log(`\n${glyph.warn} ${c.bold('This one has to be done by hand')}`);
+            console.log(`  ${fix.service}.${fix.field} → ${JSON.stringify(fix.value)}`);
+            console.log(`  ${c.dim(fix.why)}`);
+            console.log(`  ${c.dim(fix.reason ?? '')}`);
+            console.log();
+            return;
+        }
+        console.log(`\n${glyph.info} ${c.bold('proposed')}  ${fix.service}.${fix.field} → ${JSON.stringify(fix.value)}`);
+        console.log(`  ${c.dim(fix.why)}\n`);
+        if (!flags.yes && !flags.y) {
+            const ok = await confirm(`Apply this to fleet.yaml and redeploy ${fix.service}?`);
+            if (!ok)
+                return console.log(`  ${c.dim('left alone')}\n`);
+        }
+        // Read before writing, and keep the original in memory: this is what makes
+        // the change reversible without a second file on disk.
+        const path = 'fleet.yaml';
+        const before = await readFile(path, 'utf8').catch(() => {
+            throw new CliError(`No fleet.yaml here. Run this from the project directory.`, EXIT.usage);
+        });
+        const doc = parseDocument(before);
+        if (!doc.hasIn(['services', fix.service])) {
+            throw new CliError(`fleet.yaml has no service named "${fix.service}"`, EXIT.failure);
+        }
+        // Edited as a document, so the comments `fleet init` wrote survive. A
+        // round trip through parse and re-serialise would take them out, and they
+        // are the only explanation a generated manifest carries.
+        if (fix.value === null)
+            doc.deleteIn(['services', fix.service, fix.field]);
+        else
+            doc.setIn(['services', fix.service, fix.field], shape(fix.field, fix.value));
+        const wasRunning = (await statusOf(fleetId, fix.service)) === 'running';
+        await writeFile(path, String(doc));
+        console.log(`${glyph.ok} fleet.yaml updated`);
+        const restore = async (why) => {
+            await writeFile(path, before);
+            console.log(`${glyph.warn} ${why} — fleet.yaml put back`);
+            console.log(`  ${c.dim(`Deploy the previous manifest with: fleet up ${fix.service}`)}\n`);
+        };
+        console.log(`${glyph.pending} deploying…`);
+        const { body: svc } = await request('GET', `/fleets/${fleetId}/services`);
+        const target = svc.services.find((s) => s.name === fix.service);
+        if (!target) {
+            await restore(`"${fix.service}" is not in this fleet`);
+            return;
+        }
+        // Verification, and the reason the whole thing is defensible at all: a
+        // change that did not help is undone rather than left behind.
+        //
+        // Followed to a conclusion rather than read once. The deploy request
+        // returns when a node has been chosen, and the container starting is the
+        // agent's job afterwards -- so reading the status here would find
+        // "deploying" and call that success, which is a verification step that
+        // verifies nothing.
+        //
+        // Judged against where it started. A service that was already down and is
+        // still down has not been made worse by this edit, and putting the
+        // manifest back would take away a change that may well be right while
+        // leaving the real problem in place.
+        try {
+            await request('POST', `/services/${target.id}/deploy`, { body: {} });
+            await awaitRunning(target, { timeoutMs: 240_000 });
+        }
+        catch (err) {
+            if (wasRunning) {
+                await restore(`${fix.service} was running before and did not come back: ${err.message}`);
+                return;
+            }
+            console.log(`${glyph.warn} still not running — ${err.message}`);
+            console.log(`  ${c.dim('The edit was kept: it was already down, so this did not make it worse.')}`);
+            console.log(`  ${c.dim(`undo it with: git checkout fleet.yaml && fleet up ${fix.service}`)}\n`);
+            return;
+        }
+        console.log(`${glyph.ok} ${fix.service} is running`);
+        console.log(`\n  ${c.dim('check it settled:')} fleet deployments ${fix.service}`);
+        console.log(`  ${c.dim('undo it:')} git checkout fleet.yaml && fleet up ${fix.service}\n`);
+    },
+};

package/dist/commands/index.js

@@ -6,6 +6,7 @@ import { configCommand, useCommand } from './config.js';
 import { doctorCommand } from './doctor.js';
 import { upCommand } from './up.js';
 import { tuneCommand } from './tune.js';
+import { fixCommand } from './fix.js';
 import { openCommand } from './open.js';
 import { downCommand } from './down.js';
 import { unpairCommand, agentCommand } from './unpair.js';
@@ -22,6 +23,7 @@ export const commands = {
     use: useCommand,
     doctor: doctorCommand,
     tune: tuneCommand,
+    fix: fixCommand,
     init: initCommand,
     diagnose: diagnoseCommand,
     import: importCommand,

package/dist/index.js

@@ -28,6 +28,7 @@ const GROUPS = [
             ['deploy <service>', 'Build, schedule, and roll out'],
             ['explain <service>', 'Read a failed deploy and say what to do about it'],
             ['diagnose "<question>"', 'Investigate why something is wrong, and cite what it looked at'],
+            ['fix <service>', 'Diagnose, propose one manifest change, deploy it, and undo it if that was worse'],
         ],
     ],
     [

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@yadurajfleetos/cli",
-  "version": "0.13.1",
+  "version": "0.14.0",
   "description": "Fleet OS command-line interface for deploying and orchestrating services on user-owned hardware",
   "type": "module",
   "license": "MIT",