@y14e/disclosure 1.3.5 → 1.3.7

package/README.md

@@ -10,14 +10,14 @@ npm i @y14e/disclosure
 
 ```ts
 // npm
-import Disclosure from '@y14e/disclosure@1.3.5';
+import Disclosure from '@y14e/disclosure@1.3.7';
 
 // CDNs
-import Disclosure from 'https://esm.sh/@y14e/disclosure@1.3.5';
+import Disclosure from 'https://esm.sh/@y14e/disclosure@1.3.7';
 // or
-import Disclosure from 'https://cdn.jsdelivr.net/npm/@y14e/disclosure@1.3.5/+esm';
+import Disclosure from 'https://cdn.jsdelivr.net/npm/@y14e/disclosure@1.3.7/+esm';
 // or
-import Disclosure from 'https://esm.unpkg.com/@y14e/disclosure@1.3.5';
+import Disclosure from 'https://esm.unpkg.com/@y14e/disclosure@1.3.7';
 ```
 
 ## Usage

package/dist/index.cjs

@@ -335,7 +335,7 @@ function createRovingTabIndex(container, options = {}) {
     console.warn("Invalid navigationOnly option. Fallback: false.");
     navigationOnly = false;
   }
-  if (typeof selector !== "undefined" && typeof selector !== "string") {
+  if (typeof selector !== "undefined" && (typeof selector !== "string" || !selector.trim())) {
     console.warn(
       "Invalid selector. Fallback: all focusable elements (undefined)."
     );
@@ -350,10 +350,10 @@ function createRovingTabIndex(container, options = {}) {
     wrap = false;
   }
   const settings = { navigationOnly, typeahead, wrap };
-  if (direction !== void 0) {
+  if (direction) {
     Object.assign(settings, { direction });
   }
-  if (selector !== void 0) {
+  if (selector) {
     Object.assign(settings, { selector });
   }
   const roving = new RovingTabIndex(container, settings);
@@ -655,8 +655,9 @@ var Disclosure = class _Disclosure {
     this.#animationController?.abort();
     this.#animationController = null;
     this.#detailsElements.forEach((details) => {
-      details.removeAttribute("data-disclosure-name");
-      details.removeAttribute("data-disclosure-open");
+      ["name", "open"].forEach((name) => {
+        details.removeAttribute(`data-disclosure-${name}`);
+      });
     });
     this.#detailsElements.length = 0;
     restoreAttributes(this.#summaryElements);
@@ -665,6 +666,11 @@ var Disclosure = class _Disclosure {
     this.#rootElement.removeAttribute("data-disclosure-initialized");
   }
   #initialize() {
+    saveAttributes(this.#summaryElements, [
+      "aria-disabled",
+      "style",
+      "tabindex"
+    ]);
     this.#eventController = new AbortController();
     const { signal } = this.#eventController;
     this.#detailsElements.forEach((details, i) => {
@@ -681,7 +687,6 @@ var Disclosure = class _Disclosure {
         return;
       }
       if (!isFocusable2(summary)) {
-        saveAttributes([summary], ["aria-disabled", "style", "tabindex"]);
         summary.setAttribute("aria-disabled", "true");
         summary.setAttribute("tabindex", "-1");
         summary.style.setProperty("pointer-events", "none");
@@ -781,9 +786,9 @@ var Disclosure = class _Disclosure {
     if (!details.hasAttribute("data-disclosure-open")) {
       details.open = false;
     }
-    const { style } = content;
-    style.removeProperty("block-size");
-    style.removeProperty("overflow");
+    ["block-size", "overflow"].forEach((name2) => {
+      content.style.removeProperty(name2);
+    });
   }
   async #waitAnimationsFinish() {
     const promises = [];
@@ -814,7 +819,7 @@ function waitAnimationFinish(animation) {
  * WAI-ARIA compliant disclosure pattern implementation in TypeScript.
  * Using the <details> and <summary> element.
  *
- * @version 1.3.5
+ * @version 1.3.7
  * @author Yusuke Kamiyamane
  * @license MIT
  * @copyright Copyright (c) Yusuke Kamiyamane
@@ -839,7 +844,7 @@ function waitAnimationFinish(animation) {
    * Lightweight roving tabindex utility with fully focus management.
    * Designed for accessible menus, tabs, toolbars, and composite widgets.
    *
-   * @version 2.0.3
+   * @version 2.0.4
    * @author Yusuke Kamiyamane
    * @license MIT
    * @copyright Copyright (c) Yusuke Kamiyamane

package/dist/index.d.cts

@@ -3,7 +3,7 @@
  * WAI-ARIA compliant disclosure pattern implementation in TypeScript.
  * Using the <details> and <summary> element.
  *
- * @version 1.3.5
+ * @version 1.3.7
  * @author Yusuke Kamiyamane
  * @license MIT
  * @copyright Copyright (c) Yusuke Kamiyamane

package/dist/index.d.ts

@@ -3,7 +3,7 @@
  * WAI-ARIA compliant disclosure pattern implementation in TypeScript.
  * Using the <details> and <summary> element.
  *
- * @version 1.3.5
+ * @version 1.3.7
  * @author Yusuke Kamiyamane
  * @license MIT
  * @copyright Copyright (c) Yusuke Kamiyamane

package/dist/index.js

@@ -333,7 +333,7 @@ function createRovingTabIndex(container, options = {}) {
     console.warn("Invalid navigationOnly option. Fallback: false.");
     navigationOnly = false;
   }
-  if (typeof selector !== "undefined" && typeof selector !== "string") {
+  if (typeof selector !== "undefined" && (typeof selector !== "string" || !selector.trim())) {
     console.warn(
       "Invalid selector. Fallback: all focusable elements (undefined)."
     );
@@ -348,10 +348,10 @@ function createRovingTabIndex(container, options = {}) {
     wrap = false;
   }
   const settings = { navigationOnly, typeahead, wrap };
-  if (direction !== void 0) {
+  if (direction) {
     Object.assign(settings, { direction });
   }
-  if (selector !== void 0) {
+  if (selector) {
     Object.assign(settings, { selector });
   }
   const roving = new RovingTabIndex(container, settings);
@@ -653,8 +653,9 @@ var Disclosure = class _Disclosure {
     this.#animationController?.abort();
     this.#animationController = null;
     this.#detailsElements.forEach((details) => {
-      details.removeAttribute("data-disclosure-name");
-      details.removeAttribute("data-disclosure-open");
+      ["name", "open"].forEach((name) => {
+        details.removeAttribute(`data-disclosure-${name}`);
+      });
     });
     this.#detailsElements.length = 0;
     restoreAttributes(this.#summaryElements);
@@ -663,6 +664,11 @@ var Disclosure = class _Disclosure {
     this.#rootElement.removeAttribute("data-disclosure-initialized");
   }
   #initialize() {
+    saveAttributes(this.#summaryElements, [
+      "aria-disabled",
+      "style",
+      "tabindex"
+    ]);
     this.#eventController = new AbortController();
     const { signal } = this.#eventController;
     this.#detailsElements.forEach((details, i) => {
@@ -679,7 +685,6 @@ var Disclosure = class _Disclosure {
         return;
       }
       if (!isFocusable2(summary)) {
-        saveAttributes([summary], ["aria-disabled", "style", "tabindex"]);
         summary.setAttribute("aria-disabled", "true");
         summary.setAttribute("tabindex", "-1");
         summary.style.setProperty("pointer-events", "none");
@@ -779,9 +784,9 @@ var Disclosure = class _Disclosure {
     if (!details.hasAttribute("data-disclosure-open")) {
       details.open = false;
     }
-    const { style } = content;
-    style.removeProperty("block-size");
-    style.removeProperty("overflow");
+    ["block-size", "overflow"].forEach((name2) => {
+      content.style.removeProperty(name2);
+    });
   }
   async #waitAnimationsFinish() {
     const promises = [];
@@ -812,7 +817,7 @@ function waitAnimationFinish(animation) {
  * WAI-ARIA compliant disclosure pattern implementation in TypeScript.
  * Using the <details> and <summary> element.
  *
- * @version 1.3.5
+ * @version 1.3.7
  * @author Yusuke Kamiyamane
  * @license MIT
  * @copyright Copyright (c) Yusuke Kamiyamane
@@ -837,7 +842,7 @@ function waitAnimationFinish(animation) {
    * Lightweight roving tabindex utility with fully focus management.
    * Designed for accessible menus, tabs, toolbars, and composite widgets.
    *
-   * @version 2.0.3
+   * @version 2.0.4
    * @author Yusuke Kamiyamane
    * @license MIT
    * @copyright Copyright (c) Yusuke Kamiyamane

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@y14e/disclosure",
-  "version": "1.3.5",
+  "version": "1.3.7",
   "description": "WAI-ARIA compliant disclosure pattern implementation in TypeScript",
   "type": "module",
   "main": "./dist/index.cjs",
@@ -44,7 +44,7 @@
   "homepage": "https://github.com/y14e/disclosure#readme",
   "devDependencies": {
     "@y14e/attributes-utils": "^1.1.0",
-    "@y14e/roving-tabindex": "^2.0.3",
+    "@y14e/roving-tabindex": "^2.0.4",
     "bun-types": "latest",
     "tsup": "^8.0.0",
     "typescript": "^5.6.0",