@y14e/disclosure-css 1.3.2 → 1.3.4

package/README.md

@@ -10,14 +10,14 @@ npm i @y14e/disclosure-css
 
 ```ts
 // npm
-import Disclosure from '@y14e/disclosure-css@1.3.2';
+import Disclosure from '@y14e/disclosure-css@1.3.4';
 
 // CDNs
-import Disclosure from 'https://esm.sh/@y14e/disclosure-css@1.3.2';
+import Disclosure from 'https://esm.sh/@y14e/disclosure-css@1.3.4';
 // or
-import Disclosure from 'https://cdn.jsdelivr.net/npm/@y14e/disclosure-css@1.3.2/+esm';
+import Disclosure from 'https://cdn.jsdelivr.net/npm/@y14e/disclosure-css@1.3.4/+esm';
 // or
-import Disclosure from 'https://esm.unpkg.com/@y14e/disclosure-css@1.3.2';
+import Disclosure from 'https://esm.unpkg.com/@y14e/disclosure-css@1.3.4';
 ```
 
 ## Usage

package/dist/index.cjs

@@ -335,7 +335,7 @@ function createRovingTabIndex(container, options = {}) {
     console.warn("Invalid navigationOnly option. Fallback: false.");
     navigationOnly = false;
   }
-  if (typeof selector !== "undefined" && typeof selector !== "string") {
+  if (typeof selector !== "undefined" && (typeof selector !== "string" || !selector.trim())) {
     console.warn(
       "Invalid selector. Fallback: all focusable elements (undefined)."
     );
@@ -350,10 +350,10 @@ function createRovingTabIndex(container, options = {}) {
     wrap = false;
   }
   const settings = { navigationOnly, typeahead, wrap };
-  if (direction !== void 0) {
+  if (direction) {
     Object.assign(settings, { direction });
   }
-  if (selector !== void 0) {
+  if (selector) {
     Object.assign(settings, { selector });
   }
   const roving = new RovingTabIndex(container, settings);
@@ -634,16 +634,15 @@ var Disclosure = class {
     this.#rootElement.removeAttribute("data-disclosure-initialized");
   }
   #initialize() {
-    this.#summaryElements.forEach((summary) => {
-      if (!summary) {
-        return;
-      }
-      if (!isFocusable2(summary)) {
-        saveAttributes([summary], ["aria-disabled", "style", "tabindex"]);
-        summary.setAttribute("aria-disabled", "true");
-        summary.setAttribute("tabindex", "-1");
-        summary.style.setProperty("pointer-events", "none");
-      }
+    saveAttributes(this.#summaryElements, [
+      "aria-disabled",
+      "style",
+      "tabindex"
+    ]);
+    this.#summaryElements.filter((summary) => !isFocusable2(summary)).forEach((summary) => {
+      summary.setAttribute("aria-disabled", "true");
+      summary.setAttribute("tabindex", "-1");
+      summary.style.setProperty("pointer-events", "none");
     });
     this.#cleanupRovingTabIndex = createRovingTabIndex(this.#rootElement, {
       direction: "vertical",
@@ -670,7 +669,7 @@ function isFocusable2(element) {
  * WAI-ARIA compliant disclosure pattern implementation in TypeScript.
  * Using the <details> and <summary> element.
  *
- * @version 1.3.2
+ * @version 1.3.4
  * @author Yusuke Kamiyamane
  * @license MIT
  * @copyright Copyright (c) Yusuke Kamiyamane
@@ -695,7 +694,7 @@ function isFocusable2(element) {
    * Lightweight roving tabindex utility with fully focus management.
    * Designed for accessible menus, tabs, toolbars, and composite widgets.
    *
-   * @version 2.0.3
+   * @version 2.0.4
    * @author Yusuke Kamiyamane
    * @license MIT
    * @copyright Copyright (c) Yusuke Kamiyamane

package/dist/index.d.cts

@@ -3,7 +3,7 @@
  * WAI-ARIA compliant disclosure pattern implementation in TypeScript.
  * Using the <details> and <summary> element.
  *
- * @version 1.3.2
+ * @version 1.3.4
  * @author Yusuke Kamiyamane
  * @license MIT
  * @copyright Copyright (c) Yusuke Kamiyamane

package/dist/index.d.ts

@@ -3,7 +3,7 @@
  * WAI-ARIA compliant disclosure pattern implementation in TypeScript.
  * Using the <details> and <summary> element.
  *
- * @version 1.3.2
+ * @version 1.3.4
  * @author Yusuke Kamiyamane
  * @license MIT
  * @copyright Copyright (c) Yusuke Kamiyamane

package/dist/index.js

@@ -333,7 +333,7 @@ function createRovingTabIndex(container, options = {}) {
     console.warn("Invalid navigationOnly option. Fallback: false.");
     navigationOnly = false;
   }
-  if (typeof selector !== "undefined" && typeof selector !== "string") {
+  if (typeof selector !== "undefined" && (typeof selector !== "string" || !selector.trim())) {
     console.warn(
       "Invalid selector. Fallback: all focusable elements (undefined)."
     );
@@ -348,10 +348,10 @@ function createRovingTabIndex(container, options = {}) {
     wrap = false;
   }
   const settings = { navigationOnly, typeahead, wrap };
-  if (direction !== void 0) {
+  if (direction) {
     Object.assign(settings, { direction });
   }
-  if (selector !== void 0) {
+  if (selector) {
     Object.assign(settings, { selector });
   }
   const roving = new RovingTabIndex(container, settings);
@@ -632,16 +632,15 @@ var Disclosure = class {
     this.#rootElement.removeAttribute("data-disclosure-initialized");
   }
   #initialize() {
-    this.#summaryElements.forEach((summary) => {
-      if (!summary) {
-        return;
-      }
-      if (!isFocusable2(summary)) {
-        saveAttributes([summary], ["aria-disabled", "style", "tabindex"]);
-        summary.setAttribute("aria-disabled", "true");
-        summary.setAttribute("tabindex", "-1");
-        summary.style.setProperty("pointer-events", "none");
-      }
+    saveAttributes(this.#summaryElements, [
+      "aria-disabled",
+      "style",
+      "tabindex"
+    ]);
+    this.#summaryElements.filter((summary) => !isFocusable2(summary)).forEach((summary) => {
+      summary.setAttribute("aria-disabled", "true");
+      summary.setAttribute("tabindex", "-1");
+      summary.style.setProperty("pointer-events", "none");
     });
     this.#cleanupRovingTabIndex = createRovingTabIndex(this.#rootElement, {
       direction: "vertical",
@@ -668,7 +667,7 @@ function isFocusable2(element) {
  * WAI-ARIA compliant disclosure pattern implementation in TypeScript.
  * Using the <details> and <summary> element.
  *
- * @version 1.3.2
+ * @version 1.3.4
  * @author Yusuke Kamiyamane
  * @license MIT
  * @copyright Copyright (c) Yusuke Kamiyamane
@@ -693,7 +692,7 @@ function isFocusable2(element) {
    * Lightweight roving tabindex utility with fully focus management.
    * Designed for accessible menus, tabs, toolbars, and composite widgets.
    *
-   * @version 2.0.3
+   * @version 2.0.4
    * @author Yusuke Kamiyamane
    * @license MIT
    * @copyright Copyright (c) Yusuke Kamiyamane

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@y14e/disclosure-css",
-  "version": "1.3.2",
+  "version": "1.3.4",
   "description": "WAI-ARIA compliant disclosure pattern implementation in TypeScript",
   "type": "module",
   "main": "./dist/index.cjs",
@@ -44,7 +44,7 @@
   "homepage": "https://github.com/y14e/disclosure-css#readme",
   "devDependencies": {
     "@y14e/attributes-utils": "^1.1.0",
-    "@y14e/roving-tabindex": "^2.0.3",
+    "@y14e/roving-tabindex": "^2.0.4",
     "bun-types": "latest",
     "tsup": "^8.0.0",
     "typescript": "^5.6.0"