@y14e/accordion 1.4.1 → 1.4.2

package/README.md

@@ -10,14 +10,14 @@ npm i @y14e/accordion
 
 ```ts
 // npm
-import Accordion from '@y14e/accordion@1.4.1';
+import Accordion from '@y14e/accordion@1.4.2';
 
 // CDNs
-import Accordion from 'https://esm.sh/@y14e/accordion@1.4.1';
+import Accordion from 'https://esm.sh/@y14e/accordion@1.4.2';
 // or
-import Accordion from 'https://cdn.jsdelivr.net/npm/@y14e/accordion@1.4.1/+esm';
+import Accordion from 'https://cdn.jsdelivr.net/npm/@y14e/accordion@1.4.2/+esm';
 // or
-import Accordion from 'https://esm.unpkg.com/@y14e/accordion@1.4.1';
+import Accordion from 'https://esm.unpkg.com/@y14e/accordion@1.4.2';
 ```
 
 ## Usage

package/dist/index.cjs

@@ -414,7 +414,7 @@ function createRovingTabIndex(container, options = {}) {
     console.warn("Invalid navigationOnly option. Fallback: false.");
     navigationOnly = false;
   }
-  if (typeof selector !== "undefined" && typeof selector !== "string") {
+  if (typeof selector !== "undefined" && (typeof selector !== "string" || !selector.trim())) {
     console.warn(
       "Invalid selector. Fallback: all focusable elements (undefined)."
     );
@@ -429,10 +429,10 @@ function createRovingTabIndex(container, options = {}) {
     wrap = false;
   }
   const settings = { navigationOnly, typeahead, wrap };
-  if (direction !== void 0) {
+  if (direction) {
     Object.assign(settings, { direction });
   }
-  if (selector !== void 0) {
+  if (selector) {
     Object.assign(settings, { selector });
   }
   const roving = new RovingTabIndex(container, settings);
@@ -729,8 +729,6 @@ var Accordion = class _Accordion {
     this.#rootElement.removeAttribute("data-accordion-initialized");
   }
   #initialize() {
-    this.#eventController = new AbortController();
-    const { signal } = this.#eventController;
     saveAttributes(this.#triggerElements, [
       "aria-controls",
       "aria-disabled",
@@ -738,13 +736,15 @@ var Accordion = class _Accordion {
       "style",
       "tabindex"
     ]);
+    saveAttributes(this.#contentElements, ["aria-labelledby", "id", "role"]);
+    this.#eventController = new AbortController();
+    const { signal } = this.#eventController;
     this.#triggerElements.forEach((trigger2, i) => {
       const id = Math.random().toString(36).slice(-8);
       const content2 = this.#contentElements[i];
       if (!content2) {
         return;
       }
-      saveAttributes([content2], ["aria-labelledby", "id", "role"]);
       content2.id ||= `accordion-content-${id}`;
       addTokenToAttribute(trigger2, "aria-controls", content2.id);
       trigger2.setAttribute(
@@ -894,7 +894,7 @@ function waitAnimationFinish(animation) {
  * Accordion
  * WAI-ARIA compliant accordion pattern implementation in TypeScript.
  *
- * @version 1.4.1
+ * @version 1.4.2
  * @author Yusuke Kamiyamane
  * @license MIT
  * @copyright Copyright (c) Yusuke Kamiyamane
@@ -930,7 +930,7 @@ function waitAnimationFinish(animation) {
    * Lightweight roving tabindex utility with fully focus management.
    * Designed for accessible menus, tabs, toolbars, and composite widgets.
    *
-   * @version 2.0.3
+   * @version 2.0.4
    * @author Yusuke Kamiyamane
    * @license MIT
    * @copyright Copyright (c) Yusuke Kamiyamane

package/dist/index.d.cts

@@ -2,7 +2,7 @@
  * Accordion
  * WAI-ARIA compliant accordion pattern implementation in TypeScript.
  *
- * @version 1.4.1
+ * @version 1.4.2
  * @author Yusuke Kamiyamane
  * @license MIT
  * @copyright Copyright (c) Yusuke Kamiyamane

package/dist/index.d.ts

@@ -2,7 +2,7 @@
  * Accordion
  * WAI-ARIA compliant accordion pattern implementation in TypeScript.
  *
- * @version 1.4.1
+ * @version 1.4.2
  * @author Yusuke Kamiyamane
  * @license MIT
  * @copyright Copyright (c) Yusuke Kamiyamane

package/dist/index.js

@@ -412,7 +412,7 @@ function createRovingTabIndex(container, options = {}) {
     console.warn("Invalid navigationOnly option. Fallback: false.");
     navigationOnly = false;
   }
-  if (typeof selector !== "undefined" && typeof selector !== "string") {
+  if (typeof selector !== "undefined" && (typeof selector !== "string" || !selector.trim())) {
     console.warn(
       "Invalid selector. Fallback: all focusable elements (undefined)."
     );
@@ -427,10 +427,10 @@ function createRovingTabIndex(container, options = {}) {
     wrap = false;
   }
   const settings = { navigationOnly, typeahead, wrap };
-  if (direction !== void 0) {
+  if (direction) {
     Object.assign(settings, { direction });
   }
-  if (selector !== void 0) {
+  if (selector) {
     Object.assign(settings, { selector });
   }
   const roving = new RovingTabIndex(container, settings);
@@ -727,8 +727,6 @@ var Accordion = class _Accordion {
     this.#rootElement.removeAttribute("data-accordion-initialized");
   }
   #initialize() {
-    this.#eventController = new AbortController();
-    const { signal } = this.#eventController;
     saveAttributes(this.#triggerElements, [
       "aria-controls",
       "aria-disabled",
@@ -736,13 +734,15 @@ var Accordion = class _Accordion {
       "style",
       "tabindex"
     ]);
+    saveAttributes(this.#contentElements, ["aria-labelledby", "id", "role"]);
+    this.#eventController = new AbortController();
+    const { signal } = this.#eventController;
     this.#triggerElements.forEach((trigger2, i) => {
       const id = Math.random().toString(36).slice(-8);
       const content2 = this.#contentElements[i];
       if (!content2) {
         return;
       }
-      saveAttributes([content2], ["aria-labelledby", "id", "role"]);
       content2.id ||= `accordion-content-${id}`;
       addTokenToAttribute(trigger2, "aria-controls", content2.id);
       trigger2.setAttribute(
@@ -892,7 +892,7 @@ function waitAnimationFinish(animation) {
  * Accordion
  * WAI-ARIA compliant accordion pattern implementation in TypeScript.
  *
- * @version 1.4.1
+ * @version 1.4.2
  * @author Yusuke Kamiyamane
  * @license MIT
  * @copyright Copyright (c) Yusuke Kamiyamane
@@ -928,7 +928,7 @@ function waitAnimationFinish(animation) {
    * Lightweight roving tabindex utility with fully focus management.
    * Designed for accessible menus, tabs, toolbars, and composite widgets.
    *
-   * @version 2.0.3
+   * @version 2.0.4
    * @author Yusuke Kamiyamane
    * @license MIT
    * @copyright Copyright (c) Yusuke Kamiyamane

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@y14e/accordion",
-  "version": "1.4.1",
+  "version": "1.4.2",
   "description": "WAI-ARIA compliant accordion pattern implementation in TypeScript",
   "type": "module",
   "main": "./dist/index.cjs",
@@ -45,7 +45,7 @@
   "devDependencies": {
     "@y14e/attributes-utils": "^1.1.0",
     "@y14e/button": "^1.0.0",
-    "@y14e/roving-tabindex": "^2.0.3",
+    "@y14e/roving-tabindex": "^2.0.4",
     "bun-types": "latest",
     "tsup": "^8.0.0",
     "typescript": "^5.6.0",