@xyo-network/chain-validation 1.4.7 → 1.5.0

package/src/block/validators/PreviousHash.ts

@@ -5,20 +5,24 @@ export const BlockPreviousHashValidator: BlockValidatorFunction = (
   block: BlockBoundWitness,
 ) => {
   const errors: Error[] = []
-  const blockNumber = block.block
-  if (blockNumber > 0n) {
+  try {
+    const blockNumber = block.block
+    if (blockNumber > 0n) {
     // if this is not the first block, validate previous hashes
-    if (!isHash(block.previous)) {
-      errors.push(new Error('previous hash is missing or invalid'))
-    }
-  } else if (blockNumber === 0) {
+      if (!isHash(block.previous)) {
+        errors.push(new Error('previous hash is missing or invalid'))
+      }
+    } else if (blockNumber === 0) {
     // if this is the first block, validate previous hashes
-    if (block.previous !== null) {
-      errors.push(new Error('previous hash should not be set'))
-    }
-  } else {
+      if (block.previous !== null) {
+        errors.push(new Error('previous hash should not be set'))
+      }
+    } else {
     // we have a negative block number
-    errors.push(new Error('invalid block number'))
+      errors.push(new Error('invalid block number'))
+    }
+  } catch (e) {
+    errors.push(new Error(`Failed BlockPreviousHashValidator: ${e instanceof Error ? e.message : String(e)}`))
   }
   return errors
 }

package/src/elevatedPayload/lib/validateElevatedFromBlock.ts

@@ -1,5 +1,5 @@
 import type { Promisable } from '@xylabs/promise'
-import { transactionPayloadsFromHydratedBlock } from '@xyo-network/chain-protocol'
+import { transactionsFromHydratedBlock } from '@xyo-network/chain-protocol'
 import type { HydratedBlock, InBlockPayloadValidationFunction } from '@xyo-network/xl1-protocol'
 
 export const validateElevatedFromBlock: InBlockPayloadValidationFunction = (
@@ -7,9 +7,14 @@ export const validateElevatedFromBlock: InBlockPayloadValidationFunction = (
   block: HydratedBlock,
 ): Promisable<Error[]> => {
   const errors: Error[] = []
-  const txPayloadHashes = new Set(transactionPayloadsFromHydratedBlock(block).map(tx => tx._hash))
-  if (txPayloadHashes.has(payload._hash)) {
-    errors.push(new Error(`Transaction may not include block payload hash [${payload.schema}]: ${payload._hash}`))
+  try {
+    const txs = transactionsFromHydratedBlock(block)
+    const allTxPayloadHashes = new Set(txs.flatMap(tx => tx.payload_hashes))
+    if (allTxPayloadHashes.has(payload._hash)) {
+      errors.push(new Error(`Transaction may not include block payload hash [${payload.schema}]: ${payload._hash}`))
+    }
+  } catch (e) {
+    errors.push(new Error(`Failed validateElevatedFromBlock: ${e instanceof Error ? e.message : String(e)}`))
   }
   return errors
 }

package/src/elevatedPayload/lib/validateElevatedFromTransaction.ts

@@ -7,14 +7,18 @@ export const validateElevatedFromTransaction: InBlockPayloadValidationFunction =
   block: HydratedBlock,
 ): Promisable<Error[]> => {
   const errors: Error[] = []
-  const txs = transactionsFromHydratedBlock(block)
-  if (txs.length > 0) {
-    const hashes = txs.flatMap(tx => tx.payload_hashes)
-    if (!hashes.includes(payload._hash)) {
-      errors.push(new Error('Transaction does not include payload'))
+  try {
+    const txs = transactionsFromHydratedBlock(block)
+    if (txs.length > 0) {
+      const hashes = txs.flatMap(tx => tx.payload_hashes)
+      if (!hashes.includes(payload._hash)) {
+        errors.push(new Error('Transaction does not include payload'))
+      }
+    } else {
+      errors.push(new Error('No Transactions in block'))
     }
-  } else {
-    errors.push(new Error('No Transactions in block'))
+  } catch (e) {
+    errors.push(new Error(`Failed validateElevatedFromTransaction: ${e instanceof Error ? e.message : String(e)}`))
   }
   return errors
 }

package/src/elevatedPayload/lib/validateIncludedInBlock.ts

@@ -3,8 +3,12 @@ import type { BlockBoundWitness } from '@xyo-network/xl1-protocol'
 
 export const validateIncludedInBlock = (payload: WithStorageMeta<Payload>, block: BlockBoundWitness): Error[] => {
   const errors: Error[] = []
-  if (!block.payload_hashes.includes(payload._hash)) {
-    errors.push(new Error('Payload not included in block'))
+  try {
+    if (!block.payload_hashes.includes(payload._hash)) {
+      errors.push(new Error('Payload not included in block'))
+    }
+  } catch (e) {
+    errors.push(new Error(`Failed validateIncludedInBlock: ${e instanceof Error ? e.message : String(e)}`))
   }
   return errors
 }

package/src/elevatedPayload/lib/validateTransactionInBlock.ts

@@ -9,10 +9,14 @@ export const validateTransactionInBlock: InBlockPayloadValidationFunction = asyn
   _block: HydratedBlock,
 ): Promise<Error[]> => {
   const errors: Error[] = []
-  if (isTransactionBoundWitness(payload) && isStorageMeta(payload)) {
-    errors.push(...await BoundWitnessSignaturesValidator(payload))
-  } else {
-    errors.push(new Error('Payload failed isTransactionBoundWitness or isStorageMeta'))
+  try {
+    if (isTransactionBoundWitness(payload) && isStorageMeta(payload)) {
+      errors.push(...await BoundWitnessSignaturesValidator(payload))
+    } else {
+      errors.push(new Error('Payload failed isTransactionBoundWitness or isStorageMeta'))
+    }
+  } catch (e) {
+    errors.push(new Error(`Failed validateTransactionInBlock: ${e instanceof Error ? e.message : String(e)}`))
   }
   return errors
 }

package/src/elevatedPayload/lib/validateTypedPayloadInBlock.ts

@@ -13,14 +13,18 @@ export const validateTypedPayloadInBlock = async <T extends Payload>(
   identityFunction: IdentityFunction<T>,
 ): Promise<Error[]> => {
   const errors: Error[] = []
-  if (identityFunction(payload) && isStorageMeta(payload)) {
-    if (isElevatedFromBlock(payload, block)) {
-      errors.push(...await validateElevatedFromBlock(payload, block))
+  try {
+    if (identityFunction(payload) && isStorageMeta(payload)) {
+      if (isElevatedFromBlock(payload, block)) {
+        errors.push(...await validateElevatedFromBlock(payload, block))
+      } else {
+        errors.push(...await validateElevatedFromTransaction(payload, block))
+      }
     } else {
-      errors.push(...await validateElevatedFromTransaction(payload, block))
+      errors.push(new Error('Payload failed identityFunction or isElevated or isStorageMeta'))
     }
-  } else {
-    errors.push(new Error('Payload failed identityFunction or isElevated or isStorageMeta'))
+  } catch (e) {
+    errors.push(new Error(`Failed validateTypedPayloadInBlock: ${e instanceof Error ? e.message : String(e)}`))
   }
   return errors
 }

package/src/elevatedPayload/payloads/validateChainStakeIntentInBlock.ts

@@ -8,6 +8,10 @@ export const validateChainStakeIntentInBlock: InBlockPayloadValidationFunction =
   block: HydratedBlock,
 ): Promise<Error[]> => {
   const errors: Error[] = []
-  errors.push(...await validateTypedPayloadInBlock(payload, block, isChainStakeIntent))
+  try {
+    errors.push(...await validateTypedPayloadInBlock(payload, block, isChainStakeIntent))
+  } catch (e) {
+    errors.push(new Error(`Failed validateChainStakeIntentInBlock: ${e instanceof Error ? e.message : String(e)}`))
+  }
   return errors
 }

package/src/elevatedPayload/payloads/validateHashInBlock.ts

@@ -8,6 +8,10 @@ export const validateHashInBlock: InBlockPayloadValidationFunction = async (
   block: HydratedBlock,
 ): Promise<Error[]> => {
   const errors: Error[] = []
-  errors.push(...await validateTypedPayloadInBlock(payload, block, isHashPayload))
+  try {
+    errors.push(...await validateTypedPayloadInBlock(payload, block, isHashPayload))
+  } catch (e) {
+    errors.push(new Error(`Failed validateHashInBlock: ${e instanceof Error ? e.message : String(e)}`))
+  }
   return errors
 }

package/src/elevatedPayload/payloads/validateSchemaInBlock.ts

@@ -8,6 +8,10 @@ export const validateSchemaInBlock: InBlockPayloadValidationFunction = async (
   block: HydratedBlock,
 ): Promise<Error[]> => {
   const errors: Error[] = []
-  errors.push(...await validateTypedPayloadInBlock(payload, block, isSchemaPayload))
+  try {
+    errors.push(...await validateTypedPayloadInBlock(payload, block, isSchemaPayload))
+  } catch (e) {
+    errors.push(new Error(`Failed validateSchemaInBlock: ${e instanceof Error ? e.message : String(e)}`))
+  }
   return errors
 }

package/src/elevatedPayload/payloads/validateTransferInBlock.ts

@@ -9,6 +9,10 @@ export const validateTransferInBlock: InBlockPayloadValidationFunction = async (
   block: HydratedBlock,
 ): Promise<Error[]> => {
   const errors: Error[] = []
-  errors.push(...await validateTypedPayloadInBlock(payload, block, isTransfer))
+  try {
+    errors.push(...await validateTypedPayloadInBlock(payload, block, isTransfer))
+  } catch (e) {
+    errors.push(new Error(`Failed validateTransferInBlock: ${e instanceof Error ? e.message : String(e)}`))
+  }
   return errors
 }

package/src/elevatedPayload/validatePayloadInBlock.ts

@@ -27,11 +27,15 @@ export const validatePayloadInBlock: InBlockPayloadValidationFunction = async (
   block: HydratedBlock,
 ): Promise<Error[]> => {
   const errors: Error[] = []
-  const validator = payloadValidators[payload.schema]
-  if (validator) {
-    errors.push(...await validator(payload, block))
-  } else {
-    errors.push(new Error(`Unsupported payload schema: ${payload.schema}`))
+  try {
+    const validator = payloadValidators[payload.schema]
+    if (validator) {
+      errors.push(...await validator(payload, block))
+    } else {
+      errors.push(new Error(`Unsupported payload schema: ${payload.schema}`))
+    }
+  } catch (e) {
+    errors.push(new Error(`Failed validatePayloadInBlock: ${e instanceof Error ? e.message : String(e)}`))
   }
   return errors
 }

package/src/hydratedBlock/validateHydratedBlock.ts

@@ -10,11 +10,17 @@ export const validateHydratedBlock: HydratedBlockValidatorFunction = async (
   chainId?: Address,
   additionalValidators: HydratedBlockValidatorFunction[] = [],
 ): Promise<Error[]> => {
-  const errors: Error[] = await validateBlock(hydratedBlock[0], chainId)
-  const validators: HydratedBlockValidatorFunction[] = [
-    BoundWitnessReferencesValidator(),
-    PayloadsInBlockValidator,
-    ...additionalValidators,
-  ]
-  return [...errors, ...(await Promise.all(validators.map(v => v(hydratedBlock, chainId)))).flat()]
+  const errors: Error[] = []
+  try {
+    errors.push(...await validateBlock(hydratedBlock[0], chainId))
+    const validators: HydratedBlockValidatorFunction[] = [
+      BoundWitnessReferencesValidator(),
+      PayloadsInBlockValidator,
+      ...additionalValidators,
+    ]
+    errors.push(...(await Promise.all(validators.map(v => v(hydratedBlock, chainId)))).flat())
+  } catch (e) {
+    errors.push(new Error(`Failed validateHydratedBlock: ${e instanceof Error ? e.message : String(e)}`))
+  }
+  return errors
 }

package/src/hydratedBlock/validators/Payloads.ts

@@ -11,26 +11,31 @@ export const PayloadsInBlockValidator: HydratedBlockValidatorFunction = async (
   [block, payloads]: HydratedBlock,
 ) => {
   const errors: Error[] = []
+  try {
+    const payloadMap: Partial<Record<Hash, WithHashStorageMeta<Payload>>> = {}
+    for (const payload of payloads) {
+      payloadMap[payload._hash] = payload
+    }
 
-  const payloadMap: Partial<Record<Hash, WithHashStorageMeta<Payload>>> = {}
-  for (const payload of payloads) {
-    payloadMap[payload._hash] = payload
-  }
+    const remainingPayloads = { ...payloadMap }
 
-  for (let i = 0; i < block.payload_hashes.length; i++) {
-    const hash = block.payload_hashes[i]
-    const schema = block.payload_schemas[i]
-    const payload = payloadMap[hash]
-    if (payload) {
-      errors.push(...await validatePayloadInBlock(payload, [block, payloads]))
-      delete payloadMap[hash]
-    } else {
-      errors.push(new Error(`missing payload ${hash} ${schema}`))
+    for (let i = 0; i < block.payload_hashes.length; i++) {
+      const hash = block.payload_hashes[i]
+      const schema = block.payload_schemas[i]
+      const payload = payloadMap[hash]
+      if (payload) {
+        errors.push(...await validatePayloadInBlock(payload, [block, payloads]))
+        delete remainingPayloads[hash]
+      } else {
+        errors.push(new Error(`missing payload ${hash} ${schema}`))
+      }
     }
-  }
 
-  if (Object.keys(payloadMap).length > 0) {
-    errors.push(new Error(`extra payloads ${Object.keys(payloadMap).join(', ')}`))
+    if (Object.keys(remainingPayloads).length > 0) {
+      errors.push(new Error(`extra payloads ${Object.keys(payloadMap).join(', ')}`))
+    }
+  } catch (e) {
+    errors.push(new Error(`Failed PayloadsInBlockValidator: ${e instanceof Error ? e.message : String(e)}`))
   }
 
   return errors

package/src/hydratedBlockState/validateHydratedBlockState.ts

@@ -1,6 +1,7 @@
 import type { Address } from '@xylabs/hex'
-import type { ReadArchivist } from '@xyo-network/archivist-model'
-import type { HydratedBlock, HydratedBlockStateValidationFunction } from '@xyo-network/xl1-protocol'
+import type {
+  AccountBalanceService, HydratedBlock, HydratedBlockStateValidationFunction,
+} from '@xyo-network/xl1-protocol'
 
 import { validateHydratedBlock } from '../hydratedBlock/index.ts'
 import { RequiredBalanceBlockStateValidator } from './validators/index.ts'
@@ -8,13 +9,19 @@ import { RequiredBalanceBlockStateValidator } from './validators/index.ts'
 export const validateHydratedBlockState: HydratedBlockStateValidationFunction = async (
   hydratedBlock: HydratedBlock,
   chainId: Address,
-  archivist: ReadArchivist,
+  services: { accountBalance: AccountBalanceService },
   additionalValidators: HydratedBlockStateValidationFunction[] = [],
 ): Promise<Error[]> => {
-  const errors: Error[] = await validateHydratedBlock(hydratedBlock, chainId)
-  const validators: HydratedBlockStateValidationFunction[] = [
+  const errors: Error[] = []
+  try {
+    errors.push(...await validateHydratedBlock(hydratedBlock, chainId))
+    const validators: HydratedBlockStateValidationFunction[] = [
     // RequiredBalanceBlockStateValidator,
-    ...additionalValidators,
-  ]
-  return [...errors, ...(await Promise.all(validators.map(v => v(hydratedBlock, chainId, archivist)))).flat()]
+      ...additionalValidators,
+    ]
+    errors.push(...(await Promise.all(validators.map(v => v(hydratedBlock, chainId, services)))).flat())
+  } catch (e) {
+    errors.push(new Error(`Failed validateHydratedBlockState: ${e instanceof Error ? e.message : String(e)}`))
+  }
+  return errors
 }

package/src/hydratedBlockState/validators/RequiredBalance.ts

@@ -1,46 +1,37 @@
-import { assertEx } from '@xylabs/assert'
-import type { Address } from '@xylabs/hex'
-import type { ReadArchivist } from '@xyo-network/archivist-model'
-import {
-  analyzeChain, BalanceAnalyzer, isChainSummaryBalances, netBalancesForPayloads,
-} from '@xyo-network/chain-analyze'
-import { parseSignedBigInt } from '@xyo-network/chain-protocol'
-import type { HydratedBlock, HydratedBlockStateValidationFunction } from '@xyo-network/xl1-protocol'
+import { type Address, hexToBigInt } from '@xylabs/hex'
+import { netBalancesForPayloads } from '@xyo-network/chain-protocol'
+import type {
+  AccountBalanceService, HydratedBlock, HydratedBlockStateValidationFunction,
+} from '@xyo-network/xl1-protocol'
 
 export const RequiredBalanceBlockStateValidator: HydratedBlockStateValidationFunction = async (
   block: HydratedBlock,
   chainId: Address,
-  archivist: ReadArchivist,
+  services: { accountBalance: AccountBalanceService },
 ) => {
   const errors: Error[] = []
-
+  try {
   // TODO: Filter by non-producer elevated payloads
-  // to allow for transfers from ZERO address
-  const netBalances = netBalancesForPayloads(block[1])
-  const netBalanceAddresses = Object.keys(netBalances) as Address[]
-  const requiredBalances: Record<Address, bigint> = {}
-  for (const address of netBalanceAddresses) {
-    if (netBalances[address] < 0n) {
-      requiredBalances[address] = -netBalances[address]
+    // to allow for transfers from ZERO address
+    const netBalances = netBalancesForPayloads(block[1])
+    const netBalanceAddresses = Object.keys(netBalances) as Address[]
+    const requiredBalances: Record<Address, bigint> = {}
+    for (const address of netBalanceAddresses) {
+      if (netBalances[address] < 0n) {
+        requiredBalances[address] = -netBalances[address]
+      }
     }
-  }
-  const previous = block[0].previous
-  if (previous === null) return [new Error('Insufficient funds because first block')]
-  const results = await analyzeChain(
-    archivist,
-    [
-      new BalanceAnalyzer(Object.keys(requiredBalances) as Address[], Object.values(requiredBalances)),
-    ],
-    previous,
-  )
-  const summaryBalances = assertEx(results.find(isChainSummaryBalances), () => new Error('missing summary balances'))
+    const previous = block[0].previous
+    if (previous === null) return [new Error('Insufficient funds because first block')]
 
-  for (const [address, reqBalance] of Object.entries(requiredBalances) as [Address, bigint][]) {
-    const balance = parseSignedBigInt(summaryBalances.balances[address] ?? { positive: '00' })
-    if (reqBalance > balance) {
-      errors.push(new Error(`insufficient balance for ${address} ${balance} < ${requiredBalances[address]}`))
+    for (const [address, reqBalance] of Object.entries(requiredBalances) as [Address, bigint][]) {
+      const balance = hexToBigInt(services.accountBalance.getBalance(address))
+      if (reqBalance > balance) {
+        errors.push(new Error(`insufficient balance for ${address} ${balance} < ${requiredBalances[address]}`))
+      }
     }
+  } catch (e) {
+    errors.push(new Error(`Failed RequiredBalanceBlockStateValidator: ${e instanceof Error ? e.message : String(e)}`))
   }
-
-  return errors
+  return await Promise.resolve(errors)
 }

package/src/transaction/validateTransaction.ts

@@ -12,18 +12,22 @@ export async function validateTransaction(
   chainId?: Address,
   additionalValidators: HydratedTransactionValidatorFunction[] = [],
 ): Promise<Error[]> {
-  if (!isTransactionBoundWitness(tx[0])) {
-    return [new Error('failed isTransactionBoundWitness identity check')]
-  }
+  try {
+    if (!isTransactionBoundWitness(tx[0])) {
+      return [new Error('failed isTransactionBoundWitness identity check')]
+    }
 
-  const validators: HydratedTransactionValidatorFunction[] = [
-    TransactionProtocolValidator,
-    TransactionJsonSchemaValidator,
-    TransactionDurationValidator,
-    TransactionFromValidator,
-    TransactionGasValidator,
-    TransactionElevationValidator,
-    ...additionalValidators,
-  ]
-  return (await Promise.all(validators.map(v => v(tx, chainId)))).flat()
+    const validators: HydratedTransactionValidatorFunction[] = [
+      TransactionProtocolValidator,
+      TransactionJsonSchemaValidator,
+      TransactionDurationValidator,
+      TransactionFromValidator,
+      TransactionGasValidator,
+      TransactionElevationValidator,
+      ...additionalValidators,
+    ]
+    return (await Promise.all(validators.map(v => v(tx, chainId)))).flat()
+  } catch (e) {
+    return [(new Error(`Failed TransactionGasValidator: ${e instanceof Error ? e.message : String(e)}`))]
+  }
 }

package/src/transaction/validators/TransactionDurationValidator.ts

@@ -6,12 +6,16 @@ export const TransactionDurationValidator: HydratedTransactionValidatorFunction<
   [tx]: HydratedTransaction,
 ): Error[] => {
   const errors: Error[] = []
-  const { exp, nbf } = tx
-  if (nbf < 0) errors.push(new Error('Transaction nbf must be positive'))
+  try {
+    const { exp, nbf } = tx
+    if (nbf < 0) errors.push(new Error('Transaction nbf must be positive'))
 
-  if (exp < 0) errors.push(new Error('Transaction exp must be positive'))
-  if (exp <= nbf) errors.push(new Error('Transaction exp must greater than nbf'))
-  if (exp - nbf > 10_000) errors.push(new Error('Transaction exp must not be too far in the future'))
+    if (exp < 0) errors.push(new Error('Transaction exp must be positive'))
+    if (exp <= nbf) errors.push(new Error('Transaction exp must greater than nbf'))
+    if (exp - nbf > 10_000) errors.push(new Error('Transaction exp must not be too far in the future'))
+  } catch (e) {
+    errors.push(new Error(`Failed TransactionDurationValidator: ${e instanceof Error ? e.message : String(e)}`))
+  }
 
   return errors
 }

package/src/transaction/validators/TransactionElevationValidator.ts

@@ -9,9 +9,13 @@ export const TransactionElevationValidator: HydratedTransactionValidatorFunction
 ): Promisable<Error[]> => {
   const errors: Error[] = []
   try {
-    extractElevatedHashes(tx)
-  } catch {
-    errors.push(new Error('Hydrated transaction does not include all script hashes'))
+    try {
+      extractElevatedHashes(tx)
+    } catch {
+      errors.push(new Error('Hydrated transaction does not include all script hashes'))
+    }
+  } catch (e) {
+    errors.push(new Error(`Failed TransactionElevationValidator: ${e instanceof Error ? e.message : String(e)}`))
   }
   return errors
 }

package/src/transaction/validators/TransactionFromValidator.ts

@@ -8,8 +8,12 @@ export const TransactionFromValidator: HydratedTransactionValidatorFunction<Tran
   [tx]: HydratedTransaction,
 ): Error[] => {
   const errors: Error[] = []
-  const from = asAddress(tx.from)
-  if (from === undefined)errors.push(new Error('Transaction from is not a valid address'))
-  else if (!addressesContains(tx, from)) errors.push(new Error('Transaction from address must be listed in addresses'))
+  try {
+    const from = asAddress(tx.from)
+    if (from === undefined)errors.push(new Error('Transaction from is not a valid address'))
+    else if (!addressesContains(tx, from)) errors.push(new Error('Transaction from address must be listed in addresses'))
+  } catch (e) {
+    errors.push(new Error(`Failed TransactionFromValidator: ${e instanceof Error ? e.message : String(e)}`))
+  }
   return errors
 }

package/src/transaction/validators/TransactionGasValidator.ts

@@ -10,24 +10,28 @@ export const TransactionGasValidator: HydratedTransactionValidatorFunction<Trans
   [tx]: HydratedTransaction,
 ): Error[] => {
   const errors: Error[] = []
-  if (tx?.fees === undefined) {
-    errors.push(new Error('Missing fees'))
-  } else {
-    const {
-      base, gasLimit, gasPrice, priority,
-    } = parseFees(tx.fees)
+  try {
+    if (tx?.fees === undefined) {
+      errors.push(new Error('Missing fees'))
+    } else {
+      const {
+        base, gasLimit, gasPrice, priority,
+      } = parseFees(tx.fees)
 
-    if (base === undefined) errors.push(new Error('fees.base must be defined and a valid number'))
-    else if (base < minTransactionFees.base) errors.push(new Error(`fees.base must be >= ${minTransactionFees.base}`))
+      if (base === undefined) errors.push(new Error('fees.base must be defined and a valid number'))
+      else if (base < minTransactionFees.base) errors.push(new Error(`fees.base must be >= ${minTransactionFees.base}`))
 
-    if (gasLimit === undefined) errors.push(new Error('fees.gasLimit must be defined and a valid number'))
-    else if (gasLimit < minTransactionFees.gasLimit) errors.push(new Error(`fees.gasLimit must be >= ${minTransactionFees.gasLimit}`))
+      if (gasLimit === undefined) errors.push(new Error('fees.gasLimit must be defined and a valid number'))
+      else if (gasLimit < minTransactionFees.gasLimit) errors.push(new Error(`fees.gasLimit must be >= ${minTransactionFees.gasLimit}`))
 
-    if (gasPrice === undefined) errors.push(new Error('fees.gasPrice must be defined and a valid number'))
-    else if (gasPrice < minTransactionFees.gasPrice) errors.push(new Error(`fees.gasPrice must be >= ${minTransactionFees.gasPrice}`))
+      if (gasPrice === undefined) errors.push(new Error('fees.gasPrice must be defined and a valid number'))
+      else if (gasPrice < minTransactionFees.gasPrice) errors.push(new Error(`fees.gasPrice must be >= ${minTransactionFees.gasPrice}`))
 
-    if (priority === undefined) errors.push(new Error('fees.priority must be defined and a valid number'))
-    else if (priority < minTransactionFees.priority) errors.push(new Error(`fees.priority must be >= ${minTransactionFees.priority}`))
+      if (priority === undefined) errors.push(new Error('fees.priority must be defined and a valid number'))
+      else if (priority < minTransactionFees.priority) errors.push(new Error(`fees.priority must be >= ${minTransactionFees.priority}`))
+    }
+  } catch (e) {
+    errors.push(new Error(`Failed TransactionGasValidator: ${e instanceof Error ? e.message : String(e)}`))
   }
   return errors
 }

package/src/transaction/validators/TransactionProtocolValidator.ts

@@ -1,5 +1,4 @@
 import type { Address } from '@xylabs/hex'
-import { BoundWitnessWrapper } from '@xyo-network/boundwitness-wrapper'
 import type {
   HydratedTransaction, HydratedTransactionValidatorFunction, TransactionBoundWitness,
 } from '@xyo-network/xl1-protocol'
@@ -10,14 +9,11 @@ export const TransactionProtocolValidator: HydratedTransactionValidatorFunction<
 ): Promise<Error[]> => {
   const errors: Error[] = []
   try {
-    if (!await BoundWitnessWrapper.parse(tx).getValid()) {
-      errors.push(new Error('failed basic boundwitness parse'))
-    }
     if (chainId !== undefined && tx.chain !== chainId) {
       errors.push(new Error('invalid chain id'))
     }
   } catch (ex) {
     errors.push(new Error('validation excepted'), ex as Error)
   }
-  return errors
+  return await Promise.resolve(errors)
 }