@xynogen/pix-toolbox 0.1.14 → 0.1.16

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@xynogen/pix-toolbox",
-	"version": "0.1.14",
+	"version": "0.1.16",
 	"description": "Pi tool — gated tool toggle UI (/toolbox)",
 	"type": "module",
 	"main": "src/index.ts",
@@ -9,6 +9,7 @@
 	},
 	"files": [
 		"src",
+		"!src/**/*.test.*",
 		"README.md",
 		"LICENSE"
 	],

package/src/toolbox.ts

@@ -345,8 +345,8 @@ export default function registerToolbox(pi: ExtensionAPI): void {
 				const accent = "accent";
 				const mute = (s: string) => theme.fg("muted", s);
 				const guide = (key: string, action: string) =>
-					theme.fg("text", key) + theme.fg("dim", ` ${action}`);
-				const guideSep = theme.fg("dim", " · ");
+					theme.fg("text", key) + theme.fg("muted", ` ${action}`);
+				const guideSep = theme.fg("muted", " · ");
 
 				type RowState = "active" | "gated";
 				const stateOf = (name: string): RowState => (ops.isActive(name) ? "active" : "gated");
@@ -354,7 +354,7 @@ export default function registerToolbox(pi: ExtensionAPI): void {
 				const labelFor = (r: ToolRow): string => {
 					const active = stateOf(r.name) === "active";
 					const marker = active ? " " : theme.fg("warning", "#");
-					const name = active ? theme.fg("success", r.name) : theme.fg("dim", r.name);
+					const name = active ? theme.fg("success", r.name) : theme.fg("muted", r.name);
 					const kind = mute(`[${r.mcp ? "MCP" : "tool"}]`);
 					return `${marker} ${name}  ${kind}`;
 				};
@@ -386,7 +386,7 @@ export default function registerToolbox(pi: ExtensionAPI): void {
 						selectedPrefix: (t: string) => theme.fg(accent, t),
 						selectedText: (t: string) => theme.fg(accent, t),
 						description: (t: string) => t,
-						scrollInfo: (t: string) => theme.fg("dim", t),
+						scrollInfo: (t: string) => theme.fg("muted", t),
 						noMatch: (t: string) => theme.fg("warning", t),
 					},
 					{
@@ -395,6 +395,7 @@ export default function registerToolbox(pi: ExtensionAPI): void {
 					},
 				);
 
+				// SAFETY: SelectList exposes these stable fields internally for label refreshes.
 				const internal = list as unknown as {
 					items: SelectItem[];
 					filteredItems: SelectItem[];
@@ -420,7 +421,7 @@ export default function registerToolbox(pi: ExtensionAPI): void {
 					const sel = list.getSelectedItem();
 					if (!sel) return;
 					const msg = toggleTool(action, sel.value, rows, ops);
-					statusText = theme.fg("muted", msg);
+					statusText = theme.fg("dim", msg);
 					refreshLabels();
 				};
 
@@ -473,7 +474,7 @@ export default function registerToolbox(pi: ExtensionAPI): void {
 							minHeight: MIN_MODAL_HEIGHT,
 							header: [
 								theme.fg(accent, theme.bold("🧰  Toolbox")),
-								theme.fg("muted", "Search:"),
+								theme.fg("dim", "Search:"),
 								...search.render(inner),
 								"",
 							],
@@ -565,6 +566,7 @@ export default function registerToolbox(pi: ExtensionAPI): void {
 			}
 
 			if (typeof ctx.ui.custom === "function") {
+				// SAFETY: The runtime command context satisfies showPicker's narrowed UI contract.
 				await showPicker(ctx as unknown as Parameters<typeof showPicker>[0]);
 			} else {
 				ctx.ui.notify(renderList(getRows(), ops.isActive), "info");

package/src/toolbox.test.ts

@@ -1,319 +0,0 @@
-import { afterAll, beforeAll, describe, expect, test } from "bun:test";
-import { mkdtempSync, rmSync } from "node:fs";
-import { tmpdir } from "node:os";
-import { join } from "node:path";
-import registerToolbox, {
-	buildRows,
-	parseTargets,
-	renderList,
-	type ToggleOps,
-	type ToolRow,
-	toggleTool,
-} from "./toolbox.ts";
-
-// ─── Fixtures ───────────────────────────────────────────────────────────────
-
-const toolInfo = (name: string, source = "builtin") =>
-	({
-		name,
-		description: `${name} does things.`,
-		parameters: {},
-		sourceInfo: { source, path: "", scope: "user", origin: "package" },
-	}) as never;
-
-const mcpToolInfo = (name: string) => toolInfo(name, "mcp:context7");
-
-// ─── buildRows ──────────────────────────────────────────────────────────────
-
-describe("buildRows", () => {
-	test("excludes core tools (bash, edit, read, write)", () => {
-		const rows = buildRows([
-			toolInfo("bash"),
-			toolInfo("edit"),
-			toolInfo("read"),
-			toolInfo("write"),
-			toolInfo("grep"),
-			toolInfo("ls"),
-		]);
-		expect(rows.map((r) => r.name)).toEqual(["grep", "ls"]);
-		expect(rows.every((r) => !r.mcp)).toBe(true);
-	});
-
-	test("flags MCP tools", () => {
-		const rows = buildRows([mcpToolInfo("ctx_search")]);
-		expect((rows[0] as ToolRow).mcp).toBe(true);
-	});
-
-	test("empty input returns empty", () => {
-		expect(buildRows([])).toEqual([]);
-	});
-});
-
-// ─── parseTargets ───────────────────────────────────────────────────────────
-
-describe("parseTargets", () => {
-	test("splits on commas, spaces, newlines", () => {
-		expect(parseTargets("ls, find  grep\nfetch")).toEqual(["ls", "find", "grep", "fetch"]);
-	});
-
-	test("dedupes", () => {
-		expect(parseTargets("ls, ls")).toEqual(["ls"]);
-	});
-
-	test("empty yields empty", () => {
-		expect(parseTargets("")).toEqual([]);
-		expect(parseTargets("  , ")).toEqual([]);
-	});
-});
-
-// ─── renderList ─────────────────────────────────────────────────────────────
-
-describe("renderList", () => {
-	const rows: ToolRow[] = [
-		{ name: "read", description: "Read files.", mcp: false },
-		{ name: "grep", description: "Search files.", mcp: false },
-		{ name: "ctx", description: "MCP search.", mcp: true },
-	];
-	const isActive = (n: string) => n === "read";
-
-	test("shows status for each tool", () => {
-		const out = renderList(rows, isActive);
-		expect(out).toContain("✓ active  read");
-		expect(out).toContain("# gated  grep");
-		expect(out).toContain("# gated  ctx");
-		expect(out).toContain("[MCP]");
-	});
-
-	test("filters by query", () => {
-		const out = renderList(rows, isActive, "grep");
-		expect(out).toContain("grep");
-		expect(out).not.toContain("read");
-	});
-
-	test("no match message", () => {
-		const out = renderList(rows, isActive, "zzz");
-		expect(out).toContain('No tools matched "zzz"');
-	});
-
-	test("empty rows", () => {
-		expect(renderList([], isActive)).toContain("No tools registered");
-	});
-});
-
-// ─── toggleTool ─────────────────────────────────────────────────────────────
-
-describe("toggleTool", () => {
-	const rows: ToolRow[] = [
-		{ name: "read", description: "Read.", mcp: false },
-		{ name: "grep", description: "Search.", mcp: false },
-	];
-
-	test("enable calls onActivate", () => {
-		let called = "";
-		const ops: ToggleOps = {
-			onActivate: (n) => {
-				called = n;
-				return true;
-			},
-			onDeactivate: () => false,
-			isActive: () => false,
-		};
-		const msg = toggleTool("enable", "grep", rows, ops);
-		expect(called).toBe("grep");
-		expect(msg).toContain("Enabled grep");
-	});
-
-	test("disable calls onDeactivate", () => {
-		let called = "";
-		const ops: ToggleOps = {
-			onActivate: () => false,
-			onDeactivate: (n) => {
-				called = n;
-				return true;
-			},
-			isActive: () => true,
-		};
-		const msg = toggleTool("disable", "read", rows, ops);
-		expect(called).toBe("read");
-		expect(msg).toContain("Disabled read");
-	});
-
-	test("unknown tool returns error", () => {
-		const ops: ToggleOps = {
-			onActivate: () => false,
-			onDeactivate: () => false,
-			isActive: () => false,
-		};
-		expect(toggleTool("enable", "nope", rows, ops)).toContain("Unknown");
-	});
-
-	test("already active returns already message", () => {
-		const ops: ToggleOps = {
-			onActivate: () => false,
-			onDeactivate: () => false,
-			isActive: () => true,
-		};
-		expect(toggleTool("enable", "read", rows, ops)).toContain("already");
-	});
-
-	test("already gated returns already message", () => {
-		const ops: ToggleOps = {
-			onActivate: () => false,
-			onDeactivate: () => false,
-			isActive: () => false,
-		};
-		expect(toggleTool("disable", "read", rows, ops)).toContain("already");
-	});
-});
-
-// ─── Integration: /toolbox command ──────────────────────────────────────────
-
-// Isolate from real ~/.pi/agent/toolbox.json on disk
-let tmpAgentDir: string;
-beforeAll(() => {
-	tmpAgentDir = mkdtempSync(join(tmpdir(), "toolbox-test-"));
-	process.env.PI_CODING_AGENT_DIR = tmpAgentDir;
-});
-afterAll(() => {
-	delete process.env.PI_CODING_AGENT_DIR;
-	try {
-		rmSync(tmpAgentDir, { recursive: true });
-	} catch {
-		// temp dir may already be gone — safe to ignore
-	}
-});
-
-function makeHost(toolNames: string[]) {
-	const handlers: Record<string, Array<(p: unknown) => unknown>> = {};
-	let active: string[] = [...toolNames];
-	const commands: Array<{
-		name: string;
-		handler: (...args: unknown[]) => unknown;
-	}> = [];
-	const pi = {
-		on(ev: string, fn: (p: unknown) => unknown) {
-			if (!handlers[ev]) handlers[ev] = [];
-			handlers[ev].push(fn);
-		},
-		emit(ev: string, payload: unknown, ctx?: unknown) {
-			return Promise.all(
-				(handlers[ev] ?? []).map((f) => (f as (...args: unknown[]) => unknown)(payload, ctx)),
-			);
-		},
-		getAllTools() {
-			return toolNames.map((name) => ({
-				name,
-				description: `${name} does things.`,
-				parameters: {},
-				sourceInfo: { source: "builtin" },
-			}));
-		},
-		getActiveTools() {
-			return active;
-		},
-		setActiveTools(names: string[]) {
-			active = [...names];
-		},
-		getCommands() {
-			return [];
-		},
-		appendEntry() {},
-		registerTool() {},
-		registerCommand(name: string, def: { handler: (...args: unknown[]) => unknown }) {
-			commands.push({ name, handler: def.handler });
-		},
-	} as never;
-	const emit = (ev: string, payload: unknown, ctx?: unknown) =>
-		Promise.all(
-			(handlers[ev] ?? []).map((f) => (f as (...args: unknown[]) => unknown)(payload, ctx)),
-		);
-	return {
-		pi,
-		emit,
-		getActive: () => active,
-		command: (name: string) => commands.find((c) => c.name === name),
-	};
-}
-
-function makeCtx() {
-	const notes: Array<{ text: string; level?: string }> = [];
-	const ctx = {
-		ui: {
-			notify(text: string, level?: string) {
-				notes.push({ text, level });
-			},
-		},
-	} as never;
-	return { ctx, notes };
-}
-
-describe("/toolbox command", () => {
-	type Note = { text: string; level?: string };
-	const ALL = ["read", "write", "bash", "grep", "find"];
-
-	async function boot() {
-		const host = makeHost(ALL);
-		registerToolbox(host.pi);
-		// session_start triggers init
-		await host.emit("session_start", {}, {});
-		return host;
-	}
-
-	test("registers a /toolbox command", async () => {
-		const host = await boot();
-		expect(host.command("toolbox")).toBeDefined();
-	});
-
-	test("bare /toolbox falls back to listing when no custom UI", async () => {
-		const host = await boot();
-		const { ctx, notes } = makeCtx();
-		await host.command("toolbox")?.handler("", ctx);
-		expect(notes.length).toBe(1);
-		// only non-core tools shown, all start active
-		const n0 = notes[0] as Note;
-		expect(n0.text).toContain("✓ active  grep");
-		expect(n0.text).toContain("✓ active  find");
-		// core tools excluded from toolbox
-		expect(n0.text).not.toContain("  read");
-		expect(n0.text).not.toContain("  bash");
-	});
-
-	test("/toolbox list shows non-core tools with status", async () => {
-		const host = await boot();
-		const { ctx, notes } = makeCtx();
-		await host.command("toolbox")?.handler("list", ctx);
-		const ln0 = notes[0] as Note;
-		expect(ln0.text).toContain("grep");
-		expect(ln0.text).toContain("find");
-		expect(ln0.text).not.toContain("  bash");
-	});
-
-	test("/toolbox list <query> filters", async () => {
-		const host = await boot();
-		const { ctx, notes } = makeCtx();
-		await host.command("toolbox")?.handler("list fin", ctx);
-		const fn0 = notes[0] as Note;
-		expect(fn0.text).toContain("find");
-		expect(fn0.text).not.toContain("✓ active  read");
-	});
-
-	test("opens interactive picker when ctx.ui.custom exists", async () => {
-		const host = await boot();
-		let customCalled = 0;
-		const notes: Array<{ text: string; level?: string }> = [];
-		const ctx = {
-			ui: {
-				notify(text: string, level?: string) {
-					notes.push({ text, level });
-				},
-				async custom() {
-					customCalled++;
-					return null;
-				},
-			},
-		} as never;
-		await host.command("toolbox")?.handler("", ctx);
-		expect(customCalled).toBe(1);
-		expect(notes.length).toBe(0);
-	});
-});