@xynogen/pix-runtime 0.16.0 → 0.16.1

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@xynogen/pix-runtime",
-	"version": "0.16.0",
+	"version": "0.16.1",
 	"description": "Pix shared runtime — versioned pix.json config, atomic persistence, typed change events",
 	"type": "module",
 	"main": "src/index.ts",

package/src/exec.ts

@@ -97,7 +97,7 @@ export interface ToolExecOptions {
 	onStatus?: (status: ToolStatus) => void;
 	/** Test seam for the host OS. */
 	host?: HostPlatform;
-	/** Cap on captured stdout/stderr bytes each (default 50 MB). */
+	/** Cap on captured stdout/stderr bytes each (default 50 MB). Past it the child is stopped. */
 	maxBuffer?: number;
 	/** Args are already quoted for the target (cmd.exe `/c` lines); Node must not re-quote. */
 	verbatim?: boolean;
@@ -111,7 +111,7 @@ export interface ToolRunResult {
 	/** Raw stdout for binary output (clipboard images, archives). */
 	stdoutBytes: Buffer;
 	timedOut: boolean;
-	/** Output passed `maxBuffer` and was cut. A zero exit code is then not a complete result. */
+	/** Output passed `maxBuffer`; the child was stopped and output cut. Never a complete result. */
 	truncated: boolean;
 	/** The binary that ran and where it was found. */
 	tool: ResolvedTool;
@@ -220,7 +220,11 @@ function collect(
 		let truncated = false;
 		const push = (list: Buffer[], chunk: Buffer, len: number): number => {
 			const room = cap - len;
-			if (chunk.length > room) truncated = true;
+			// Like pi.exec: stop a runaway child instead of draining output nobody keeps.
+			if (chunk.length > room) {
+				truncated = true;
+				stop();
+			}
 			if (room <= 0) return len;
 			list.push(chunk.length > room ? chunk.subarray(0, room) : chunk);
 			return len + Math.min(chunk.length, room);

package/src/os.ts

@@ -46,7 +46,7 @@ export function openCommand(
 	target: string,
 	host: HostPlatform,
 	app?: string,
-): { name: string; args: string[]; verbatim?: boolean } {
+): { name: string; args: string[]; verbatim?: boolean; cwd?: string } {
 	if (host.os === "darwin") return { name: "open", args: app ? ["-a", app, target] : [target] };
 	if (host.os === "win32") {
 		// `start` is a cmd.exe builtin; "" is its window-title argument.
@@ -54,8 +54,9 @@ export function openCommand(
 		return { name: "cmd", args: ["/d", "/s", "/c", `"${parts.join(" ")}"`], verbatim: true };
 	}
 	if (host.wsl && !app) {
-		// WSL: hand the target to Windows so the user's default browser opens.
-		return { name: "wslview", args: [target] };
+		// WSL: hand the target to Windows so the user's default browser opens. Windows programs
+		// cannot start from a long `\\wsl.localhost\...` cwd, so start from `/`.
+		return { name: "wslview", args: [target], cwd: "/" };
 	}
 	return { name: app ?? "xdg-open", args: [target] };
 }
@@ -71,6 +72,7 @@ export async function openTarget(target: string, opts: OpenOptions = {}): Promis
 	if (cmd.name === "wslview" && !resolveTool("wslview", opts))
 		cmd = openCommand(target, { ...host, wsl: false });
 	const result = await runTool(cmd.name, cmd.args, {
+		cwd: cmd.cwd,
 		env: opts.env,
 		host,
 		timeoutMs: opts.timeoutMs ?? 15_000,
@@ -140,10 +142,16 @@ export function pickPreferredMime(types: readonly string[]): string | null {
 }
 
 /** Output bytes when the tool exists and exits 0; null otherwise (probing, never throws). */
-function probe(name: string, args: string[], timeoutMs: number, opts: OsOptions): Buffer | null {
+function probe(
+	name: string,
+	args: string[],
+	timeoutMs: number,
+	opts: OsOptions,
+	cwd?: string,
+): Buffer | null {
 	if (!resolveTool(name, opts)) return null;
 	try {
-		const r = runToolSync(name, args, { env: opts.env, host: opts.host, timeoutMs });
+		const r = runToolSync(name, args, { env: opts.env, host: opts.host, timeoutMs, cwd });
 		return r.code === 0 ? r.stdoutBytes : null;
 	} catch {
 		return null;
@@ -203,7 +211,8 @@ function viaPowerShell(host: HostPlatform, opts: OsOptions): ClipboardImage | nu
 			"if ($img) { $img.Save($path, [System.Drawing.Imaging.ImageFormat]::Png); Write-Output 'ok' } else { Write-Output 'empty' }",
 		].join("; ");
 		const args = ["-NoProfile", "-STA", "-Command", script];
-		const out = probe("powershell", args, POWERSHELL_TIMEOUT_MS, opts);
+		// From WSL, Windows programs cannot start from a long `\\wsl.localhost\...` cwd.
+		const out = probe("powershell", args, POWERSHELL_TIMEOUT_MS, opts, host.wsl ? "/" : undefined);
 		if (out?.toString("utf-8").trim() !== "ok") return null;
 		const bytes = readFileSync(tmpFile);
 		return bytes.length ? { bytes, mimeType: "image/png" } : null;

package/src/pix-command.ts

@@ -42,6 +42,21 @@ function row<T>(r: SettingRow<T>): SettingRow<unknown> {
 	return r as SettingRow<unknown>;
 }
 
+/** Pi-owned theme row: not stored in pix.json, applied through `ctx.ui.setTheme`. */
+interface ThemeRow {
+	kind: "theme";
+	section: string;
+	label: string;
+	values: readonly string[];
+	current: () => string;
+}
+
+type Row = SettingRow<unknown> | ThemeRow;
+
+function isThemeRow(row: Row): row is ThemeRow {
+	return "kind" in row;
+}
+
 /** Render a token count as a compact label: 1_000_000 → "1M", 150_000 → "150k". */
 function formatTokens(tokens: number): string {
 	return tokens % 1_000_000 === 0 ? `${tokens / 1_000_000}M` : `${tokens / 1000}k`;
@@ -291,12 +306,32 @@ export function registerPixCommand(pi: ExtensionAPI, runtime: PixRuntime): void
 		if (data && typeof data === "object" && "registered" in data) data.registered = true;
 	});
 	pi.registerCommand("pix", {
-		description: "pix: open shared settings (edit pix.json)",
-		handler: async (_args: string, ctx: ExtensionCommandContext) => {
+		description: "pix: open shared settings (edit pix.json); /pix <tab> opens that tab",
+		getArgumentCompletions: (prefix: string) => {
+			const p = prefix.trim().toLowerCase();
+			const items = [...TABS, ...packageSettings(pi).map((entry) => entry.label)]
+				.map((label) => label.toLowerCase())
+				.filter((name) => name.startsWith(p))
+				.map((name) => ({ value: name, label: name }));
+			return items.length ? items : null;
+		},
+		handler: async (args: string, ctx: ExtensionCommandContext) => {
 			// Re-parse pix.json so section parsers remain the single validation source.
 			await runtime.reload({ origin: "command", source: "pix" });
 			const panels = packageSettings(pi);
 			const settings = visibleSettings(pi);
+			// Pi owns the active theme (settings.json); `/pix` only cycles it through `ctx.ui.setTheme`.
+			const themeNames = (ctx.ui.getAllThemes?.() ?? []).map((t) => t.name).sort();
+			const themeRow: ThemeRow | undefined =
+				themeNames.length > 1
+					? {
+							kind: "theme",
+							section: "Pretty",
+							label: "theme",
+							values: themeNames,
+							current: () => ctx.ui.theme.name ?? "",
+						}
+					: undefined;
 			// SAFETY: Runtime UI supports custom overlays beyond the published command context type.
 			const ui = ctx.ui as unknown as {
 				custom?: (f: unknown, opts?: unknown) => Promise<unknown>;
@@ -338,7 +373,8 @@ export function registerPixCommand(pi: ExtensionAPI, runtime: PixRuntime): void
 						),
 						...panels.map((entry) => entry.label),
 					].sort((a, b) => tabRank(a) - tabRank(b));
-					let tab = "Settings";
+					const wanted = (args ?? "").trim().toLowerCase();
+					let tab = tabs.find((name) => name.toLowerCase() === wanted) ?? "Settings";
 					let embedded:
 						| { render(width: number): string[]; handleInput(data: string): void; dispose?(): void }
 						| undefined;
@@ -429,11 +465,27 @@ export function registerPixCommand(pi: ExtensionAPI, runtime: PixRuntime): void
 						mountPanel();
 					};
 
-					const rows = () =>
-						settings.filter((r) => (r.section === "Footer") === (tab === "Footer"));
+					// `/pix <tab>` opens straight into that tab.
+					if (tab === "Binaries") binariesTab().refresh();
+					mountPanel();
+
+					const rows = (): Row[] => {
+						const list = settings.filter((r) => (r.section === "Footer") === (tab === "Footer"));
+						return tab === "Settings" && themeRow ? [themeRow, ...list] : list;
+					};
 					const cycle = (direction: -1 | 1) => {
 						const row = rows()[selected];
 						if (!row) return;
+						if (isThemeRow(row)) {
+							const cur = row.values.indexOf(row.current());
+							const start = cur === -1 && direction === -1 ? 0 : cur;
+							const next = row.values[(start + direction + row.values.length) % row.values.length];
+							const result = next ? ctx.ui.setTheme(next) : undefined;
+							if (result && !result.success)
+								ui.notify(`pix: theme ${next}: ${result.error ?? "failed"}`, "error");
+							tui.requestRender();
+							return;
+						}
 						// Functional updater: the runtime queue serializes writes, and the
 						// callback sees the latest committed value — so rapid presses each
 						// advance exactly one step instead of collapsing on a stale snapshot.
@@ -538,8 +590,8 @@ export function registerPixCommand(pi: ExtensionAPI, runtime: PixRuntime): void
 								const sel = i === selected;
 								const cursor = sel ? theme.fg("accent", "→") : " ";
 								const label = theme.fg(sel ? "accent" : "text", row.label.padEnd(labelW));
-								const value = row.read(runtime.get(row.handle));
-								const isDefault = value === row.read(row.handle.defaults);
+								const value = isThemeRow(row) ? row.current() : row.read(runtime.get(row.handle));
+								const isDefault = isThemeRow(row) || value === row.read(row.handle.defaults);
 								settingBodyLines[i] = body.length;
 								body.push(`${cursor} ${label}  ${theme.fg(isDefault ? "dim" : "success", value)}`);
 							}