@xynogen/pix-runtime 0.10.1 → 0.12.2

package/src/user-shell.ts

@@ -0,0 +1,51 @@
+/**
+ * user-shell.ts — pick the shell for user `!` commands, per OS.
+ *
+ * - Windows: PowerShell (Pi resolves pwsh 7, else powershell.exe 5.1). Pi's
+ *   default is Git Bash, which is not what a Windows user types into `!`.
+ * - POSIX: $SHELL when it is not bash. zsh also needs rc + aliases: `zsh -c`
+ *   is non-interactive and resolves aliases at parse time, so we source
+ *   .zshrc and then `eval` the command to get a fresh parse boundary.
+ */
+
+import { homeDir } from "./paths.ts";
+import { currentPlatform, type HostPlatform } from "./platform.ts";
+
+export type UserShell =
+	| { kind: "powershell"; wrap(command: string): string }
+	| { kind: "posix"; shellPath: string; wrap(command: string): string };
+
+export interface UserShellOptions {
+	host?: HostPlatform;
+	shell?: string;
+	home?: string;
+}
+
+/** Guarded: `$PSStyle` exists only in PowerShell 7.2+. Strips ANSI color from output. */
+// ponytail: duplicated from pix-powershell (Package Independence). One line, keep both in sync.
+export const PLAIN_TEXT_PREAMBLE = "if ($PSStyle) { $PSStyle.OutputRendering = 'PlainText' }\n";
+
+/** Single-quote a string for POSIX shell embedding. */
+function quote(s: string): string {
+	return `'${s.replace(/'/g, "'\\''")}'`;
+}
+
+export function userShell(opts: UserShellOptions = {}): UserShell | undefined {
+	const host = opts.host ?? currentPlatform();
+	// ponytail: no opt-out back to Git Bash on Windows. Add a pix.json knob on request.
+	if (host.os === "win32") {
+		return { kind: "powershell", wrap: (command) => `${PLAIN_TEXT_PREAMBLE}${command}` };
+	}
+	const shell = "shell" in opts ? opts.shell : process.env.SHELL;
+	if (!shell) return undefined;
+	const name = shell.split("/").pop() ?? "";
+	if (name === "bash") return undefined;
+	if (name !== "zsh") return { kind: "posix", shellPath: shell, wrap: (command) => command };
+	// ponytail: only zsh gets rc wrapping. fish/nu run with shellPath alone. Add their rc logic on request.
+	const rc = quote(`${opts.home ?? homeDir()}/.zshrc`);
+	return {
+		kind: "posix",
+		shellPath: shell,
+		wrap: (command) => `. ${rc} 2>/dev/null; eval ${quote(command)}`,
+	};
+}

package/src/which.ts

@@ -16,15 +16,24 @@
 import { accessSync, constants, statSync } from "node:fs";
 import { access, stat } from "node:fs/promises";
 import { delimiter, isAbsolute, join, sep } from "node:path";
+import { currentPlatform } from "./platform.ts";
 
-const isWindows = process.platform === "win32";
+const isWindows = currentPlatform().os === "win32";
 
 /** Windows executable extensions, from `PATHEXT` with a sane fallback. */
 function pathExtensions(env: NodeJS.ProcessEnv): string[] {
 	if (!isWindows) return [""];
 	const raw = env.PATHEXT ?? ".COM;.EXE;.BAT;.CMD";
-	// Leading "" lets an already-suffixed name (foo.exe) match as-is.
-	return ["", ...raw.split(";").filter(Boolean)];
+	// Leading "" lets an already-suffixed name (foo.exe) match as-is. Lowercased:
+	// NTFS matches either case, and the returned path should read `rtk.exe`, not
+	// `rtk.EXE`, since that is how the files are conventionally named.
+	return [
+		"",
+		...raw
+			.split(";")
+			.filter(Boolean)
+			.map((ext) => ext.toLowerCase()),
+	];
 }
 
 /** Directories to scan, from `PATH`. Windows also probes the current directory first. */
@@ -40,7 +49,15 @@ export interface FindExecutableOptions {
 }
 
 function candidatesFor(name: string, env: NodeJS.ProcessEnv): string[] {
-	const exts = pathExtensions(env);
+	let exts = pathExtensions(env);
+	// Windows cannot spawn an extensionless file (npm ships a `npm` sh script
+	// beside `npm.cmd`), so only accept the bare name when it already carries a
+	// PATHEXT extension.
+	if (isWindows) {
+		const lower = name.toLowerCase();
+		const suffixed = exts.some((ext) => ext && lower.endsWith(ext));
+		exts = suffixed ? [""] : exts.filter(Boolean);
+	}
 	const withExts = (base: string): string[] => exts.map((ext) => base + ext);
 	// A name with a separator (or absolute) is a direct path — do not scan PATH.
 	if (isAbsolute(name) || name.includes(sep) || (isWindows && name.includes("/"))) {