@xynogen/pix-pretty 1.7.18 → 1.7.19

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@xynogen/pix-pretty",
-	"version": "1.7.18",
+	"version": "1.7.19",
 	"description": "Enhanced tool output rendering with syntax highlighting, file icons, tree views, diff rendering, and FFF search",
 	"type": "module",
 	"main": "src/index.ts",

package/src/utils.test.ts

@@ -2,7 +2,7 @@ import { describe, expect, it } from "bun:test";
 
 import { MAX_PREVIEW_LINES } from "./config.js";
 import type { FgTheme } from "./types.js";
-import { pluralize, renderDimPreview } from "./utils.js";
+import { pluralize, renderDimPreview, setResultDetails } from "./utils.js";
 
 // Strip ANSI escapes so assertions test content, not color codes.
 const ANSI = /\x1b\[[0-9;]*m/g;
@@ -29,6 +29,27 @@ describe("pluralize", () => {
 	});
 });
 
+describe("setResultDetails", () => {
+	it("preserves upstream metadata while adding renderer details", () => {
+		const result = {
+			content: [{ type: "text" as const, text: "output" }],
+			details: {
+				truncation: { truncated: true, totalLines: 500 },
+				fullOutputPath: "/tmp/full.log",
+			},
+		};
+
+		setResultDetails(result, { _type: "bashResult", exitCode: 0 });
+
+		expect(result.details as Record<string, unknown>).toEqual({
+			truncation: { truncated: true, totalLines: 500 },
+			fullOutputPath: "/tmp/full.log",
+			_type: "bashResult",
+			exitCode: 0,
+		});
+	});
+});
+
 describe("renderDimPreview", () => {
 	it("renders 'done' for empty input", () => {
 		expect(plain(renderDimPreview("", theme))).toContain("done");
@@ -79,7 +100,9 @@ describe("renderDimPreview", () => {
 		expect(plain(raw)).toContain("foo bar foo");
 	});
 
-	it("does not throw on an invalid highlight regex", () => {
-		expect(() => renderDimPreview("text", theme, { highlight: "(" })).not.toThrow();
+	it("treats regex metacharacters as literal highlight text", () => {
+		const raw = renderDimPreview("call(foo)", theme, { highlight: "(" });
+		expect(plain(raw)).toContain("call(foo)");
+		expect(raw).toContain("\x1b[");
 	});
 });

package/src/utils.ts

@@ -59,21 +59,23 @@ export type DimPreviewOptions = {
 	highlight?: string;
 };
 
-function safeHighlightRegex(pattern: string): RegExp | null {
-	try {
-		return new RegExp(`(${pattern})`, "gi");
-	} catch {
-		return null;
+function dimLineWithHighlight(line: string, theme: FgTheme, pattern?: string): string {
+	if (!pattern) return theme.fg("dim", line);
+	const foldedLine = line.toLocaleLowerCase();
+	const foldedPattern = pattern.toLocaleLowerCase();
+	if (!foldedPattern) return theme.fg("dim", line);
+
+	const parts: string[] = [];
+	let start = 0;
+	for (;;) {
+		const match = foldedLine.indexOf(foldedPattern, start);
+		if (match < 0) break;
+		if (match > start) parts.push(theme.fg("dim", line.slice(start, match)));
+		parts.push(`${FG_GREEN}${BOLD}${line.slice(match, match + pattern.length)}${RST}`);
+		start = match + pattern.length;
 	}
-}
-
-function dimLineWithHighlight(line: string, theme: FgTheme, re: RegExp | null): string {
-	if (!re) return theme.fg("dim", line);
-	// split with capture group: odd indexes are matches
-	return line
-		.split(re)
-		.map((part, i) => (i % 2 ? `${FG_GREEN}${BOLD}${part}${RST}` : theme.fg("dim", part)))
-		.join("");
+	if (start < line.length) parts.push(theme.fg("dim", line.slice(start)));
+	return parts.length > 0 ? parts.join("") : theme.fg("dim", line);
 }
 
 export function renderDimPreview(
@@ -82,12 +84,12 @@ export function renderDimPreview(
 	opts: DimPreviewOptions = {},
 ): string {
 	const maxLines = opts.maxLines ?? MAX_PREVIEW_LINES;
-	const re = opts.highlight ? safeHighlightRegex(opts.highlight) : null;
+	const highlight = opts.highlight;
 	const output = normalizeLineEndings(text).trim() || "done";
 	const lines = output.split("\n");
 	const preview = lines
 		.slice(0, maxLines)
-		.map((line) => `  ${dimLineWithHighlight(line, theme, re)}`);
+		.map((line) => `  ${dimLineWithHighlight(line, theme, highlight)}`);
 	if (opts.header) preview.unshift(`  ${theme.fg("dim", opts.header)}`);
 	if (lines.length > maxLines) {
 		const more = pluralize(lines.length - maxLines, "more line");
@@ -208,8 +210,13 @@ export function getTextContent(result: ToolResultLike): string {
 	);
 }
 
+/** Add renderer metadata without discarding execution metadata from the upstream tool. */
 export function setResultDetails<T>(result: ToolResultLike, details: T): void {
-	result.details = details;
+	const upstream =
+		result.details && typeof result.details === "object"
+			? (result.details as Record<string, unknown>)
+			: undefined;
+	result.details = upstream ? { ...upstream, ...details } : details;
 }
 
 export function makeTextResult<TDetails>(