@xynogen/pix-pretty 1.18.3 → 1.18.4

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@xynogen/pix-pretty",
-	"version": "1.18.3",
+	"version": "1.18.4",
 	"description": "Enhanced tool output rendering with syntax highlighting, file icons, tree views, diff rendering, and FFF search",
 	"type": "module",
 	"main": "src/index.ts",

package/src/gate-overlay.test.ts

@@ -158,6 +158,7 @@ describe("showOverlay — confirm mode", () => {
 				title: "SSH FILE TRANSFER",
 				body: [
 					"Intent: Copy a release artifact",
+					"Command: scp app.tar.gz host:/tmp",
 					"Host: deploy@example.com",
 					"Direction: Download",
 					"From: /srv/releases/app.tar.gz",
@@ -170,6 +171,8 @@ describe("showOverlay — confirm mode", () => {
 			},
 		);
 		const joined = captured.join("\n");
+		expect(joined).toContain("<dim>Intent:</dim> <text>Copy a release artifact</text>");
+		expect(joined).toContain("<dim>Command:</dim> <dim>scp app.tar.gz host:/tmp</dim>");
 		expect(joined).toContain("<dim>Host:</dim> <accent>deploy@example.com</accent>");
 		expect(joined).toContain("<dim>Direction:</dim> <warning>Download</warning>");
 		expect(joined).toContain("<dim>From:</dim> <text>/srv/releases/app.tar.gz</text>");
@@ -178,6 +181,44 @@ describe("showOverlay — confirm mode", () => {
 		expect(joined).toContain("<dim>Auth:</dim> <success>SSH key (no password)</success>");
 	});
 
+	// Regression guard (readability fix, pix-pretty 1.18.4): Intent:/Command:
+	// lines must go through the label/value colour map — a <dim> label plus a
+	// semantic value — never a bare bright value with the label stripped off.
+	// Pre-1.18.4 they were sliced and dumped as bright <text> with no label,
+	// which was hard to read on the modal background. Command value must be <dim>.
+	test("Intent/Command body lines keep a dim label and never drop it", async () => {
+		const coloredTheme = {
+			fg: (color: string, text: string) => `<${color}>${text}</${color}>`,
+			bg: (_color: string, text: string) => text,
+			bold: (text: string) => text,
+		};
+		let captured: string[] = [];
+		await showOverlay(
+			makeUI(
+				(comp) => {
+					captured = comp.render(100);
+					comp.handleInput(ENTER);
+				},
+				undefined,
+				coloredTheme,
+			),
+			{
+				mode: "sudo",
+				title: "ROOT COMMAND REQUEST",
+				accent: "error",
+				body: ["Intent: install a package", "Command: apt install foo"],
+				timeoutMs: 0,
+			},
+		);
+		const joined = captured.join("\n");
+		// Command label + value both dim; intent value stays readable text but is
+		// always prefixed by a dim label (never a bare label-less value).
+		expect(joined).toContain("<dim>Command:</dim> <dim>apt install foo</dim>");
+		expect(joined).toContain("<dim>Intent:</dim> <text>install a package</text>");
+		// The pre-1.18.4 bug: label stripped, value dumped bright with no dim label.
+		expect(joined).not.toContain("<text>apt install foo</text>"); // command value is dim, not text
+	});
+
 	test("wraps a long body command instead of truncating it", async () => {
 		// A command far wider than any modal width — must survive in full, wrapped.
 		const longCmd = `echo ${"pix-gate-installed-or-linked ".repeat(8)}done`;

package/src/gate-overlay.ts

@@ -176,8 +176,6 @@ function buildSections(opts: {
 	const inner = width - 4; // CHROME = 2 border + 2 padding
 	const header = [theme.fg(accent, theme.bold(config.title))];
 	const body = (config.body ?? []).map((line) => {
-		if (line.startsWith("Intent:")) return theme.fg("text", line.slice(7).trimStart());
-		if (line.startsWith("Command:")) return theme.fg("text", line.slice(8).trimStart());
 		if (line.startsWith("Warning:")) return theme.fg("warning", line);
 		if (line.startsWith("(") && line.endsWith(")")) return theme.fg("muted", line);
 
@@ -186,6 +184,8 @@ function buildSections(opts: {
 		const label = line.slice(0, separator + 1);
 		const value = line.slice(separator + 1).trimStart();
 		const valueColors: Record<string, string> = {
+			"Intent:": "text",
+			"Command:": "dim",
 			"Host:": "accent",
 			"Direction:": "warning",
 			"From:": "text",