@xynogen/pix-find 0.1.13 → 0.1.15

package/README.md

@@ -8,13 +8,13 @@ Replaces Pi's default `find` tool with an enhanced version backed by `pix-pretty
 
 ## Auto-collapse
 
-After a configurable delay (default 10 seconds) the output card automatically collapses. Controlled via the `collapse` section of `~/.pi/agent/pix.json`:
+After a configurable delay (default 10 seconds), completed output collapses to a row such as `✓ find **/*.ts · 24 files`. Structured failures use a compact `✗` row after the delay. Expanding restores the existing bounded result list or exact diagnostic without restarting the elapsed timer. This is controlled via the `collapse` section of `~/.pi/agent/pix.json`:
 
 ```jsonc
 {
   "collapse": {
     "enabled": true,
-    "delayMs": 10000,
+    "delaySec": 10,
     "tools": { "find": true }
   }
 }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@xynogen/pix-find",
-	"version": "0.1.13",
+	"version": "0.1.15",
 	"description": "Pi tool — glob file search",
 	"type": "module",
 	"main": "src/index.ts",
@@ -34,7 +34,7 @@
 		"access": "public"
 	},
 	"dependencies": {
-		"@xynogen/pix-pretty": "^1.7.9",
+		"@xynogen/pix-pretty": "^1.7.20",
 		"@xynogen/pix-data": "^0.3.0"
 	},
 	"peerDependencies": {

package/src/find.test.ts

@@ -1,6 +1,11 @@
 import { describe, expect, it } from "bun:test";
 import type { CursorStore, FffState } from "@xynogen/pix-pretty/fff";
-import type { PiPrettyApi, TextComponentCtor } from "@xynogen/pix-pretty/types";
+import type {
+	PiPrettyApi,
+	RenderContextLike,
+	TextComponentCtor,
+	ThemeLike,
+} from "@xynogen/pix-pretty/types";
 import { applyFindDefaults, DEFAULT_FIND_LIMIT, registerFindTool } from "./find";
 
 class MockTextComponent {
@@ -58,4 +63,103 @@ describe("registerFindTool", () => {
 		);
 		expect(tools).toEqual(["find"]);
 	});
+
+	it("restores result paths when an elapsed card is expanded", () => {
+		const registered: { renderResult?: (...args: unknown[]) => MockTextComponent } = {};
+		const mockPi: PiPrettyApi = {
+			registerTool(tool: unknown) {
+				Object.assign(registered, tool);
+			},
+			registerCommand() {},
+			on() {},
+		};
+		registerFindTool(
+			mockPi,
+			() => ({ execute: async () => ({ content: [], details: undefined }) }),
+			{
+				cwd: process.cwd(),
+				sp: (p: string) => p,
+				TextComponent: MockTextComponent as unknown as TextComponentCtor,
+				fffState: { module: null, finder: null, partialIndex: false, dbDir: null },
+				cursorStore: { store: () => "", get: () => undefined } as unknown as CursorStore,
+			},
+		);
+		const theme: ThemeLike = {
+			fg: (_key: string, value: string) => value,
+			bold: (value: string) => value,
+		};
+		const result = registered.renderResult?.(
+			{
+				content: [{ type: "text", text: "src/one.ts\nsrc/two.ts" }],
+				details: {
+					_type: "findResult",
+					text: "src/one.ts\nsrc/two.ts",
+					pattern: "**/*.ts",
+					matchCount: 2,
+				},
+			},
+			undefined,
+			theme,
+			{
+				expanded: true,
+				isError: false,
+				invalidate: () => {},
+				state: { collapsed: true },
+			} as unknown as RenderContextLike,
+		);
+
+		expect(result?.getText()).toContain("src/one.ts");
+		expect(result?.getText()).toContain("src/two.ts");
+		expect(result?.getText()).not.toContain("2 files");
+	});
+
+	it("collapses structured errors and restores the exact diagnostic on expansion", () => {
+		const registered: { renderResult?: (...args: unknown[]) => MockTextComponent } = {};
+		const mockPi: PiPrettyApi = {
+			registerTool(tool: unknown) {
+				Object.assign(registered, tool);
+			},
+			registerCommand() {},
+			on() {},
+		};
+		registerFindTool(
+			mockPi,
+			() => ({ execute: async () => ({ content: [], details: undefined }) }),
+			{
+				cwd: process.cwd(),
+				sp: (p: string) => p,
+				TextComponent: MockTextComponent as unknown as TextComponentCtor,
+				fffState: { module: null, finder: null, partialIndex: false, dbDir: null },
+				cursorStore: { store: () => "", get: () => undefined } as unknown as CursorStore,
+			},
+		);
+		const theme: ThemeLike = {
+			fg: (_key: string, value: string) => value,
+			bold: (value: string) => value,
+		};
+		const diagnostic = "Invalid glob pattern: [";
+		const result = {
+			content: [{ type: "text", text: diagnostic }],
+			details: {
+				_type: "findResult",
+				text: diagnostic,
+				pattern: "[",
+				path: "src",
+				matchCount: 0,
+			},
+		};
+		const render = (state: Record<string, unknown>, expanded = false) =>
+			registered
+				.renderResult?.(result, { isPartial: false }, theme, {
+					expanded,
+					isError: true,
+					invalidate: () => {},
+					state,
+				} as unknown as RenderContextLike)
+				?.getText() ?? "";
+
+		expect(render({ timer: 1 })).toContain(diagnostic);
+		expect(render({ collapsed: true })).toContain("✗ find [ in src · failed");
+		expect(render({ collapsed: true }, true)).toContain(diagnostic);
+	});
 });

package/src/find.ts

@@ -18,7 +18,9 @@ import {
 	appendNotices,
 	fillToolBackground,
 	getTextContent,
+	hideCollapsedToolCall,
 	makeTextResult,
+	renderCollapsedToolRow,
 	renderDimPreview,
 	renderToolError,
 	setResultDetails,
@@ -80,6 +82,7 @@ export function registerFindTool(
 							_type: "findResult",
 							text: textContent,
 							pattern: effectiveParams.pattern,
+							path: effectiveParams.path,
 							matchCount: trimmed.length,
 						});
 					}
@@ -97,6 +100,7 @@ export function registerFindTool(
 				_type: "findResult",
 				text: textContent,
 				pattern: params.pattern,
+				path: params.path,
 				matchCount,
 			});
 
@@ -107,6 +111,12 @@ export function registerFindTool(
 			const pattern = args.pattern ?? "";
 			const path = args.path ? ` ${theme.fg("muted", `in ${sp(args.path)}`)}` : "";
 			const text = renderCtx.lastComponent ?? new TextComponent("", 0, 0);
+			if (
+				hideCollapsedToolCall(renderCtx.state as CollapseState, renderCtx.expanded, (value) =>
+					text.setText(value),
+				)
+			)
+				return text;
 			text.setText(
 				fillToolBackground(
 					`${theme.fg("toolTitle", theme.bold("find"))} ${theme.fg("accent", pattern)}${path}`,
@@ -122,19 +132,36 @@ export function registerFindTool(
 			renderCtx: RenderContextLike,
 		) {
 			const text = renderCtx.lastComponent ?? new TextComponent("", 0, 0);
+			const d = result.details;
+			const isPartial = _opt?.isPartial === true;
+			const structuredError = renderCtx.isError && d?._type === "findResult";
 
-			if (renderCtx.isError) {
+			if (renderCtx.isError && (!structuredError || isPartial)) {
 				text.setText(renderToolError(getTextContent(result) || "Error", theme));
 				return text;
 			}
 
 			// Auto-collapse: show summary line after delay
 			const cs = renderCtx.state as CollapseState;
-			if (tickCollapse("find", cs, renderCtx.invalidate)) {
-				const d = result.details;
+			if (!isPartial && tickCollapse("find", cs, renderCtx.invalidate, renderCtx.expanded)) {
 				const summary =
 					d?._type === "findResult" && d.matchCount != null ? `${d.matchCount} files` : "found";
-				text.setText(fillToolBackground(`  ${theme.fg("muted", summary)}`));
+				const target = d?._type === "findResult" ? d.pattern : "";
+				const scope = d?._type === "findResult" && d.path ? ` in ${sp(d.path)}` : "";
+				text.setText(
+					renderCollapsedToolRow(
+						theme,
+						"find",
+						`${target}${scope}`,
+						renderCtx.isError ? "failed" : summary,
+						renderCtx.isError ? "error" : "success",
+					),
+				);
+				return text;
+			}
+
+			if (renderCtx.isError) {
+				text.setText(renderToolError(getTextContent(result) || "Error", theme));
 				return text;
 			}