@xynogen/pix-find 0.1.12 → 0.1.14

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@xynogen/pix-find",
-	"version": "0.1.12",
+	"version": "0.1.14",
 	"description": "Pi tool — glob file search",
 	"type": "module",
 	"main": "src/index.ts",
@@ -34,7 +34,7 @@
 		"access": "public"
 	},
 	"dependencies": {
-		"@xynogen/pix-pretty": "^1.7.9",
+		"@xynogen/pix-pretty": "^1.7.20",
 		"@xynogen/pix-data": "^0.3.0"
 	},
 	"peerDependencies": {

package/src/find.test.ts

@@ -1,7 +1,7 @@
 import { describe, expect, it } from "bun:test";
 import type { CursorStore, FffState } from "@xynogen/pix-pretty/fff";
 import type { PiPrettyApi, TextComponentCtor } from "@xynogen/pix-pretty/types";
-import { registerFindTool } from "./find";
+import { applyFindDefaults, DEFAULT_FIND_LIMIT, registerFindTool } from "./find";
 
 class MockTextComponent {
 	private text = "";
@@ -13,6 +13,19 @@ class MockTextComponent {
 	}
 }
 
+describe("applyFindDefaults", () => {
+	it("applies a conservative default without overriding an explicit limit", () => {
+		expect(applyFindDefaults({ pattern: "**/*.ts" })).toEqual({
+			pattern: "**/*.ts",
+			limit: DEFAULT_FIND_LIMIT,
+		});
+		expect(applyFindDefaults({ pattern: "**/*.ts", limit: 8 })).toEqual({
+			pattern: "**/*.ts",
+			limit: 8,
+		});
+	});
+});
+
 describe("registerFindTool", () => {
 	it("registers a tool named 'find'", () => {
 		const tools: string[] = [];

package/src/find.ts

@@ -18,12 +18,20 @@ import {
 	appendNotices,
 	fillToolBackground,
 	getTextContent,
+	hideCollapsedToolCall,
 	makeTextResult,
+	renderCollapsedToolRow,
 	renderDimPreview,
 	renderToolError,
 	setResultDetails,
 } from "@xynogen/pix-pretty/utils";
 
+export const DEFAULT_FIND_LIMIT = 200;
+
+export function applyFindDefaults(params: FindParams): FindParams {
+	return params.limit === undefined ? { ...params, limit: DEFAULT_FIND_LIMIT } : params;
+}
+
 export function registerFindTool(
 	pi: PiPrettyApi,
 	createFindTool: ToolFactory<FindToolInput>,
@@ -35,6 +43,8 @@ export function registerFindTool(
 	pi.registerTool({
 		...origFind,
 		name: "find",
+		description:
+			"Find files by glob pattern. Defaults to 200 paths; use limit to request more. Respects .gitignore and remains capped by Pi's 50KB hard limit.",
 		renderShell: "self",
 
 		async execute(
@@ -44,12 +54,14 @@ export function registerFindTool(
 			upd: unknown,
 			toolCtx: ExtensionContext,
 		) {
+			const effectiveParams = applyFindDefaults(params);
+
 			// Try FFF first (frecency-ranked, SIMD-accelerated)
 			if (fffState.finder && !fffState.finder.isDestroyed) {
 				try {
-					const effectiveLimit = Math.max(1, params.limit ?? 200);
-					let query = params.pattern;
-					if (params.path) query = `${params.path} ${query}`;
+					const effectiveLimit = Math.max(1, effectiveParams.limit ?? DEFAULT_FIND_LIMIT);
+					let query = effectiveParams.pattern;
+					if (effectiveParams.path) query = `${effectiveParams.path} ${query}`;
 
 					const searchResult = fffState.finder.fileSearch(query, {
 						pageSize: effectiveLimit,
@@ -69,7 +81,8 @@ export function registerFindTool(
 						return makeTextResult<FindResultDetails>(textContent, {
 							_type: "findResult",
 							text: textContent,
-							pattern: params.pattern,
+							pattern: effectiveParams.pattern,
+							path: effectiveParams.path,
 							matchCount: trimmed.length,
 						});
 					}
@@ -79,7 +92,7 @@ export function registerFindTool(
 			}
 
 			// SDK fallback
-			const result = await origFind.execute(tid, params, sig, upd as never, toolCtx);
+			const result = await origFind.execute(tid, effectiveParams, sig, upd as never, toolCtx);
 			const textContent = getTextContent(result);
 			const matchCount = textContent ? textContent.trim().split("\n").filter(Boolean).length : 0;
 
@@ -87,6 +100,7 @@ export function registerFindTool(
 				_type: "findResult",
 				text: textContent,
 				pattern: params.pattern,
+				path: params.path,
 				matchCount,
 			});
 
@@ -97,6 +111,12 @@ export function registerFindTool(
 			const pattern = args.pattern ?? "";
 			const path = args.path ? ` ${theme.fg("muted", `in ${sp(args.path)}`)}` : "";
 			const text = renderCtx.lastComponent ?? new TextComponent("", 0, 0);
+			if (
+				hideCollapsedToolCall(renderCtx.state as CollapseState, renderCtx.expanded, (value) =>
+					text.setText(value),
+				)
+			)
+				return text;
 			text.setText(
 				fillToolBackground(
 					`${theme.fg("toolTitle", theme.bold("find"))} ${theme.fg("accent", pattern)}${path}`,
@@ -124,7 +144,9 @@ export function registerFindTool(
 				const d = result.details;
 				const summary =
 					d?._type === "findResult" && d.matchCount != null ? `${d.matchCount} files` : "found";
-				text.setText(fillToolBackground(`  ${theme.fg("muted", summary)}`));
+				const target = d?._type === "findResult" ? d.pattern : "";
+				const scope = d?._type === "findResult" && d.path ? ` in ${sp(d.path)}` : "";
+				text.setText(renderCollapsedToolRow(theme, "find", `${target}${scope}`, summary));
 				return text;
 			}