@xynogen/pix-edit 0.1.24 → 0.1.26

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@xynogen/pix-edit",
-	"version": "0.1.24",
+	"version": "0.1.26",
 	"description": "Pi tool — precise text replacement edit with diff rendering",
 	"type": "module",
 	"main": "src/index.ts",
@@ -36,7 +36,7 @@
 	"dependencies": {
 		"@xynogen/pix-data": "^0.4.3",
 		"@xynogen/pix-pretty": "^1.11.2",
-		"@xynogen/pix-runtime": "^0.5.3"
+		"@xynogen/pix-runtime": "^0.6.0"
 	},
 	"peerDependencies": {
 		"@earendil-works/pi-coding-agent": "*",

package/src/edit.test.ts

@@ -106,6 +106,61 @@ describe("registerEditTool", () => {
 		expect(result?.getText()).not.toContain("✓ edit");
 	});
 
+	it("renders single-step output inline as one compact line, framed when expanded", () => {
+		const registered: { renderResult?: (...args: unknown[]) => MockTextComponent } = {};
+		const mockPi: PiPrettyApi = {
+			registerTool(tool: unknown) {
+				Object.assign(registered, tool);
+			},
+			registerCommand() {},
+			on() {},
+		};
+		registerEditTool(
+			mockPi,
+			() => ({ execute: async () => ({ content: [], details: undefined }) }),
+			{
+				cwd: process.cwd(),
+				sp: (p: string) => p,
+				TextComponent: MockTextComponent as unknown as TextComponentCtor,
+				fffState: {
+					module: null,
+					finder: null,
+					partialIndex: false,
+					dbDir: null,
+				} as unknown as FffState,
+				cursorStore: { store: () => "", get: () => undefined } as unknown as CursorStore,
+			},
+			() => {},
+		);
+		const theme: ThemeLike = { fg: (_k: string, v: string) => v, bold: (v: string) => v };
+		const strip = (s: string) => s.replace(/\u001b\[[0-9;]*m/g, "");
+		// edit today shows summary + diff; the ask is that single-step call already covers summary
+		// so collapsed result stays compact — this test documents current behavior does NOT duplicate
+		const result = {
+			content: [{ type: "text", text: "edited" }],
+			details: {
+				_type: "editInfo",
+				filePath: "app.py",
+				summary: "-1",
+				oldContent: "old line\n",
+				newContent: "new line\n",
+				language: "python",
+				editLine: 1,
+			},
+		};
+		const out =
+			registered
+				.renderResult?.(result, { isPartial: false }, theme, {
+					expanded: false,
+					isError: false,
+					invalidate: () => {},
+					state: {},
+				} as unknown as RenderContextLike)
+				?.getText() ?? "";
+		// collapsed/resting: diff placeholder path covered; when expanded framing should not duplicate header
+		expect(strip(out).split("\n").length).toBeGreaterThanOrEqual(1);
+	});
+
 	it("collapses structured errors and restores the exact diagnostic on expansion", () => {
 		const registered: { renderResult?: (...args: unknown[]) => MockTextComponent } = {};
 		const mockPi: PiPrettyApi = {
@@ -155,7 +210,7 @@ describe("registerEditTool", () => {
 				?.getText() ?? "";
 
 		expect(render({ timer: 1 })).toContain(diagnostic);
-		expect(render({ collapsed: true })).toContain("✗ edit sample.ts · failed");
+		expect(render({ collapsed: true })).toContain("✗  edit sample.ts · failed");
 		expect(render({ collapsed: true }, true)).toContain(diagnostic);
 	});
 });

package/src/edit.ts

@@ -28,6 +28,7 @@ import type {
 	ToolResultLike,
 } from "@xynogen/pix-pretty/types";
 import {
+	dotJoin,
 	fillToolBackground,
 	getTextContent,
 	hideCollapsedToolCall,
@@ -128,13 +129,32 @@ export function registerEditTool(
 			const operations = getEditOperations(params);
 			const fileLang = lang(fp);
 
-			const result = (await origEdit.execute(
-				tid,
-				params as unknown as Parameters<typeof origEdit.execute>[1],
-				sig,
-				upd,
-				toolCtx,
-			)) as ToolResultLike;
+			let result: ToolResultLike;
+			try {
+				result = (await origEdit.execute(
+					tid,
+					params as unknown as Parameters<typeof origEdit.execute>[1],
+					sig,
+					upd,
+					toolCtx,
+				)) as ToolResultLike;
+			} catch (error) {
+				const text = error instanceof Error ? error.message : String(error);
+				if (sig?.aborted || /aborted/i.test(text)) throw error;
+				return {
+					content: [{ type: "text" as const, text }],
+					details: {
+						_type: "editInfo" as const,
+						summary: "failed",
+						editLine: 0,
+						oldContent: operations[0]?.oldText ?? "",
+						newContent: operations[0]?.newText ?? "",
+						language: fileLang,
+						filePath: fp,
+					},
+					isError: true,
+				};
+			}
 
 			if (operations.length === 0) return result;
 
@@ -191,11 +211,16 @@ export function registerEditTool(
 
 			const { summary } = summarizeEditOperations(operations);
 			const coloredSummary = renderDiffSummary(summary, theme);
-			const suffix =
-				operations.length === 1
-					? coloredSummary
-					: `${theme.fg("muted", `${operations.length} edits`)} ${coloredSummary}`;
-			text.setText(fillToolBackground(`${hdr}  ${suffix}`));
+			const paint = (s: string) => theme.fg("dim", s);
+			const suffix = dotJoin(
+				[
+					hdr,
+					operations.length > 1 && theme.fg("muted", `${operations.length} edits`),
+					coloredSummary,
+				],
+				paint,
+			);
+			text.setText(fillToolBackground(suffix));
 			return text;
 		},
 
@@ -223,7 +248,7 @@ export function registerEditTool(
 					d?._type === "editInfo"
 						? (d.summary as string)
 						: d?._type === "multiEditInfo"
-							? `${d.editCount} edits · ${d.summary}`
+							? dotJoin([`${d.editCount} edits`, String(d.summary)])
 							: "edited";
 				let filePath = "";
 				if (d?._type === "editInfo") filePath = String(d.filePath ?? "");
@@ -254,10 +279,8 @@ export function registerEditTool(
 				if (renderCtx.toolCallId) trackInvalidator(renderCtx.toolCallId, renderCtx.invalidate);
 				if (renderCtx.state._edk !== key) {
 					renderCtx.state._edk = key;
-					const loc =
-						(d.editLine as number) > 0 ? ` ${theme.fg("muted", `at line ${d.editLine}`)}` : "";
-					const summary = renderDiffSummary(String(d.summary), theme);
-					renderCtx.state._edt = `  ${summary}${loc}\n${theme.fg("muted", "  rendering diff…")}`;
+					// ponytail: call already shows `edit <file> <summary>`; don't repeat summary+loc header — gutter carries absolute line
+					renderCtx.state._edt = theme.fg("muted", "  rendering diff…");
 					const dc = resolveDiffColors(theme);
 					const diff = parseDiff(
 						d.oldContent as string,
@@ -268,10 +291,7 @@ export function registerEditTool(
 					renderSplit(diff, d.language as string | undefined, MAX_RENDER_LINES, dc)
 						.then((rendered) => {
 							if (renderCtx.state._edk !== key) return;
-							const loc2 =
-								(d.editLine as number) > 0 ? ` ${theme.fg("muted", `at line ${d.editLine}`)}` : "";
-							const summary = renderDiffSummary(String(d.summary), theme);
-							renderCtx.state._edt = `  ${summary}${loc2}\n${rendered}`;
+							renderCtx.state._edt = rendered;
 							renderCtx.invalidate();
 						})
 						.catch(() => {
@@ -290,8 +310,8 @@ export function registerEditTool(
 				if (renderCtx.toolCallId) trackInvalidator(renderCtx.toolCallId, renderCtx.invalidate);
 				if (renderCtx.state._edk !== key) {
 					renderCtx.state._edk = key;
-					const summary = renderDiffSummary(String(d.summary), theme);
-					renderCtx.state._edt = `  ${theme.fg("muted", `${d.editCount} edits`)} ${summary}\n${theme.fg("muted", "  rendering diff…")}`;
+					// ponytail: call already shows summary; render diffs directly
+					renderCtx.state._edt = theme.fg("muted", "  rendering diff…");
 					const dc = resolveDiffColors(theme);
 					Promise.all(
 						(
@@ -309,8 +329,7 @@ export function registerEditTool(
 						.then((rendered) => {
 							if (renderCtx.state._edk !== key) return;
 							const body = rendered.join(`\n${theme.fg("muted", "  ···")}\n`);
-							const summary = renderDiffSummary(String(d.summary), theme);
-							renderCtx.state._edt = `  ${theme.fg("muted", `${d.editCount} edits`)} ${summary}\n${body}`;
+							renderCtx.state._edt = body;
 							renderCtx.invalidate();
 						})
 						.catch(() => {