@xuda.io/account_module 1.2.2310 → 1.2.2311

package/index.mjs

@@ -3535,6 +3535,7 @@ export const get_account_name = async function (req) {
       active_account_profile_id,
       network_country_code,
       public_profile_disabled,
+      verify_level,
     } = data.data.account_info;
 
     obj = {
@@ -3570,6 +3571,11 @@ export const get_account_name = async function (req) {
       // email,// email?.[0] || '',
       avatar_source,
       active_account_profile_id,
+      // The verification level of the account behind a card. Every caller that
+      // builds a contact card off another account copies this onto the card doc
+      // so the background tile can say what the level is; without it a card for
+      // a verified person read as L0, which is a false statement about them.
+      verify_level,
     };
   }
   return { code: 1, data: obj }; //is_online: data?.data?.socket_id ? true : false
@@ -4305,6 +4311,13 @@ const level_pattern = function (doc) {
   return `level-${level}-pattern.png`;
 };
 
+// The level tile is the DEFAULT for every contact card, not a fallback. It used
+// to be computed first and then overwritten by a tile keyed off where the
+// contact came from (xu / authentic / fictional / email / web), so a card for a
+// verified person showed the generic XU tile and the level never appeared on any
+// card that had a contact_uid, which is every card for a real account. Only the
+// states that say the card cannot show a level at all still win: a shared card
+// wears its owner's avatar, an avatar being processed says so, and spam says so.
 const get_contact_pattern = async function (doc) {
   let ret = level_pattern(doc);
 
@@ -4325,84 +4338,12 @@ const get_contact_pattern = async function (doc) {
     }
   } else if (doc.is_spam) {
     ret = `spam-pattern.png`;
-  } else {
-    // if (doc.account_type === 'business') {
-    //   // if (doc?.is_real_person) {
-    //   ret = doc.profile_picture;
-    //   // }
-    // } else {
-    // if (doc.my_contact) {
-    //   if (doc.account_type === 'business') {
-    //     ret = doc.profile_picture;
-    //   } else {
-    //     switch (doc.avatar_source) {
-    //       case 'fictional':
-    //         ret = `fictional-avatar-pattern.png`;
-    //         break;
-
-    //       case 'ai profile':
-    //         ret = `fictional-avatar-pattern.png`;
-    //         break;
-
-    //       case 'authentic profile':
-    //         ret = `authentic-avatar-pattern.png`;
-    //         break;
-
-    //       default:
-    //         ret = `xu-pattern.png`;
-    //         break;
-    //     }
-    //   }
-    // } else
-
-    // if (doc?.shared_from_uid) {
-    //   //&& (doc.pending || (doc.team_req_id && doc.contact_share_copy))) {
-    //   // pending or active share request
-    //   const shared_from_uid_ret = await get_account_name({ uid_query: doc.shared_from_uid });
-    //   ret = shared_from_uid_ret.data.profile_avatar;
-    // }
-
-    // else if (doc?.reference_doc?.shared_from_uid) {
-    //   //active share
-    //   const shared_from_uid_ret = await get_account_name({ uid_query: doc.reference_doc.shared_from_uid });
-    //   ret = shared_from_uid_ret.data.profile_avatar;
-    // }
-    // else
-    if (doc.contact_uid) {
-      switch (doc.avatar_source) {
-        case 'fictional':
-          ret = `fictional-avatar-pattern.png`;
-          break;
-
-        case 'ai profile':
-          ret = `fictional-avatar-pattern.png`;
-          break;
-
-        case 'authentic profile':
-          ret = `authentic-avatar-pattern.png`;
-          break;
-
-        default:
-          ret = `xu-pattern.png`;
-          break;
-      }
-    } else {
-      switch (doc.source) {
-        case 'read emails': {
-          ret = `email-pattern.png`;
-          break;
-        }
-        case 'web': {
-          ret = `web-pattern.png`;
-          break;
-        }
-
-        default:
-          break;
-      }
-    }
-    // }
   }
+  // Everything else keeps the level tile. The old where-it-came-from tiles
+  // (xu / authentic / fictional for an account, email / web for a scraped
+  // contact) are gone on purpose: they occupied the one surface that now
+  // carries the verification level, and a contact with no account behind it
+  // has no level to show, which is exactly what L0 says.
   return ret;
 };
 
@@ -4570,6 +4511,10 @@ export const get_contact_info = async function (uid, contact_doc, _id) {
       }
 
       doc.avatar_source = account_info_ret.data.avatar_source;
+      // The card's background tile is the contact's verification level, and the
+      // level lives on the account, not on my copy of them. Carry it over here,
+      // where the account is already in hand, so the tile costs no extra read.
+      doc.verify_level = account_info_ret.data.verify_level;
       // doc.icon_pattern = await get_contact_pattern(doc);
       doc.username = account_info_ret.data.username;
       doc.business_name = account_info_ret.data.business_name;
@@ -4634,6 +4579,7 @@ export const get_pending_contact_out = async function (uid, _id) {
       doc.account_type = account_info_ret.data.account_type;
       doc.avatar_source = account_info_ret.data.avatar_source;
       doc.profile_avatar = account_info_ret.data.profile_avatar;
+      doc.verify_level = account_info_ret.data.verify_level;
       doc.name = `${account_info_ret.data.first_name} ${account_info_ret.data.last_name}`;
     }
     doc.icon_pattern = await get_contact_pattern(doc);
@@ -4665,6 +4611,7 @@ export const get_pending_contact_in = async function (uid, _id) {
       doc.account_type = account_info_ret.data.account_type;
       doc.avatar_source = account_info_ret.data.avatar_source;
       doc.profile_avatar = account_info_ret.data.profile_avatar;
+      doc.verify_level = account_info_ret.data.verify_level;
       doc.name = `${account_info_ret.data.first_name} ${account_info_ret.data.last_name}`;
     }
     doc.card_background = get_contact_background({ pending: true });
@@ -4704,6 +4651,7 @@ const get_user_contact = async function (uid, uid_query) {
   doc.profile_avatar = account_info.profile_avatar;
   doc.profile_picture = account_info.profile_picture;
   doc.avatar_source = account_info.avatar_source;
+  doc.verify_level = account_info.verify_level;
   doc.card_background = get_contact_background(doc);
   doc.icon_pattern = await get_contact_pattern(doc);
   doc.border = get_contact_border(doc);
@@ -5618,28 +5566,18 @@ setTimeout(async () => {
 
 //////// CONTACTS  //////////////
 
-function identifyPersonalProvider(domain) {
-  const providers = {
-    'gmail.com': 'Google Gmail',
-    'googlemail.com': 'Google Gmail',
-    'outlook.com': 'Microsoft Outlook',
-    'hotmail.com': 'Microsoft Hotmail',
-    'live.com': 'Microsoft Live',
-    'yahoo.com': 'Yahoo Mail',
-    'ymail.com': 'Yahoo Mail',
-    'aol.com': 'AOL Mail',
-    'icloud.com': 'Apple iCloud',
-    'me.com': 'Apple iCloud',
-    'mac.com': 'Apple iCloud',
-    'protonmail.com': 'ProtonMail',
-    'proton.me': 'ProtonMail',
-    'zoho.com': 'Zoho Mail',
-    'yandex.com': 'Yandex Mail',
-    'mail.com': 'Mail.com',
-    'gmx.com': 'GMX Mail',
-  };
+// A "business" that resolves to the address's own mail provider is not the contact's
+// employer, it is Gmail. get_business_info, handed a bare gmail.com address, answers
+// "Gmail / gmail.com / Technology" rather than "Not available", so the only escape hatch the
+// classification had (business_name === 'Not available') never fired and every personal
+// Gmail contact came out as a business, storefront placeholder and all. This is the second
+// escape hatch, built on the provider list that already exists directly below.
+const businessIsJustTheMailProvider = (business_info) => !!identifyPersonalProvider(business_info?.business_domain || '');
 
-  return providers[domain.toLowerCase()];
+function identifyPersonalProvider(domain) {
+  // The list moved to common so ai_module's contact classifier reads the same one. It used to
+  // live here alone, which is exactly why the classifier could call gmail.com a business.
+  return _common.personal_email_provider(domain);
 }
 
 export const add_contact = async function (req, job_id, headers) {
@@ -5714,21 +5652,24 @@ export const add_contact = async function (req, job_id, headers) {
           await activity('spam_check', { by: 'ai', is_spam: !!is_spam, subject: metadata.subject });
         }
         if (!is_spam) {
-          const is_business = await ai_ms.is_business_contact(uid, email, name, metadata.subject, metadata.summarized_body, account_profile_info);
+          const verdict = await ai_ms.is_business_contact(uid, email, name, metadata.subject, metadata.summarized_body, account_profile_info);
+          // Tolerates the old bare boolean, in case a stale ai_module answers this call.
+          const is_business = typeof verdict === 'object' && verdict !== null ? verdict.is_business : !!verdict;
           account_type = is_business ? 'business' : 'personal';
-          await activity('classified', { by: 'ai', account_type, inputs: { email: email.toLowerCase(), name: name || '', subject: metadata.subject || '' } });
+          await activity('classified', { by: 'ai', account_type, confidence: verdict?.confidence, why: verdict?.reason, inputs: { email: email.toLowerCase(), name: name || '', subject: metadata.subject || '' } });
           if (is_business) {
             business_info = await ai_ms.get_business_info(uid, '', email, account_profile_info, { light: true });
-            if (business_info.business_name !== 'Not available') {
+            if (business_info.business_name !== 'Not available' && !businessIsJustTheMailProvider(business_info)) {
               await activity('business_info', { by: 'ai', depth: 'light', business_name: business_info.business_name, business_domain: business_info.business_domain, business_category: business_info.business_category });
               business_has_person = await ai_ms.is_business_contact_has_person(uid, email, name, metadata.subject, metadata.summarized_body, account_profile_info);
               await activity('business_has_person', { by: 'ai', has_person: !!business_has_person });
             } else {
+              const provider = identifyPersonalProvider(business_info?.business_domain || '');
               account_type = 'personal';
               business_info = undefined;
               // The reversal matters more than the original verdict: the card says
               // personal even though the business call answered yes.
-              await activity('classified', { by: 'ai', account_type, reverted_from: 'business', reason: 'no business could be identified behind the address' });
+              await activity('classified', { by: 'ai', account_type, reverted_from: 'business', reason: provider ? `the only business behind the address is its mail provider (${provider})` : 'no business could be identified behind the address' });
             }
           }
           if (_.isEmpty(cached_contact) && account_type === 'business' && !business_has_person) {
@@ -6372,19 +6313,31 @@ export const not_spam_contact = async function (req, job_id, headers) {
     }
 
     const previous_account_type = contact_doc.account_type;
-    const is_business = await ai_ms.is_business_contact(uid, contact_doc.email, contact_doc.name, contact_doc?.metadata?.subject, contact_doc?.metadata?.summarized_body, account_profile_info);
+    const verdict = await ai_ms.is_business_contact(uid, contact_doc.email, contact_doc.name, contact_doc?.metadata?.subject, contact_doc?.metadata?.summarized_body, account_profile_info);
+    const is_business = typeof verdict === 'object' && verdict !== null ? verdict.is_business : !!verdict;
     contact_doc.account_type = is_business ? 'business' : 'personal';
-    await log_contact_activity(uid, contact_id, 'classified', { by: 'ai', trigger: 'not spam', account_type: contact_doc.account_type, previous_account_type: previous_account_type || 'unset' });
+    await log_contact_activity(uid, contact_id, 'classified', { by: 'ai', trigger: 'not spam', account_type: contact_doc.account_type, confidence: verdict?.confidence, why: verdict?.reason, previous_account_type: previous_account_type || 'unset' });
+    if (!is_business && (contact_doc.business_info || contact_doc.business_has_person)) {
+      // A contact that reclassifies from business to person used to keep the company profile
+      // the old verdict attached to it, because business_info is only ever written inside the
+      // is_business branch and nothing clears it on the way out. The card then showed a person
+      // with a company still on file.
+      const dropped = contact_doc?.business_info?.business_name;
+      contact_doc.business_info = undefined;
+      contact_doc.business_has_person = undefined;
+      await log_contact_activity(uid, contact_id, 'business_info_cleared', { reason: 'contact reclassified as a person', dropped });
+    }
     if (is_business) {
       contact_doc.business_info = await ai_ms.get_business_info(uid, '', contact_doc.email, account_profile_info, { light: true });
-      if (contact_doc.business_info.business_name !== 'Not available') {
+      if (contact_doc.business_info.business_name !== 'Not available' && !businessIsJustTheMailProvider(contact_doc.business_info)) {
         await log_contact_activity(uid, contact_id, 'business_info', { by: 'ai', depth: 'light', business_name: contact_doc.business_info.business_name, business_domain: contact_doc.business_info.business_domain, business_category: contact_doc.business_info.business_category });
         contact_doc.business_has_person = await ai_ms.is_business_contact_has_person(uid, contact_doc.email, contact_doc.name, contact_doc?.metadata?.subject, contact_doc?.metadata?.summarized_body, account_profile_info);
         await log_contact_activity(uid, contact_id, 'business_has_person', { by: 'ai', has_person: !!contact_doc.business_has_person });
       } else {
+        const provider = identifyPersonalProvider(contact_doc.business_info?.business_domain || '');
         contact_doc.account_type = 'personal';
         contact_doc.business_info = undefined;
-        await log_contact_activity(uid, contact_id, 'classified', { by: 'ai', account_type: 'personal', reverted_from: 'business', reason: 'no business could be identified behind the address' });
+        await log_contact_activity(uid, contact_id, 'classified', { by: 'ai', account_type: 'personal', reverted_from: 'business', reason: provider ? `the only business behind the address is its mail provider (${provider})` : 'no business could be identified behind the address' });
       }
     }
 
@@ -6471,14 +6424,15 @@ export const set_deep_research_contact = async function (req, job_id, headers) {
 
     if (contact_doc.account_type === 'business') {
       contact_doc.business_info = await ai_ms.get_business_info(uid, '', contact_doc.email, account_profile_info);
-      if (contact_doc.business_info.business_name !== 'Not available') {
+      if (contact_doc.business_info.business_name !== 'Not available' && !businessIsJustTheMailProvider(contact_doc.business_info)) {
         await log_contact_activity(uid, contact_id, 'business_info', { by: 'ai', depth: 'deep', business_name: contact_doc.business_info.business_name, business_domain: contact_doc.business_info.business_domain, business_category: contact_doc.business_info.business_category });
         contact_doc.business_has_person = await ai_ms.is_business_contact_has_person(uid, contact_doc.email, contact_doc.name, contact_doc?.metadata?.subject, contact_doc?.metadata?.summarized_body, account_profile_info);
         await log_contact_activity(uid, contact_id, 'business_has_person', { by: 'ai', has_person: !!contact_doc.business_has_person });
       } else {
+        const provider = identifyPersonalProvider(contact_doc.business_info?.business_domain || '');
         contact_doc.account_type = 'personal';
         contact_doc.business_info = undefined;
-        await log_contact_activity(uid, contact_id, 'classified', { by: 'ai', account_type: 'personal', reverted_from: 'business', reason: 'deep research found no business behind the address' });
+        await log_contact_activity(uid, contact_id, 'classified', { by: 'ai', account_type: 'personal', reverted_from: 'business', reason: provider ? `the only business behind the address is its mail provider (${provider})` : 'deep research found no business behind the address' });
       }
     }
 
@@ -6568,7 +6522,16 @@ export const get_contact_activity = async function (req) {
   try {
     if (!contact_id) throw new Error('contact_id is missing');
     const account_profile_info = await get_active_account_profile_info(uid);
-    const contact_doc = await db_module.get_app_couch_doc_native(account_profile_info.app_id, contact_id);
+    // get_app_couch_doc_native THROWS a bare couch 'missing' for an id that is not in
+    // this account's app db (an id from another account is the common way to get here),
+    // so the not-found check below never ran and the caller saw "missing" with nothing
+    // to act on. Catch it and answer the question that was actually asked.
+    let contact_doc;
+    try {
+      contact_doc = await db_module.get_app_couch_doc_native(account_profile_info.app_id, contact_id);
+    } catch (_) {
+      contact_doc = null;
+    }
     if (!contact_doc || contact_doc.docType !== 'contact') throw new Error(`contact ${contact_id} not found`);
     if (contact_doc.uid !== uid && contact_doc?.uid_created !== uid) throw new Error('Operation not allowed');
 
@@ -6688,7 +6651,11 @@ export const get_account_profile_info = async function (uid, contact_profile_doc
 
   const get_pattern = async function (doc) {
     // Same level-based default as get_contact_pattern, so a card shows the same
-    // verification tile whichever path built it.
+    // verification tile whichever path built it, and the same two states that
+    // outrank a level: a shared profile wears its owner's avatar, spam says
+    // spam. A business profile used to paint its own logo across the card face,
+    // which is why a verified business showed no level at all; the logo is
+    // already the avatar on the same card, so the tile is the level here too.
     let ret = level_pattern(doc);
 
     if (doc.shared_from_uid) {
@@ -6697,26 +6664,6 @@ export const get_account_profile_info = async function (uid, contact_profile_doc
       ret = shared_from_uid_ret.data.profile_avatar;
     } else if (doc.is_spam) {
       ret = `spam-pattern.png`;
-    } else if (doc.account_type === 'business') {
-      ret = doc.profile_picture;
-    } else {
-      switch (doc.avatar_source) {
-        case 'fictional':
-          ret = `fictional-avatar-pattern.png`;
-          break;
-
-        case 'ai profile':
-          ret = `fictional-avatar-pattern.png`;
-          break;
-
-        case 'authentic profile':
-          ret = `authentic-avatar-pattern.png`;
-          break;
-
-        default:
-          ret = `xu-pattern.png`;
-          break;
-      }
     }
 
     return ret;
@@ -6774,6 +6721,10 @@ export const get_account_profile_info = async function (uid, contact_profile_doc
   // console.log(stringToColour('Project Z')); // -> Consistent color for "Project Z"
 
   doc.avatar_source = account_info_ret.data.avatar_source;
+  // A profile inherits the verification level of the account that owns it (a
+  // shared profile, the account that shared it), so its card reads the same
+  // level as its owner's contact card instead of falling back to L0.
+  doc.verify_level = account_info_ret.data.verify_level;
   doc.icon_pattern = await get_pattern(doc);
   doc.name = doc.profile_name;
   doc.interactions = 0;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xuda.io/account_module",
-  "version": "1.2.2310",
+  "version": "1.2.2311",
   "description": "Xuda Account Server Module",
   "main": "index.mjs",
   "dependencies": {