@xuda.io/account_module 1.2.2303 → 1.2.2304

package/index.mjs

@@ -1678,6 +1678,10 @@ export const get_account_data = async function (req) {
     // one-shot notice at suspension time can be missed or predate this). Best-
     // effort + fire-and-forget; only touches the DB for the rare suspended account.
     if (acc_obj.account_email_bounce_suspended) _ensure_bounce_suspension_banner(acc_obj);
+    // UI-82: same treatment for the billing hold. Called on every load, not
+    // only when the hold is on, because this is also what retires the banner
+    // once the hold is lifted.
+    _ensure_billing_hold_banner(acc_obj);
 
     return ret;
   } catch (err) {
@@ -4887,6 +4891,61 @@ const _notify_bounce_suspended = async (account) => {
 // can be missed or predate this; get_account_data calls this on every load.
 // Idempotent + banner-only: bails if a persistent (app_id '') banner already
 // exists, so it never duplicates the doc or re-sends the SMS.
+// The billing-hold band, as a notification instead of a hardcoded strip in the
+// dashboard shell (UI-82). Driven by account state on every load rather than
+// hooked onto the four places that flip the flag (ops apply, ops release, and
+// both Stripe webhook paths), because a state check cannot drift out of sync
+// with the flag the way four call sites can. Raises the banner while the hold
+// is on, retires it when the hold lifts.
+const _ensure_billing_hold_banner = async (account) => {
+  try {
+    const uid = account._id;
+    const on = account.account_billing_hold_status === 1;
+    const ret = await db_module.find_couch_query('xuda_notification', {
+      selector: { docType: 'notification', uid, topic: 'account_billing_hold', delivery_method: 'banner', read: false },
+    });
+    const docs = ret?.docs || [];
+
+    if (!on) {
+      // Hold lifted: retire whatever is on screen. Same read + stat 4 the
+      // bounce banner uses for its duplicates, so the notification centre
+      // treats it as handled rather than leaving a stale warning up.
+      for (const doc of docs) {
+        doc.read = true;
+        doc.stat = 4;
+        doc.stat_ts = Date.now();
+        await db_module.save_couch_doc('xuda_notification', doc).catch(() => {});
+      }
+      return;
+    }
+
+    // Same de-duplication as the bounce banner: find-then-create is not atomic
+    // and the index lags a fresh doc, so concurrent loads can both create one.
+    if (docs.length) {
+      docs.sort((a, b) => (b.date_created_ts || 0) - (a.date_created_ts || 0));
+      for (let i = 1; i < docs.length; i++) {
+        docs[i].read = true;
+        docs[i].stat = 4;
+        docs[i].stat_ts = Date.now();
+        await db_module.save_couch_doc('xuda_notification', docs[i]).catch(() => {});
+      }
+      return;
+    }
+
+    const host = _conf.is_debug ? process.env.XUDA_HOSTNAME || _conf.domain : _conf.domain;
+    await notification_msa.submit_notification({
+      type: 'account',
+      app_id: null,
+      to_app_id: '',
+      uid_arr: [uid],
+      topic: 'account_billing_hold',
+      params: { action_label: 'Review billing', action_href: `https://${host}/dashboard/settings/billing` },
+    });
+  } catch (e) {
+    console.error('ensure billing hold banner failed:', e.message);
+  }
+};
+
 const _ensure_bounce_suspension_banner = async (account) => {
   try {
     const uid = account._id;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xuda.io/account_module",
-  "version": "1.2.2303",
+  "version": "1.2.2304",
   "description": "Xuda Account Server Module",
   "main": "index.mjs",
   "dependencies": {