@xrmforge/devkit 0.7.2 → 0.7.4

package/dist/templates/AGENT.md

@@ -568,6 +568,29 @@ const customerId = formLookupId(form.customerid);  // already clean: "a1b2c3d4-.
 if (customerId === otherNormalizedId) { ... }       // simple ===
 ```
 
+### Typed repetition beats untyped loops
+
+When multiple fields need the same operation (e.g. 8 address fields), write
+8 typed lines instead of 1 loop with raw strings:
+
+```typescript
+// WRONG: DRY reflex, but raw strings bypass type safety
+for (const f of ['address1_name', 'address1_line1', 'address1_city']) {
+  form.$unsafe(f)?.addOnChange(handler);
+}
+
+// CORRECT: more lines, but every field is compile-time validated
+form.address1_name.addOnChange(handler);
+form.address1_line1.addOnChange(handler);
+form.address1_city.addOnChange(handler);
+form.address1_postalcode.addOnChange(handler);
+form.address1_country.addOnChange(handler);
+```
+
+8 typed lines are better than 1 loop with raw strings. The type system
+catches renamed/removed fields at compile time. A loop with raw strings
+only fails at runtime. DRY is a recommendation, type safety is mandatory.
+
 **Rule of thumb:** If a helper function just wraps a single Xrm API call with a
 string parameter, it MUST NOT exist. The typed API is shorter, safer, and provides
 IDE autocomplete. Only keep shared helpers that contain actual domain logic

package/dist/templates/validate-form.mjs

@@ -87,9 +87,14 @@ function collectTsFiles(dir) {
 
 /**
  * Check a pattern rule against all files.
+ * @param {string} label - Description of the check
+ * @param {string[]} files - Files to check
+ * @param {RegExp} regex - Pattern to match (violation)
+ * @param {string[]} excludeFiles - File paths to exclude
+ * @param {RegExp[]} excludePatterns - Line patterns to exclude (not violations even if regex matches)
  * @returns Number of violations
  */
-function checkPattern(label, files, regex, excludeFiles = []) {
+function checkPattern(label, files, regex, excludeFiles = [], excludePatterns = []) {
   const violations = [];
   for (const file of files) {
     const relPath = relative(process.cwd(), file);
@@ -100,6 +105,7 @@ function checkPattern(label, files, regex, excludeFiles = []) {
       const line = lines[i];
       const trimmed = line.trim();
       if (trimmed.startsWith('//') || trimmed.startsWith('*') || trimmed.startsWith('/*')) continue;
+      if (excludePatterns.some((ep) => ep.test(trimmed))) continue;
       if (regex.test(line)) {
         violations.push(`  ${relPath}:${i + 1}: ${trimmed}`);
       }
@@ -212,13 +218,39 @@ checkPattern(
   ['logger.ts'],
 );
 
+// ── Type Safety Bypass ───────────────────────────────────────────────────────
+
+// 3l2. Cast to Xrm.FormContext (bypasses typed form interface)
+checkPattern(
+  'Cast to Xrm.FormContext (use typedForm $unsafe() for off-form fields)',
+  formFiles,
+  /as\s+(?:unknown\s+as\s+)?Xrm\.FormContext/,
+);
+
+// 3l3. Raw strings in $filter (field names must use Fields Enum interpolation)
+checkPattern(
+  'Raw field names in $filter (use Fields Enum interpolation)',
+  allSrcFiles,
+  /\$filter=[^$]*\b(?:eq|ne|gt|lt|ge|le|contains|startswith)\b/,
+  ['generated/', 'validate-form'],
+  [
+    // Allow if the line contains template literal interpolation (${...})
+    /\$\{/,
+  ],
+);
+
 // ── Handler Pattern ──────────────────────────────────────────────────────────
 
-// 3l. Exported handlers without wrapHandler
+// 3l. Exported handlers without wrapHandler or wrapCommand
 checkPattern(
-  'Exported handlers without wrapHandler',
+  'Exported handlers without wrapHandler/wrapCommand',
   formFiles,
-  /^export\s+(const|async\s+function|function)\s+\w+(?!.*wrapHandler)/,
+  /^export\s+(const|async\s+function|function)\s+\w+(?!.*(?:wrapHandler|wrapCommand))/,
+  [],
+  [
+    // Re-exports: `export const form_OnLoad = onLoad;` (alias for a wrapped handler)
+    /^export\s+const\s+\w+\s*=\s*[a-zA-Z][a-zA-Z0-9]*\s*;/,
+  ],
 );
 
 // ── Raw $select ──────────────────────────────────────────────────────────────

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xrmforge/devkit",
-  "version": "0.7.2",
+  "version": "0.7.4",
   "description": "Build orchestration and project tooling for Dynamics 365 WebResources",
   "keywords": [
     "dynamics-365",