@xn-intenton-z2a/agentic-lib 7.2.17 → 7.2.18

package/agentic-lib.toml

@@ -134,7 +134,7 @@ library-limit = 64                     # max library entries in library/ directo
 # Thresholds for deterministic mission-complete declaration.
 # All conditions must be met simultaneously.
 min-resolved-issues = 3            # minimum closed-as-RESOLVED issues since init
-require-dedicated-tests = true     # require test files that import from src/lib/
+min-dedicated-tests = 1            # minimum test files that import from src/lib/
 max-source-todos = 0               # max TODO comments allowed in ./src (0 = none)
 
 [bot]

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@xn-intenton-z2a/agentic-lib",
-  "version": "7.2.17",
+  "version": "7.2.18",
   "description": "Agentic-lib Agentic Coding Systems SDK powering automated GitHub workflows.",
   "type": "module",
   "scripts": {

package/src/actions/agentic-step/config-loader.js

@@ -261,7 +261,7 @@ export function loadConfig(configPath) {
   const mc = toml["mission-complete"] || {};
   const missionCompleteThresholds = {
     minResolvedIssues: mc["min-resolved-issues"] ?? 3,
-    requireDedicatedTests: mc["require-dedicated-tests"] ?? true,
+    minDedicatedTests: mc["min-dedicated-tests"] ?? (mc["require-dedicated-tests"] === false ? 0 : 1),
     maxSourceTodos: mc["max-source-todos"] ?? 0,
   };
 

package/src/actions/agentic-step/index.js

@@ -86,20 +86,20 @@ function buildMissionMetrics(config, result, limitsStatus, cumulativeCost, featu
   const srcRoot = sourceDir.includes("/") ? sourceDir.split("/").slice(0, -1).join("/") || "src" : "src";
   const todoCount = countSourceTodos(srcRoot);
 
-  // W3: Check for dedicated test files
-  const hasDedicatedTests = result.hasDedicatedTests ?? false;
+  // W3: Count dedicated test files
+  const dedicatedTestCount = result.dedicatedTestCount ?? 0;
 
   // W11: Thresholds from config
   const thresholds = config.missionCompleteThresholds || {};
   const minResolved = thresholds.minResolvedIssues ?? 3;
-  const requireTests = thresholds.requireDedicatedTests ?? true;
+  const minTests = thresholds.minDedicatedTests ?? 1;
   const maxTodos = thresholds.maxSourceTodos ?? 0;
 
   const metrics = [
     { metric: "Open issues", value: String(openIssues), target: "0", status: openIssues === 0 ? "MET" : "NOT MET" },
     { metric: "Open PRs", value: String(openPrs), target: "0", status: openPrs === 0 ? "MET" : "NOT MET" },
     { metric: "Issues resolved (review or PR merge)", value: String(resolvedCount), target: `>= ${minResolved}`, status: resolvedCount >= minResolved ? "MET" : "NOT MET" },
-    { metric: "Dedicated test files", value: hasDedicatedTests ? "YES" : "NO", target: requireTests ? "YES" : "—", status: !requireTests || hasDedicatedTests ? "MET" : "NOT MET" },
+    { metric: "Dedicated test files", value: String(dedicatedTestCount), target: `>= ${minTests}`, status: dedicatedTestCount >= minTests ? "MET" : "NOT MET" },
     { metric: "Source TODO count", value: String(todoCount), target: `<= ${maxTodos}`, status: todoCount <= maxTodos ? "MET" : "NOT MET" },
     { metric: "Transformation budget used", value: `${cumulativeCost}/${budgetCap}`, target: budgetCap > 0 ? `< ${budgetCap}` : "unlimited", status: budgetCap > 0 && cumulativeCost >= budgetCap ? "EXHAUSTED" : "OK" },
     { metric: "Cumulative transforms", value: String(cumulativeCost), target: ">= 1", status: cumulativeCost >= 1 ? "MET" : "NOT MET" },
@@ -117,7 +117,7 @@ function buildMissionReadiness(metrics) {
   const openIssues = parseInt(metrics.find((m) => m.metric === "Open issues")?.value || "0", 10);
   const openPrs = parseInt(metrics.find((m) => m.metric === "Open PRs")?.value || "0", 10);
   const resolved = parseInt(metrics.find((m) => m.metric === "Issues resolved (review or PR merge)")?.value || "0", 10);
-  const hasDedicatedTests = metrics.find((m) => m.metric === "Dedicated test files")?.value === "YES";
+  const dedicatedTests = parseInt(metrics.find((m) => m.metric === "Dedicated test files")?.value || "0", 10);
   const todoCount = parseInt(metrics.find((m) => m.metric === "Source TODO count")?.value || "0", 10);
   const missionComplete = metrics.find((m) => m.metric === "Mission complete declared")?.value === "YES";
   const missionFailed = metrics.find((m) => m.metric === "Mission failed declared")?.value === "YES";
@@ -136,7 +136,7 @@ function buildMissionReadiness(metrics) {
 
   if (allMet) {
     parts.push("Mission complete conditions ARE met.");
-    parts.push(`0 open issues, 0 open PRs, ${resolved} issue(s) resolved, dedicated tests: ${hasDedicatedTests ? "yes" : "no"}, TODOs: ${todoCount}.`);
+    parts.push(`0 open issues, 0 open PRs, ${resolved} issue(s) resolved, ${dedicatedTests} dedicated test(s), TODOs: ${todoCount}.`);
   } else {
     parts.push("Mission complete conditions are NOT met.");
     if (openIssues > 0) parts.push(`${openIssues} open issue(s) remain.`);
@@ -262,9 +262,9 @@ async function run() {
       ? readdirSync(libraryPath).filter((f) => f.endsWith(".md")).length
       : 0;
 
-    // W3/W10: Detect dedicated test files (centrally, for all tasks)
-    let hasDedicatedTests = result.hasDedicatedTests ?? false;
-    if (!hasDedicatedTests) {
+    // W3/W10: Count dedicated test files (centrally, for all tasks)
+    let dedicatedTestCount = result.dedicatedTestCount ?? 0;
+    if (dedicatedTestCount === 0) {
       try {
         const { scanDirectory: scanDir } = await import("./copilot.js");
         const testDirs = ["tests", "__tests__"];
@@ -275,17 +275,14 @@ async function run() {
               if (/^(main|web|behaviour)\.test\.[jt]s$/.test(tf.name)) continue;
               const content = readFileSync(tf.path, "utf8");
               if (/from\s+['"].*src\/lib\//.test(content) || /require\s*\(\s*['"].*src\/lib\//.test(content)) {
-                hasDedicatedTests = true;
-                break;
+                dedicatedTestCount++;
               }
             }
-            if (hasDedicatedTests) break;
           }
         }
       } catch { /* ignore — scanDirectory not available in test environment */ }
     }
-    // Inject hasDedicatedTests into result for buildMissionMetrics
-    result.hasDedicatedTests = hasDedicatedTests;
+    result.dedicatedTestCount = dedicatedTestCount;
 
     // Count open automated issues (feature vs maintenance)
     let featureIssueCount = 0;

package/src/actions/agentic-step/tasks/direct.js

@@ -40,7 +40,6 @@ function countTodos(dir) {
  * Detect dedicated test files that import from src/lib/.
  */
 function detectDedicatedTests() {
-  let hasDedicatedTests = false;
   const dedicatedTestFiles = [];
   const testDirs = ["tests", "__tests__"];
   for (const dir of testDirs) {
@@ -51,14 +50,13 @@ function detectDedicatedTests() {
           if (/^(main|web|behaviour)\.test\.[jt]s$/.test(tf.name)) continue;
           const content = readFileSync(tf.path, "utf8");
           if (/from\s+['"].*src\/lib\//.test(content) || /require\s*\(\s*['"].*src\/lib\//.test(content)) {
-            hasDedicatedTests = true;
             dedicatedTestFiles.push(tf.name);
           }
         }
       } catch { /* ignore */ }
     }
   }
-  return { hasDedicatedTests, dedicatedTestFiles };
+  return { dedicatedTestCount: dedicatedTestFiles.length, dedicatedTestFiles };
 }
 
 /**
@@ -68,14 +66,14 @@ function detectDedicatedTests() {
 function buildMetricAssessment(ctx, config) {
   const thresholds = config.missionCompleteThresholds || {};
   const minResolved = thresholds.minResolvedIssues ?? 3;
-  const requireTests = thresholds.requireDedicatedTests ?? true;
+  const minTests = thresholds.minDedicatedTests ?? 1;
   const maxTodos = thresholds.maxSourceTodos ?? 0;
 
   const metrics = [
     { metric: "Open issues", value: ctx.issuesSummary.length, target: 0, met: ctx.issuesSummary.length === 0 },
     { metric: "Open PRs", value: ctx.prsSummary.length, target: 0, met: ctx.prsSummary.length === 0 },
     { metric: "Issues resolved", value: ctx.resolvedCount, target: minResolved, met: ctx.resolvedCount >= minResolved },
-    { metric: "Dedicated tests", value: ctx.hasDedicatedTests ? "YES" : "NO", target: requireTests ? "YES" : "—", met: !requireTests || ctx.hasDedicatedTests },
+    { metric: "Dedicated tests", value: ctx.dedicatedTestCount, target: minTests, met: ctx.dedicatedTestCount >= minTests },
     { metric: "Source TODOs", value: ctx.sourceTodoCount, target: maxTodos, met: ctx.sourceTodoCount <= maxTodos },
     { metric: "Budget", value: ctx.cumulativeTransformationCost, target: ctx.transformationBudget || "unlimited", met: !(ctx.transformationBudget > 0 && ctx.cumulativeTransformationCost >= ctx.transformationBudget) },
   ];
@@ -86,7 +84,7 @@ function buildMetricAssessment(ctx, config) {
   const table = [
     "| Metric | Value | Target | Status |",
     "|--------|-------|--------|--------|",
-    ...metrics.map((m) => `| ${m.metric} | ${m.value} | ${typeof m.target === "number" ? (m.metric.includes("TODO") ? `<= ${m.target}` : m.metric.includes("resolved") ? `>= ${m.target}` : `${m.target}`) : m.target} | ${m.met ? "MET" : "NOT MET"} |`),
+    ...metrics.map((m) => `| ${m.metric} | ${m.value} | ${typeof m.target === "number" ? (m.metric.includes("TODO") ? `<= ${m.target}` : `>= ${m.target}`) : m.target} | ${m.met ? "MET" : "NOT MET"} |`),
   ].join("\n");
 
   let assessment;
@@ -134,8 +132,8 @@ function buildPrompt(ctx, agentInstructions, metricAssessment) {
         ]
       : []),
     `### Test Coverage`,
-    ctx.hasDedicatedTests
-      ? `Dedicated test files: ${ctx.dedicatedTestFiles.join(", ")}`
+    ctx.dedicatedTestCount > 0
+      ? `Dedicated test files (${ctx.dedicatedTestCount}): ${ctx.dedicatedTestFiles.join(", ")}`
       : "**No dedicated test files found.**",
     "",
     `### Source TODO Count: ${ctx.sourceTodoCount}`,
@@ -348,7 +346,7 @@ export async function direct(context) {
   } catch { /* ignore */ }
 
   // Dedicated tests
-  const { hasDedicatedTests, dedicatedTestFiles } = detectDedicatedTests();
+  const { dedicatedTestCount, dedicatedTestFiles } = detectDedicatedTests();
 
   // TODO count
   const sourcePath = config.paths.source?.path || "src/lib/";
@@ -365,7 +363,7 @@ export async function direct(context) {
     resolvedCount,
     prsSummary,
     sourceExports,
-    hasDedicatedTests,
+    dedicatedTestCount,
     dedicatedTestFiles,
     sourceTodoCount,
     cumulativeTransformationCost,
@@ -424,7 +422,7 @@ export async function direct(context) {
     narrative: `Director: ${reason}`,
     metricAssessment: metricAssessment.assessment,
     directorAnalysis: analysis,
-    hasDedicatedTests,
+    dedicatedTestCount,
     resolvedCount,
     changes: outcome === "mission-complete"
       ? [{ action: "mission-complete", file: "MISSION_COMPLETE.md", sizeInfo: reason.substring(0, 100) }]

package/src/actions/agentic-step/tasks/supervise.js

@@ -312,9 +312,9 @@ async function gatherContext(octokit, repo, config, t) {
     }
   } catch { /* ignore */ }
 
-  // Check for dedicated test files (not just seed tests)
+  // Count dedicated test files (not just seed tests)
   // A dedicated test imports from the source directory (src/lib/) rather than being a seed test
-  let hasDedicatedTests = false;
+  let dedicatedTestCount = 0;
   let dedicatedTestFiles = [];
   try {
     const testDirs = ["tests", "__tests__"];
@@ -327,7 +327,7 @@ async function gatherContext(octokit, repo, config, t) {
           const content = readFileSync(tf.path, "utf8");
           // Check if it imports from src/lib/ (mission-specific code)
           if (/from\s+['"].*src\/lib\//.test(content) || /require\s*\(\s*['"].*src\/lib\//.test(content)) {
-            hasDedicatedTests = true;
+            dedicatedTestCount++;
             dedicatedTestFiles.push(tf.name);
           }
         }
@@ -395,7 +395,7 @@ async function gatherContext(octokit, repo, config, t) {
     cumulativeTransformationCost,
     recentlyClosedSummary,
     sourceExports,
-    hasDedicatedTests,
+    dedicatedTestCount,
     dedicatedTestFiles,
     sourceTodoCount,
   };
@@ -434,8 +434,8 @@ function buildPrompt(ctx, agentInstructions, config) {
         ]
       : []),
     `### Test Coverage`,
-    ctx.hasDedicatedTests
-      ? `Dedicated test files: ${ctx.dedicatedTestFiles.join(", ")}`
+    ctx.dedicatedTestCount > 0
+      ? `Dedicated test files (${ctx.dedicatedTestCount}): ${ctx.dedicatedTestFiles.join(", ")}`
       : "**No dedicated test files found.** Only seed tests (main.test.js, web.test.js) exist. Mission-complete requires dedicated tests that import from src/lib/.",
     "",
     `### Source TODO Count: ${ctx.sourceTodoCount}`,
@@ -447,7 +447,7 @@ function buildPrompt(ctx, agentInstructions, config) {
       // W10: Build mission-complete metrics inline for the LLM
       const thresholds = config?.missionCompleteThresholds || {};
       const minResolved = thresholds.minResolvedIssues ?? 3;
-      const requireTests = thresholds.requireDedicatedTests ?? true;
+      const minTests = thresholds.minDedicatedTests ?? 1;
       const maxTodos = thresholds.maxSourceTodos ?? 0;
       const resolvedCount = ctx.recentlyClosedSummary.filter((s) => s.includes("RESOLVED")).length;
       const rows = [
@@ -457,7 +457,7 @@ function buildPrompt(ctx, agentInstructions, config) {
         `| Open issues | ${ctx.issuesSummary.length} | 0 | ${ctx.issuesSummary.length === 0 ? "MET" : "NOT MET"} |`,
         `| Open PRs | ${ctx.prsSummary.length} | 0 | ${ctx.prsSummary.length === 0 ? "MET" : "NOT MET"} |`,
         `| Issues resolved (RESOLVED) | ${resolvedCount} | >= ${minResolved} | ${resolvedCount >= minResolved ? "MET" : "NOT MET"} |`,
-        `| Dedicated test files | ${ctx.hasDedicatedTests ? "YES" : "NO"} | ${requireTests ? "YES" : "—"} | ${!requireTests || ctx.hasDedicatedTests ? "MET" : "NOT MET"} |`,
+        `| Dedicated test files | ${ctx.dedicatedTestCount} | >= ${minTests} | ${ctx.dedicatedTestCount >= minTests ? "MET" : "NOT MET"} |`,
         `| Source TODO count | ${ctx.sourceTodoCount} | <= ${maxTodos} | ${ctx.sourceTodoCount <= maxTodos ? "MET" : "NOT MET"} |`,
         `| Budget used | ${ctx.cumulativeTransformationCost}/${ctx.transformationBudget} | < ${ctx.transformationBudget || "unlimited"} | ${ctx.transformationBudget > 0 && ctx.cumulativeTransformationCost >= ctx.transformationBudget ? "EXHAUSTED" : "OK"} |`,
         "",

package/src/seeds/zero-package.json

@@ -17,7 +17,7 @@
   "author": "",
   "license": "MIT",
   "dependencies": {
-    "@xn-intenton-z2a/agentic-lib": "^7.2.17"
+    "@xn-intenton-z2a/agentic-lib": "^7.2.18"
   },
   "devDependencies": {
     "@playwright/test": "^1.58.0",