@xmoxmo/bncr 0.5.6 → 0.5.8

package/src/core/dead-letter-diagnostics.ts

@@ -5,6 +5,7 @@ import type {
   BncrDeadLetterEntrySummary,
   OutboxEntry,
 } from './types.ts';
+import { asString } from './value-sanitize.ts';
 
 export type DeadLetterTopReason = { reason: string; count: number };
 
@@ -15,12 +16,6 @@ export type BuildDeadLetterDiagnosticsOptions = {
   cappedAt: number;
 };
 
-function asString(value: unknown, fallback = ''): string {
-  if (typeof value === 'string') return value;
-  if (value == null) return fallback;
-  return String(value);
-}
-
 function asPayloadMessage(payload: OutboxEntry['payload']): {
   msg?: string;
   type?: string;
@@ -87,15 +82,14 @@ export function parseDeadLetterOlderThan(raw: unknown): number | null {
 }
 
 export function summarizeDeadLetterEntry(entry: OutboxEntry) {
-  const meta = entry.payload?._meta || {};
-  const msg = asPayloadMessage(entry.payload);
-  const text = asString(meta.text || msg.msg || '');
+  const msg = asPayloadMessage(entry.payload) || {};
+  const text = asString(msg.msg || '');
   return {
     messageId: entry.messageId,
     accountId: entry.accountId,
     sessionKey: entry.sessionKey,
     route: formatDisplayScope(entry.route),
-    kind: asString(meta.kind || msg.type || 'message'),
+    kind: asString(msg.type || 'message'),
     createdAt: Number.isFinite(Number(entry.createdAt)) ? Number(entry.createdAt) : null,
     retryCount: Number.isFinite(Number(entry.retryCount)) ? Number(entry.retryCount) : 0,
     lastError: entry.lastError || null,

package/src/core/logging.ts

@@ -117,7 +117,7 @@ function sanitizeDebugValue(key: string, value: unknown): unknown {
   return value;
 }
 
-export function sanitizeBncrDebugPayload(payload: Record<string, unknown>) {
+function sanitizeBncrDebugPayload(payload: Record<string, unknown>) {
   return sanitizeDebugPayload(payload);
 }
 

package/src/core/outbox-entry-builders.ts

@@ -2,28 +2,77 @@ import type { OutboundReplyTargetPolicy } from '../messaging/outbound/reply-targ
 import { normalizeOutboundReplyToId } from '../messaging/outbound/reply-target-policy.ts';
 import type { BncrRoute, OutboxEntry } from './types.ts';
 
-export function buildFileTransferOutboxEntry(args: {
+/** Strip empty/falsy values from extra so they don't override existing message defaults. */
+function sanitizeExtraSpread(extra: Record<string, unknown>): Record<string, unknown> {
+  const out: Record<string, unknown> = {};
+  for (const [key, value] of Object.entries(extra)) {
+    if (value === '' || value === null || value === undefined) continue;
+    out[key] = value;
+  }
+  return out;
+}
+
+export type BuildOutboxEntryParams = {
   createMessageId: () => string;
   now: () => number;
   normalizeAccountId: (accountId?: string | null) => string;
-  pushEvent: string;
   accountId: string;
   sessionKey: string;
   route: BncrRoute;
-  mediaUrl: string;
-  mediaLocalRoots?: readonly string[];
-  text: string;
-  asVoice?: boolean;
-  audioAsVoice?: boolean;
+  /** For text sends this is 'text'; for media it may be undefined (inferred downstream). */
   type?: string;
-  extra?: Record<string, unknown>;
+  /** Message body (text content for text sends, caption for media sends). */
+  msg: string;
   kind?: 'tool' | 'block' | 'final';
   replyToId?: string;
   replyTargetPolicy?: OutboundReplyTargetPolicy;
+  extra?: Record<string, unknown>;
+  /** Media-only fields. When transferMode === 'media' these shape the frame. */
+  transferMode?: 'text' | 'media';
+  mediaUrl?: string;
+  mediaLocalRoots?: readonly string[];
+  asVoice?: boolean;
+  audioAsVoice?: boolean;
   downloadMedia?: boolean;
-}): OutboxEntry {
+};
+
+/**
+ * Unified outbox entry builder.
+ *
+ * Text and media sends share the same outbox lifecycle (queue, drain, retry).
+ * The only structural difference is that media entries carry extra media fields
+ * and set `transferMode: 'media'` so the push layer knows to process media.
+ *
+ * - **Text**: `{ type: 'text', transferMode: undefined, no media fields }`
+ * - **Media**: `{ type: args.type || undefined, transferMode: 'media', ...media fields }`
+ */
+export function buildOutboxEntry(args: BuildOutboxEntryParams): OutboxEntry {
   const messageId = args.createMessageId();
   const createdAt = args.now();
+  const isMedia = args.transferMode === 'media';
+
+  const message: Record<string, unknown> = {
+    platform: args.route.platform,
+    groupId: args.route.groupId,
+    userId: args.route.userId,
+    type: isMedia ? args.type : 'text',
+    kind: args.kind,
+    msg: args.msg,
+    path: '',
+    base64: '',
+    fileName: '',
+    ...(args.extra ? sanitizeExtraSpread(args.extra) : {}),
+  };
+
+  if (isMedia) {
+    message.mediaUrl = args.mediaUrl || '';
+    if (args.mediaLocalRoots) message.mediaLocalRoots = Array.from(args.mediaLocalRoots);
+    message.asVoice = args.asVoice === true;
+    message.audioAsVoice = args.audioAsVoice === true;
+    message.downloadMedia = args.downloadMedia;
+    message.transferMode = 'media';
+  }
+
   return {
     messageId,
     accountId: args.normalizeAccountId(args.accountId),
@@ -31,86 +80,31 @@ export function buildFileTransferOutboxEntry(args: {
     route: args.route,
     payload: {
       type: 'message.outbound',
+      messageId,
+      idempotencyKey: messageId,
       sessionKey: args.sessionKey,
-      _meta: {
-        kind: 'file-transfer',
-        mediaUrl: args.mediaUrl,
-        mediaLocalRoots: args.mediaLocalRoots ? Array.from(args.mediaLocalRoots) : undefined,
-        text: args.text,
-        asVoice: args.asVoice === true,
-        audioAsVoice: args.audioAsVoice === true,
-        type: args.type,
-        downloadMedia: args.downloadMedia === true,
-        ...(args.extra ? { extra: { ...args.extra } } : {}),
-        finalEvent: args.pushEvent,
-        replyToId:
-          normalizeOutboundReplyToId({
-            kind: args.kind,
-            replyToId: args.replyToId,
-            replyTargetPolicy: args.replyTargetPolicy,
-          }) || undefined,
-        messageKind: args.kind,
+      replyToId:
+        normalizeOutboundReplyToId({
+          kind: args.kind,
+          replyToId: args.replyToId,
+          replyTargetPolicy: args.replyTargetPolicy,
+        }) || undefined,
+      message: message as {
+        platform: string;
+        groupId: string;
+        userId: string;
+        type?: string;
+        kind?: 'tool' | 'block' | 'final';
+        msg: string;
+        path: string;
+        base64: string;
+        fileName: string;
+        [key: string]: unknown;
       },
+      ts: createdAt,
     },
     createdAt,
     retryCount: 0,
     nextAttemptAt: createdAt,
   };
 }
-
-export function buildTextOutboxEntry(args: {
-  createMessageId: () => string;
-  now: () => number;
-  normalizeAccountId: (accountId?: string | null) => string;
-  normalizeReplyToId: (value?: string | null) => string;
-  accountId: string;
-  extra?: Record<string, unknown>;
-  sessionKey: string;
-  route: BncrRoute;
-  text: string;
-  kind?: 'tool' | 'block' | 'final';
-  replyToId?: string;
-  replyTargetPolicy?: OutboundReplyTargetPolicy;
-  downloadMedia?: boolean;
-}): OutboxEntry {
-  const messageId = args.createMessageId();
-  const createdAt = args.now();
-  const frame = {
-    type: 'message.outbound',
-    messageId,
-    idempotencyKey: messageId,
-    sessionKey: args.sessionKey,
-    replyToId:
-      normalizeOutboundReplyToId({
-        kind: args.kind,
-        replyToId: args.replyToId,
-        replyTargetPolicy: args.replyTargetPolicy,
-      }) || undefined,
-    message: {
-      platform: args.route.platform,
-      groupId: args.route.groupId,
-      userId: args.route.userId,
-      type: 'text',
-      kind: args.kind,
-      msg: args.text,
-      path: '',
-      base64: '',
-      fileName: '',
-      // Extra fields from marker/pipeline spread for adapter-specific data
-      // (e.g. type="appmsg", msg="<appmsg>..." from [BncrParam:...])
-      ...(args.extra ? { ...args.extra } : {}),
-    },
-    ts: createdAt,
-  };
-
-  return {
-    messageId,
-    accountId: args.normalizeAccountId(args.accountId),
-    sessionKey: args.sessionKey,
-    route: args.route,
-    payload: frame,
-    createdAt,
-    retryCount: 0,
-    nextAttemptAt: createdAt,
-  };
-}

package/src/core/outbox-file-transfer-failure.ts

@@ -1,3 +1,8 @@
+/*
+ * Intentionally separate from outbox-text-push-failure.ts.
+ * File transfer failure adds retryable-state resolution logic
+ * that text push doesn't need (no chunk-level retry semantics).
+ */
 import { buildPushFailureArgs } from './outbox-push-args.ts';
 import type { OutboxEntry } from './types.ts';
 

package/src/core/outbox-file-transfer-guards.ts

@@ -1,3 +1,9 @@
+/*
+ * Intentionally separate from outbox-text-push-guards.ts.
+ * File transfer guard has distinct output type (includes owner/mediaUrl)
+ * and extra mediaUrl validation that text push doesn't need.
+ * Merging would add unnecessary conditional branches.
+ */
 import type { BncrConnection, OutboxEntry } from './types.ts';
 
 export type FileTransferGuardResult =

package/src/core/outbox-file-transfer-prep.ts

@@ -1,26 +1,29 @@
 import type { BncrConnection, OutboxEntry } from './types.ts';
 
-export function prepareFileTransferRouteSelection(args: {
+type PushRouteSelectionArgs<C> = {
   entry: OutboxEntry;
   owner: BncrConnection | null;
   resolvePushConnIds: (accountId: string) => Iterable<string>;
   resolveRecentInboundConnIds: (accountId: string) => Iterable<string>;
   hasRecentInboundReachability: (accountId: string) => boolean;
   isRevalidatedAttemptedConn: (connId: string) => boolean;
-  selectOutboxFileTransferRouteCandidates: (args: {
+  selectRouteCandidates: (args: {
     routeCandidates: Iterable<string>;
     attemptedConnIds: string[];
     recentInboundConnIds: Iterable<string>;
     ownerConnId?: string;
     recentInboundReachable: boolean;
     isRevalidatedAttemptedConn: (connId: string) => boolean;
-  }) => { connIds: Iterable<string>; recentInboundReachable: boolean; routeReason: string };
-}) {
+  }) => C;
+};
+
+/** Shared route selection prep for both text and file push flows. */
+export function prepareRouteSelection<C>(args: PushRouteSelectionArgs<C>): C {
   const attemptedConnIds = Array.isArray(args.entry.routeAttemptConnIds)
     ? args.entry.routeAttemptConnIds.filter((v): v is string => typeof v === 'string' && !!v)
     : [];
 
-  return args.selectOutboxFileTransferRouteCandidates({
+  return args.selectRouteCandidates({
     routeCandidates: args.resolvePushConnIds(args.entry.accountId),
     attemptedConnIds,
     recentInboundConnIds: args.resolveRecentInboundConnIds(args.entry.accountId),

package/src/core/outbox-file-transfer-success.ts

@@ -1,3 +1,8 @@
+/*
+ * Intentionally separate from outbox-text-push-success.ts.
+ * File transfer success uses kind:'file-transfer' tag and different
+ * argument shapes (owner vs connId). Separate callers, separate files.
+ */
 import { buildPushBroadcastPayload, buildPushRouteSelectArgs } from './outbox-push-args.ts';
 import type { BncrConnection, OutboxEntry } from './types.ts';
 

package/src/core/outbox-queue.ts

@@ -50,13 +50,7 @@ export function collectDueOutboxEntries(args: {
       nextAttemptAt: args.now + args.backoffMs(nextAttempt),
     };
     updatedEntries.push(updatedEntry);
-    duePayloads.push({
-      ...updatedEntry.payload,
-      _meta: {
-        retryCount: updatedEntry.retryCount,
-        nextAttemptAt: updatedEntry.nextAttemptAt,
-      },
-    });
+    duePayloads.push(updatedEntry.payload);
 
     if (duePayloads.length >= args.maxBatch) break;
   }

package/src/core/outbox-summary.ts

@@ -1,33 +1,6 @@
 import type { OutboxEntry } from './types.ts';
 
-type OutboxSummaryMeta = {
-  kind?: string;
-  asVoice?: boolean;
-  audioAsVoice?: boolean;
-  type?: unknown;
-  mediaUrl?: unknown;
-  text?: unknown;
-};
-
-type OutboxSummaryMessage = {
-  type?: unknown;
-  msg?: unknown;
-};
-
-type OutboxSummaryPayload = {
-  type?: unknown;
-  message?: OutboxSummaryMessage;
-  _meta?: OutboxSummaryMeta;
-};
-
-function inferMediaTypeFromUrl(raw: string): 'image' | 'video' | 'audio' | 'file' {
-  const clean = String(raw || '').split(/[?#]/, 1)[0] || '';
-  const ext = clean.includes('.') ? clean.slice(clean.lastIndexOf('.') + 1).toLowerCase() : '';
-  if (['jpg', 'jpeg', 'png', 'gif', 'webp', 'bmp', 'heic', 'heif'].includes(ext)) return 'image';
-  if (['mp4', 'mov', 'mkv', 'webm', 'avi', 'm4v'].includes(ext)) return 'video';
-  if (['mp3', 'wav', 'ogg', 'oga', 'opus', 'm4a', 'aac', 'flac'].includes(ext)) return 'audio';
-  return 'file';
-}
+type OutboxSummaryMessage = { type?: unknown; msg?: unknown; mediaUrl?: unknown };
 
 function filenameFromUrl(raw: string): string {
   const clean = String(raw || '').split(/[?#]/, 1)[0] || '';
@@ -40,34 +13,15 @@ function filenameFromUrl(raw: string): string {
   }
 }
 
-function summarizeOutboxType(
-  payload: OutboxSummaryPayload,
-  msg: OutboxSummaryMessage,
-  asString: (value: unknown) => string,
-) {
-  const directType = asString(msg.type || '');
-  if (directType) return directType;
-
-  const meta = payload?._meta || {};
-  if (meta.kind === 'file-transfer') {
-    if (meta.asVoice === true || meta.audioAsVoice === true) return 'voice';
-    const hintedType = asString(meta.type || '').trim();
-    if (hintedType) return hintedType;
-    return inferMediaTypeFromUrl(asString(meta.mediaUrl || ''));
-  }
-
-  return asString(payload?.type || 'unknown');
+function summarizeOutboxType(msg: OutboxSummaryMessage, asString: (value: unknown) => string) {
+  return asString(msg.type || '') || 'unknown';
 }
 
-function summarizeOutboxText(
-  payload: OutboxSummaryPayload,
-  msg: OutboxSummaryMessage,
-  asString: (value: unknown) => string,
-) {
-  const text = asString(msg.msg || payload?._meta?.text || '').trim();
+function summarizeOutboxText(msg: OutboxSummaryMessage, asString: (value: unknown) => string) {
+  const text = asString(msg.msg || '').trim();
   if (text) return text;
-  const meta = payload?._meta || {};
-  if (meta.kind === 'file-transfer') return filenameFromUrl(asString(meta.mediaUrl || ''));
+  const mediaUrl = asString(msg.mediaUrl || '');
+  if (mediaUrl) return filenameFromUrl(mediaUrl);
   return '';
 }
 
@@ -77,10 +31,10 @@ export function summarizeOutboxEntry(args: {
   formatDisplayScope: (route: OutboxEntry['route']) => string;
   summarizeTextPreview: (raw: string, limit?: number) => string;
 }) {
-  const payload = args.entry.payload as OutboxSummaryPayload;
+  const payload = args.entry.payload as { message?: OutboxSummaryMessage } | undefined;
   const msg = payload?.message || {};
-  const type = summarizeOutboxType(payload, msg, args.asString);
-  const text = summarizeOutboxText(payload, msg, args.asString);
+  const type = summarizeOutboxType(msg, args.asString);
+  const text = summarizeOutboxText(msg, args.asString);
   const preview = args.summarizeTextPreview(text);
   return [type, args.formatDisplayScope(args.entry.route), preview].join('|');
 }

package/src/core/permissions.ts

@@ -1,8 +1,4 @@
-function asString(v: unknown, fallback = ''): string {
-  if (typeof v === 'string') return v;
-  if (v == null) return fallback;
-  return String(v);
-}
+import { asString } from '../core/value-sanitize.ts';
 
 type BncrElevatedConfigRoot = {
   tools?: {
@@ -14,21 +10,18 @@ type BncrElevatedConfigRoot = {
     };
   };
 };
-
-export function getBncrElevatedConfig(rootCfg: BncrElevatedConfigRoot | null | undefined) {
+function getBncrElevatedConfig(rootCfg: BncrElevatedConfigRoot | null | undefined) {
   const elevated = rootCfg?.tools?.elevated || {};
   const allowFrom = elevated?.allowFrom || {};
   const bncrRules = Array.isArray(allowFrom?.bncr)
     ? allowFrom.bncr.map((x: unknown) => asString(x).trim()).filter(Boolean)
     : [];
-
   return {
     enabled: elevated?.enabled === true,
     bncrAllowed: bncrRules.length > 0,
     bncrRules,
   };
 }
-
 export function buildBncrPermissionSummary(rootCfg: BncrElevatedConfigRoot | null | undefined) {
   const elevated = getBncrElevatedConfig(rootCfg);
   return {
@@ -40,5 +33,4 @@ export function buildBncrPermissionSummary(rootCfg: BncrElevatedConfigRoot | nul
       : 'bncr elevated not explicitly allowed',
   };
 }
-
 export type BncrPermissionSummary = ReturnType<typeof buildBncrPermissionSummary>;

package/src/core/persisted-outbox-entry.ts

@@ -1,22 +1,12 @@
 import { normalizeAccountId } from './accounts.ts';
 import { normalizeStoredSessionKey, parseRouteLike } from './targets.ts';
 import type { OutboxEntry } from './types.ts';
+import { asString, finiteNumberOr } from './value-sanitize.ts';
 
 type PersistedOutboxEntryInput = Partial<OutboxEntry> & {
   payload?: Record<string, unknown>;
 };
 
-function asString(v: unknown, fallback = ''): string {
-  if (typeof v === 'string') return v;
-  if (v == null) return fallback;
-  return String(v);
-}
-
-function finiteNumberOr(value: unknown, fallback: number): number {
-  const n = Number(value);
-  return Number.isFinite(n) ? n : fallback;
-}
-
 function optionalFiniteNumber(value: unknown): number | undefined {
   if (value == null || value === '') return undefined;
   const n = Number(value);
@@ -43,6 +33,59 @@ export function normalizePersistedOutboxEntry(args: {
   payload.groupId = route.groupId;
   payload.userId = route.userId;
 
+  // Migrate old _meta format entries to the new message format.
+  // Old entries persisted before the _meta→message refactor carry media
+  // metadata in payload._meta.  New code reads from payload.message.
+  const oldMeta = payload._meta as Record<string, unknown> | undefined;
+  if (oldMeta && !payload.message) {
+    const oldKind = asString(oldMeta.kind);
+    if (oldKind === 'file-transfer') {
+      // Move replyToId from _meta to payload top level
+      const replyToId = asString(oldMeta.replyToId || '').trim() || undefined;
+      if (replyToId) payload.replyToId = replyToId;
+
+      // Build new message object from old _meta fields
+      const msg: Record<string, unknown> = {
+        type: (oldMeta.type as string) || 'file',
+        msg: oldMeta.text || '',
+        mediaUrl: oldMeta.mediaUrl,
+        mediaLocalRoots: oldMeta.mediaLocalRoots,
+        asVoice: oldMeta.asVoice === true,
+        audioAsVoice: oldMeta.audioAsVoice === true,
+        downloadMedia: oldMeta.downloadMedia === true,
+        kind: oldMeta.messageKind,
+        transferMode: 'media',
+        path: '',
+        base64: '',
+        fileName: '',
+      };
+      // Strip consumed _meta keys, pass through remaining as extra
+      const consumed = new Set([
+        'kind',
+        'mediaUrl',
+        'mediaLocalRoots',
+        'text',
+        'asVoice',
+        'audioAsVoice',
+        'replyToId',
+        'finalEvent',
+        'type',
+        'downloadMedia',
+        'messageKind',
+        'retryCount',
+        'nextAttemptAt',
+      ]);
+      for (const [key, value] of Object.entries(oldMeta)) {
+        if (!consumed.has(key)) {
+          msg[key] = value;
+        }
+      }
+      payload.message = msg;
+    }
+    // Remove old _meta after migration
+    delete payload._meta;
+  }
+
   return {
     ...entry,
     messageId: asString(entry.messageId).trim(),

package/src/core/policy.ts

@@ -1,8 +1,4 @@
-function asString(v: unknown, fallback = ''): string {
-  if (typeof v === 'string') return v;
-  if (v == null) return fallback;
-  return String(v);
-}
+import { asBoolean, asString } from './value-sanitize.ts';
 
 export type BncrChannelPolicyConfig = {
   enabled?: boolean;
@@ -21,12 +17,6 @@ function asList(v: unknown): string[] {
   return v.map((x) => asString(x).trim()).filter(Boolean);
 }
 
-function asBoolean(v: unknown, fallback = false): boolean {
-  if (typeof v === 'boolean') return v;
-  if (v == null) return fallback;
-  return String(v).trim().toLowerCase() === 'true';
-}
-
 function normalizeDmPolicy(value: unknown): BncrDmPolicy {
   const normalized = asString(value || 'open')
     .trim()

package/src/core/register-trace.ts

@@ -1,9 +1,6 @@
-const DEFAULT_REGISTER_WARMUP_WINDOW_MS = 30_000;
+import { finiteNumberOr } from './value-sanitize.ts';
 
-function finiteNumberOr(value: unknown, fallback: number): number {
-  const n = Number(value);
-  return Number.isFinite(n) ? n : fallback;
-}
+const DEFAULT_REGISTER_WARMUP_WINDOW_MS = 30_000;
 
 export type RegisterTraceEntry = {
   ts: number;
@@ -46,7 +43,7 @@ export type RegisterDriftSnapshot = {
   traceRecent: Array<Record<string, unknown>>;
 };
 
-export function classifyRegisterTrace(stack: string) {
+function classifyRegisterTrace(stack: string) {
   if (
     stack.includes('prepareSecretsRuntimeSnapshot') ||
     stack.includes('resolveRuntimeWebTools') ||
@@ -69,7 +66,7 @@ export function classifyRegisterTrace(stack: string) {
   return 'other';
 }
 
-export function dominantRegisterBucket(sourceBuckets: Record<string, number>) {
+function dominantRegisterBucket(sourceBuckets: Record<string, number>) {
   let winner: string | null = null;
   let winnerCount = -1;
   for (const [bucket, count] of Object.entries(sourceBuckets)) {

package/src/core/status-meta.ts

@@ -1,4 +1,5 @@
 import type { PendingAdmission } from './types.ts';
+import { finiteNumberOrNull, now } from './value-sanitize.ts';
 
 type RuntimeStatusMetaDisplayInput = {
   pendingAdmissions?: PendingAdmission[];
@@ -8,15 +9,6 @@ type RuntimeStatusMetaDisplayInput = {
   lastOutboundAt?: number | null;
 };
 
-function now() {
-  return Date.now();
-}
-
-function finiteNumberOrNull(value: unknown): number | null {
-  const n = Number(value);
-  return Number.isFinite(n) ? n : null;
-}
-
 function formatPendingAdmissionScope(route: unknown): string | null {
   if (!route || typeof route !== 'object') return null;
   const record = route as Record<string, unknown>;

package/src/core/status.ts

@@ -2,6 +2,7 @@ import fs from 'node:fs';
 import path from 'node:path';
 import { buildRuntimeStatusMetaDisplay } from './status-meta.ts';
 import type { BncrDiagnosticsSummary, BncrRuntimeLastSession, PendingAdmission } from './types.ts';
+import { finiteNumberOr, nonNegativeFiniteNumberOr, now } from './value-sanitize.ts';
 
 type RuntimeStatusInput = {
   accountId: string;
@@ -27,19 +28,6 @@ type RuntimeStatusInput = {
   channelRoot?: string;
 };
 
-function now() {
-  return Date.now();
-}
-
-function finiteNumberOr(value: unknown, fallback: number): number {
-  const n = Number(value);
-  return Number.isFinite(n) ? n : fallback;
-}
-
-function nonNegativeFiniteNumberOr(value: unknown, fallback: number): number {
-  return Math.max(0, finiteNumberOr(value, fallback));
-}
-
 export function buildIntegratedDiagnostics(input: RuntimeStatusInput): BncrDiagnosticsSummary {
   const root = input.channelRoot || path.join(process.cwd(), 'plugins', 'bncr');
   const pluginIndexExists = fs.existsSync(path.join(root, 'index.ts'));
@@ -230,11 +218,3 @@ export function buildAccountStatusSnapshot(input: {
     diagnostics,
   };
 }
-
-export function buildChannelSummaryFromRuntime(input: RuntimeStatusInput) {
-  const headline = buildStatusHeadlineFromRuntime(input);
-  return {
-    linked: input.connected,
-    self: { e164: headline },
-  };
-}