@xmoxmo/bncr 0.3.3 → 0.3.5

package/src/runtime/status-snapshots.ts

@@ -15,7 +15,9 @@ export function buildRuntimeQueueSnapshot(args: {
 }) {
   const accountId = normalizeAccountId(args.accountId);
   const pending = Array.from(args.outboxEntries).filter((v) => v.accountId === accountId).length;
-  const deadLetter = Array.from(args.deadLetterEntries).filter((v) => v.accountId === accountId).length;
+  const deadLetter = Array.from(args.deadLetterEntries).filter(
+    (v) => v.accountId === accountId,
+  ).length;
   const sessionRoutesCount = Array.from(args.sessionRouteEntries).filter(
     (v) => v.accountId === accountId,
   ).length;
@@ -44,6 +46,10 @@ export function buildRuntimeEventCounters(args: {
   };
 }
 
+function nullableMapNumber(map: Map<string, number>, key: string): number | null {
+  return map.get(key) ?? null;
+}
+
 export function buildRuntimeActivitySnapshot(args: {
   accountId: string;
   activeConnectionCount: (accountId: string) => number;
@@ -56,9 +62,9 @@ export function buildRuntimeActivitySnapshot(args: {
   return {
     activeConnections: args.activeConnectionCount(accountId),
     lastSession: args.lastSessionByAccount.get(accountId) || null,
-    lastActivityAt: args.lastActivityByAccount.get(accountId) || null,
-    lastInboundAt: args.lastInboundByAccount.get(accountId) || null,
-    lastOutboundAt: args.lastOutboundByAccount.get(accountId) || null,
+    lastActivityAt: nullableMapNumber(args.lastActivityByAccount, accountId),
+    lastInboundAt: nullableMapNumber(args.lastInboundByAccount, accountId),
+    lastOutboundAt: nullableMapNumber(args.lastOutboundByAccount, accountId),
   };
 }
 

package/src/runtime/status-worker.ts

@@ -15,8 +15,58 @@ export type ChannelAccountWorkerHandle = {
   timer: NodeJS.Timeout;
   finish: (reason: string) => void;
   cleanupAbortListener?: () => void;
+  healthLogState?: HealthStatusLogState;
 };
 
+export const HEALTH_STATUS_STABLE_WINDOW_MS = 10_000;
+
+export type HealthStatusLogState = {
+  emittedSig: string | null;
+  pendingSig: string | null;
+  pendingSince: number;
+};
+
+export function createHealthStatusLogState(): HealthStatusLogState {
+  return { emittedSig: null, pendingSig: null, pendingSince: 0 };
+}
+
+function finiteNumberOr(value: unknown, fallback: number): number {
+  const n = Number(value);
+  return Number.isFinite(n) ? n : fallback;
+}
+
+function nonNegativeFiniteNumberOr(value: unknown, fallback: number): number {
+  return Math.max(0, finiteNumberOr(value, fallback));
+}
+
+export function updateHealthStatusLogState(args: {
+  state: HealthStatusLogState;
+  sig: string;
+  nowMs: number;
+  stableWindowMs?: number;
+}): 'pending' | 'stable' | 'unchanged' {
+  const stableWindowMs = nonNegativeFiniteNumberOr(
+    args.stableWindowMs,
+    HEALTH_STATUS_STABLE_WINDOW_MS,
+  );
+  const nowMs = finiteNumberOr(args.nowMs, 0);
+  if (args.state.emittedSig === args.sig) {
+    args.state.pendingSig = null;
+    args.state.pendingSince = 0;
+    return 'unchanged';
+  }
+  if (args.state.pendingSig !== args.sig) {
+    args.state.pendingSig = args.sig;
+    args.state.pendingSince = nowMs;
+    if (stableWindowMs > 0) return 'pending';
+  }
+  if (nowMs - args.state.pendingSince < stableWindowMs) return 'pending';
+  args.state.emittedSig = args.sig;
+  args.state.pendingSig = null;
+  args.state.pendingSince = 0;
+  return 'stable';
+}
+
 type StatusWorkerHooks = {
   isOnline: (accountId: string) => boolean;
   hasRecentInboundReachability: (accountId: string) => boolean;
@@ -30,6 +80,8 @@ type StatusWorkerHooks = {
     message: string,
     options: { key: string; sig: string; debugOnly?: boolean; windowMs?: number },
   ) => void;
+  now?: () => number;
+  healthStableWindowMs?: number;
 };
 
 type StatusWorkerRuntime = {
@@ -60,9 +112,13 @@ export function clearAllBncrStatusWorkers(runtime: StatusWorkerRuntime, reason:
   }
 }
 
-export async function startBncrStatusWorker(runtime: StatusWorkerRuntime, ctx: StatusWorkerContext) {
+export async function startBncrStatusWorker(
+  runtime: StatusWorkerRuntime,
+  ctx: StatusWorkerContext,
+) {
   const accountId = normalizeAccountId(ctx.accountId);
   clearBncrStatusWorker(runtime, accountId, 'start-replace');
+  let worker!: ChannelAccountWorkerHandle;
 
   const tick = () => {
     const previous = ctx.getStatus?.() || {};
@@ -81,14 +137,20 @@ export async function startBncrStatusWorker(runtime: StatusWorkerRuntime, ctx: S
       activeConnections,
     });
     const conns = activeConnections.length;
-    runtime.hooks.logInfoDedup(
-      'health',
-      `status-tick ${accountId}|changed|${connected ? 'linked' : 'configured'}|onlineByConn=${onlineByConn}|recentInboundReachable=${recentInboundReachable}|conns=${conns}`,
-      {
-        key: `health-status-tick:${accountId}`,
-        sig: healthSig,
-      },
-    );
+    const healthLogState = worker.healthLogState || createHealthStatusLogState();
+    worker.healthLogState = healthLogState;
+    const healthLogDecision = updateHealthStatusLogState({
+      state: healthLogState,
+      sig: healthSig,
+      nowMs: runtime.hooks.now?.() ?? Date.now(),
+      stableWindowMs: runtime.hooks.healthStableWindowMs,
+    });
+    if (healthLogDecision === 'stable') {
+      runtime.hooks.logInfo(
+        'health',
+        `status-tick ${accountId}|stable|${connected ? 'linked' : 'configured'}|onlineByConn=${onlineByConn}|recentInboundReachable=${recentInboundReachable}|conns=${conns}`,
+      );
+    }
     runtime.hooks.logInfoDedup('health', `status-tick ${healthSig}`, {
       key: `health-status-tick-debug:${accountId}`,
       sig: healthSig,
@@ -108,9 +170,7 @@ export async function startBncrStatusWorker(runtime: StatusWorkerRuntime, ctx: S
     });
   };
 
-  tick();
   const timer = setInterval(tick, 5_000);
-  let worker!: ChannelAccountWorkerHandle;
   const done = new Promise<void>((resolve) => {
     let settled = false;
     const finish = (reason: string) => {
@@ -132,9 +192,11 @@ export async function startBncrStatusWorker(runtime: StatusWorkerRuntime, ctx: S
       resolve();
     };
 
-    worker = { timer, finish };
+    worker = { timer, finish, healthLogState: createHealthStatusLogState() };
     runtime.workers.set(accountId, worker);
 
+    tick();
+
     const onAbort = () => finish('abort');
     const abortSignal = ctx.abortSignal;
 
@@ -151,7 +213,10 @@ export async function startBncrStatusWorker(runtime: StatusWorkerRuntime, ctx: S
   await done;
 }
 
-export async function stopBncrStatusWorker(runtime: StatusWorkerRuntime, ctx: Partial<StatusWorkerContext>) {
+export async function stopBncrStatusWorker(
+  runtime: StatusWorkerRuntime,
+  ctx: Partial<StatusWorkerContext>,
+) {
   const accountId = normalizeAccountId(ctx?.accountId);
   const cleared = clearBncrStatusWorker(runtime, accountId, 'explicit-stop');
   const previous = ctx?.getStatus?.() || {};