@xmldom/xmldom 0.9.4 → 0.9.5

package/CHANGELOG.md

@@ -4,6 +4,17 @@ All notable changes to this project will be documented in this file.
 
 This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.9.5](https://github.com/xmldom/xmldom/compare/0.9.4...0.9.5)
+
+### Fixed
+
+- fix: re-index childNodes on insertBefore [`#763`](https://github.com/xmldom/xmldom/issues/763) / [`#766`](https://github.com/xmldom/xmldom/pull/766)
+
+Thank you,
+[@mureinik](https://github.com/mureinik),
+for your contributions.
+
+
 ## [0.9.4](https://github.com/xmldom/xmldom/compare/0.9.3...0.9.4)
 
 ### Fixed

package/lib/dom.js

@@ -1623,37 +1623,39 @@ function _onRemoveAttribute(doc, el, newAttr, remove) {
 }
 
 /**
- * Updates `el.childNodes`, adjusting the indexed items and its `length`.
- * If `newChild` is provided, it will be appended to the childNodes list.
- * Otherwise, it's assumed that an item has been removed,
- * and `el.firstNode` and its `.nextSibling` are used to iterate over the current list of child
- * nodes, effectively reindexing them.
+ * Updates `parent.childNodes`, adjusting the indexed items and its `length`.
+ * If `newChild` is provided and has no nextSibling, it will be appended.
+ * Otherwise, it's assumed that an item has been removed or inserted,
+ * and `parent.firstNode` and its `.nextSibling` to re-indexing all child nodes of `parent`.
  *
  * @param {Document} doc
  * The parent document of `el`.
- * @param {Node} el
+ * @param {Node} parent
  * The parent node whose childNodes list needs to be updated.
  * @param {Node} [newChild]
  * The new child node to be appended. If not provided, the function assumes a node has been
  * removed.
  * @private
  */
-function _onUpdateChild(doc, el, newChild) {
+function _onUpdateChild(doc, parent, newChild) {
 	if (doc && doc._inc) {
 		doc._inc++;
-		//update childNodes
-		var cs = el.childNodes;
-		if (newChild) {
-			cs[cs.length++] = newChild;
+		var childNodes = parent.childNodes;
+		// assumes nextSibling and previousSibling were already configured upfront
+		if (newChild && !newChild.nextSibling) {
+			// if an item has been appended, we only need to update the last index and the length
+			childNodes[childNodes.length++] = newChild;
 		} else {
-			var child = el.firstChild;
+			// otherwise we need to reindex all items,
+			// which can take a while when processing nodes with a lot of children
+			var child = parent.firstChild;
 			var i = 0;
 			while (child) {
-				cs[i++] = child;
+				childNodes[i++] = child;
 				child = child.nextSibling;
 			}
-			cs.length = i;
-			delete cs[cs.length];
+			childNodes.length = i;
+			delete childNodes[childNodes.length];
 		}
 	}
 }

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "@xmldom/xmldom",
-	"version": "0.9.4",
+	"version": "0.9.5",
 	"description": "A pure JavaScript W3C standard-based (XML DOM Level 2 Core) DOMParser and XMLSerializer module.",
 	"keywords": [
 		"w3c",